From: Kalle Valo <kvalo@codeaurora.org>
To: Venkateswara Naralasetty <vnaralas@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Venkateswara Naralasetty <vnaralas@codeaurora.org>,
Kan Yan <kyan@chromium.org>
Subject: Re: [PATCHv2] ath10k: Add wrapper function to ath10k debug
Date: Tue, 25 Jun 2019 12:49:58 +0000 (UTC) [thread overview]
Message-ID: <20190625124958.5F3B1606DC@smtp.codeaurora.org> (raw)
In-Reply-To: <1556283505-29539-1-git-send-email-vnaralas@codeaurora.org>
Venkateswara Naralasetty <vnaralas@codeaurora.org> wrote:
> ath10k_dbg() is called in ath10k_process_rx() with huge set of arguments
> which is causing CPU overhead even when debug_mask is not set.
> Good improvement was observed in the receive side performance when call
> to ath10k_dbg() is avoided in the RX path.
>
> Since currently all debug messages are sent via tracing infrastructure,
> we cannot entirely avoid calling ath10k_dbg. Therefore, call to
> ath10k_dbg() is made conditional based on tracing config in the driver.
>
> Trasmit performance remains unchanged with this patch; below are some
> experimental results with this patch and tracing disabled.
>
> mesh mode:
>
> w/o this patch with this patch
> Traffic TP CPU Usage TP CPU usage
>
> TCP 840Mbps 76.53% 960Mbps 78.14%
> UDP 1030Mbps 74.58% 1132Mbps 74.31%
>
> Infra mode:
>
> w/o this patch with this patch
> Traffic TP CPU Usage TP CPU usage
>
> TCP Rx 1241Mbps 80.89% 1270Mbps 73.50%
> UDP Rx 1433Mbps 81.77% 1472Mbps 72.80%
>
> Tested platform : IPQ8064
> hardware used : QCA9984
> firmware ver : ver 10.4-3.5.3-00057
>
> Signed-off-by: Kan Yan <kyan@chromium.org>
> Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
9d740d6380e5 ath10k: Add wrapper function to ath10k debug
--
https://patchwork.kernel.org/patch/10919117/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2019-06-25 12:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 12:58 [PATCHv2] ath10k: Add wrapper function to ath10k debug Venkateswara Naralasetty
2019-04-26 12:58 ` Venkateswara Naralasetty
2019-04-26 13:21 ` Ben Greear
2019-04-26 13:21 ` Ben Greear
2019-04-26 13:38 ` Venkateswara Naralasetty
2019-04-26 13:38 ` Venkateswara Naralasetty
2019-04-26 13:57 ` Ben Greear
2019-04-26 13:57 ` Ben Greear
2019-04-26 13:44 ` Michał Kazior
2019-04-26 13:44 ` Michał Kazior
2019-04-26 13:56 ` Ben Greear
2019-04-26 13:56 ` Ben Greear
2019-04-30 6:13 ` Venkateswara Naralasetty
2019-04-30 6:13 ` Venkateswara Naralasetty
2019-05-09 12:48 ` Venkateswara Naralasetty
2019-05-09 12:48 ` Venkateswara Naralasetty
2019-06-25 12:49 ` Kalle Valo
2019-06-25 12:49 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625124958.5F3B1606DC@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=kyan@chromium.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vnaralas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.