All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michał Kazior" <kazikcz@gmail.com>
To: Venkateswara Naralasetty <vnaralas@codeaurora.org>
Cc: ath10k@lists.infradead.org,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Kan Yan <kyan@chromium.org>
Subject: Re: [PATCHv2] ath10k: Add wrapper function to ath10k debug
Date: Fri, 26 Apr 2019 15:44:59 +0200	[thread overview]
Message-ID: <CABvG-CVxmnm=JsSsgYQqEzHHYU8RJDxqCZJn4Rzy=zPLtKY1hA@mail.gmail.com> (raw)
In-Reply-To: <1556283505-29539-1-git-send-email-vnaralas@codeaurora.org>

On Fri, 26 Apr 2019 at 14:58, Venkateswara Naralasetty
<vnaralas@codeaurora.org> wrote:
>
> ath10k_dbg() is called in ath10k_process_rx() with huge set of arguments
> which is causing CPU overhead even when debug_mask is not set.
> Good improvement was observed in the receive side performance when call
> to ath10k_dbg() is avoided in the RX path.
[...]

> +/* Avoid calling __ath10k_dbg() if debug_mask is not set and tracing
> + * disabled.
> + */
> +#define ath10k_dbg(ar, dbg_mask, fmt, ...)                     \
> +do {                                                           \
> +       if ((ath10k_debug_mask & dbg_mask) ||                   \
> +           trace_ath10k_log_dbg_enabled())                     \
> +               __ath10k_dbg(ar, dbg_mask, fmt, ##__VA_ARGS__); \
> +} while (0)

Did you consider using jump labels (see include/linux/jump_label.h)?
It's what tracing uses under the hood. I wonder if you could squeeze
out a bit more performance with that? I guess you'd need to add
`struct static_key ath10k_dbg_mask_keys[ATH10K_DBG_MAX]` and re-do
ath10k_debug_mask enum a bit.


Michal

WARNING: multiple messages have this Message-ID (diff)
From: "Michał Kazior" <kazikcz@gmail.com>
To: Venkateswara Naralasetty <vnaralas@codeaurora.org>
Cc: Kan Yan <kyan@chromium.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	ath10k@lists.infradead.org
Subject: Re: [PATCHv2] ath10k: Add wrapper function to ath10k debug
Date: Fri, 26 Apr 2019 15:44:59 +0200	[thread overview]
Message-ID: <CABvG-CVxmnm=JsSsgYQqEzHHYU8RJDxqCZJn4Rzy=zPLtKY1hA@mail.gmail.com> (raw)
In-Reply-To: <1556283505-29539-1-git-send-email-vnaralas@codeaurora.org>

On Fri, 26 Apr 2019 at 14:58, Venkateswara Naralasetty
<vnaralas@codeaurora.org> wrote:
>
> ath10k_dbg() is called in ath10k_process_rx() with huge set of arguments
> which is causing CPU overhead even when debug_mask is not set.
> Good improvement was observed in the receive side performance when call
> to ath10k_dbg() is avoided in the RX path.
[...]

> +/* Avoid calling __ath10k_dbg() if debug_mask is not set and tracing
> + * disabled.
> + */
> +#define ath10k_dbg(ar, dbg_mask, fmt, ...)                     \
> +do {                                                           \
> +       if ((ath10k_debug_mask & dbg_mask) ||                   \
> +           trace_ath10k_log_dbg_enabled())                     \
> +               __ath10k_dbg(ar, dbg_mask, fmt, ##__VA_ARGS__); \
> +} while (0)

Did you consider using jump labels (see include/linux/jump_label.h)?
It's what tracing uses under the hood. I wonder if you could squeeze
out a bit more performance with that? I guess you'd need to add
`struct static_key ath10k_dbg_mask_keys[ATH10K_DBG_MAX]` and re-do
ath10k_debug_mask enum a bit.


Michal

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  parent reply	other threads:[~2019-04-26 13:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-26 12:58 [PATCHv2] ath10k: Add wrapper function to ath10k debug Venkateswara Naralasetty
2019-04-26 12:58 ` Venkateswara Naralasetty
2019-04-26 13:21 ` Ben Greear
2019-04-26 13:21   ` Ben Greear
2019-04-26 13:38   ` Venkateswara Naralasetty
2019-04-26 13:38     ` Venkateswara Naralasetty
2019-04-26 13:57     ` Ben Greear
2019-04-26 13:57       ` Ben Greear
2019-04-26 13:44 ` Michał Kazior [this message]
2019-04-26 13:44   ` Michał Kazior
2019-04-26 13:56   ` Ben Greear
2019-04-26 13:56     ` Ben Greear
2019-04-30  6:13     ` Venkateswara Naralasetty
2019-04-30  6:13       ` Venkateswara Naralasetty
2019-05-09 12:48   ` Venkateswara Naralasetty
2019-05-09 12:48     ` Venkateswara Naralasetty
2019-06-25 12:49 ` Kalle Valo
2019-06-25 12:49 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABvG-CVxmnm=JsSsgYQqEzHHYU8RJDxqCZJn4Rzy=zPLtKY1hA@mail.gmail.com' \
    --to=kazikcz@gmail.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kyan@chromium.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=vnaralas@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.