From: Sasha Levin <sashal@kernel.org>
To: Josh Hunt <johunt@akamai.com>
Cc: gregkh@linuxfoundation.org, edumazet@google.com,
stable@vger.kernel.org, jbaron@akamai.com
Subject: Re: [PATCH 4.14] tcp: refine memory limit test in tcp_fragment()
Date: Tue, 25 Jun 2019 16:26:26 -0400 [thread overview]
Message-ID: <20190625202626.GD7898@sasha-vm> (raw)
In-Reply-To: <1561483177-30254-1-git-send-email-johunt@akamai.com>
On Tue, Jun 25, 2019 at 01:19:37PM -0400, Josh Hunt wrote:
>Backport of dad3a9314ac95dedc007bc7dacacb396ea10e376:
You probably meant b6653b3629e5b88202be3c9abc44713973f5c4b4 here.
>tcp_fragment() might be called for skbs in the write queue.
>
>Memory limits might have been exceeded because tcp_sendmsg() only
>checks limits at full skb (64KB) boundaries.
>
>Therefore, we need to make sure tcp_fragment() wont punish applications
>that might have setup very low SO_SNDBUF values.
>
>Backport notes:
>Initial version used tcp_queue type which is not present in older kernels,
>so added a new arg to tcp_fragment() to determine whether this is a
>retransmit or not.
>
>Fixes: 9daf226ff926 ("tcp: tcp_fragment() should apply sane memory limits")
>Signed-off-by: Josh Hunt <johunt@akamai.com>
>Reviewed-by: Jason Baron <jbaron@akamai.com>
>---
>
>Eric/Greg - This applies on top of v4.14.130. I did not see anything come
>through for the older (<4.19) stable kernels yet. Without this change
>Christoph Paasch's packetrill script (https://lore.kernel.org/netdev/CALMXkpYVRxgeqarp4gnmX7GqYh1sWOAt6UaRFqYBOaaNFfZ5sw@mail.gmail.com/)
>will fail on 4.14 stable kernels, but passes with this change.
Eric, it would be great if you could Ack this, it's very different from
your original patch.
--
Thanks,
Sasha
next prev parent reply other threads:[~2019-06-25 20:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 17:19 [PATCH 4.14] tcp: refine memory limit test in tcp_fragment() Josh Hunt
2019-06-25 20:26 ` Sasha Levin [this message]
2019-06-25 20:29 ` Josh Hunt
2019-06-25 22:18 ` Greg KH
2019-06-25 22:49 ` Josh Hunt
2019-06-26 0:48 ` Greg KH
2019-06-26 8:29 ` Greg KH
2019-06-26 16:28 ` Josh Hunt
2019-06-25 22:40 ` Sasha Levin
2019-06-25 22:53 ` Josh Hunt
2019-06-26 0:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625202626.GD7898@sasha-vm \
--to=sashal@kernel.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@akamai.com \
--cc=johunt@akamai.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.