All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Josh Hunt <johunt@akamai.com>,
	edumazet@google.com, stable@vger.kernel.org, jbaron@akamai.com
Subject: Re: [PATCH 4.14] tcp: refine memory limit test in tcp_fragment()
Date: Wed, 26 Jun 2019 08:50:43 +0800	[thread overview]
Message-ID: <20190626005043.GB21530@kroah.com> (raw)
In-Reply-To: <20190625224050.GE7898@sasha-vm>

On Tue, Jun 25, 2019 at 06:40:50PM -0400, Sasha Levin wrote:
> On Tue, Jun 25, 2019 at 01:29:35PM -0700, Josh Hunt wrote:
> > On 6/25/19 1:26 PM, Sasha Levin wrote:
> > > On Tue, Jun 25, 2019 at 01:19:37PM -0400, Josh Hunt wrote:
> > > > Backport of dad3a9314ac95dedc007bc7dacacb396ea10e376:
> > > 
> > > You probably meant b6653b3629e5b88202be3c9abc44713973f5c4b4 here.
> > 
> > I wasn't sure if I should reference the upstream commit or stable
> > commit. dad3a9314 is the version of the commit from linux-4.14.y. There
> > may be a similar issue with the Fixes tag below since that also
> > references the 4.14 vers of the change.
> 
> We try to just reference upstream commits when possible. I can edit
> these if this patch will be merged.

I think for this issue we will do as was mentioned in other responses in
this thread.

But, to the topic of original sha1 ids, I think I need to document how
we have been using these in a much better way.  It's a very powerful way
to determine what is fixed where and allows people to properly audit
fixes and how they propagate around different kernel trees, distros
included.

I've been talking to other projects and they like how we have been doing
this and want to copy it, so I guess it's time to actually describe what
we do here :)

thanks,

greg k-h

      parent reply	other threads:[~2019-06-26  0:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25 17:19 [PATCH 4.14] tcp: refine memory limit test in tcp_fragment() Josh Hunt
2019-06-25 20:26 ` Sasha Levin
2019-06-25 20:29   ` Josh Hunt
2019-06-25 22:18     ` Greg KH
2019-06-25 22:49       ` Josh Hunt
2019-06-26  0:48         ` Greg KH
2019-06-26  8:29           ` Greg KH
2019-06-26 16:28             ` Josh Hunt
2019-06-25 22:40     ` Sasha Levin
2019-06-25 22:53       ` Josh Hunt
2019-06-26  0:50       ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190626005043.GB21530@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=edumazet@google.com \
    --cc=jbaron@akamai.com \
    --cc=johunt@akamai.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.