All of lore.kernel.org
 help / color / mirror / Atom feed
* [driver-core:driver-core-testing 84/85] drivers/s390/cio/device.c:1660:9: warning: assignment discards 'const' qualifier from pointer target type
@ 2019-06-25 14:28 kbuild test robot
  2019-06-26  1:22 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2019-06-25 14:28 UTC (permalink / raw)
  To: Suzuki K Poulose; +Cc: devel, Greg Kroah-Hartman, kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2617 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing
head:   65b66682344a15ba2069d4dd8d0cc39cc3aed7e9
commit: 92ce7e83b4e5c86687d748ba53cb755acdce1256 [84/85] driver_find_device: Unify the match function with class_find_device()
config: s390-debug_defconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 92ce7e83b4e5c86687d748ba53cb755acdce1256
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/s390/cio/device.c: In function '__ccwdev_check_busid':
>> drivers/s390/cio/device.c:1660:9: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     bus_id = id;
            ^
--
   drivers/s390/cio/ccwgroup.c: In function '__ccwgroupdev_check_busid':
>> drivers/s390/cio/ccwgroup.c:613:17: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     char *bus_id = id;
                    ^~

vim +/const +1660 drivers/s390/cio/device.c

^1da177e Linus Torvalds   2005-04-16  1651  
^1da177e Linus Torvalds   2005-04-16  1652  /*
^1da177e Linus Torvalds   2005-04-16  1653   * get ccw_device matching the busid, but only if owned by cdrv
^1da177e Linus Torvalds   2005-04-16  1654   */
b0744bd2 Cornelia Huck    2005-06-25  1655  static int
92ce7e83 Suzuki K Poulose 2019-06-14  1656  __ccwdev_check_busid(struct device *dev, const void *id)
b0744bd2 Cornelia Huck    2005-06-25  1657  {
b0744bd2 Cornelia Huck    2005-06-25  1658  	char *bus_id;
b0744bd2 Cornelia Huck    2005-06-25  1659  
12975aef Cornelia Huck    2006-10-11 @1660  	bus_id = id;
b0744bd2 Cornelia Huck    2005-06-25  1661  
98df67b3 Kay Sievers      2008-12-25  1662  	return (strcmp(bus_id, dev_name(dev)) == 0);
b0744bd2 Cornelia Huck    2005-06-25  1663  }
b0744bd2 Cornelia Huck    2005-06-25  1664  

:::::: The code at line 1660 was first introduced by commit
:::::: 12975aef62836e9f3e179afaaded8045f8a25ac4 [S390] cio: remove casts from/to (void *).

:::::: TO: Cornelia Huck <cornelia.huck@de.ibm.com>
:::::: CC: Martin Schwidefsky <schwidefsky@de.ibm.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 20387 bytes --]

[-- Attachment #3: Type: text/plain, Size: 169 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [driver-core:driver-core-testing 84/85] drivers/s390/cio/device.c:1660:9: warning: assignment discards 'const' qualifier from pointer target type
  2019-06-25 14:28 [driver-core:driver-core-testing 84/85] drivers/s390/cio/device.c:1660:9: warning: assignment discards 'const' qualifier from pointer target type kbuild test robot
@ 2019-06-26  1:22 ` Greg Kroah-Hartman
  2019-06-26  8:46     ` Suzuki K Poulose
  0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2019-06-26  1:22 UTC (permalink / raw)
  To: kbuild test robot, Suzuki K Poulose, devel, kbuild-all

On Tue, Jun 25, 2019 at 10:28:55PM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing
> head:   65b66682344a15ba2069d4dd8d0cc39cc3aed7e9
> commit: 92ce7e83b4e5c86687d748ba53cb755acdce1256 [84/85] driver_find_device: Unify the match function with class_find_device()
> config: s390-debug_defconfig (attached as .config)
> compiler: s390-linux-gcc (GCC) 7.4.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 92ce7e83b4e5c86687d748ba53cb755acdce1256
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.4.0 make.cross ARCH=s390 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/s390/cio/device.c: In function '__ccwdev_check_busid':
> >> drivers/s390/cio/device.c:1660:9: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>      bus_id = id;
>             ^
> --
>    drivers/s390/cio/ccwgroup.c: In function '__ccwgroupdev_check_busid':
> >> drivers/s390/cio/ccwgroup.c:613:17: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>      char *bus_id = id;
>                     ^~

Suzuki, can you send me a fix for this please?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] drivers: s390/cio: Fix compilation warning about const qualifiers
  2019-06-26  1:22 ` Greg Kroah-Hartman
@ 2019-06-26  8:46     ` Suzuki K Poulose
  0 siblings, 0 replies; 4+ messages in thread
From: Suzuki K Poulose @ 2019-06-26  8:46 UTC (permalink / raw)
  To: gregkh; +Cc: suzuki.poulose, linux-kernel, devel

Update __ccwdev_check_busid() and __ccwgroupdev_check_busid() to use
"const" qualifiers to fix the compiler warning.

Reported-by: kbuild test robot <lkp@intel.com>
Cc: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
 drivers/s390/cio/ccwgroup.c | 2 +-
 drivers/s390/cio/device.c   | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c
index ea176157..c522e93 100644
--- a/drivers/s390/cio/ccwgroup.c
+++ b/drivers/s390/cio/ccwgroup.c
@@ -610,7 +610,7 @@ EXPORT_SYMBOL(ccwgroup_driver_unregister);
 
 static int __ccwgroupdev_check_busid(struct device *dev, const void *id)
 {
-	char *bus_id = id;
+	const char *bus_id = id;
 
 	return (strcmp(bus_id, dev_name(dev)) == 0);
 }
diff --git a/drivers/s390/cio/device.c b/drivers/s390/cio/device.c
index f27536b..1132482 100644
--- a/drivers/s390/cio/device.c
+++ b/drivers/s390/cio/device.c
@@ -1655,9 +1655,7 @@ EXPORT_SYMBOL_GPL(ccw_device_force_console);
 static int
 __ccwdev_check_busid(struct device *dev, const void *id)
 {
-	char *bus_id;
-
-	bus_id = id;
+	const char *bus_id = id;
 
 	return (strcmp(bus_id, dev_name(dev)) == 0);
 }
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] drivers: s390/cio: Fix compilation warning about const qualifiers
@ 2019-06-26  8:46     ` Suzuki K Poulose
  0 siblings, 0 replies; 4+ messages in thread
From: Suzuki K Poulose @ 2019-06-26  8:46 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel, suzuki.poulose

Update __ccwdev_check_busid() and __ccwgroupdev_check_busid() to use
"const" qualifiers to fix the compiler warning.

Reported-by: kbuild test robot <lkp@intel.com>
Cc: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
 drivers/s390/cio/ccwgroup.c | 2 +-
 drivers/s390/cio/device.c   | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c
index ea176157..c522e93 100644
--- a/drivers/s390/cio/ccwgroup.c
+++ b/drivers/s390/cio/ccwgroup.c
@@ -610,7 +610,7 @@ EXPORT_SYMBOL(ccwgroup_driver_unregister);
 
 static int __ccwgroupdev_check_busid(struct device *dev, const void *id)
 {
-	char *bus_id = id;
+	const char *bus_id = id;
 
 	return (strcmp(bus_id, dev_name(dev)) == 0);
 }
diff --git a/drivers/s390/cio/device.c b/drivers/s390/cio/device.c
index f27536b..1132482 100644
--- a/drivers/s390/cio/device.c
+++ b/drivers/s390/cio/device.c
@@ -1655,9 +1655,7 @@ EXPORT_SYMBOL_GPL(ccw_device_force_console);
 static int
 __ccwdev_check_busid(struct device *dev, const void *id)
 {
-	char *bus_id;
-
-	bus_id = id;
+	const char *bus_id = id;
 
 	return (strcmp(bus_id, dev_name(dev)) == 0);
 }
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-26  8:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-25 14:28 [driver-core:driver-core-testing 84/85] drivers/s390/cio/device.c:1660:9: warning: assignment discards 'const' qualifier from pointer target type kbuild test robot
2019-06-26  1:22 ` Greg Kroah-Hartman
2019-06-26  8:46   ` [PATCH] drivers: s390/cio: Fix compilation warning about const qualifiers Suzuki K Poulose
2019-06-26  8:46     ` Suzuki K Poulose

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.