From: Greg KH <gregkh@linuxfoundation.org>
To: "Christian Müller" <muellerch-privat@web.de>
Cc: devel@driverdev.osuosl.org, felix.trommer@hotmail.de,
linux-kernel@i4.cs.fau.de, linux-kernel@vger.kernel.org,
johnfwhitmore@gmail.com
Subject: Re: [PATCH 1/2] drivers/staging/rtl8192u: adjust block comments
Date: Wed, 26 Jun 2019 09:53:01 +0800 [thread overview]
Message-ID: <20190626015301.GA30966@kroah.com> (raw)
In-Reply-To: <20190624094640.5459-2-muellerch-privat@web.de>
On Mon, Jun 24, 2019 at 11:46:39AM +0200, Christian Müller wrote:
> As stated in coding-styles.rst multiline comments should be structured in a way,
> that the actual comment starts on the second line of the commented portion. E.g:
<snip>
You sent 2 patches that did different things, yet have the identical
subject line :(
Please fix up and resend the series.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: "Christian Müller" <muellerch-privat@web.de>
Cc: devel@driverdev.osuosl.org, felix.trommer@hotmail.de,
linux-kernel@vger.kernel.org, johnfwhitmore@gmail.com,
linux-kernel@i4.cs.fau.de
Subject: Re: [PATCH 1/2] drivers/staging/rtl8192u: adjust block comments
Date: Wed, 26 Jun 2019 09:53:01 +0800 [thread overview]
Message-ID: <20190626015301.GA30966@kroah.com> (raw)
In-Reply-To: <20190624094640.5459-2-muellerch-privat@web.de>
On Mon, Jun 24, 2019 at 11:46:39AM +0200, Christian Müller wrote:
> As stated in coding-styles.rst multiline comments should be structured in a way,
> that the actual comment starts on the second line of the commented portion. E.g:
<snip>
You sent 2 patches that did different things, yet have the identical
subject line :(
Please fix up and resend the series.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-06-26 2:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 9:45 [PATCH 0/1] drivers/staging/rtl8192u: adjust block comments Christian Müller
2019-06-20 9:45 ` Christian Müller
2019-06-20 9:45 ` [PATCH 1/1] drivers/staging/rtl8129u: " Christian Müller
2019-06-20 11:33 ` Greg KH
2019-06-24 9:46 ` [PATCH 0/2] drivers/staging/rtl8192u: " Christian Müller
2019-06-24 9:46 ` Christian Müller
2019-06-24 9:46 ` [PATCH 1/2] " Christian Müller
2019-06-24 9:46 ` Christian Müller
2019-06-26 1:53 ` Greg KH [this message]
2019-06-26 1:53 ` Greg KH
2019-06-27 8:33 ` [PATCH v2 1/2] drivers/staging/rtl8192u: drop first comment line Christian Müller
2019-06-27 8:33 ` Christian Müller
2019-06-27 8:33 ` [PATCH v2 2/2] drivers/staging/rtl8192u: style nonstyled comments Christian Müller
2019-06-27 8:33 ` Christian Müller
2019-06-27 16:45 ` [PATCH v2 1/2] drivers/staging/rtl8192u: drop first comment line Greg KH
2019-06-27 16:45 ` Greg KH
2019-07-01 8:27 ` [PATCH v3 " Christian Müller
2019-07-01 8:27 ` Christian Müller
2019-07-01 8:27 ` [PATCH v3 2/2] drivers/staging/rtl8192u: style nonstyled comments Christian Müller
2019-07-01 8:27 ` Christian Müller
2019-06-24 9:46 ` [PATCH 2/2] drivers/staging/rtl8192u: adjust block comments Christian Müller
2019-06-24 9:46 ` Christian Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626015301.GA30966@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=felix.trommer@hotmail.de \
--cc=johnfwhitmore@gmail.com \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=muellerch-privat@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.