All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Fail harder if GPU reset fails outright
@ 2019-06-25 23:08 Chris Wilson
  2019-06-26  2:55 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2019-06-25 23:08 UTC (permalink / raw)
  To: intel-gfx

If we request a reset and the GPU fails to respond, abandon all hope. If
the request is still stuck when we attempt to do another, fail early and
avoid requesting multiple possibly conflicting domains be reset
simultaneously.

We should never see this in practice, and if we do, it is already too
late.

References: https://bugs.freedesktop.org/show_bug.cgi?id=110998
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
 drivers/gpu/drm/i915/gt/intel_reset.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
index 72002c0f9698..56c43f8cbc17 100644
--- a/drivers/gpu/drm/i915/gt/intel_reset.c
+++ b/drivers/gpu/drm/i915/gt/intel_reset.c
@@ -301,8 +301,16 @@ static int gen6_hw_domain_reset(struct drm_i915_private *i915,
 				u32 hw_domain_mask)
 {
 	struct intel_uncore *uncore = &i915->uncore;
+	u32 status;
 	int err;
 
+	/*
+	 * Check that all previous reset requests have been flushed so
+	 * that we don't simultaneously try to reset 2 overlapping domains.
+	 */
+	if (intel_uncore_read_fw(uncore, GEN6_GDRST))
+		return -EIO;
+
 	/*
 	 * GEN6_GDRST is not in the gt power well, no need to check
 	 * for fifo space for the write or forcewake the chip for
@@ -314,10 +322,11 @@ static int gen6_hw_domain_reset(struct drm_i915_private *i915,
 	err = __intel_wait_for_register_fw(uncore,
 					   GEN6_GDRST, hw_domain_mask, 0,
 					   500, 0,
-					   NULL);
+					   &status);
+	intel_uncore_write_fw(uncore, GEN6_GDRST, 0);
 	if (err)
-		DRM_DEBUG_DRIVER("Wait for 0x%08x engines reset failed\n",
-				 hw_domain_mask);
+		DRM_DEBUG_DRIVER("Wait for 0x%08x [HW] engines reset failed: %08x\n",
+				 hw_domain_mask, status);
 
 	return err;
 }
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-26  9:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-25 23:08 [PATCH] drm/i915: Fail harder if GPU reset fails outright Chris Wilson
2019-06-26  2:55 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-06-26  8:57 ` ✓ Fi.CI.IGT: " Patchwork
2019-06-26  9:00 ` [PATCH] " Chris Wilson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.