[PATCH] drm: Allow range of 0 for drm_mm_insert_node_in_range()

[PATCH] drm: Allow range of 0 for drm_mm_insert_node_in_range()

[Chris Wilson]

We gracefully handle the caller specifying a zero range, so don't force
them to special case that condition if it naturally falls out of their
setup. What we don't check is if the end < start, so keep that as an
assert for an illegal call.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/drm_mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index 9a59865ce574..4581c5387372 100644
--- a/drivers/gpu/drm/drm_mm.c
+++ b/drivers/gpu/drm/drm_mm.c
@@ -472,7 +472,7 @@ int drm_mm_insert_node_in_range(struct drm_mm * const mm,
 	u64 remainder_mask;
 	bool once;
 
-	DRM_MM_BUG_ON(range_start >= range_end);
+	DRM_MM_BUG_ON(range_start > range_end);
 
 	if (unlikely(size == 0 || range_end - range_start < size))
 		return -ENOSPC;
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm: Allow range of 0 for drm_mm_insert_node_in_range()

[Patchwork]

== Series Details ==

Series: drm: Allow range of 0 for drm_mm_insert_node_in_range()
URL   : https://patchwork.freedesktop.org/series/62768/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6356 -> Patchwork_13435
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/

Known issues
------------

  Here are the changes found in Patchwork_13435 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@debugfs_test@read_all_entries:
    - fi-ilk-650:         [PASS][1] -> [DMESG-WARN][2] ([fdo#106387])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/fi-ilk-650/igt@debugfs_test@read_all_entries.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/fi-ilk-650/igt@debugfs_test@read_all_entries.html

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-kbl-7500u:       [PASS][3] -> [DMESG-WARN][4] ([fdo#105128] / [fdo#107139])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/fi-kbl-7500u/igt@gem_exec_suspend@basic-s4-devices.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/fi-kbl-7500u/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@i915_pm_rpm@module-reload:
    - fi-skl-6770hq:      [PASS][5] -> [FAIL][6] ([fdo#108511])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html

  * igt@i915_selftest@live_execlists:
    - fi-icl-dsi:         [PASS][7] -> [INCOMPLETE][8] ([fdo#107713])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/fi-icl-dsi/igt@i915_selftest@live_execlists.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/fi-icl-dsi/igt@i915_selftest@live_execlists.html

  
#### Possible fixes ####

  * igt@gem_exec_fence@basic-busy-default:
    - fi-icl-u3:          [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/fi-icl-u3/igt@gem_exec_fence@basic-busy-default.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/fi-icl-u3/igt@gem_exec_fence@basic-busy-default.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][11] ([fdo#109485]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
  [fdo#105128]: https://bugs.freedesktop.org/show_bug.cgi?id=105128
  [fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387
  [fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485


Participating hosts (52 -> 45)
------------------------------

  Additional (2): fi-icl-guc fi-pnv-d510 
  Missing    (9): fi-kbl-soraka fi-ilk-m540 fi-skl-gvtdvm fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_6356 -> Patchwork_13435

  CI_DRM_6356: 2df88ba97fac57f25c0c530323c2f387ca92d35e @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5068: 15ad664534413628f06c0f172aac11598bfdb895 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13435: d94b5ea9a4eaf52da8cb3f623d5cc2a575ea8586 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

d94b5ea9a4ea drm: Allow range of 0 for drm_mm_insert_node_in_range()

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm: Allow range of 0 for drm_mm_insert_node_in_range()

[Daniele Ceraolo Spurio]

On 6/26/19 2:43 AM, Chris Wilson wrote:
> We gracefully handle the caller specifying a zero range, so don't force
> them to special case that condition if it naturally falls out of their
> setup. What we don't check is if the end < start, so keep that as an
> assert for an illegal call.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

>   drivers/gpu/drm/drm_mm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
> index 9a59865ce574..4581c5387372 100644
> --- a/drivers/gpu/drm/drm_mm.c
> +++ b/drivers/gpu/drm/drm_mm.c
> @@ -472,7 +472,7 @@ int drm_mm_insert_node_in_range(struct drm_mm * const mm,
>   	u64 remainder_mask;
>   	bool once;
>   
> -	DRM_MM_BUG_ON(range_start >= range_end);
> +	DRM_MM_BUG_ON(range_start > range_end);
>   
>   	if (unlikely(size == 0 || range_end - range_start < size))
>   		return -ENOSPC;
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

✓ Fi.CI.IGT: success for drm: Allow range of 0 for drm_mm_insert_node_in_range()

[Patchwork]

== Series Details ==

Series: drm: Allow range of 0 for drm_mm_insert_node_in_range()
URL   : https://patchwork.freedesktop.org/series/62768/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6356_full -> Patchwork_13435_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Known issues
------------

  Here are the changes found in Patchwork_13435_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_caching@reads:
    - shard-glk:          [PASS][1] -> [DMESG-WARN][2] ([fdo#110913 ]) +2 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-glk9/igt@gem_caching@reads.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-glk2/igt@gem_caching@reads.html

  * igt@gem_ctx_isolation@rcs0-reset:
    - shard-hsw:          [PASS][3] -> [DMESG-WARN][4] ([fdo#110789] / [fdo#110913 ])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-hsw1/igt@gem_ctx_isolation@rcs0-reset.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-hsw6/igt@gem_ctx_isolation@rcs0-reset.html

  * igt@gem_eio@wait-10ms:
    - shard-apl:          [PASS][5] -> [DMESG-WARN][6] ([fdo#110913 ]) +2 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-apl1/igt@gem_eio@wait-10ms.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-apl3/igt@gem_eio@wait-10ms.html

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#110854])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-iclb2/igt@gem_exec_balancer@smoke.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-iclb8/igt@gem_exec_balancer@smoke.html

  * igt@gem_partial_pwrite_pread@writes-after-reads-display:
    - shard-kbl:          [PASS][9] -> [DMESG-WARN][10] ([fdo#110913 ]) +2 similar issues
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-kbl1/igt@gem_partial_pwrite_pread@writes-after-reads-display.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-kbl3/igt@gem_partial_pwrite_pread@writes-after-reads-display.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-hsw:          [PASS][11] -> [FAIL][12] ([fdo#108686])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-hsw6/igt@gem_tiled_swapping@non-threaded.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-hsw1/igt@gem_tiled_swapping@non-threaded.html

  * igt@gem_userptr_blits@sync-unmap:
    - shard-snb:          [PASS][13] -> [DMESG-WARN][14] ([fdo#110789] / [fdo#110913 ]) +3 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-snb7/igt@gem_userptr_blits@sync-unmap.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-snb1/igt@gem_userptr_blits@sync-unmap.html

  * igt@i915_pm_rc6_residency@rc6-accuracy:
    - shard-kbl:          [PASS][15] -> [SKIP][16] ([fdo#109271])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-kbl6/igt@i915_pm_rc6_residency@rc6-accuracy.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-kbl2/igt@i915_pm_rc6_residency@rc6-accuracy.html

  * igt@i915_pm_rpm@i2c:
    - shard-hsw:          [PASS][17] -> [FAIL][18] ([fdo#104097])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-hsw2/igt@i915_pm_rpm@i2c.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-hsw1/igt@i915_pm_rpm@i2c.html

  * igt@kms_flip@2x-plain-flip:
    - shard-hsw:          [PASS][19] -> [SKIP][20] ([fdo#109271]) +27 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-hsw2/igt@kms_flip@2x-plain-flip.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-hsw1/igt@kms_flip@2x-plain-flip.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
    - shard-iclb:         [PASS][21] -> [FAIL][22] ([fdo#103167])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@fbc-1p-rte:
    - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#103167] / [fdo#110378])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-rte.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-rte.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render:
    - shard-iclb:         [PASS][25] -> [DMESG-WARN][26] ([fdo#110913 ])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-iclb8/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-iclb3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-render.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
    - shard-apl:          [PASS][27] -> [DMESG-WARN][28] ([fdo#108566])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-apl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html

  * igt@kms_plane_lowres@pipe-a-tiling-x:
    - shard-iclb:         [PASS][29] -> [FAIL][30] ([fdo#103166])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-x.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-x.html

  * igt@kms_psr@no_drrs:
    - shard-iclb:         [PASS][31] -> [FAIL][32] ([fdo#108341])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-iclb4/igt@kms_psr@no_drrs.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-iclb1/igt@kms_psr@no_drrs.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [PASS][33] -> [SKIP][34] ([fdo#109441]) +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-iclb8/igt@kms_psr@psr2_cursor_render.html

  * igt@prime_vgem@sync-render:
    - shard-iclb:         [PASS][35] -> [INCOMPLETE][36] ([fdo#107713])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-iclb5/igt@prime_vgem@sync-render.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-iclb4/igt@prime_vgem@sync-render.html

  
#### Possible fixes ####

  * igt@gem_busy@basic-hang-rcs0:
    - shard-hsw:          [DMESG-WARN][37] ([fdo#110789] / [fdo#110913 ]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-hsw5/igt@gem_busy@basic-hang-rcs0.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-hsw2/igt@gem_busy@basic-hang-rcs0.html

  * igt@gem_eio@execbuf:
    - shard-kbl:          [DMESG-WARN][39] ([fdo#110913 ]) -> [PASS][40] +2 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-kbl1/igt@gem_eio@execbuf.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-kbl3/igt@gem_eio@execbuf.html

  * igt@gem_eio@unwedge-stress:
    - shard-snb:          [FAIL][41] ([fdo#109661]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-snb4/igt@gem_eio@unwedge-stress.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-snb5/igt@gem_eio@unwedge-stress.html

  * igt@gem_fence_thrash@bo-write-verify-threaded-x:
    - shard-snb:          [INCOMPLETE][43] ([fdo#105411]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-snb1/igt@gem_fence_thrash@bo-write-verify-threaded-x.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-snb7/igt@gem_fence_thrash@bo-write-verify-threaded-x.html

  * igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
    - shard-apl:          [DMESG-WARN][45] ([fdo#110913 ]) -> [PASS][46] +2 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-apl1/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-apl3/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html

  * igt@gem_softpin@evict-active:
    - shard-glk:          [DMESG-WARN][47] ([fdo#110913 ]) -> [PASS][48] +3 similar issues
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-glk5/igt@gem_softpin@evict-active.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-glk2/igt@gem_softpin@evict-active.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
    - shard-skl:          [DMESG-WARN][49] ([fdo#110913 ]) -> [PASS][50]
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-skl8/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-skl4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html

  * igt@i915_pm_rpm@universal-planes-dpms:
    - shard-iclb:         [INCOMPLETE][51] ([fdo#107713] / [fdo#108840]) -> [PASS][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-iclb2/igt@i915_pm_rpm@universal-planes-dpms.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-iclb8/igt@i915_pm_rpm@universal-planes-dpms.html

  * igt@kms_flip@flip-vs-blocking-wf-vblank:
    - shard-iclb:         [INCOMPLETE][53] ([fdo#107713]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-iclb1/igt@kms_flip@flip-vs-blocking-wf-vblank.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-iclb5/igt@kms_flip@flip-vs-blocking-wf-vblank.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-skl:          [FAIL][55] ([fdo#105363]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite:
    - shard-hsw:          [SKIP][57] ([fdo#109271]) -> [PASS][58] +39 similar issues
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-hsw4/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
    - shard-iclb:         [FAIL][59] ([fdo#103167]) -> [PASS][60] +3 similar issues
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-cpu:
    - shard-iclb:         [DMESG-WARN][61] ([fdo#110913 ]) -> [PASS][62]
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-iclb8/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-cpu.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-iclb3/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-cpu.html

  * igt@kms_plane_lowres@pipe-a-tiling-y:
    - shard-iclb:         [FAIL][63] ([fdo#103166]) -> [PASS][64]
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-y.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-y.html

  * igt@kms_psr@psr2_no_drrs:
    - shard-iclb:         [SKIP][65] ([fdo#109441]) -> [PASS][66]
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-iclb5/igt@kms_psr@psr2_no_drrs.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-iclb2/igt@kms_psr@psr2_no_drrs.html

  * igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
    - shard-kbl:          [FAIL][67] ([fdo#103925]) -> [PASS][68]
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-kbl1/igt@kms_rotation_crc@sprite-rotation-90-pos-100-0.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-kbl2/igt@kms_rotation_crc@sprite-rotation-90-pos-100-0.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-apl:          [INCOMPLETE][69] ([fdo#103927]) -> [PASS][70] +1 similar issue
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-apl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-apl8/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@kms_vblank@pipe-b-query-forked-busy-hang:
    - shard-snb:          [DMESG-WARN][71] ([fdo#110789] / [fdo#110913 ]) -> [PASS][72] +4 similar issues
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-snb1/igt@kms_vblank@pipe-b-query-forked-busy-hang.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-snb4/igt@kms_vblank@pipe-b-query-forked-busy-hang.html

  
#### Warnings ####

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
    - shard-skl:          [FAIL][73] ([fdo#108040]) -> [FAIL][74] ([fdo#103167])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6356/shard-skl10/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/shard-skl6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

  
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103925]: https://bugs.freedesktop.org/show_bug.cgi?id=103925
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
  [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
  [fdo#110378]: https://bugs.freedesktop.org/show_bug.cgi?id=110378
  [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
  [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
  [fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913 


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_6356 -> Patchwork_13435

  CI_DRM_6356: 2df88ba97fac57f25c0c530323c2f387ca92d35e @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5068: 15ad664534413628f06c0f172aac11598bfdb895 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13435: d94b5ea9a4eaf52da8cb3f623d5cc2a575ea8586 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13435/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm: Allow range of 0 for drm_mm_insert_node_in_range()

[Daniel Vetter]

On Wed, Jun 26, 2019 at 10:43:30AM +0100, Chris Wilson wrote:
> We gracefully handle the caller specifying a zero range, so don't force
> them to special case that condition if it naturally falls out of their
> setup. What we don't check is if the end < start, so keep that as an
> assert for an illegal call.

Maybe spend a few words on why a drm_mm user might want to do that. Sounds
very funky ...
-Daniel

> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/drm_mm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
> index 9a59865ce574..4581c5387372 100644
> --- a/drivers/gpu/drm/drm_mm.c
> +++ b/drivers/gpu/drm/drm_mm.c
> @@ -472,7 +472,7 @@ int drm_mm_insert_node_in_range(struct drm_mm * const mm,
>  	u64 remainder_mask;
>  	bool once;
>  
> -	DRM_MM_BUG_ON(range_start >= range_end);
> +	DRM_MM_BUG_ON(range_start > range_end);
>  
>  	if (unlikely(size == 0 || range_end - range_start < size))
>  		return -ENOSPC;
> -- 
> 2.20.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel