From: Jacob Pan <jacob.jun.pan@linux.intel.com> To: Lu Baolu <baolu.lu@linux.intel.com> Cc: iommu@lists.linux-foundation.org, LKML <linux-kernel@vger.kernel.org>, Joerg Roedel <joro@8bytes.org>, David Woodhouse <dwmw2@infradead.org>, Eric Auger <eric.auger@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, Jean-Philippe Brucker <jean-philippe.brucker@arm.com>, Yi Liu <yi.l.liu@intel.com>, "Tian, Kevin" <kevin.tian@intel.com>, Raj Ashok <ashok.raj@intel.com>, Christoph Hellwig <hch@infradead.org>, Andriy Shevchenko <andriy.shevchenko@linux.intel.com>, jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v4 15/22] iommu/vt-d: Replace Intel specific PASID allocator with IOASID Date: Thu, 27 Jun 2019 08:40:33 -0700 [thread overview] Message-ID: <20190627084033.650dc7ed@jacob-builder> (raw) In-Reply-To: <1cffc7c7-b71b-767a-a35f-d6063dc64b2b@linux.intel.com> On Thu, 27 Jun 2019 09:53:11 +0800 Lu Baolu <baolu.lu@linux.intel.com> wrote: > Hi Jacob, > > On 6/9/19 9:44 PM, Jacob Pan wrote: > > Make use of generic IOASID code to manage PASID allocation, > > free, and lookup. Replace Intel specific code. > > > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> > > --- > > drivers/iommu/intel-iommu.c | 11 +++++------ > > drivers/iommu/intel-pasid.c | 36 > > ------------------------------------ drivers/iommu/intel-svm.c | > > 37 +++++++++++++++++++++---------------- 3 files changed, 26 > > insertions(+), 58 deletions(-) > > > > diff --git a/drivers/iommu/intel-iommu.c > > b/drivers/iommu/intel-iommu.c index 5b84994..39b63fe 100644 > > --- a/drivers/iommu/intel-iommu.c > > +++ b/drivers/iommu/intel-iommu.c > > @@ -5167,7 +5167,7 @@ static void auxiliary_unlink_device(struct > > dmar_domain *domain, domain->auxd_refcnt--; > > > > if (!domain->auxd_refcnt && domain->default_pasid > 0) > > - intel_pasid_free_id(domain->default_pasid); > > + ioasid_free(domain->default_pasid); > > } > > > > static int aux_domain_add_dev(struct dmar_domain *domain, > > @@ -5185,10 +5185,9 @@ static int aux_domain_add_dev(struct > > dmar_domain *domain, if (domain->default_pasid <= 0) { > > int pasid; > > > > - pasid = intel_pasid_alloc_id(domain, PASID_MIN, > > - > > pci_max_pasids(to_pci_dev(dev)), > > - GFP_KERNEL); > > - if (pasid <= 0) { > > + pasid = ioasid_alloc(NULL, PASID_MIN, > > pci_max_pasids(to_pci_dev(dev)) - 1, > > + domain); > > + if (pasid == INVALID_IOASID) { > > pr_err("Can't allocate default pasid\n"); > > return -ENODEV; > > } > > @@ -5224,7 +5223,7 @@ static int aux_domain_add_dev(struct > > dmar_domain *domain, spin_unlock(&iommu->lock); > > spin_unlock_irqrestore(&device_domain_lock, flags); > > if (!domain->auxd_refcnt && domain->default_pasid > 0) > > - intel_pasid_free_id(domain->default_pasid); > > + ioasid_free(domain->default_pasid); > > > > return ret; > > } > > diff --git a/drivers/iommu/intel-pasid.c > > b/drivers/iommu/intel-pasid.c index 69fddd3..1e25539 100644 > > --- a/drivers/iommu/intel-pasid.c > > +++ b/drivers/iommu/intel-pasid.c > > @@ -26,42 +26,6 @@ > > */ > > static DEFINE_SPINLOCK(pasid_lock); > > u32 intel_pasid_max_id = PASID_MAX; > > -static DEFINE_IDR(pasid_idr); > > - > > -int intel_pasid_alloc_id(void *ptr, int start, int end, gfp_t gfp) > > -{ > > - int ret, min, max; > > - > > - min = max_t(int, start, PASID_MIN); > > - max = min_t(int, end, intel_pasid_max_id); > > - > > - WARN_ON(in_interrupt()); > > - idr_preload(gfp); > > - spin_lock(&pasid_lock); > > - ret = idr_alloc(&pasid_idr, ptr, min, max, GFP_ATOMIC); > > - spin_unlock(&pasid_lock); > > - idr_preload_end(); > > - > > - return ret; > > -} > > - > > -void intel_pasid_free_id(int pasid) > > -{ > > - spin_lock(&pasid_lock); > > - idr_remove(&pasid_idr, pasid); > > - spin_unlock(&pasid_lock); > > -} > > - > > -void *intel_pasid_lookup_id(int pasid) > > -{ > > - void *p; > > - > > - spin_lock(&pasid_lock); > > - p = idr_find(&pasid_idr, pasid); > > - spin_unlock(&pasid_lock); > > - > > - return p; > > -} > > > > int vcmd_alloc_pasid(struct intel_iommu *iommu, unsigned int > > *pasid) { > > diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c > > index 8f87304..9cbcc1f 100644 > > --- a/drivers/iommu/intel-svm.c > > +++ b/drivers/iommu/intel-svm.c > > @@ -25,6 +25,7 @@ > > #include <linux/dmar.h> > > #include <linux/interrupt.h> > > #include <linux/mm_types.h> > > +#include <linux/ioasid.h> > > #include <asm/page.h> > > > > #include "intel-pasid.h" > > @@ -332,16 +333,15 @@ int intel_svm_bind_mm(struct device *dev, int > > *pasid, int flags, struct svm_dev_ if (pasid_max > > > intel_pasid_max_id) pasid_max = intel_pasid_max_id; > > > > - /* Do not use PASID 0 in caching mode (virtualised > > IOMMU) */ > > - ret = intel_pasid_alloc_id(svm, > > - !!cap_caching_mode(iommu->cap), > > - pasid_max - 1, > > GFP_KERNEL); > > - if (ret < 0) { > > + /* Do not use PASID 0, reserved for RID to PASID */ > > + svm->pasid = ioasid_alloc(NULL, PASID_MIN, > > + pasid_max - 1, svm); > > + if (svm->pasid == INVALID_IOASID) { > > kfree(svm); > > kfree(sdev); > > + ret = ENOSPC; > > goto out; > > } > > - svm->pasid = ret; > > svm->notifier.ops = &intel_mmuops; > > svm->mm = mm; > > svm->flags = flags; > > @@ -351,7 +351,7 @@ int intel_svm_bind_mm(struct device *dev, int > > *pasid, int flags, struct svm_dev_ if (mm) { > > ret = > > mmu_notifier_register(&svm->notifier, mm); if (ret) { > > - intel_pasid_free_id(svm->pasid); > > + ioasid_free(svm->pasid); > > kfree(svm); > > kfree(sdev); > > goto out; > > @@ -367,7 +367,7 @@ int intel_svm_bind_mm(struct device *dev, int > > *pasid, int flags, struct svm_dev_ if (ret) { > > if (mm) > > mmu_notifier_unregister(&svm->notifier, > > mm); > > - intel_pasid_free_id(svm->pasid); > > + ioasid_free(svm->pasid); > > kfree(svm); > > kfree(sdev); > > goto out; > > @@ -400,7 +400,12 @@ int intel_svm_unbind_mm(struct device *dev, > > int pasid) if (!iommu) > > goto out; > > > > - svm = intel_pasid_lookup_id(pasid); > > + svm = ioasid_find(NULL, pasid, NULL); > > + if (IS_ERR(svm)) { > > + ret = PTR_ERR(svm); > > + goto out; > > + } > > + > > if (!svm) > > goto out; > > > > How about using IS_ERR_OR_NULL() here? > makes sense, same below. thanks! > [...] > > Same here. > > [...] > > Ditto. > > [...] > > Best regards, > Baolu [Jacob Pan]
WARNING: multiple messages have this Message-ID (diff)
From: Jacob Pan <jacob.jun.pan@linux.intel.com> To: Lu Baolu <baolu.lu@linux.intel.com> Cc: "Tian, Kevin" <kevin.tian@intel.com>, Raj Ashok <ashok.raj@intel.com>, Jean-Philippe Brucker <jean-philippe.brucker@arm.com>, iommu@lists.linux-foundation.org, LKML <linux-kernel@vger.kernel.org>, Alex Williamson <alex.williamson@redhat.com>, Andriy Shevchenko <andriy.shevchenko@linux.intel.com>, David Woodhouse <dwmw2@infradead.org> Subject: Re: [PATCH v4 15/22] iommu/vt-d: Replace Intel specific PASID allocator with IOASID Date: Thu, 27 Jun 2019 08:40:33 -0700 [thread overview] Message-ID: <20190627084033.650dc7ed@jacob-builder> (raw) In-Reply-To: <1cffc7c7-b71b-767a-a35f-d6063dc64b2b@linux.intel.com> On Thu, 27 Jun 2019 09:53:11 +0800 Lu Baolu <baolu.lu@linux.intel.com> wrote: > Hi Jacob, > > On 6/9/19 9:44 PM, Jacob Pan wrote: > > Make use of generic IOASID code to manage PASID allocation, > > free, and lookup. Replace Intel specific code. > > > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> > > --- > > drivers/iommu/intel-iommu.c | 11 +++++------ > > drivers/iommu/intel-pasid.c | 36 > > ------------------------------------ drivers/iommu/intel-svm.c | > > 37 +++++++++++++++++++++---------------- 3 files changed, 26 > > insertions(+), 58 deletions(-) > > > > diff --git a/drivers/iommu/intel-iommu.c > > b/drivers/iommu/intel-iommu.c index 5b84994..39b63fe 100644 > > --- a/drivers/iommu/intel-iommu.c > > +++ b/drivers/iommu/intel-iommu.c > > @@ -5167,7 +5167,7 @@ static void auxiliary_unlink_device(struct > > dmar_domain *domain, domain->auxd_refcnt--; > > > > if (!domain->auxd_refcnt && domain->default_pasid > 0) > > - intel_pasid_free_id(domain->default_pasid); > > + ioasid_free(domain->default_pasid); > > } > > > > static int aux_domain_add_dev(struct dmar_domain *domain, > > @@ -5185,10 +5185,9 @@ static int aux_domain_add_dev(struct > > dmar_domain *domain, if (domain->default_pasid <= 0) { > > int pasid; > > > > - pasid = intel_pasid_alloc_id(domain, PASID_MIN, > > - > > pci_max_pasids(to_pci_dev(dev)), > > - GFP_KERNEL); > > - if (pasid <= 0) { > > + pasid = ioasid_alloc(NULL, PASID_MIN, > > pci_max_pasids(to_pci_dev(dev)) - 1, > > + domain); > > + if (pasid == INVALID_IOASID) { > > pr_err("Can't allocate default pasid\n"); > > return -ENODEV; > > } > > @@ -5224,7 +5223,7 @@ static int aux_domain_add_dev(struct > > dmar_domain *domain, spin_unlock(&iommu->lock); > > spin_unlock_irqrestore(&device_domain_lock, flags); > > if (!domain->auxd_refcnt && domain->default_pasid > 0) > > - intel_pasid_free_id(domain->default_pasid); > > + ioasid_free(domain->default_pasid); > > > > return ret; > > } > > diff --git a/drivers/iommu/intel-pasid.c > > b/drivers/iommu/intel-pasid.c index 69fddd3..1e25539 100644 > > --- a/drivers/iommu/intel-pasid.c > > +++ b/drivers/iommu/intel-pasid.c > > @@ -26,42 +26,6 @@ > > */ > > static DEFINE_SPINLOCK(pasid_lock); > > u32 intel_pasid_max_id = PASID_MAX; > > -static DEFINE_IDR(pasid_idr); > > - > > -int intel_pasid_alloc_id(void *ptr, int start, int end, gfp_t gfp) > > -{ > > - int ret, min, max; > > - > > - min = max_t(int, start, PASID_MIN); > > - max = min_t(int, end, intel_pasid_max_id); > > - > > - WARN_ON(in_interrupt()); > > - idr_preload(gfp); > > - spin_lock(&pasid_lock); > > - ret = idr_alloc(&pasid_idr, ptr, min, max, GFP_ATOMIC); > > - spin_unlock(&pasid_lock); > > - idr_preload_end(); > > - > > - return ret; > > -} > > - > > -void intel_pasid_free_id(int pasid) > > -{ > > - spin_lock(&pasid_lock); > > - idr_remove(&pasid_idr, pasid); > > - spin_unlock(&pasid_lock); > > -} > > - > > -void *intel_pasid_lookup_id(int pasid) > > -{ > > - void *p; > > - > > - spin_lock(&pasid_lock); > > - p = idr_find(&pasid_idr, pasid); > > - spin_unlock(&pasid_lock); > > - > > - return p; > > -} > > > > int vcmd_alloc_pasid(struct intel_iommu *iommu, unsigned int > > *pasid) { > > diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c > > index 8f87304..9cbcc1f 100644 > > --- a/drivers/iommu/intel-svm.c > > +++ b/drivers/iommu/intel-svm.c > > @@ -25,6 +25,7 @@ > > #include <linux/dmar.h> > > #include <linux/interrupt.h> > > #include <linux/mm_types.h> > > +#include <linux/ioasid.h> > > #include <asm/page.h> > > > > #include "intel-pasid.h" > > @@ -332,16 +333,15 @@ int intel_svm_bind_mm(struct device *dev, int > > *pasid, int flags, struct svm_dev_ if (pasid_max > > > intel_pasid_max_id) pasid_max = intel_pasid_max_id; > > > > - /* Do not use PASID 0 in caching mode (virtualised > > IOMMU) */ > > - ret = intel_pasid_alloc_id(svm, > > - !!cap_caching_mode(iommu->cap), > > - pasid_max - 1, > > GFP_KERNEL); > > - if (ret < 0) { > > + /* Do not use PASID 0, reserved for RID to PASID */ > > + svm->pasid = ioasid_alloc(NULL, PASID_MIN, > > + pasid_max - 1, svm); > > + if (svm->pasid == INVALID_IOASID) { > > kfree(svm); > > kfree(sdev); > > + ret = ENOSPC; > > goto out; > > } > > - svm->pasid = ret; > > svm->notifier.ops = &intel_mmuops; > > svm->mm = mm; > > svm->flags = flags; > > @@ -351,7 +351,7 @@ int intel_svm_bind_mm(struct device *dev, int > > *pasid, int flags, struct svm_dev_ if (mm) { > > ret = > > mmu_notifier_register(&svm->notifier, mm); if (ret) { > > - intel_pasid_free_id(svm->pasid); > > + ioasid_free(svm->pasid); > > kfree(svm); > > kfree(sdev); > > goto out; > > @@ -367,7 +367,7 @@ int intel_svm_bind_mm(struct device *dev, int > > *pasid, int flags, struct svm_dev_ if (ret) { > > if (mm) > > mmu_notifier_unregister(&svm->notifier, > > mm); > > - intel_pasid_free_id(svm->pasid); > > + ioasid_free(svm->pasid); > > kfree(svm); > > kfree(sdev); > > goto out; > > @@ -400,7 +400,12 @@ int intel_svm_unbind_mm(struct device *dev, > > int pasid) if (!iommu) > > goto out; > > > > - svm = intel_pasid_lookup_id(pasid); > > + svm = ioasid_find(NULL, pasid, NULL); > > + if (IS_ERR(svm)) { > > + ret = PTR_ERR(svm); > > + goto out; > > + } > > + > > if (!svm) > > goto out; > > > > How about using IS_ERR_OR_NULL() here? > makes sense, same below. thanks! > [...] > > Same here. > > [...] > > Ditto. > > [...] > > Best regards, > Baolu [Jacob Pan] _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-06-27 15:37 UTC|newest] Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-09 13:44 [PATCH v4 00/22] Shared virtual address IOMMU and VT-d support Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-09 13:44 ` [PATCH v4 01/22] driver core: Add per device iommu param Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-09 13:44 ` [PATCH v4 02/22] iommu: Introduce device fault data Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-18 15:42 ` Jonathan Cameron 2019-06-18 15:42 ` Jonathan Cameron 2019-06-09 13:44 ` [PATCH v4 03/22] iommu: Introduce device fault report API Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-18 15:41 ` Jonathan Cameron 2019-06-18 15:41 ` Jonathan Cameron 2019-06-09 13:44 ` [PATCH v4 04/22] iommu: Add recoverable fault reporting Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-18 15:44 ` Jonathan Cameron 2019-06-18 15:44 ` Jonathan Cameron 2019-06-09 13:44 ` [PATCH v4 05/22] iommu: Add a timeout parameter for PRQ response Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-09 13:44 ` [PATCH v4 06/22] trace/iommu: Add sva trace events Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-09 13:44 ` [PATCH v4 07/22] iommu: Use device fault trace event Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-09 13:44 ` [PATCH v4 08/22] iommu: Introduce attach/detach_pasid_table API Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-18 15:41 ` Jonathan Cameron 2019-06-18 15:41 ` Jonathan Cameron 2019-06-24 15:06 ` Auger Eric 2019-06-24 15:06 ` Auger Eric 2019-06-24 15:23 ` Jean-Philippe Brucker 2019-06-24 15:23 ` Jean-Philippe Brucker 2019-06-09 13:44 ` [PATCH v4 09/22] iommu: Introduce cache_invalidate API Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-18 15:41 ` Jonathan Cameron 2019-06-18 15:41 ` Jonathan Cameron 2019-06-09 13:44 ` [PATCH v4 10/22] iommu: Fix compile error without IOMMU_API Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-18 14:10 ` Jonathan Cameron 2019-06-18 14:10 ` Jonathan Cameron 2019-06-24 22:28 ` Jacob Pan 2019-06-24 22:28 ` Jacob Pan 2019-06-09 13:44 ` [PATCH v4 11/22] iommu: Introduce guest PASID bind function Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-18 15:36 ` Jean-Philippe Brucker 2019-06-18 15:36 ` Jean-Philippe Brucker 2019-06-24 22:24 ` Jacob Pan 2019-06-24 22:24 ` Jacob Pan 2019-07-16 16:44 ` Auger Eric 2019-07-16 16:44 ` Auger Eric 2019-08-05 21:02 ` Jacob Pan 2019-08-05 21:02 ` Jacob Pan 2019-08-05 23:13 ` Jacob Pan 2019-08-05 23:13 ` Jacob Pan 2019-06-09 13:44 ` [PATCH v4 12/22] iommu: Add I/O ASID allocator Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-18 16:50 ` Jonathan Cameron 2019-06-18 16:50 ` Jonathan Cameron 2019-06-25 18:55 ` Jacob Pan 2019-06-25 18:55 ` Jacob Pan 2019-06-09 13:44 ` [PATCH v4 13/22] iommu/vt-d: Enlightened PASID allocation Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-07-16 9:29 ` Auger Eric 2019-07-16 9:29 ` Auger Eric 2019-08-13 16:57 ` Jacob Pan 2019-08-13 16:57 ` Jacob Pan 2019-06-09 13:44 ` [PATCH v4 14/22] iommu/vt-d: Add custom allocator for IOASID Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-07-16 9:30 ` Auger Eric 2019-07-16 9:30 ` Auger Eric 2019-08-05 20:02 ` Jacob Pan 2019-08-05 20:02 ` Jacob Pan 2019-06-09 13:44 ` [PATCH v4 15/22] iommu/vt-d: Replace Intel specific PASID allocator with IOASID Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-18 15:57 ` Jonathan Cameron 2019-06-18 15:57 ` Jonathan Cameron 2019-06-24 21:36 ` Jacob Pan 2019-06-24 21:36 ` Jacob Pan 2019-06-27 1:53 ` Lu Baolu 2019-06-27 1:53 ` Lu Baolu 2019-06-27 15:40 ` Jacob Pan [this message] 2019-06-27 15:40 ` Jacob Pan 2019-06-09 13:44 ` [PATCH v4 16/22] iommu/vt-d: Move domain helper to header Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-07-16 9:33 ` Auger Eric 2019-07-16 9:33 ` Auger Eric 2019-06-09 13:44 ` [PATCH v4 17/22] iommu/vt-d: Avoid duplicated code for PASID setup Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-18 16:03 ` Jonathan Cameron 2019-06-18 16:03 ` Jonathan Cameron 2019-06-24 23:44 ` Jacob Pan 2019-06-24 23:44 ` Jacob Pan 2019-07-16 9:52 ` Auger Eric 2019-07-16 9:52 ` Auger Eric 2019-06-09 13:44 ` [PATCH v4 18/22] iommu/vt-d: Add nested translation helper function Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-09 13:44 ` [PATCH v4 19/22] iommu/vt-d: Clean up for SVM device list Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-18 16:42 ` Jonathan Cameron 2019-06-18 16:42 ` Jonathan Cameron 2019-06-24 23:59 ` Jacob Pan 2019-06-24 23:59 ` Jacob Pan 2019-06-09 13:44 ` [PATCH v4 20/22] iommu/vt-d: Add bind guest PASID support Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-06-18 16:44 ` Jonathan Cameron 2019-06-18 16:44 ` Jonathan Cameron 2019-06-24 22:41 ` Jacob Pan 2019-06-24 22:41 ` Jacob Pan 2019-06-27 2:50 ` Lu Baolu 2019-06-27 2:50 ` Lu Baolu 2019-06-27 20:22 ` Jacob Pan 2019-06-27 20:22 ` Jacob Pan 2019-07-05 2:21 ` Lu Baolu 2019-07-05 2:21 ` Lu Baolu 2019-08-14 17:20 ` Jacob Pan 2019-08-14 17:20 ` Jacob Pan 2019-07-16 16:45 ` Auger Eric 2019-07-16 16:45 ` Auger Eric 2019-07-16 17:04 ` Raj, Ashok 2019-07-16 17:04 ` Raj, Ashok 2019-07-18 7:47 ` Auger Eric 2019-07-18 7:47 ` Auger Eric 2019-06-09 13:44 ` [PATCH v4 21/22] iommu/vt-d: Support flushing more translation cache types Jacob Pan 2019-06-09 13:44 ` Jacob Pan 2019-07-18 8:35 ` Auger Eric 2019-07-18 8:35 ` Auger Eric 2019-08-14 20:17 ` Jacob Pan 2019-08-14 20:17 ` Jacob Pan 2019-06-09 13:44 ` [PATCH v4 22/22] iommu/vt-d: Add svm/sva invalidate function Jacob Pan 2019-06-09 13:44 ` Jacob Pan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190627084033.650dc7ed@jacob-builder \ --to=jacob.jun.pan@linux.intel.com \ --cc=alex.williamson@redhat.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=ashok.raj@intel.com \ --cc=baolu.lu@linux.intel.com \ --cc=dwmw2@infradead.org \ --cc=eric.auger@redhat.com \ --cc=hch@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jean-philippe.brucker@arm.com \ --cc=joro@8bytes.org \ --cc=kevin.tian@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=yi.l.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.