[PATCH v7 0/3] drm/i915: CTS fixes

[PATCH v7 0/3] drm/i915: CTS fixes

[Lionel Landwerlin]

Anuj tested the update to the ICL whitelist. We need a good soul to
either Rb/Ack the rest.

Thanks,

Lionel Landwerlin (3):
  drm/i915: fix whitelist selftests with readonly registers
  drm/i915: whitelist PS_(DEPTH|INVOCATION)_COUNT
  drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT

 drivers/gpu/drm/i915/gt/intel_workarounds.c   | 30 ++++++++++++++++++-
 .../gpu/drm/i915/gt/selftest_workarounds.c    |  3 ++
 2 files changed, 32 insertions(+), 1 deletion(-)

--
2.21.0.392.gf8f6787159e
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH v7 1/3] drm/i915: fix whitelist selftests with readonly registers

[Lionel Landwerlin]

When a register is readonly there is not much we can tell about its
value (apart from its default value?). This can be covered by tests
exercising the value of the register from userspace.

For PS_INVOCATION_COUNT we've got the following piglit tests :

   KHR-GL45.pipeline_statistics_query_tests_ARB.functional_fragment_shader_invocations

Vulkan CTS tests :

   dEQP-VK.query_pool.statistics_query.fragment_shader_invocations.*

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 86554f48e511 ("drm/i915/selftests: Verify whitelist of context registers")
---
 drivers/gpu/drm/i915/gt/selftest_workarounds.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/selftest_workarounds.c b/drivers/gpu/drm/i915/gt/selftest_workarounds.c
index f12cb20fe785..a06f96df1bfd 100644
--- a/drivers/gpu/drm/i915/gt/selftest_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/selftest_workarounds.c
@@ -926,6 +926,9 @@ check_whitelisted_registers(struct intel_engine_cs *engine,
 
 	err = 0;
 	for (i = 0; i < engine->whitelist.count; i++) {
+		if (engine->whitelist.list[i].reg.reg & RING_FORCE_TO_NONPRIV_RD)
+			continue;
+
 		if (!fn(engine, a[i], b[i], engine->whitelist.list[i].reg))
 			err = -EINVAL;
 	}
-- 
2.21.0.392.gf8f6787159e

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH v7 2/3] drm/i915: whitelist PS_(DEPTH|INVOCATION)_COUNT

[Lionel Landwerlin]

CFL:C0+ changed the status of those registers which are now
blacklisted by default.

This is breaking a number of CTS tests on GL & Vulkan :

  KHR-GL45.pipeline_statistics_query_tests_ARB.functional_fragment_shader_invocations (GL)

  dEQP-VK.query_pool.statistics_query.fragment_shader_invocations.* (Vulkan)

v2: Only use one whitelist entry (Lionel)

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 993804d09517..b117583e38bb 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1092,10 +1092,25 @@ static void glk_whitelist_build(struct intel_engine_cs *engine)
 
 static void cfl_whitelist_build(struct intel_engine_cs *engine)
 {
+	struct i915_wa_list *w = &engine->whitelist;
+
 	if (engine->class != RENDER_CLASS)
 		return;
 
-	gen9_whitelist_build(&engine->whitelist);
+	gen9_whitelist_build(w);
+
+	/*
+	 * WaAllowPMDepthAndInvocationCountAccessFromUMD:cfl,whl,cml,aml
+	 *
+	 * This covers 4 register which are next to one another :
+	 *   - PS_INVOCATION_COUNT
+	 *   - PS_INVOCATION_COUNT_UDW
+	 *   - PS_DEPTH_COUNT
+	 *   - PS_DEPTH_COUNT_UDW
+	 */
+	whitelist_reg_ext(w, PS_INVOCATION_COUNT,
+			  RING_FORCE_TO_NONPRIV_RD |
+			  RING_FORCE_TO_NONPRIV_RANGE_4);
 }
 
 static void cnl_whitelist_build(struct intel_engine_cs *engine)
-- 
2.21.0.392.gf8f6787159e

[PATCH v7 3/3] drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT

[Lionel Landwerlin]

The same tests failing on CFL+ platforms are also failing on ICL.
Documentation doesn't list the
WaAllowPMDepthAndInvocationCountAccessFromUMD workaround for ICL but
applying it fixes the same tests as CFL.

v2: Use only one whitelist entry (Lionel)

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Tested-by:  Anuj Phogat <anuj.phogat@gmail.com>
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index b117583e38bb..a908d829d6bd 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1138,6 +1138,19 @@ static void icl_whitelist_build(struct intel_engine_cs *engine)
 
 		/* WaEnableStateCacheRedirectToCS:icl */
 		whitelist_reg(w, GEN9_SLICE_COMMON_ECO_CHICKEN1);
+
+		/*
+		 * WaAllowPMDepthAndInvocationCountAccessFromUMD:icl
+		 *
+		 * This covers 4 register which are next to one another :
+		 *   - PS_INVOCATION_COUNT
+		 *   - PS_INVOCATION_COUNT_UDW
+		 *   - PS_DEPTH_COUNT
+		 *   - PS_DEPTH_COUNT_UDW
+		 */
+		whitelist_reg_ext(w, PS_INVOCATION_COUNT,
+				  RING_FORCE_TO_NONPRIV_RD |
+				  RING_FORCE_TO_NONPRIV_RANGE_4);
 		break;
 
 	case VIDEO_DECODE_CLASS:
-- 
2.21.0.392.gf8f6787159e

✗ Fi.CI.CHECKPATCH: warning for drm/i915: CTS fixes (rev7)

[Patchwork]

== Series Details ==

Series: drm/i915: CTS fixes (rev7)
URL   : https://patchwork.freedesktop.org/series/62437/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2d3e1d83dab1 drm/i915: fix whitelist selftests with readonly registers
-:12: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12: 
   KHR-GL45.pipeline_statistics_query_tests_ARB.functional_fragment_shader_invocations

total: 0 errors, 1 warnings, 0 checks, 9 lines checked
cc8667f8e259 drm/i915: whitelist PS_(DEPTH|INVOCATION)_COUNT
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11: 
  KHR-GL45.pipeline_statistics_query_tests_ARB.functional_fragment_shader_invocations (GL)

total: 0 errors, 1 warnings, 0 checks, 26 lines checked
14633be38d4e drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT
-:14: WARNING:BAD_SIGN_OFF: Use a single space after Tested-by:
#14: 
Tested-by:  Anuj Phogat <anuj.phogat@gmail.com>

total: 0 errors, 1 warnings, 0 checks, 19 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v7 1/3] drm/i915: fix whitelist selftests with readonly registers

[Anuj Phogat]

For the series:
Tested-by: Anuj Phogat <anuj.phogat@gmail.com>


On Fri, Jun 28, 2019 at 5:07 AM Lionel Landwerlin
<lionel.g.landwerlin@intel.com> wrote:
>
> When a register is readonly there is not much we can tell about its
> value (apart from its default value?). This can be covered by tests
> exercising the value of the register from userspace.
>
> For PS_INVOCATION_COUNT we've got the following piglit tests :
>
>    KHR-GL45.pipeline_statistics_query_tests_ARB.functional_fragment_shader_invocations
>
> Vulkan CTS tests :
>
>    dEQP-VK.query_pool.statistics_query.fragment_shader_invocations.*
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Fixes: 86554f48e511 ("drm/i915/selftests: Verify whitelist of context registers")
> ---
>  drivers/gpu/drm/i915/gt/selftest_workarounds.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_workarounds.c b/drivers/gpu/drm/i915/gt/selftest_workarounds.c
> index f12cb20fe785..a06f96df1bfd 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_workarounds.c
> @@ -926,6 +926,9 @@ check_whitelisted_registers(struct intel_engine_cs *engine,
>
>         err = 0;
>         for (i = 0; i < engine->whitelist.count; i++) {
> +               if (engine->whitelist.list[i].reg.reg & RING_FORCE_TO_NONPRIV_RD)
> +                       continue;
> +
>                 if (!fn(engine, a[i], b[i], engine->whitelist.list[i].reg))
>                         err = -EINVAL;
>         }
> --
> 2.21.0.392.gf8f6787159e
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915: CTS fixes (rev7)

[Patchwork]

== Series Details ==

Series: drm/i915: CTS fixes (rev7)
URL   : https://patchwork.freedesktop.org/series/62437/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6380 -> Patchwork_13469
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/

Known issues
------------

  Here are the changes found in Patchwork_13469 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_fence@basic-wait-default:
    - fi-icl-u3:          [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/fi-icl-u3/igt@gem_exec_fence@basic-wait-default.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/fi-icl-u3/igt@gem_exec_fence@basic-wait-default.html

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-blb-e6850:       [PASS][3] -> [INCOMPLETE][4] ([fdo#107718])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-icl-u3:          [PASS][5] -> [FAIL][6] ([fdo#103167])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/fi-icl-u3/igt@kms_frontbuffer_tracking@basic.html

  
#### Possible fixes ####

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - fi-kbl-r:           [DMESG-WARN][7] ([fdo#111012]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/fi-kbl-r/igt@i915_pm_rpm@basic-pci-d3-state.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/fi-kbl-r/igt@i915_pm_rpm@basic-pci-d3-state.html

  * igt@i915_selftest@live_blt:
    - fi-skl-iommu:       [INCOMPLETE][9] ([fdo#108602]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/fi-skl-iommu/igt@i915_selftest@live_blt.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/fi-skl-iommu/igt@i915_selftest@live_blt.html

  
#### Warnings ####

  * igt@runner@aborted:
    - fi-kbl-r:           [FAIL][11] ([fdo#103841] / [fdo#110992]) -> [FAIL][12] ([fdo#103841] / [fdo#109383] / [fdo#110992])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/fi-kbl-r/igt@runner@aborted.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/fi-kbl-r/igt@runner@aborted.html

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103841]: https://bugs.freedesktop.org/show_bug.cgi?id=103841
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
  [fdo#109383]: https://bugs.freedesktop.org/show_bug.cgi?id=109383
  [fdo#110992]: https://bugs.freedesktop.org/show_bug.cgi?id=110992
  [fdo#111012]: https://bugs.freedesktop.org/show_bug.cgi?id=111012


Participating hosts (52 -> 44)
------------------------------

  Missing    (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-icl-y fi-icl-dsi 


Build changes
-------------

  * Linux: CI_DRM_6380 -> Patchwork_13469

  CI_DRM_6380: ea9572c68749ecb4eac919803b02a5a1be1782fc @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5073: fd02e325b9169e69b8a444137a553f359967c227 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13469: 14633be38d4ec70cec2cadb193f03bfa16aea452 @ git://anongit.freedesktop.org/gfx-ci/linux


== Kernel 32bit build ==

Warning: Kernel 32bit buildtest failed:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/build_32bit.log

  CALL    scripts/checksyscalls.sh
  CALL    scripts/atomic/check-atomics.sh
  CHK     include/generated/compile.h
Kernel: arch/x86/boot/bzImage is ready  (#1)
  Building modules, stage 2.
  MODPOST 112 modules
ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: "__divdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
scripts/Makefile.modpost:91: recipe for target '__modpost' failed
make[1]: *** [__modpost] Error 1
Makefile:1287: recipe for target 'modules' failed
make: *** [modules] Error 2


== Linux commits ==

14633be38d4e drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT
cc8667f8e259 drm/i915: whitelist PS_(DEPTH|INVOCATION)_COUNT
2d3e1d83dab1 drm/i915: fix whitelist selftests with readonly registers

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for drm/i915: CTS fixes (rev7)

[Patchwork]

== Series Details ==

Series: drm/i915: CTS fixes (rev7)
URL   : https://patchwork.freedesktop.org/series/62437/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6380_full -> Patchwork_13469_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Known issues
------------

  Here are the changes found in Patchwork_13469_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [PASS][1] -> [SKIP][2] ([fdo#110854])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-iclb4/igt@gem_exec_balancer@smoke.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-iclb7/igt@gem_exec_balancer@smoke.html

  * igt@gem_exec_nop@basic-series:
    - shard-hsw:          [PASS][3] -> [INCOMPLETE][4] ([fdo#103540])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-hsw1/igt@gem_exec_nop@basic-series.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-hsw4/igt@gem_exec_nop@basic-series.html

  * igt@gem_softpin@noreloc-s3:
    - shard-kbl:          [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +2 similar issues
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-kbl1/igt@gem_softpin@noreloc-s3.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-kbl3/igt@gem_softpin@noreloc-s3.html

  * igt@gem_workarounds@suspend-resume-context:
    - shard-skl:          [PASS][7] -> [INCOMPLETE][8] ([fdo#104108])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-skl6/igt@gem_workarounds@suspend-resume-context.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-skl1/igt@gem_workarounds@suspend-resume-context.html

  * igt@kms_color@pipe-c-ctm-negative:
    - shard-skl:          [PASS][9] -> [FAIL][10] ([fdo#107361])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-skl7/igt@kms_color@pipe-c-ctm-negative.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-skl3/igt@kms_color@pipe-c-ctm-negative.html

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
    - shard-hsw:          [PASS][11] -> [FAIL][12] ([fdo#105767])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-hsw5/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html

  * igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
    - shard-hsw:          [PASS][13] -> [SKIP][14] ([fdo#109271])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-hsw2/igt@kms_flip@2x-dpms-vs-vblank-race-interruptible.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-hsw1/igt@kms_flip@2x-dpms-vs-vblank-race-interruptible.html

  * igt@kms_flip_tiling@flip-yf-tiled:
    - shard-skl:          [PASS][15] -> [FAIL][16] ([fdo#108145])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-skl7/igt@kms_flip_tiling@flip-yf-tiled.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-skl3/igt@kms_flip_tiling@flip-yf-tiled.html

  * igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
    - shard-iclb:         [PASS][17] -> [FAIL][18] ([fdo#103167]) +1 similar issue
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         [PASS][19] -> [SKIP][20] ([fdo#109441]) +3 similar issues
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [PASS][21] -> [FAIL][22] ([fdo#99912])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-kbl3/igt@kms_setmode@basic.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-kbl1/igt@kms_setmode@basic.html

  * igt@kms_sysfs_edid_timing:
    - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#100047])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-iclb6/igt@kms_sysfs_edid_timing.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-iclb3/igt@kms_sysfs_edid_timing.html

  * igt@perf_pmu@rc6-runtime-pm:
    - shard-iclb:         [PASS][25] -> [FAIL][26] ([fdo#105010])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-iclb1/igt@perf_pmu@rc6-runtime-pm.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-iclb2/igt@perf_pmu@rc6-runtime-pm.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s3:
    - shard-kbl:          [DMESG-WARN][27] ([fdo#108566]) -> [PASS][28] +3 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-kbl6/igt@gem_exec_suspend@basic-s3.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-kbl6/igt@gem_exec_suspend@basic-s3.html

  * igt@kms_atomic_transition@2x-modeset-transitions-fencing:
    - shard-hsw:          [SKIP][29] ([fdo#109271]) -> [PASS][30] +25 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-hsw1/igt@kms_atomic_transition@2x-modeset-transitions-fencing.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-hsw5/igt@kms_atomic_transition@2x-modeset-transitions-fencing.html

  * igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding:
    - shard-skl:          [FAIL][31] ([fdo#103232]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding.html

  * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
    - shard-glk:          [FAIL][33] ([fdo#104873]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-glk2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-glk5/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-glk:          [FAIL][35] ([fdo#105363]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
    - shard-iclb:         [FAIL][37] ([fdo#103167]) -> [PASS][38] +6 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
    - shard-snb:          [DMESG-WARN][39] ([fdo#102365]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-snb6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-snb1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [SKIP][41] ([fdo#109441]) -> [PASS][42] +3 similar issues
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-apl:          [DMESG-WARN][43] ([fdo#108566]) -> [PASS][44] +5 similar issues
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-apl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-apl8/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@perf@blocking:
    - shard-skl:          [FAIL][45] ([fdo#110728]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-skl6/igt@perf@blocking.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-skl1/igt@perf@blocking.html

  * igt@perf_pmu@rc6-runtime-pm:
    - shard-glk:          [FAIL][47] ([fdo#105010]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-glk3/igt@perf_pmu@rc6-runtime-pm.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-glk9/igt@perf_pmu@rc6-runtime-pm.html

  
#### Warnings ####

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [SKIP][49] ([fdo#109349]) -> [DMESG-WARN][50] ([fdo#107724])
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-iclb7/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  
  [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
  [fdo#102365]: https://bugs.freedesktop.org/show_bug.cgi?id=102365
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
  [fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
  [fdo#107361]: https://bugs.freedesktop.org/show_bug.cgi?id=107361
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
  [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_6380 -> Patchwork_13469

  CI_DRM_6380: ea9572c68749ecb4eac919803b02a5a1be1782fc @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5073: fd02e325b9169e69b8a444137a553f359967c227 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13469: 14633be38d4ec70cec2cadb193f03bfa16aea452 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✓ Fi.CI.IGT: success for drm/i915: CTS fixes (rev7)

[Lionel Landwerlin]

Okay to land?

-Lionel

On 29/06/2019 06:33, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: CTS fixes (rev7)
> URL   : https://patchwork.freedesktop.org/series/62437/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_6380_full -> Patchwork_13469_full
> ====================================================
>
> Summary
> -------
>
>    **SUCCESS**
>
>    No regressions found.
>
>    
>
> Known issues
> ------------
>
>    Here are the changes found in Patchwork_13469_full that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>    * igt@gem_exec_balancer@smoke:
>      - shard-iclb:         [PASS][1] -> [SKIP][2] ([fdo#110854])
>     [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-iclb4/igt@gem_exec_balancer@smoke.html
>     [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-iclb7/igt@gem_exec_balancer@smoke.html
>
>    * igt@gem_exec_nop@basic-series:
>      - shard-hsw:          [PASS][3] -> [INCOMPLETE][4] ([fdo#103540])
>     [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-hsw1/igt@gem_exec_nop@basic-series.html
>     [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-hsw4/igt@gem_exec_nop@basic-series.html
>
>    * igt@gem_softpin@noreloc-s3:
>      - shard-kbl:          [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +2 similar issues
>     [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-kbl1/igt@gem_softpin@noreloc-s3.html
>     [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-kbl3/igt@gem_softpin@noreloc-s3.html
>
>    * igt@gem_workarounds@suspend-resume-context:
>      - shard-skl:          [PASS][7] -> [INCOMPLETE][8] ([fdo#104108])
>     [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-skl6/igt@gem_workarounds@suspend-resume-context.html
>     [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-skl1/igt@gem_workarounds@suspend-resume-context.html
>
>    * igt@kms_color@pipe-c-ctm-negative:
>      - shard-skl:          [PASS][9] -> [FAIL][10] ([fdo#107361])
>     [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-skl7/igt@kms_color@pipe-c-ctm-negative.html
>     [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-skl3/igt@kms_color@pipe-c-ctm-negative.html
>
>    * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
>      - shard-hsw:          [PASS][11] -> [FAIL][12] ([fdo#105767])
>     [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-hsw5/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
>     [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
>
>    * igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
>      - shard-hsw:          [PASS][13] -> [SKIP][14] ([fdo#109271])
>     [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-hsw2/igt@kms_flip@2x-dpms-vs-vblank-race-interruptible.html
>     [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-hsw1/igt@kms_flip@2x-dpms-vs-vblank-race-interruptible.html
>
>    * igt@kms_flip_tiling@flip-yf-tiled:
>      - shard-skl:          [PASS][15] -> [FAIL][16] ([fdo#108145])
>     [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-skl7/igt@kms_flip_tiling@flip-yf-tiled.html
>     [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-skl3/igt@kms_flip_tiling@flip-yf-tiled.html
>
>    * igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
>      - shard-iclb:         [PASS][17] -> [FAIL][18] ([fdo#103167]) +1 similar issue
>     [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
>     [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
>
>    * igt@kms_psr@psr2_sprite_plane_move:
>      - shard-iclb:         [PASS][19] -> [SKIP][20] ([fdo#109441]) +3 similar issues
>     [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
>     [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
>
>    * igt@kms_setmode@basic:
>      - shard-kbl:          [PASS][21] -> [FAIL][22] ([fdo#99912])
>     [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-kbl3/igt@kms_setmode@basic.html
>     [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-kbl1/igt@kms_setmode@basic.html
>
>    * igt@kms_sysfs_edid_timing:
>      - shard-iclb:         [PASS][23] -> [FAIL][24] ([fdo#100047])
>     [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-iclb6/igt@kms_sysfs_edid_timing.html
>     [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-iclb3/igt@kms_sysfs_edid_timing.html
>
>    * igt@perf_pmu@rc6-runtime-pm:
>      - shard-iclb:         [PASS][25] -> [FAIL][26] ([fdo#105010])
>     [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-iclb1/igt@perf_pmu@rc6-runtime-pm.html
>     [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-iclb2/igt@perf_pmu@rc6-runtime-pm.html
>
>    
> #### Possible fixes ####
>
>    * igt@gem_exec_suspend@basic-s3:
>      - shard-kbl:          [DMESG-WARN][27] ([fdo#108566]) -> [PASS][28] +3 similar issues
>     [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-kbl6/igt@gem_exec_suspend@basic-s3.html
>     [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-kbl6/igt@gem_exec_suspend@basic-s3.html
>
>    * igt@kms_atomic_transition@2x-modeset-transitions-fencing:
>      - shard-hsw:          [SKIP][29] ([fdo#109271]) -> [PASS][30] +25 similar issues
>     [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-hsw1/igt@kms_atomic_transition@2x-modeset-transitions-fencing.html
>     [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-hsw5/igt@kms_atomic_transition@2x-modeset-transitions-fencing.html
>
>    * igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding:
>      - shard-skl:          [FAIL][31] ([fdo#103232]) -> [PASS][32]
>     [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding.html
>     [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding.html
>
>    * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
>      - shard-glk:          [FAIL][33] ([fdo#104873]) -> [PASS][34]
>     [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-glk2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
>     [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-glk5/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
>
>    * igt@kms_flip@flip-vs-expired-vblank-interruptible:
>      - shard-glk:          [FAIL][35] ([fdo#105363]) -> [PASS][36]
>     [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
>     [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
>
>    * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
>      - shard-iclb:         [FAIL][37] ([fdo#103167]) -> [PASS][38] +6 similar issues
>     [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
>     [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
>
>    * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
>      - shard-snb:          [DMESG-WARN][39] ([fdo#102365]) -> [PASS][40]
>     [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-snb6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
>     [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-snb1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
>
>    * igt@kms_psr@psr2_primary_mmap_cpu:
>      - shard-iclb:         [SKIP][41] ([fdo#109441]) -> [PASS][42] +3 similar issues
>     [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
>     [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
>
>    * igt@kms_vblank@pipe-a-ts-continuation-suspend:
>      - shard-apl:          [DMESG-WARN][43] ([fdo#108566]) -> [PASS][44] +5 similar issues
>     [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-apl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
>     [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-apl8/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
>
>    * igt@perf@blocking:
>      - shard-skl:          [FAIL][45] ([fdo#110728]) -> [PASS][46]
>     [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-skl6/igt@perf@blocking.html
>     [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-skl1/igt@perf@blocking.html
>
>    * igt@perf_pmu@rc6-runtime-pm:
>      - shard-glk:          [FAIL][47] ([fdo#105010]) -> [PASS][48]
>     [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-glk3/igt@perf_pmu@rc6-runtime-pm.html
>     [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-glk9/igt@perf_pmu@rc6-runtime-pm.html
>
>    
> #### Warnings ####
>
>    * igt@kms_dp_dsc@basic-dsc-enable-edp:
>      - shard-iclb:         [SKIP][49] ([fdo#109349]) -> [DMESG-WARN][50] ([fdo#107724])
>     [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6380/shard-iclb7/igt@kms_dp_dsc@basic-dsc-enable-edp.html
>     [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
>
>    
>    [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
>    [fdo#102365]: https://bugs.freedesktop.org/show_bug.cgi?id=102365
>    [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>    [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
>    [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
>    [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
>    [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
>    [fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
>    [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
>    [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
>    [fdo#107361]: https://bugs.freedesktop.org/show_bug.cgi?id=107361
>    [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
>    [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>    [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>    [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>    [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
>    [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>    [fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
>    [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
>    [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
>
>
> Participating hosts (10 -> 10)
> ------------------------------
>
>    No changes in participating hosts
>
>
> Build changes
> -------------
>
>    * Linux: CI_DRM_6380 -> Patchwork_13469
>
>    CI_DRM_6380: ea9572c68749ecb4eac919803b02a5a1be1782fc @ git://anongit.freedesktop.org/gfx-ci/linux
>    IGT_5073: fd02e325b9169e69b8a444137a553f359967c227 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>    Patchwork_13469: 14633be38d4ec70cec2cadb193f03bfa16aea452 @ git://anongit.freedesktop.org/gfx-ci/linux
>    piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13469/
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH] drm/i915: fix whitelist selftests with readonly registers

[Chris Wilson]

From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>

When a register is readonly there is not much we can tell about its
value (apart from its default value?). This can be covered by tests
exercising the value of the register from userspace.

For PS_INVOCATION_COUNT we've got the following piglit tests :

   KHR-GL45.pipeline_statistics_query_tests_ARB.functional_fragment_shader_invocations

Vulkan CTS tests :

   dEQP-VK.query_pool.statistics_query.fragment_shader_invocations.*

v2: Use a local to shrink under 80cols.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 86554f48e511 ("drm/i915/selftests: Verify whitelist of context registers")
Tested-by: Anuj Phogat <anuj.phogat@gmail.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
Fixes is a bit much, since the test is still very much nerfed and not
complemented by a test for read-only non-priv registers...
-Chris
---
 drivers/gpu/drm/i915/gt/selftest_workarounds.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/selftest_workarounds.c b/drivers/gpu/drm/i915/gt/selftest_workarounds.c
index f12cb20fe785..b933d831eeb1 100644
--- a/drivers/gpu/drm/i915/gt/selftest_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/selftest_workarounds.c
@@ -926,7 +926,12 @@ check_whitelisted_registers(struct intel_engine_cs *engine,
 
 	err = 0;
 	for (i = 0; i < engine->whitelist.count; i++) {
-		if (!fn(engine, a[i], b[i], engine->whitelist.list[i].reg))
+		const struct i915_wa *wa = &engine->whitelist.list[i];
+
+		if (i915_mmio_reg_offset(wa->reg) & RING_FORCE_TO_NONPRIV_RD)
+			continue;
+
+		if (!fn(engine, a[i], b[i], wa->reg))
 			err = -EINVAL;
 	}
 
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.CHECKPATCH: warning for drm/i915: CTS fixes (rev8)

[Patchwork]

== Series Details ==

Series: drm/i915: CTS fixes (rev8)
URL   : https://patchwork.freedesktop.org/series/62437/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
96062a805ac2 drm/i915: fix whitelist selftests with readonly registers
-:12: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#12: 
   KHR-GL45.pipeline_statistics_query_tests_ARB.functional_fragment_shader_invocations

total: 0 errors, 1 warnings, 0 checks, 13 lines checked
b2832f02b355 drm/i915: whitelist PS_(DEPTH|INVOCATION)_COUNT
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11: 
  KHR-GL45.pipeline_statistics_query_tests_ARB.functional_fragment_shader_invocations (GL)

total: 0 errors, 1 warnings, 0 checks, 26 lines checked
bc5b2156f922 drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT
-:14: WARNING:BAD_SIGN_OFF: Use a single space after Tested-by:
#14: 
Tested-by:  Anuj Phogat <anuj.phogat@gmail.com>

total: 0 errors, 1 warnings, 0 checks, 19 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915: CTS fixes (rev8)

[Patchwork]

== Series Details ==

Series: drm/i915: CTS fixes (rev8)
URL   : https://patchwork.freedesktop.org/series/62437/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6385 -> Patchwork_13474
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/

Known issues
------------

  Here are the changes found in Patchwork_13474 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_basic@create-fd-close:
    - fi-icl-dsi:         [PASS][1] -> [INCOMPLETE][2] ([fdo#107713])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/fi-icl-dsi/igt@gem_basic@create-fd-close.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/fi-icl-dsi/igt@gem_basic@create-fd-close.html

  * igt@gem_mmap_gtt@basic-read-write-distinct:
    - fi-icl-u3:          [PASS][3] -> [DMESG-WARN][4] ([fdo#107724])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/fi-icl-u3/igt@gem_mmap_gtt@basic-read-write-distinct.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/fi-icl-u3/igt@gem_mmap_gtt@basic-read-write-distinct.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [PASS][5] -> [FAIL][6] ([fdo#109485])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Possible fixes ####

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-blb-e6850:       [INCOMPLETE][7] ([fdo#107718]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html

  * igt@i915_pm_rpm@basic-rte:
    - fi-kbl-r:           [DMESG-WARN][9] ([fdo#111012]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/fi-kbl-r/igt@i915_pm_rpm@basic-rte.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/fi-kbl-r/igt@i915_pm_rpm@basic-rte.html

  * igt@i915_pm_rpm@module-reload:
    - fi-cml-u:           [DMESG-WARN][11] ([fdo#111012]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/fi-cml-u/igt@i915_pm_rpm@module-reload.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/fi-cml-u/igt@i915_pm_rpm@module-reload.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
  [fdo#111012]: https://bugs.freedesktop.org/show_bug.cgi?id=111012


Participating hosts (51 -> 42)
------------------------------

  Additional (1): fi-skl-gvtdvm 
  Missing    (10): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-pnv-d510 fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_6385 -> Patchwork_13474

  CI_DRM_6385: 25969d0b2ad59fac64891281e70efa0714084345 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5075: 03779dd3de8a57544f124d9952a6d2b3e34e34ca @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13474: bc5b2156f922a93198b12069686ec03ca405c049 @ git://anongit.freedesktop.org/gfx-ci/linux


== Kernel 32bit build ==

Warning: Kernel 32bit buildtest failed:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/build_32bit.log

  CALL    scripts/checksyscalls.sh
  CALL    scripts/atomic/check-atomics.sh
  CHK     include/generated/compile.h
Kernel: arch/x86/boot/bzImage is ready  (#1)
  Building modules, stage 2.
  MODPOST 112 modules
ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: "__divdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
scripts/Makefile.modpost:91: recipe for target '__modpost' failed
make[1]: *** [__modpost] Error 1
Makefile:1287: recipe for target 'modules' failed
make: *** [modules] Error 2


== Linux commits ==

bc5b2156f922 drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT
b2832f02b355 drm/i915: whitelist PS_(DEPTH|INVOCATION)_COUNT
96062a805ac2 drm/i915: fix whitelist selftests with readonly registers

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: fix whitelist selftests with readonly registers

[Lionel Landwerlin]

Ship it!

On 29/06/2019 16:13, Chris Wilson wrote:
> From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>
> When a register is readonly there is not much we can tell about its
> value (apart from its default value?). This can be covered by tests
> exercising the value of the register from userspace.
>
> For PS_INVOCATION_COUNT we've got the following piglit tests :
>
>     KHR-GL45.pipeline_statistics_query_tests_ARB.functional_fragment_shader_invocations
>
> Vulkan CTS tests :
>
>     dEQP-VK.query_pool.statistics_query.fragment_shader_invocations.*
>
> v2: Use a local to shrink under 80cols.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Fixes: 86554f48e511 ("drm/i915/selftests: Verify whitelist of context registers")
> Tested-by: Anuj Phogat <anuj.phogat@gmail.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> Fixes is a bit much, since the test is still very much nerfed and not
> complemented by a test for read-only non-priv registers...
> -Chris
> ---
>   drivers/gpu/drm/i915/gt/selftest_workarounds.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_workarounds.c b/drivers/gpu/drm/i915/gt/selftest_workarounds.c
> index f12cb20fe785..b933d831eeb1 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_workarounds.c
> @@ -926,7 +926,12 @@ check_whitelisted_registers(struct intel_engine_cs *engine,
>   
>   	err = 0;
>   	for (i = 0; i < engine->whitelist.count; i++) {
> -		if (!fn(engine, a[i], b[i], engine->whitelist.list[i].reg))
> +		const struct i915_wa *wa = &engine->whitelist.list[i];
> +
> +		if (i915_mmio_reg_offset(wa->reg) & RING_FORCE_TO_NONPRIV_RD)
> +			continue;
> +
> +		if (!fn(engine, a[i], b[i], wa->reg))
>   			err = -EINVAL;
>   	}
>   


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for drm/i915: CTS fixes (rev8)

[Patchwork]

== Series Details ==

Series: drm/i915: CTS fixes (rev8)
URL   : https://patchwork.freedesktop.org/series/62437/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6385_full -> Patchwork_13474_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Known issues
------------

  Here are the changes found in Patchwork_13474_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_isolation@vecs0-s3:
    - shard-apl:          [PASS][1] -> [DMESG-WARN][2] ([fdo#108566]) +2 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-apl2/igt@gem_ctx_isolation@vecs0-s3.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-apl3/igt@gem_ctx_isolation@vecs0-s3.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-apl:          [PASS][3] -> [DMESG-WARN][4] ([fdo#108686] / [fdo#110853])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-apl6/igt@gem_tiled_swapping@non-threaded.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-apl2/igt@gem_tiled_swapping@non-threaded.html
    - shard-glk:          [PASS][5] -> [DMESG-WARN][6] ([fdo#108686] / [fdo#110853])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-glk3/igt@gem_tiled_swapping@non-threaded.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-glk4/igt@gem_tiled_swapping@non-threaded.html

  * igt@i915_pm_rpm@gem-mmap-gtt:
    - shard-iclb:         [PASS][7] -> [INCOMPLETE][8] ([fdo#107713] / [fdo#108840])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-iclb2/igt@i915_pm_rpm@gem-mmap-gtt.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-iclb2/igt@i915_pm_rpm@gem-mmap-gtt.html

  * igt@kms_color@pipe-b-ctm-negative:
    - shard-skl:          [PASS][9] -> [FAIL][10] ([fdo#107361])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-skl4/igt@kms_color@pipe-b-ctm-negative.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-skl2/igt@kms_color@pipe-b-ctm-negative.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-kbl:          [PASS][11] -> [DMESG-WARN][12] ([fdo#108566]) +5 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_flip@2x-blocking-absolute-wf_vblank:
    - shard-hsw:          [PASS][13] -> [SKIP][14] ([fdo#109271]) +1 similar issue
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-hsw2/igt@kms_flip@2x-blocking-absolute-wf_vblank.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-hsw1/igt@kms_flip@2x-blocking-absolute-wf_vblank.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite:
    - shard-iclb:         [PASS][15] -> [FAIL][16] ([fdo#103167]) +2 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html

  * igt@kms_plane@plane-position-hole-dpms-pipe-c-planes:
    - shard-iclb:         [PASS][17] -> [INCOMPLETE][18] ([fdo#107713])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-iclb7/igt@kms_plane@plane-position-hole-dpms-pipe-c-planes.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-iclb7/igt@kms_plane@plane-position-hole-dpms-pipe-c-planes.html

  * igt@kms_psr@psr2_suspend:
    - shard-iclb:         [PASS][19] -> [SKIP][20] ([fdo#109441])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-iclb2/igt@kms_psr@psr2_suspend.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-iclb7/igt@kms_psr@psr2_suspend.html

  * igt@kms_setmode@basic:
    - shard-skl:          [PASS][21] -> [FAIL][22] ([fdo#99912])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-skl2/igt@kms_setmode@basic.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-skl6/igt@kms_setmode@basic.html

  
#### Possible fixes ####

  * igt@gem_eio@in-flight-suspend:
    - shard-skl:          [INCOMPLETE][23] ([fdo#104108]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-skl5/igt@gem_eio@in-flight-suspend.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-skl8/igt@gem_eio@in-flight-suspend.html

  * igt@gem_exec_balancer@smoke:
    - shard-iclb:         [SKIP][25] ([fdo#110854]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-iclb5/igt@gem_exec_balancer@smoke.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-iclb4/igt@gem_exec_balancer@smoke.html

  * igt@gem_tiled_swapping@non-threaded:
    - shard-hsw:          [FAIL][27] ([fdo#108686]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-hsw2/igt@gem_tiled_swapping@non-threaded.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-hsw1/igt@gem_tiled_swapping@non-threaded.html

  * igt@gem_workarounds@suspend-resume-fd:
    - shard-kbl:          [DMESG-WARN][29] ([fdo#108566]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-kbl6/igt@gem_workarounds@suspend-resume-fd.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-kbl1/igt@gem_workarounds@suspend-resume-fd.html

  * igt@i915_suspend@sysfs-reader:
    - shard-apl:          [DMESG-WARN][31] ([fdo#108566]) -> [PASS][32] +3 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-apl5/igt@i915_suspend@sysfs-reader.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-apl8/igt@i915_suspend@sysfs-reader.html

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-skl:          [FAIL][33] ([fdo#105363]) -> [PASS][34]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-skl5/igt@kms_flip@flip-vs-expired-vblank.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-skl6/igt@kms_flip@flip-vs-expired-vblank.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move:
    - shard-hsw:          [SKIP][35] ([fdo#109271]) -> [PASS][36] +32 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-hsw5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
    - shard-iclb:         [FAIL][37] ([fdo#103167]) -> [PASS][38] +6 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

  * igt@kms_psr@psr2_cursor_blt:
    - shard-iclb:         [SKIP][39] ([fdo#109441]) -> [PASS][40] +1 similar issue
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-iclb4/igt@kms_psr@psr2_cursor_blt.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html

  * igt@kms_setmode@basic:
    - shard-kbl:          [FAIL][41] ([fdo#99912]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6385/shard-kbl3/igt@kms_setmode@basic.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/shard-kbl1/igt@kms_setmode@basic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#107361]: https://bugs.freedesktop.org/show_bug.cgi?id=107361
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110853]: https://bugs.freedesktop.org/show_bug.cgi?id=110853
  [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_6385 -> Patchwork_13474

  CI_DRM_6385: 25969d0b2ad59fac64891281e70efa0714084345 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5075: 03779dd3de8a57544f124d9952a6d2b3e34e34ca @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_13474: bc5b2156f922a93198b12069686ec03ca405c049 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13474/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v7 2/3] drm/i915: whitelist PS_(DEPTH|INVOCATION)_COUNT

[Chris Wilson]

Quoting Lionel Landwerlin (2019-06-28 13:07:19)
> CFL:C0+ changed the status of those registers which are now
> blacklisted by default.
> 
> This is breaking a number of CTS tests on GL & Vulkan :
> 
>   KHR-GL45.pipeline_statistics_query_tests_ARB.functional_fragment_shader_invocations (GL)
> 
>   dEQP-VK.query_pool.statistics_query.fragment_shader_invocations.* (Vulkan)
> 
> v2: Only use one whitelist entry (Lionel)

Bspec: 14091
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Cc: stable@vger.kernel.org
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

Re: [Intel-gfx] [PATCH v7 3/3] drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT

[Chris Wilson]

Quoting Lionel Landwerlin (2019-06-28 13:07:20)
> The same tests failing on CFL+ platforms are also failing on ICL.
> Documentation doesn't list the
> WaAllowPMDepthAndInvocationCountAccessFromUMD workaround for ICL but
> applying it fixes the same tests as CFL.
> 
> v2: Use only one whitelist entry (Lionel)
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Tested-by:  Anuj Phogat <anuj.phogat@gmail.com>
> Cc: stable@vger.kernel.org
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

Re: [PATCH] drm/i915: fix whitelist selftests with readonly registers

[Chris Wilson]

Quoting Chris Wilson (2019-06-29 14:13:50)
> From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> 
> When a register is readonly there is not much we can tell about its
> value (apart from its default value?). This can be covered by tests
> exercising the value of the register from userspace.
> 
> For PS_INVOCATION_COUNT we've got the following piglit tests :
> 
>    KHR-GL45.pipeline_statistics_query_tests_ARB.functional_fragment_shader_invocations
> 
> Vulkan CTS tests :
> 
>    dEQP-VK.query_pool.statistics_query.fragment_shader_invocations.*
> 
> v2: Use a local to shrink under 80cols.
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Fixes: 86554f48e511 ("drm/i915/selftests: Verify whitelist of context registers")
> Tested-by: Anuj Phogat <anuj.phogat@gmail.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✓ Fi.CI.IGT: success for drm/i915: CTS fixes (rev7)

[Chris Wilson]

Quoting Lionel Landwerlin (2019-06-29 14:00:40)
> Okay to land?

Pushed with my ack. Thanks for the patches and sorry that simple changes
with such clear causality take so long to get reviewed.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v7 2/3] drm/i915: whitelist PS_(DEPTH|INVOCATION)_COUNT

[Mika Kuoppala]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Quoting Lionel Landwerlin (2019-06-28 13:07:19)
>> CFL:C0+ changed the status of those registers which are now
>> blacklisted by default.
>> 
>> This is breaking a number of CTS tests on GL & Vulkan :
>> 
>>   KHR-GL45.pipeline_statistics_query_tests_ARB.functional_fragment_shader_invocations (GL)
>> 
>>   dEQP-VK.query_pool.statistics_query.fragment_shader_invocations.* (Vulkan)
>> 
>> v2: Only use one whitelist entry (Lionel)
>
> Bspec: 14091

Sometimes we have optionally used References: BSID#0934 to
mark the workaround. But it feels a tad redudant now.

>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>> Cc: stable@vger.kernel.org
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Re: [Intel-gfx] [PATCH v7 3/3] drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT

[Mika Kuoppala]

Lionel Landwerlin <lionel.g.landwerlin@intel.com> writes:

> The same tests failing on CFL+ platforms are also failing on ICL.
> Documentation doesn't list the
> WaAllowPMDepthAndInvocationCountAccessFromUMD workaround for ICL but
> applying it fixes the same tests as CFL.

Didn't find more documentation either but I have asked
for the wa author for update.

>
> v2: Use only one whitelist entry (Lionel)
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Tested-by:  Anuj Phogat <anuj.phogat@gmail.com>
> Cc: stable@vger.kernel.org

The register offsets are the same so we can't really do
harm with this so we go with the evidence,

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/gt/intel_workarounds.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index b117583e38bb..a908d829d6bd 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -1138,6 +1138,19 @@ static void icl_whitelist_build(struct intel_engine_cs *engine)
>  
>  		/* WaEnableStateCacheRedirectToCS:icl */
>  		whitelist_reg(w, GEN9_SLICE_COMMON_ECO_CHICKEN1);
> +
> +		/*
> +		 * WaAllowPMDepthAndInvocationCountAccessFromUMD:icl
> +		 *
> +		 * This covers 4 register which are next to one another :
> +		 *   - PS_INVOCATION_COUNT
> +		 *   - PS_INVOCATION_COUNT_UDW
> +		 *   - PS_DEPTH_COUNT
> +		 *   - PS_DEPTH_COUNT_UDW
> +		 */
> +		whitelist_reg_ext(w, PS_INVOCATION_COUNT,
> +				  RING_FORCE_TO_NONPRIV_RD |
> +				  RING_FORCE_TO_NONPRIV_RANGE_4);
>  		break;
>  
>  	case VIDEO_DECODE_CLASS:
> -- 
> 2.21.0.392.gf8f6787159e
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v7 3/3] drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT

[Lionel Landwerlin]

On 02/07/2019 15:30, Mika Kuoppala wrote:
> Lionel Landwerlin <lionel.g.landwerlin@intel.com> writes:
>
>> The same tests failing on CFL+ platforms are also failing on ICL.
>> Documentation doesn't list the
>> WaAllowPMDepthAndInvocationCountAccessFromUMD workaround for ICL but
>> applying it fixes the same tests as CFL.
> Didn't find more documentation either but I have asked
> for the wa author for update.


I've filed an issue on the register definition (maybe a week ago), so 
far no response.

Hopefully you get luckier ;)


-Lionel


>
>> v2: Use only one whitelist entry (Lionel)
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>> Tested-by:  Anuj Phogat <anuj.phogat@gmail.com>
>> Cc: stable@vger.kernel.org
> The register offsets are the same so we can't really do
> harm with this so we go with the evidence,
>
> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>
>> ---
>>   drivers/gpu/drm/i915/gt/intel_workarounds.c | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> index b117583e38bb..a908d829d6bd 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
>> @@ -1138,6 +1138,19 @@ static void icl_whitelist_build(struct intel_engine_cs *engine)
>>   
>>   		/* WaEnableStateCacheRedirectToCS:icl */
>>   		whitelist_reg(w, GEN9_SLICE_COMMON_ECO_CHICKEN1);
>> +
>> +		/*
>> +		 * WaAllowPMDepthAndInvocationCountAccessFromUMD:icl
>> +		 *
>> +		 * This covers 4 register which are next to one another :
>> +		 *   - PS_INVOCATION_COUNT
>> +		 *   - PS_INVOCATION_COUNT_UDW
>> +		 *   - PS_DEPTH_COUNT
>> +		 *   - PS_DEPTH_COUNT_UDW
>> +		 */
>> +		whitelist_reg_ext(w, PS_INVOCATION_COUNT,
>> +				  RING_FORCE_TO_NONPRIV_RD |
>> +				  RING_FORCE_TO_NONPRIV_RANGE_4);
>>   		break;
>>   
>>   	case VIDEO_DECODE_CLASS:
>> -- 
>> 2.21.0.392.gf8f6787159e
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx