* [Linux-kernel-mentees] [PATCH] drivers: mtd: nand: raw: Remove unnecessary return variables.
@ 2019-07-01 14:17 ` Sanjana Sanikommu
0 siblings, 0 replies; 2+ messages in thread
From: sanjana99reddy99 @ 2019-07-01 14:17 UTC (permalink / raw)
Issue found using coccinelle tool.
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99 at gmail.com>
---
drivers/mtd/nand/raw/marvell_nand.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
index f38e5c1b87e4..ac91ce6a8764 100644
--- a/drivers/mtd/nand/raw/marvell_nand.c
+++ b/drivers/mtd/nand/raw/marvell_nand.c
@@ -1029,8 +1029,7 @@ static int marvell_nfc_hw_ecc_hmg_do_read_page(struct nand_chip *chip,
marvell_nfc_xfer_data_in_pio(nfc, oob_buf, oob_bytes);
}
- ret = marvell_nfc_wait_cmdd(chip);
- return ret;
+ return marvell_nfc_wait_cmdd(chip);
}
static int marvell_nfc_hw_ecc_hmg_read_page_raw(struct nand_chip *chip, u8 *buf,
@@ -1141,9 +1140,8 @@ static int marvell_nfc_hw_ecc_hmg_do_write_page(struct nand_chip *chip,
if (ret)
return ret;
- ret = marvell_nfc_wait_op(chip,
+ return marvell_nfc_wait_op(chip,
PSEC_TO_MSEC(chip->data_interface.timings.sdr.tPROG_max));
- return ret;
}
static int marvell_nfc_hw_ecc_hmg_write_page_raw(struct nand_chip *chip,
@@ -2708,8 +2706,7 @@ static int marvell_nand_chips_init(struct device *dev, struct marvell_nfc *nfc)
* NAND controller node.
*/
if (nfc->caps->legacy_of_bindings) {
- ret = marvell_nand_chip_init(dev, nfc, np);
- return ret;
+ return marvell_nand_chip_init(dev, nfc, np);
}
for_each_child_of_node(np, nand_np) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Linux-kernel-mentees] [PATCH] drivers: mtd: nand: raw: Remove unnecessary return variables.
@ 2019-07-01 14:17 ` Sanjana Sanikommu
0 siblings, 0 replies; 2+ messages in thread
From: Sanjana Sanikommu @ 2019-07-01 14:17 UTC (permalink / raw)
Issue found using coccinelle tool.
Signed-off-by: Sanjana Sanikommu <sanjana99reddy99 at gmail.com>
---
drivers/mtd/nand/raw/marvell_nand.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
index f38e5c1b87e4..ac91ce6a8764 100644
--- a/drivers/mtd/nand/raw/marvell_nand.c
+++ b/drivers/mtd/nand/raw/marvell_nand.c
@@ -1029,8 +1029,7 @@ static int marvell_nfc_hw_ecc_hmg_do_read_page(struct nand_chip *chip,
marvell_nfc_xfer_data_in_pio(nfc, oob_buf, oob_bytes);
}
- ret = marvell_nfc_wait_cmdd(chip);
- return ret;
+ return marvell_nfc_wait_cmdd(chip);
}
static int marvell_nfc_hw_ecc_hmg_read_page_raw(struct nand_chip *chip, u8 *buf,
@@ -1141,9 +1140,8 @@ static int marvell_nfc_hw_ecc_hmg_do_write_page(struct nand_chip *chip,
if (ret)
return ret;
- ret = marvell_nfc_wait_op(chip,
+ return marvell_nfc_wait_op(chip,
PSEC_TO_MSEC(chip->data_interface.timings.sdr.tPROG_max));
- return ret;
}
static int marvell_nfc_hw_ecc_hmg_write_page_raw(struct nand_chip *chip,
@@ -2708,8 +2706,7 @@ static int marvell_nand_chips_init(struct device *dev, struct marvell_nfc *nfc)
* NAND controller node.
*/
if (nfc->caps->legacy_of_bindings) {
- ret = marvell_nand_chip_init(dev, nfc, np);
- return ret;
+ return marvell_nand_chip_init(dev, nfc, np);
}
for_each_child_of_node(np, nand_np) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-01 14:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-01 14:17 [Linux-kernel-mentees] [PATCH] drivers: mtd: nand: raw: Remove unnecessary return variables sanjana99reddy99
2019-07-01 14:17 ` Sanjana Sanikommu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.