All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] oeqa: Test bitbake --skip-setsecene
@ 2019-07-01 18:23 Joshua Watt
  2019-07-02 12:36 ` Richard Purdie
  0 siblings, 1 reply; 3+ messages in thread
From: Joshua Watt @ 2019-07-01 18:23 UTC (permalink / raw)
  To: openembedded-core

Tests the bitbake --skip-setscene option to verify that it correctly
reuses tasks previously restored from sstate, but doesn't execute new
sstate tasks

Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
 meta/lib/oeqa/selftest/cases/bbtests.py | 30 +++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/meta/lib/oeqa/selftest/cases/bbtests.py b/meta/lib/oeqa/selftest/cases/bbtests.py
index e9ad44b027e..2a310bc4af2 100644
--- a/meta/lib/oeqa/selftest/cases/bbtests.py
+++ b/meta/lib/oeqa/selftest/cases/bbtests.py
@@ -242,6 +242,36 @@ INHERIT_remove = \"report-error\"
             self.assertIn('_setscene', task, 'A task different from _setscene ran: %s.\n'
                                              'Executed tasks were: %s' % (task, str(tasks)))
 
+    def test_skip_setscene(self):
+        test_recipe = 'ed'
+
+        bitbake(test_recipe)
+        bitbake('-c clean %s' % test_recipe)
+
+        ret = bitbake('--setscene-only %s' % test_recipe)
+        tasks = re.findall(r'task\s+(do_\S+):', ret.output)
+
+        for task in tasks:
+            self.assertIn('_setscene', task, 'A task different from _setscene ran: %s.\n'
+                                             'Executed tasks were: %s' % (task, str(tasks)))
+
+        # Run without setscene. Should do nothing
+        ret = bitbake('--skip-setscene %s' % test_recipe)
+        tasks = re.findall(r'task\s+(do_\S+):', ret.output)
+
+        self.assertFalse(tasks, 'Tasks %s ran when they should not have' % (str(tasks)))
+
+        # Clean (leave sstate cache) and run with --skip-setscene. No setscene
+        # tasks should run
+        bitbake('-c clean %s' % test_recipe)
+
+        ret = bitbake('--skip-setscene %s' % test_recipe)
+        tasks = re.findall(r'task\s+(do_\S+):', ret.output)
+
+        for task in tasks:
+            self.assertNotIn('_setscene', task, 'A _setscene task ran: %s.\n'
+                                                'Executed tasks were: %s' % (task, str(tasks)))
+
     def test_bbappend_order(self):
         """ Bitbake should bbappend to recipe in a predictable order """
         test_recipe = 'ed'
-- 
2.21.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] oeqa: Test bitbake --skip-setsecene
  2019-07-01 18:23 [PATCH] oeqa: Test bitbake --skip-setsecene Joshua Watt
@ 2019-07-02 12:36 ` Richard Purdie
  2019-07-02 13:01   ` Joshua Watt
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2019-07-02 12:36 UTC (permalink / raw)
  To: Joshua Watt, openembedded-core

On Mon, 2019-07-01 at 13:23 -0500, Joshua Watt wrote:
> Tests the bitbake --skip-setscene option to verify that it correctly
> reuses tasks previously restored from sstate, but doesn't execute new
> sstate tasks
> 
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ---
>  meta/lib/oeqa/selftest/cases/bbtests.py | 30
> +++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)

I like the idea but unfortunately it doesn't pass:

https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/267
https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/265

Cheers,

Richard




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] oeqa: Test bitbake --skip-setsecene
  2019-07-02 12:36 ` Richard Purdie
@ 2019-07-02 13:01   ` Joshua Watt
  0 siblings, 0 replies; 3+ messages in thread
From: Joshua Watt @ 2019-07-02 13:01 UTC (permalink / raw)
  To: Richard Purdie, openembedded-core


On 7/2/19 7:36 AM, Richard Purdie wrote:
> On Mon, 2019-07-01 at 13:23 -0500, Joshua Watt wrote:
>> Tests the bitbake --skip-setscene option to verify that it correctly
>> reuses tasks previously restored from sstate, but doesn't execute new
>> sstate tasks
>>
>> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
>> ---
>>   meta/lib/oeqa/selftest/cases/bbtests.py | 30
>> +++++++++++++++++++++++++
>>   1 file changed, 30 insertions(+)
> I like the idea but unfortunately it doesn't pass:
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/267
> https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/265

I think it failed because 
http://lists.openembedded.org/pipermail/bitbake-devel/2019-July/020105.html 
is not in master-next of bitbake? I split the bitbake change and the 
oeqa change to test it into separate patches.

>
> Cheers,
>
> Richard
>
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-02 13:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-01 18:23 [PATCH] oeqa: Test bitbake --skip-setsecene Joshua Watt
2019-07-02 12:36 ` Richard Purdie
2019-07-02 13:01   ` Joshua Watt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.