From: Jesper Dangaard Brouer <brouer@redhat.com> To: Jose Abreu <Jose.Abreu@synopsys.com> Cc: brouer@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Joao Pinto <Joao.Pinto@synopsys.com>, "David S . Miller" <davem@davemloft.net>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, Alexandre Torgue <alexandre.torgue@st.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Maxime Ripard <maxime.ripard@bootlin.com>, Chen-Yu Tsai <wens@csie.org>, Ilias Apalodimas <ilias.apalodimas@linaro.org> Subject: Re: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool Date: Thu, 4 Jul 2019 11:48:04 +0200 [thread overview] Message-ID: <20190704114804.10c38b42@carbon> (raw) In-Reply-To: <1b254bb7fc6044c5e6e2fdd9e00088d1d13a808b.1562149883.git.joabreu@synopsys.com> On Wed, 3 Jul 2019 12:37:50 +0200 Jose Abreu <Jose.Abreu@synopsys.com> wrote: > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -1197,26 +1197,14 @@ static int stmmac_init_rx_buffers(struct stmmac_priv *priv, struct dma_desc *p, > int i, gfp_t flags, u32 queue) > { > struct stmmac_rx_queue *rx_q = &priv->rx_queue[queue]; > - struct sk_buff *skb; > + struct stmmac_rx_buffer *buf = &rx_q->buf_pool[i]; > > - skb = __netdev_alloc_skb_ip_align(priv->dev, priv->dma_buf_sz, flags); > - if (!skb) { > - netdev_err(priv->dev, > - "%s: Rx init fails; skb is NULL\n", __func__); > + buf->page = page_pool_dev_alloc_pages(rx_q->page_pool); > + if (!buf->page) > return -ENOMEM; > - } > - rx_q->rx_skbuff[i] = skb; > - rx_q->rx_skbuff_dma[i] = dma_map_single(priv->device, skb->data, > - priv->dma_buf_sz, > - DMA_FROM_DEVICE); > - if (dma_mapping_error(priv->device, rx_q->rx_skbuff_dma[i])) { > - netdev_err(priv->dev, "%s: DMA mapping error\n", __func__); > - dev_kfree_skb_any(skb); > - return -EINVAL; > - } > - > - stmmac_set_desc_addr(priv, p, rx_q->rx_skbuff_dma[i]); > > + buf->addr = buf->page->dma_addr; We/Ilias added a wrapper/helper function for accessing dma_addr, as it will help us later identifying users. page_pool_get_dma_addr(page) > + stmmac_set_desc_addr(priv, p, buf->addr); > if (priv->dma_buf_sz == BUF_SIZE_16KiB) > stmmac_init_desc3(priv, p); > -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer
WARNING: multiple messages have this Message-ID (diff)
From: Jesper Dangaard Brouer <brouer@redhat.com> To: Jose Abreu <Jose.Abreu@synopsys.com> Cc: Joao Pinto <Joao.Pinto@synopsys.com>, Alexandre Torgue <alexandre.torgue@st.com>, Maxime Ripard <maxime.ripard@bootlin.com>, netdev@vger.kernel.org, Ilias Apalodimas <ilias.apalodimas@linaro.org>, linux-kernel@vger.kernel.org, "David S . Miller" <davem@davemloft.net>, Chen-Yu Tsai <wens@csie.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, brouer@redhat.com, Giuseppe Cavallaro <peppe.cavallaro@st.com>, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool Date: Thu, 4 Jul 2019 11:48:04 +0200 [thread overview] Message-ID: <20190704114804.10c38b42@carbon> (raw) In-Reply-To: <1b254bb7fc6044c5e6e2fdd9e00088d1d13a808b.1562149883.git.joabreu@synopsys.com> On Wed, 3 Jul 2019 12:37:50 +0200 Jose Abreu <Jose.Abreu@synopsys.com> wrote: > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -1197,26 +1197,14 @@ static int stmmac_init_rx_buffers(struct stmmac_priv *priv, struct dma_desc *p, > int i, gfp_t flags, u32 queue) > { > struct stmmac_rx_queue *rx_q = &priv->rx_queue[queue]; > - struct sk_buff *skb; > + struct stmmac_rx_buffer *buf = &rx_q->buf_pool[i]; > > - skb = __netdev_alloc_skb_ip_align(priv->dev, priv->dma_buf_sz, flags); > - if (!skb) { > - netdev_err(priv->dev, > - "%s: Rx init fails; skb is NULL\n", __func__); > + buf->page = page_pool_dev_alloc_pages(rx_q->page_pool); > + if (!buf->page) > return -ENOMEM; > - } > - rx_q->rx_skbuff[i] = skb; > - rx_q->rx_skbuff_dma[i] = dma_map_single(priv->device, skb->data, > - priv->dma_buf_sz, > - DMA_FROM_DEVICE); > - if (dma_mapping_error(priv->device, rx_q->rx_skbuff_dma[i])) { > - netdev_err(priv->dev, "%s: DMA mapping error\n", __func__); > - dev_kfree_skb_any(skb); > - return -EINVAL; > - } > - > - stmmac_set_desc_addr(priv, p, rx_q->rx_skbuff_dma[i]); > > + buf->addr = buf->page->dma_addr; We/Ilias added a wrapper/helper function for accessing dma_addr, as it will help us later identifying users. page_pool_get_dma_addr(page) > + stmmac_set_desc_addr(priv, p, buf->addr); > if (priv->dma_buf_sz == BUF_SIZE_16KiB) > stmmac_init_desc3(priv, p); > -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-04 9:48 UTC|newest] Thread overview: 236+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-03 10:37 [PATCH net-next 0/3] net: stmmac: Some performance improvements and a fix Jose Abreu 2019-07-03 10:37 ` Jose Abreu 2019-07-03 10:37 ` [PATCH net-next 1/3] net: stmmac: Implement RX Coalesce Frames setting Jose Abreu 2019-07-03 10:37 ` Jose Abreu 2019-07-03 20:41 ` Jakub Kicinski 2019-07-03 20:41 ` Jakub Kicinski 2019-07-03 10:37 ` [PATCH net-next 2/3] net: stmmac: Fix descriptors address being in > 32 bits address space Jose Abreu 2019-07-03 10:37 ` Jose Abreu 2019-07-03 10:37 ` [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool Jose Abreu 2019-07-03 10:37 ` Jose Abreu 2019-07-03 10:40 ` Jose Abreu 2019-07-03 10:40 ` Jose Abreu 2019-07-04 9:39 ` Jesper Dangaard Brouer 2019-07-04 9:39 ` Jesper Dangaard Brouer 2019-07-04 14:45 ` Jose Abreu 2019-07-04 14:45 ` Jose Abreu 2019-07-04 15:09 ` Jesper Dangaard Brouer 2019-07-04 15:09 ` Jesper Dangaard Brouer 2019-07-04 15:18 ` Jose Abreu 2019-07-04 15:18 ` Jose Abreu 2019-07-04 15:33 ` Jesper Dangaard Brouer 2019-07-04 15:33 ` Jesper Dangaard Brouer 2019-07-04 9:48 ` Jesper Dangaard Brouer [this message] 2019-07-04 9:48 ` Jesper Dangaard Brouer 2019-07-04 10:00 ` Jesper Dangaard Brouer 2019-07-04 10:00 ` Jesper Dangaard Brouer 2019-07-04 10:13 ` Jose Abreu 2019-07-04 10:13 ` Jose Abreu 2019-07-04 11:11 ` Ilias Apalodimas 2019-07-04 11:11 ` Ilias Apalodimas 2019-07-04 11:54 ` Jesper Dangaard Brouer 2019-07-04 11:54 ` Jesper Dangaard Brouer 2019-07-04 12:04 ` Ilias Apalodimas 2019-07-04 12:04 ` Ilias Apalodimas 2019-07-04 12:59 ` Jose Abreu 2019-07-04 12:59 ` Jose Abreu 2019-07-04 13:06 ` Ilias Apalodimas 2019-07-04 13:06 ` Ilias Apalodimas 2019-07-04 10:30 ` Ilias Apalodimas 2019-07-04 10:30 ` Ilias Apalodimas 2019-07-04 12:14 ` Arnd Bergmann 2019-07-04 12:14 ` Arnd Bergmann 2019-07-04 12:49 ` Ilias Apalodimas 2019-07-04 12:49 ` Ilias Apalodimas 2019-07-17 18:58 ` Jon Hunter 2019-07-17 18:58 ` Jon Hunter 2019-07-17 18:58 ` Jon Hunter 2019-07-18 7:29 ` Jose Abreu 2019-07-18 7:29 ` Jose Abreu 2019-07-18 7:29 ` Jose Abreu 2019-07-18 7:48 ` Jose Abreu 2019-07-18 7:48 ` Jose Abreu 2019-07-18 7:48 ` Jose Abreu 2019-07-18 9:16 ` Jon Hunter 2019-07-18 9:16 ` Jon Hunter 2019-07-18 9:16 ` Jon Hunter 2019-07-19 7:51 ` Jose Abreu 2019-07-19 7:51 ` Jose Abreu 2019-07-19 7:51 ` Jose Abreu 2019-07-19 8:37 ` Jon Hunter 2019-07-19 8:37 ` Jon Hunter 2019-07-19 8:37 ` Jon Hunter 2019-07-19 8:44 ` Jose Abreu 2019-07-19 8:44 ` Jose Abreu 2019-07-19 8:44 ` Jose Abreu 2019-07-19 8:49 ` Jon Hunter 2019-07-19 8:49 ` Jon Hunter 2019-07-19 8:49 ` Jon Hunter 2019-07-19 10:25 ` Jose Abreu 2019-07-19 10:25 ` Jose Abreu 2019-07-19 10:25 ` Jose Abreu 2019-07-19 12:28 ` Jose Abreu 2019-07-19 12:28 ` Jose Abreu 2019-07-19 12:28 ` Jose Abreu 2019-07-19 13:33 ` Jon Hunter 2019-07-19 13:33 ` Jon Hunter 2019-07-19 13:33 ` Jon Hunter 2019-07-19 12:30 ` Jon Hunter 2019-07-19 12:30 ` Jon Hunter 2019-07-19 12:30 ` Jon Hunter 2019-07-19 12:32 ` Jose Abreu 2019-07-19 12:32 ` Jose Abreu 2019-07-19 12:32 ` Jose Abreu 2019-07-19 13:35 ` Jon Hunter 2019-07-19 13:35 ` Jon Hunter 2019-07-22 7:23 ` Jose Abreu 2019-07-22 7:23 ` Jose Abreu 2019-07-22 7:23 ` Jose Abreu 2019-07-22 9:37 ` Jon Hunter 2019-07-22 9:37 ` Jon Hunter 2019-07-22 9:37 ` Jon Hunter 2019-07-22 9:47 ` Jose Abreu 2019-07-22 9:47 ` Jose Abreu 2019-07-22 9:47 ` Jose Abreu 2019-07-22 9:57 ` Jose Abreu 2019-07-22 9:57 ` Jose Abreu 2019-07-22 9:57 ` Jose Abreu 2019-07-22 10:27 ` Jon Hunter 2019-07-22 10:27 ` Jon Hunter 2019-07-22 10:27 ` Jon Hunter 2019-07-22 10:18 ` Ilias Apalodimas 2019-07-22 10:18 ` Ilias Apalodimas 2019-07-22 10:18 ` Ilias Apalodimas 2019-07-22 11:11 ` Lars Persson 2019-07-22 11:11 ` Lars Persson 2019-07-22 11:11 ` Lars Persson 2019-07-22 11:39 ` Jose Abreu 2019-07-22 11:39 ` Jose Abreu 2019-07-22 11:39 ` Jose Abreu 2019-07-22 12:05 ` Jon Hunter 2019-07-22 12:05 ` Jon Hunter 2019-07-22 12:05 ` Jon Hunter 2019-07-22 14:04 ` Jose Abreu 2019-07-22 14:04 ` Jose Abreu 2019-07-22 14:04 ` Jose Abreu 2019-07-23 8:14 ` Jose Abreu 2019-07-23 8:14 ` Jose Abreu 2019-07-23 8:14 ` Jose Abreu 2019-07-23 10:01 ` Jon Hunter 2019-07-23 10:01 ` Jon Hunter 2019-07-23 10:01 ` Jon Hunter 2019-07-23 10:07 ` Jose Abreu 2019-07-23 10:07 ` Jose Abreu 2019-07-23 10:07 ` Jose Abreu 2019-07-23 10:29 ` Robin Murphy 2019-07-23 10:29 ` Robin Murphy 2019-07-23 10:29 ` Robin Murphy 2019-07-23 11:22 ` Jose Abreu 2019-07-23 11:22 ` Jose Abreu 2019-07-23 11:22 ` Jose Abreu 2019-07-23 12:09 ` Jon Hunter 2019-07-23 12:09 ` Jon Hunter 2019-07-23 12:09 ` Jon Hunter 2019-07-23 13:19 ` Robin Murphy 2019-07-23 13:19 ` Robin Murphy 2019-07-23 13:19 ` Robin Murphy 2019-07-23 21:39 ` Jon Hunter 2019-07-23 21:39 ` Jon Hunter 2019-07-23 21:39 ` Jon Hunter 2019-07-24 10:03 ` Robin Murphy 2019-07-24 10:03 ` Robin Murphy 2019-07-24 10:03 ` Robin Murphy 2019-07-23 18:51 ` David Miller 2019-07-23 18:51 ` David Miller 2019-07-24 8:54 ` Ilias Apalodimas 2019-07-24 8:54 ` Ilias Apalodimas 2019-07-24 9:43 ` Jose Abreu 2019-07-24 9:43 ` Jose Abreu 2019-07-24 9:43 ` Jose Abreu 2019-07-24 9:53 ` Ilias Apalodimas 2019-07-24 9:53 ` Ilias Apalodimas 2019-07-24 9:53 ` Ilias Apalodimas 2019-07-24 10:04 ` Jose Abreu 2019-07-24 10:04 ` Jose Abreu 2019-07-24 10:04 ` Jose Abreu 2019-07-24 11:10 ` Jon Hunter 2019-07-24 11:10 ` Jon Hunter 2019-07-24 11:10 ` Jon Hunter 2019-07-24 11:34 ` Jose Abreu 2019-07-24 11:34 ` Jose Abreu 2019-07-24 11:34 ` Jose Abreu 2019-07-24 11:58 ` Jon Hunter 2019-07-24 11:58 ` Jon Hunter 2019-07-24 11:58 ` Jon Hunter 2019-07-25 7:44 ` Jose Abreu 2019-07-25 7:44 ` Jose Abreu 2019-07-25 7:44 ` Jose Abreu 2019-07-25 9:45 ` Jon Hunter 2019-07-25 9:45 ` Jon Hunter 2019-07-25 9:45 ` Jon Hunter 2019-07-25 11:39 ` Ilias Apalodimas 2019-07-25 11:39 ` Ilias Apalodimas 2019-07-25 11:39 ` Ilias Apalodimas 2019-07-23 10:38 ` Jon Hunter 2019-07-23 10:38 ` Jon Hunter 2019-07-23 10:38 ` Jon Hunter 2019-07-23 10:49 ` Jose Abreu 2019-07-23 10:49 ` Jose Abreu 2019-07-23 10:49 ` Jose Abreu 2019-07-23 11:58 ` Jon Hunter 2019-07-23 11:58 ` Jon Hunter 2019-07-23 11:58 ` Jon Hunter 2019-07-23 12:51 ` Jose Abreu 2019-07-23 12:51 ` Jose Abreu 2019-07-23 12:51 ` Jose Abreu 2019-07-23 13:34 ` Jon Hunter 2019-07-23 13:34 ` Jon Hunter 2019-07-23 13:34 ` Jon Hunter 2019-07-29 9:45 ` Mikko Perttunen 2019-07-29 9:45 ` Mikko Perttunen 2019-07-29 9:45 ` Mikko Perttunen 2019-07-25 13:20 ` Jon Hunter 2019-07-25 13:20 ` Jon Hunter 2019-07-25 13:20 ` Jon Hunter 2019-07-25 13:26 ` Jose Abreu 2019-07-25 13:26 ` Jose Abreu 2019-07-25 13:26 ` Jose Abreu 2019-07-25 14:25 ` Jon Hunter 2019-07-25 14:25 ` Jon Hunter 2019-07-25 14:25 ` Jon Hunter 2019-07-25 15:12 ` Jose Abreu 2019-07-25 15:12 ` Jose Abreu 2019-07-25 15:12 ` Jose Abreu 2019-07-26 14:11 ` Jon Hunter 2019-07-26 14:11 ` Jon Hunter 2019-07-26 14:11 ` Jon Hunter 2019-07-27 15:56 ` Jose Abreu 2019-07-27 15:56 ` Jose Abreu 2019-07-27 15:56 ` Jose Abreu 2019-07-29 8:16 ` Jose Abreu 2019-07-29 8:16 ` Jose Abreu 2019-07-29 8:16 ` Jose Abreu 2019-07-29 10:55 ` Jon Hunter 2019-07-29 10:55 ` Jon Hunter 2019-07-29 10:55 ` Jon Hunter 2019-07-29 11:29 ` Jose Abreu 2019-07-29 11:29 ` Jose Abreu 2019-07-29 11:29 ` Jose Abreu 2019-07-29 11:52 ` Robin Murphy 2019-07-29 11:52 ` Robin Murphy 2019-07-29 11:52 ` Robin Murphy 2019-07-29 14:08 ` Jose Abreu 2019-07-29 14:08 ` Jose Abreu 2019-07-29 14:08 ` Jose Abreu 2019-07-29 21:33 ` Jon Hunter 2019-07-29 21:33 ` Jon Hunter 2019-07-29 21:33 ` Jon Hunter 2019-07-30 9:39 ` Jose Abreu 2019-07-30 9:39 ` Jose Abreu 2019-07-30 9:39 ` Jose Abreu 2019-07-30 13:36 ` Jon Hunter 2019-07-30 13:36 ` Jon Hunter 2019-07-30 13:36 ` Jon Hunter 2019-07-30 13:58 ` Jose Abreu 2019-07-30 13:58 ` Jose Abreu 2019-07-30 13:58 ` Jose Abreu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190704114804.10c38b42@carbon \ --to=brouer@redhat.com \ --cc=Joao.Pinto@synopsys.com \ --cc=Jose.Abreu@synopsys.com \ --cc=alexandre.torgue@st.com \ --cc=davem@davemloft.net \ --cc=ilias.apalodimas@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=maxime.ripard@bootlin.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=peppe.cavallaro@st.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.