* [PATCH -next] nfsd: Make two functions static
@ 2019-07-08 7:29 YueHaibing
2019-07-09 23:36 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-07-08 7:29 UTC (permalink / raw)
To: bfields, chuck.lever; +Cc: linux-kernel, linux-nfs, YueHaibing
Fix sparse warnings:
fs/nfsd/nfs4state.c:1908:6: warning: symbol 'drop_client' was not declared. Should it be static?
fs/nfsd/nfs4state.c:2518:6: warning: symbol 'force_expire_client' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/nfsd/nfs4state.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 94de5c3..7857942 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1905,7 +1905,7 @@ static void __free_client(struct kref *k)
kmem_cache_free(client_slab, clp);
}
-void drop_client(struct nfs4_client *clp)
+static void drop_client(struct nfs4_client *clp)
{
kref_put(&clp->cl_nfsdfs.cl_ref, __free_client);
}
@@ -2515,7 +2515,7 @@ static const struct file_operations client_states_fops = {
* so the caller has a guarantee that the client's locks are gone by
* the time the write returns:
*/
-void force_expire_client(struct nfs4_client *clp)
+static void force_expire_client(struct nfs4_client *clp)
{
struct nfsd_net *nn = net_generic(clp->net, nfsd_net_id);
bool already_expired;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] nfsd: Make two functions static
2019-07-08 7:29 [PATCH -next] nfsd: Make two functions static YueHaibing
@ 2019-07-09 23:36 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2019-07-09 23:36 UTC (permalink / raw)
To: YueHaibing; +Cc: chuck.lever, linux-kernel, linux-nfs
Thanks, applied.--b.
On Mon, Jul 08, 2019 at 03:29:33PM +0800, YueHaibing wrote:
> Fix sparse warnings:
>
> fs/nfsd/nfs4state.c:1908:6: warning: symbol 'drop_client' was not declared. Should it be static?
> fs/nfsd/nfs4state.c:2518:6: warning: symbol 'force_expire_client' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> fs/nfsd/nfs4state.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 94de5c3..7857942 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -1905,7 +1905,7 @@ static void __free_client(struct kref *k)
> kmem_cache_free(client_slab, clp);
> }
>
> -void drop_client(struct nfs4_client *clp)
> +static void drop_client(struct nfs4_client *clp)
> {
> kref_put(&clp->cl_nfsdfs.cl_ref, __free_client);
> }
> @@ -2515,7 +2515,7 @@ static const struct file_operations client_states_fops = {
> * so the caller has a guarantee that the client's locks are gone by
> * the time the write returns:
> */
> -void force_expire_client(struct nfs4_client *clp)
> +static void force_expire_client(struct nfs4_client *clp)
> {
> struct nfsd_net *nn = net_generic(clp->net, nfsd_net_id);
> bool already_expired;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-09 23:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-08 7:29 [PATCH -next] nfsd: Make two functions static YueHaibing
2019-07-09 23:36 ` J. Bruce Fields
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.