* [PATCH 1/3] drm/amdgpu: add missing documentation on new module parameters
@ 2019-07-08 18:48 Alex Deucher
[not found] ` <20190708184811.6409-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2019-07-08 18:48 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alex Deucher
New parameters added for navi lack documentation.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 3913a75924c6..7941a5368fb5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -581,14 +581,27 @@ MODULE_PARM_DESC(async_gfx_ring,
"Asynchronous GFX rings that could be configured with either different priorities (HP3D ring and LP3D ring), or equal priorities (0 = disabled, 1 = enabled (default))");
module_param_named(async_gfx_ring, amdgpu_async_gfx_ring, int, 0444);
+/**
+ * DOC: mcbp (int)
+ * It is used to enable mid command buffer preemption. (0 = disabled (default), 1 = enabled)
+ */
MODULE_PARM_DESC(mcbp,
"Enable Mid-command buffer preemption (0 = disabled (default), 1 = enabled)");
module_param_named(mcbp, amdgpu_mcbp, int, 0444);
+/**
+ * DOC: discovery (int)
+ * Allow driver to discover hardware IP information from IP Discovery table at the top of VRAM.
+ */
MODULE_PARM_DESC(discovery,
"Allow driver to discover hardware IPs from IP Discovery table at the top of VRAM");
module_param_named(discovery, amdgpu_discovery, int, 0444);
+/**
+ * DOC: mes (int)
+ * Enable Micro Engine Scheduler. This is a new hw scheduling engine for gfx, sdma, and compute.
+ * (0 = disabled (default), 1 = enabled)
+ */
MODULE_PARM_DESC(mes,
"Enable Micro Engine Scheduler (0 = disabled (default), 1 = enabled)");
module_param_named(mes, amdgpu_mes, int, 0444);
--
2.20.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] drm/amdgpu: properly guard the generic discovery code
[not found] ` <20190708184811.6409-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
@ 2019-07-08 18:48 ` Alex Deucher
2019-07-08 18:48 ` [PATCH 3/3] drm/amdgpu: enable IP discovery by default on navi Alex Deucher
1 sibling, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2019-07-08 18:48 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alex Deucher
It's only available on navi and newer.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 8f0f207bf3d9..6cf3175bcf85 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2623,7 +2623,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,
if (amdgpu_mes && adev->asic_type >= CHIP_NAVI10)
adev->enable_mes = true;
- if (amdgpu_discovery) {
+ if (amdgpu_discovery && adev->asic_type >= CHIP_NAVI10) {
r = amdgpu_discovery_init(adev);
if (r) {
dev_err(adev->dev, "amdgpu_discovery_init failed\n");
@@ -2891,7 +2891,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev)
amdgpu_ucode_sysfs_fini(adev);
amdgpu_pmu_fini(adev);
amdgpu_debugfs_preempt_cleanup(adev);
- if (amdgpu_discovery)
+ if (amdgpu_discovery && adev->asic_type >= CHIP_NAVI10)
amdgpu_discovery_fini(adev);
}
--
2.20.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] drm/amdgpu: enable IP discovery by default on navi
[not found] ` <20190708184811.6409-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2019-07-08 18:48 ` [PATCH 2/3] drm/amdgpu: properly guard the generic discovery code Alex Deucher
@ 2019-07-08 18:48 ` Alex Deucher
[not found] ` <20190708184811.6409-3-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
1 sibling, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2019-07-08 18:48 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alex Deucher, Xiaojie Yuan
Use the IP discovery table rather than hardcoding the
settings in the driver.
Reviewed-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 7941a5368fb5..6f7772eeeb78 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -140,7 +140,7 @@ uint amdgpu_smu_memory_pool_size = 0;
uint amdgpu_dc_feature_mask = 0;
int amdgpu_async_gfx_ring = 1;
int amdgpu_mcbp = 0;
-int amdgpu_discovery = 0;
+int amdgpu_discovery = -1;
int amdgpu_mes = 0;
struct amdgpu_mgpu_info mgpu_info = {
@@ -592,6 +592,7 @@ module_param_named(mcbp, amdgpu_mcbp, int, 0444);
/**
* DOC: discovery (int)
* Allow driver to discover hardware IP information from IP Discovery table at the top of VRAM.
+ * (-1 = auto (default), 0 = disabled, 1 = enabled)
*/
MODULE_PARM_DESC(discovery,
"Allow driver to discover hardware IPs from IP Discovery table at the top of VRAM");
--
2.20.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] drm/amdgpu: enable IP discovery by default on navi
[not found] ` <20190708184811.6409-3-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
@ 2019-07-09 1:16 ` Yuan, Xiaojie
0 siblings, 0 replies; 4+ messages in thread
From: Yuan, Xiaojie @ 2019-07-09 1:16 UTC (permalink / raw)
To: Alex Deucher; +Cc: Deucher, Alexander, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Series is Reviewed-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
BR,
Xiaojie
> On Jul 9, 2019, at 2:48 AM, Alex Deucher <alexdeucher@gmail.com> wrote:
>
> Use the IP discovery table rather than hardcoding the
> settings in the driver.
>
> Reviewed-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 7941a5368fb5..6f7772eeeb78 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -140,7 +140,7 @@ uint amdgpu_smu_memory_pool_size = 0;
> uint amdgpu_dc_feature_mask = 0;
> int amdgpu_async_gfx_ring = 1;
> int amdgpu_mcbp = 0;
> -int amdgpu_discovery = 0;
> +int amdgpu_discovery = -1;
> int amdgpu_mes = 0;
>
> struct amdgpu_mgpu_info mgpu_info = {
> @@ -592,6 +592,7 @@ module_param_named(mcbp, amdgpu_mcbp, int, 0444);
> /**
> * DOC: discovery (int)
> * Allow driver to discover hardware IP information from IP Discovery table at the top of VRAM.
> + * (-1 = auto (default), 0 = disabled, 1 = enabled)
> */
> MODULE_PARM_DESC(discovery,
> "Allow driver to discover hardware IPs from IP Discovery table at the top of VRAM");
> --
> 2.20.1
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-09 1:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-08 18:48 [PATCH 1/3] drm/amdgpu: add missing documentation on new module parameters Alex Deucher
[not found] ` <20190708184811.6409-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2019-07-08 18:48 ` [PATCH 2/3] drm/amdgpu: properly guard the generic discovery code Alex Deucher
2019-07-08 18:48 ` [PATCH 3/3] drm/amdgpu: enable IP discovery by default on navi Alex Deucher
[not found] ` <20190708184811.6409-3-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2019-07-09 1:16 ` Yuan, Xiaojie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.