* [LTP] [PATCH 1/1] syscalls/ioctl08: Require btrfs
@ 2019-07-03 15:47 Petr Vorel
2019-07-09 10:24 ` Cyril Hrubis
2019-07-29 14:19 ` Petr Vorel
0 siblings, 2 replies; 4+ messages in thread
From: Petr Vorel @ 2019-07-03 15:47 UTC (permalink / raw)
To: ltp
Test requires btrfs otherwise it fails:
WARNING: failed to open /dev/btrfs-control, skipping device
registration: No such file or directory
safe_macros.c:757: BROK: tst_test.c:752: mount(/dev/loop0, mnt_point,
btrfs, 0, (nil)) failed: ENODEV
Cc: Christian Amann <camann@suse.com>
Reported-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi Amir,
thanks a lot for a report and sorry for longer time to reply (vacation).
Could you please test it? (I don't have any VM with kernel >= 4.5 && !btrfs).
Kind regards,
Petr
testcases/kernel/syscalls/ioctl/ioctl08.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/testcases/kernel/syscalls/ioctl/ioctl08.c b/testcases/kernel/syscalls/ioctl/ioctl08.c
index 8de80048c..dca898a65 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl08.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl08.c
@@ -112,6 +112,11 @@ static void setup(void)
sizeof(struct file_dedupe_range_info));
}
+static const char *const needed_drivers[] = {
+ "btrfs",
+ NULL,
+};
+
static struct tst_test test = {
.test = verify_ioctl,
.tcnt = ARRAY_SIZE(tcases),
@@ -122,6 +127,7 @@ static struct tst_test test = {
.mount_device = 1,
.mntpoint = MNTPOINT,
.dev_fs_type = "btrfs",
+ .needs_drivers = needed_drivers,
};
#else
TST_TEST_TCONF(
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [LTP] [PATCH 1/1] syscalls/ioctl08: Require btrfs
2019-07-03 15:47 [LTP] [PATCH 1/1] syscalls/ioctl08: Require btrfs Petr Vorel
@ 2019-07-09 10:24 ` Cyril Hrubis
2019-07-29 14:19 ` Petr Vorel
1 sibling, 0 replies; 4+ messages in thread
From: Cyril Hrubis @ 2019-07-09 10:24 UTC (permalink / raw)
To: ltp
Hi!
> WARNING: failed to open /dev/btrfs-control, skipping device
> registration: No such file or directory
> safe_macros.c:757: BROK: tst_test.c:752: mount(/dev/loop0, mnt_point,
> btrfs, 0, (nil)) failed: ENODEV
>
> Cc: Christian Amann <camann@suse.com>
> Reported-by: Amir Goldstein <amir73il@gmail.com>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi Amir,
>
> thanks a lot for a report and sorry for longer time to reply (vacation).
> Could you please test it? (I don't have any VM with kernel >= 4.5 && !btrfs).
Looks good to me.
Amir have you had a chance to test this patch?
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] [PATCH 1/1] syscalls/ioctl08: Require btrfs
2019-07-03 15:47 [LTP] [PATCH 1/1] syscalls/ioctl08: Require btrfs Petr Vorel
2019-07-09 10:24 ` Cyril Hrubis
@ 2019-07-29 14:19 ` Petr Vorel
2019-07-31 20:51 ` Petr Vorel
1 sibling, 1 reply; 4+ messages in thread
From: Petr Vorel @ 2019-07-29 14:19 UTC (permalink / raw)
To: ltp
Hi Amir,
> Test requires btrfs otherwise it fails:
> WARNING: failed to open /dev/btrfs-control, skipping device
> registration: No such file or directory
> safe_macros.c:757: BROK: tst_test.c:752: mount(/dev/loop0, mnt_point,
> btrfs, 0, (nil)) failed: ENODEV
could you please test it?
Kind regards,
Petr
https://patchwork.ozlabs.org/patch/1126923/
> Cc: Christian Amann <camann@suse.com>
> Reported-by: Amir Goldstein <amir73il@gmail.com>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi Amir,
> thanks a lot for a report and sorry for longer time to reply (vacation).
> Could you please test it? (I don't have any VM with kernel >= 4.5 && !btrfs).
> Kind regards,
> Petr
> testcases/kernel/syscalls/ioctl/ioctl08.c | 6 ++++++
> 1 file changed, 6 insertions(+)
> diff --git a/testcases/kernel/syscalls/ioctl/ioctl08.c b/testcases/kernel/syscalls/ioctl/ioctl08.c
> index 8de80048c..dca898a65 100644
> --- a/testcases/kernel/syscalls/ioctl/ioctl08.c
> +++ b/testcases/kernel/syscalls/ioctl/ioctl08.c
> @@ -112,6 +112,11 @@ static void setup(void)
> sizeof(struct file_dedupe_range_info));
> }
> +static const char *const needed_drivers[] = {
> + "btrfs",
> + NULL,
> +};
> +
> static struct tst_test test = {
> .test = verify_ioctl,
> .tcnt = ARRAY_SIZE(tcases),
> @@ -122,6 +127,7 @@ static struct tst_test test = {
> .mount_device = 1,
> .mntpoint = MNTPOINT,
> .dev_fs_type = "btrfs",
> + .needs_drivers = needed_drivers,
> };
> #else
> TST_TEST_TCONF(
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] [PATCH 1/1] syscalls/ioctl08: Require btrfs
2019-07-29 14:19 ` Petr Vorel
@ 2019-07-31 20:51 ` Petr Vorel
0 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2019-07-31 20:51 UTC (permalink / raw)
To: ltp
Hi Amir,
> > Test requires btrfs otherwise it fails:
> > WARNING: failed to open /dev/btrfs-control, skipping device
> > registration: No such file or directory
> > safe_macros.c:757: BROK: tst_test.c:752: mount(/dev/loop0, mnt_point,
> > btrfs, 0, (nil)) failed: ENODEV
> could you please test it?
I tested it on kernel without btrfs and it works as expected, thus pushed.
Thanks again for your report.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-31 20:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-03 15:47 [LTP] [PATCH 1/1] syscalls/ioctl08: Require btrfs Petr Vorel
2019-07-09 10:24 ` Cyril Hrubis
2019-07-29 14:19 ` Petr Vorel
2019-07-31 20:51 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.