All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2] serial: mxc: Add compatibles to NXP's serial driver (for imx21 and imx53)
@ 2019-07-09 15:00 Lukasz Majewski
  2019-07-09 15:41 ` Marek Vasut
  2019-07-20  8:45 ` sbabic at denx.de
  0 siblings, 2 replies; 3+ messages in thread
From: Lukasz Majewski @ 2019-07-09 15:00 UTC (permalink / raw)
  To: u-boot

This patch fixes not enabled uart2 (and hence serial console) on i.MX53
devices. After following commit 1d255904c306 ("ARM: dts: imx: imx53:
Synchronize iMX53 DT with Linux") from the uart2 compatible the
'fsl,imx7d-uart' has been removed (which was correct).

However, the root cause of the problem was the commit 98d62e618bb9 ("arm:
imx: add i.MX53 Beckhoff CX9020 Embedded PC") which introduced this
compatible.

Moreover, without this patch all i.MX53 UARTs are not usable as neither
'fsl,imx53-uart' nor 'fsl,imx21-uart' are in compatible IDs in
drivers/serial/serial_mxc.c file.

The fix is to add 'fsl,imx53-uart' and 'fsl,imx21-uart' as compatibles
for the aforementioned serial driver (those are also defined in the Linux
kernel).

Signed-off-by: Lukasz Majewski <lukma@denx.de>

---

Changes in v2:
- Add 'fsl,imx21-uart' to the compatible table
- Change the subject tags to 'serial: mxc:"

 drivers/serial/serial_mxc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c
index a435e68005..e73e979897 100644
--- a/drivers/serial/serial_mxc.c
+++ b/drivers/serial/serial_mxc.c
@@ -342,6 +342,8 @@ static int mxc_serial_ofdata_to_platdata(struct udevice *dev)
 }
 
 static const struct udevice_id mxc_serial_ids[] = {
+	{ .compatible = "fsl,imx21-uart" },
+	{ .compatible = "fsl,imx53-uart" },
 	{ .compatible = "fsl,imx6sx-uart" },
 	{ .compatible = "fsl,imx6ul-uart" },
 	{ .compatible = "fsl,imx7d-uart" },
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH v2] serial: mxc: Add compatibles to NXP's serial driver (for imx21 and imx53)
  2019-07-09 15:00 [U-Boot] [PATCH v2] serial: mxc: Add compatibles to NXP's serial driver (for imx21 and imx53) Lukasz Majewski
@ 2019-07-09 15:41 ` Marek Vasut
  2019-07-20  8:45 ` sbabic at denx.de
  1 sibling, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2019-07-09 15:41 UTC (permalink / raw)
  To: u-boot

On 7/9/19 5:00 PM, Lukasz Majewski wrote:
> This patch fixes not enabled uart2 (and hence serial console) on i.MX53
> devices. After following commit 1d255904c306 ("ARM: dts: imx: imx53:
> Synchronize iMX53 DT with Linux") from the uart2 compatible the
> 'fsl,imx7d-uart' has been removed (which was correct).
> 
> However, the root cause of the problem was the commit 98d62e618bb9 ("arm:
> imx: add i.MX53 Beckhoff CX9020 Embedded PC") which introduced this
> compatible.
> 
> Moreover, without this patch all i.MX53 UARTs are not usable as neither
> 'fsl,imx53-uart' nor 'fsl,imx21-uart' are in compatible IDs in
> drivers/serial/serial_mxc.c file.
> 
> The fix is to add 'fsl,imx53-uart' and 'fsl,imx21-uart' as compatibles
> for the aforementioned serial driver (those are also defined in the Linux
> kernel).
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>

Acked-by: Marek Vasut <marex@denx.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH v2] serial: mxc: Add compatibles to NXP's serial driver (for imx21 and imx53)
  2019-07-09 15:00 [U-Boot] [PATCH v2] serial: mxc: Add compatibles to NXP's serial driver (for imx21 and imx53) Lukasz Majewski
  2019-07-09 15:41 ` Marek Vasut
@ 2019-07-20  8:45 ` sbabic at denx.de
  1 sibling, 0 replies; 3+ messages in thread
From: sbabic at denx.de @ 2019-07-20  8:45 UTC (permalink / raw)
  To: u-boot

> This patch fixes not enabled uart2 (and hence serial console) on i.MX53
> devices. After following commit 1d255904c306 ("ARM: dts: imx: imx53:
> Synchronize iMX53 DT with Linux") from the uart2 compatible the
> 'fsl,imx7d-uart' has been removed (which was correct).
> However, the root cause of the problem was the commit 98d62e618bb9 ("arm:
> imx: add i.MX53 Beckhoff CX9020 Embedded PC") which introduced this
> compatible.
> Moreover, without this patch all i.MX53 UARTs are not usable as neither
> 'fsl,imx53-uart' nor 'fsl,imx21-uart' are in compatible IDs in
> drivers/serial/serial_mxc.c file.
> The fix is to add 'fsl,imx53-uart' and 'fsl,imx21-uart' as compatibles
> for the aforementioned serial driver (those are also defined in the Linux
> kernel).
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> Acked-by: Marek Vasut <marex@denx.de>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-20  8:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-09 15:00 [U-Boot] [PATCH v2] serial: mxc: Add compatibles to NXP's serial driver (for imx21 and imx53) Lukasz Majewski
2019-07-09 15:41 ` Marek Vasut
2019-07-20  8:45 ` sbabic at denx.de

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.