From: Masami Hiramatsu <masami.hiramatsu@gmail.com> To: Anders Roxell <anders.roxell@linaro.org>, Steven Rostedt <rostedt@goodmis.org> Cc: James Morse <james.morse@arm.com>, "Naveen N . Rao" <naveen.n.rao@linux.ibm.com>, Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>, David Miller <davem@davemloft.net>, Masami Hiramatsu <mhiramat@kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: kprobes sanity test fails on next-20190708 Date: Tue, 9 Jul 2019 21:36:57 +0900 [thread overview] Message-ID: <20190709213657.1447f508bd6b72495ec225d9@gmail.com> (raw) In-Reply-To: <CADYN=9LBQ4NYFe8BPguJmxJFMiAJ405AZNU7W6gHXLSrZOSgTA@mail.gmail.com> On Tue, 9 Jul 2019 12:19:15 +0200 Anders Roxell <anders.roxell@linaro.org> wrote: > On Mon, 8 Jul 2019 at 17:56, James Morse <james.morse@arm.com> wrote: > > > > Hi, > > > > On 08/07/2019 15:11, Anders Roxell wrote: > > > argh... resending, with plaintext... Sorry =/ > > > > > > I tried to build a next-201908 defconfig + CONFIG_KPROBES=y and > > > CONFIG_KPROBES_SANITY_TEST=y > > > > > > I get the following Call trace, any ideas? > > > I've tried tags back to next-20190525 and they also failes... I haven't > > > found a commit that works yet. > > > > > > [ 0.098694] Kprobe smoke test: started > > > [ 0.102001] audit: type=2000 audit(0.088:1): state=initialized > > > audit_enabled=0 res=1 > > > [ 0.104753] Internal error: aarch64 BRK: f2000004 [#1] PREEMPT SMP > > > > This sounds like the issue Mark reported: > > https://lore.kernel.org/r/20190702165008.GC34718@lakrids.cambridge.arm.com > > > > It doesn't look like Steve's patch has percolated into next yet: > > https://lore.kernel.org/lkml/20190703103715.32579c25@gandalf.local.home/ > > > > Could you give that a try to see if this is a new issue? > > The patch didn't apply cleanly. > However, when I resolved the issue it works. > I'm a bit embarrassed since I now remembered that I reported it a while back. > https://lore.kernel.org/lkml/20190625191545.245259106@goodmis.org/ > > Both patches resolved the issue. > I've tested both. In that case, the later one (move postcore to subsys) seems good to me. Delaying the test is just avoiding the issue that the selftest found, since right after init_kprobes() are called, the kprobe is ready for use. This means that the selftest must be run as the first user of the kprobes and it must be run right after initialize kprobes. Thank you, > > Cheers, > Anders -- Masami Hiramatsu
WARNING: multiple messages have this Message-ID (diff)
From: Masami Hiramatsu <masami.hiramatsu@gmail.com> To: Anders Roxell <anders.roxell@linaro.org>, Steven Rostedt <rostedt@goodmis.org> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>, James Morse <james.morse@arm.com>, Masami Hiramatsu <mhiramat@kernel.org>, "Naveen N . Rao" <naveen.n.rao@linux.ibm.com>, David Miller <davem@davemloft.net>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: kprobes sanity test fails on next-20190708 Date: Tue, 9 Jul 2019 21:36:57 +0900 [thread overview] Message-ID: <20190709213657.1447f508bd6b72495ec225d9@gmail.com> (raw) In-Reply-To: <CADYN=9LBQ4NYFe8BPguJmxJFMiAJ405AZNU7W6gHXLSrZOSgTA@mail.gmail.com> On Tue, 9 Jul 2019 12:19:15 +0200 Anders Roxell <anders.roxell@linaro.org> wrote: > On Mon, 8 Jul 2019 at 17:56, James Morse <james.morse@arm.com> wrote: > > > > Hi, > > > > On 08/07/2019 15:11, Anders Roxell wrote: > > > argh... resending, with plaintext... Sorry =/ > > > > > > I tried to build a next-201908 defconfig + CONFIG_KPROBES=y and > > > CONFIG_KPROBES_SANITY_TEST=y > > > > > > I get the following Call trace, any ideas? > > > I've tried tags back to next-20190525 and they also failes... I haven't > > > found a commit that works yet. > > > > > > [ 0.098694] Kprobe smoke test: started > > > [ 0.102001] audit: type=2000 audit(0.088:1): state=initialized > > > audit_enabled=0 res=1 > > > [ 0.104753] Internal error: aarch64 BRK: f2000004 [#1] PREEMPT SMP > > > > This sounds like the issue Mark reported: > > https://lore.kernel.org/r/20190702165008.GC34718@lakrids.cambridge.arm.com > > > > It doesn't look like Steve's patch has percolated into next yet: > > https://lore.kernel.org/lkml/20190703103715.32579c25@gandalf.local.home/ > > > > Could you give that a try to see if this is a new issue? > > The patch didn't apply cleanly. > However, when I resolved the issue it works. > I'm a bit embarrassed since I now remembered that I reported it a while back. > https://lore.kernel.org/lkml/20190625191545.245259106@goodmis.org/ > > Both patches resolved the issue. > I've tested both. In that case, the later one (move postcore to subsys) seems good to me. Delaying the test is just avoiding the issue that the selftest found, since right after init_kprobes() are called, the kprobe is ready for use. This means that the selftest must be run as the first user of the kprobes and it must be run right after initialize kprobes. Thank you, > > Cheers, > Anders -- Masami Hiramatsu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-09 12:37 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-08 14:11 kprobes sanity test fails on next-20190708 Anders Roxell 2019-07-08 14:11 ` Anders Roxell 2019-07-08 15:56 ` James Morse 2019-07-08 15:56 ` James Morse 2019-07-09 10:19 ` Anders Roxell 2019-07-09 10:19 ` Anders Roxell 2019-07-09 12:36 ` Masami Hiramatsu [this message] 2019-07-09 12:36 ` Masami Hiramatsu 2019-07-09 15:25 ` Steven Rostedt 2019-07-09 15:25 ` Steven Rostedt 2019-07-09 15:37 ` Mark Rutland 2019-07-09 15:37 ` Mark Rutland 2019-07-09 15:40 ` Steven Rostedt 2019-07-09 15:40 ` Steven Rostedt 2019-07-10 2:46 ` Masami Hiramatsu 2019-07-10 2:46 ` Masami Hiramatsu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190709213657.1447f508bd6b72495ec225d9@gmail.com \ --to=masami.hiramatsu@gmail.com \ --cc=anders.roxell@linaro.org \ --cc=anil.s.keshavamurthy@intel.com \ --cc=davem@davemloft.net \ --cc=james.morse@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mhiramat@kernel.org \ --cc=naveen.n.rao@linux.ibm.com \ --cc=rostedt@goodmis.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.