All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/4] armv8: ls1028aqds: Remove the definition of CONFIG_SYS_I2C_EARLY_INIT
@ 2019-07-10  7:48 Chuanhua Han
  2019-07-10  7:48 ` [U-Boot] [PATCH 2/4] configs: ls1028aqds: Enable DM support for pcf2127 rtc Chuanhua Han
                   ` (3 more replies)
  0 siblings, 4 replies; 14+ messages in thread
From: Chuanhua Han @ 2019-07-10  7:48 UTC (permalink / raw)
  To: u-boot

Since i2c uses dm mode, i2 controller will be initialized when reading
and writing devices on i2c bus. So there is no need for the original
non-dm mode i2c early initialization function call, this patch removed
the definition of CONFIG_SYS_I2C_EARLY_INIT.

Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
---
depends on:
	- http://patchwork.ozlabs.org/project/uboot/list/?series=117203
	- http://patchwork.ozlabs.org/project/uboot/list/?series=117224
	- http://patchwork.ozlabs.org/project/uboot/list/?series=118231

 include/configs/ls1028aqds.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/configs/ls1028aqds.h b/include/configs/ls1028aqds.h
index be018ef..b0e9441 100644
--- a/include/configs/ls1028aqds.h
+++ b/include/configs/ls1028aqds.h
@@ -16,7 +16,6 @@
 #define CONFIG_DIMM_SLOTS_PER_CTLR		2
 
 #define CONFIG_QIXIS_I2C_ACCESS
-#define CONFIG_SYS_I2C_EARLY_INIT
 
 /*
  * QIXIS Definitions
-- 
2.9.5

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH 2/4] configs: ls1028aqds: Enable DM support for pcf2127 rtc
  2019-07-10  7:48 [U-Boot] [PATCH 1/4] armv8: ls1028aqds: Remove the definition of CONFIG_SYS_I2C_EARLY_INIT Chuanhua Han
@ 2019-07-10  7:48 ` Chuanhua Han
  2019-07-15  7:15   ` Alex Marginean
  2019-07-10  7:48 ` [U-Boot] [PATCH 3/4] armv8: dts: ls1028aqds: Add pca9547 node under the i2c0 controller Chuanhua Han
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 14+ messages in thread
From: Chuanhua Han @ 2019-07-10  7:48 UTC (permalink / raw)
  To: u-boot

Enable related configs on all ls1028aqds boards to support pcf2127
rtc DM function.

Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
---
depends on:
	- http://patchwork.ozlabs.org/project/uboot/list/?series=117203
	- http://patchwork.ozlabs.org/project/uboot/list/?series=117224
	- http://patchwork.ozlabs.org/project/uboot/list/?series=118231

 configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 11 ++++++++++-
 configs/ls1028aqds_tfa_defconfig             | 11 ++++++++++-
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/configs/ls1028aqds_tfa_SECURE_BOOT_defconfig b/configs/ls1028aqds_tfa_SECURE_BOOT_defconfig
index 7cd2f59..5f66b55 100644
--- a/configs/ls1028aqds_tfa_SECURE_BOOT_defconfig
+++ b/configs/ls1028aqds_tfa_SECURE_BOOT_defconfig
@@ -1,5 +1,6 @@
 CONFIG_ARM=y
 CONFIG_TARGET_LS1028AQDS=y
+CONFIG_SYS_MALLOC_F_LEN=0x6000
 CONFIG_SECURE_BOOT=y
 CONFIG_SYS_FSL_SDHC_CLK_DIV=1
 CONFIG_TFABOOT=y
@@ -8,7 +9,6 @@ CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT=y
 CONFIG_SEC_FIRMWARE_ARMV8_PSCI=y
 CONFIG_AHCI=y
 CONFIG_DISTRO_DEFAULTS=y
-# CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT_VERBOSE=y
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_OF_STDOUT_VIA_ALIAS=y
@@ -60,3 +60,12 @@ CONFIG_WDT=y
 CONFIG_WDT_SP805=y
 CONFIG_RSA=y
 CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
+CONFIG_DM_I2C=y
+CONFIG_I2C_SET_DEFAULT_BUS_NUM=y
+CONFIG_I2C_DEFAULT_BUS_NUMBER=0
+CONFIG_DM_RTC=y
+CONFIG_DM_GPIO=y
+CONFIG_CMD_DATE=y
+CONFIG_RTC_PCF2127=y
+CONFIG_I2C_MUX=y
+CONFIG_I2C_MUX_PCA954x=y
diff --git a/configs/ls1028aqds_tfa_defconfig b/configs/ls1028aqds_tfa_defconfig
index 7982ce4..d221624 100644
--- a/configs/ls1028aqds_tfa_defconfig
+++ b/configs/ls1028aqds_tfa_defconfig
@@ -1,5 +1,6 @@
 CONFIG_ARM=y
 CONFIG_TARGET_LS1028AQDS=y
+CONFIG_SYS_MALLOC_F_LEN=0x6000
 CONFIG_SYS_FSL_SDHC_CLK_DIV=1
 CONFIG_TFABOOT=y
 CONFIG_NR_DRAM_BANKS=2
@@ -7,7 +8,6 @@ CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT=y
 CONFIG_SEC_FIRMWARE_ARMV8_PSCI=y
 CONFIG_AHCI=y
 CONFIG_DISTRO_DEFAULTS=y
-# CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT_VERBOSE=y
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_OF_STDOUT_VIA_ALIAS=y
@@ -63,3 +63,12 @@ CONFIG_USB_XHCI_DWC3=y
 CONFIG_WDT=y
 CONFIG_WDT_SP805=y
 CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
+CONFIG_DM_I2C=y
+CONFIG_I2C_SET_DEFAULT_BUS_NUM=y
+CONFIG_I2C_DEFAULT_BUS_NUMBER=0
+CONFIG_DM_RTC=y
+CONFIG_DM_GPIO=y
+CONFIG_CMD_DATE=y
+CONFIG_RTC_PCF2127=y
+CONFIG_I2C_MUX=y
+CONFIG_I2C_MUX_PCA954x=y
-- 
2.9.5

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH 3/4] armv8: dts: ls1028aqds: Add pca9547 node under the i2c0 controller
  2019-07-10  7:48 [U-Boot] [PATCH 1/4] armv8: ls1028aqds: Remove the definition of CONFIG_SYS_I2C_EARLY_INIT Chuanhua Han
  2019-07-10  7:48 ` [U-Boot] [PATCH 2/4] configs: ls1028aqds: Enable DM support for pcf2127 rtc Chuanhua Han
@ 2019-07-10  7:48 ` Chuanhua Han
  2019-07-15  7:16   ` Alex Marginean
  2019-07-10  7:48 ` [U-Boot] [PATCH 4/4] armv8: dts: ls1028aqds: Add pcf2127 node under i2c1 Chuanhua Han
  2019-07-15  7:13 ` [U-Boot] [PATCH 1/4] armv8: ls1028aqds: Remove the definition of CONFIG_SYS_I2C_EARLY_INIT Alex Marginean
  3 siblings, 1 reply; 14+ messages in thread
From: Chuanhua Han @ 2019-07-10  7:48 UTC (permalink / raw)
  To: u-boot

This patch adds pca9547 node to support i2c multiplexer
under the i2c0 controller for ls1028aqds boards.

Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
---
depends on:
	- http://patchwork.ozlabs.org/project/uboot/list/?series=117203
	- http://patchwork.ozlabs.org/project/uboot/list/?series=117224
	- http://patchwork.ozlabs.org/project/uboot/list/?series=118231

 arch/arm/dts/fsl-ls1028a-qds.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/dts/fsl-ls1028a-qds.dts b/arch/arm/dts/fsl-ls1028a-qds.dts
index 46a0419..dde45d6 100644
--- a/arch/arm/dts/fsl-ls1028a-qds.dts
+++ b/arch/arm/dts/fsl-ls1028a-qds.dts
@@ -37,6 +37,14 @@
 
 &i2c0 {
 	status = "okay";
+	u-boot,dm-pre-reloc;
+
+	i2c-mux at 77 {
+		compatible = "nxp,pca9547";
+		reg = <0x77>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+	};
 };
 
 &i2c1 {
-- 
2.9.5

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH 4/4] armv8: dts: ls1028aqds: Add pcf2127 node under i2c1
  2019-07-10  7:48 [U-Boot] [PATCH 1/4] armv8: ls1028aqds: Remove the definition of CONFIG_SYS_I2C_EARLY_INIT Chuanhua Han
  2019-07-10  7:48 ` [U-Boot] [PATCH 2/4] configs: ls1028aqds: Enable DM support for pcf2127 rtc Chuanhua Han
  2019-07-10  7:48 ` [U-Boot] [PATCH 3/4] armv8: dts: ls1028aqds: Add pca9547 node under the i2c0 controller Chuanhua Han
@ 2019-07-10  7:48 ` Chuanhua Han
  2019-07-15  7:17   ` Alex Marginean
  2019-07-15  7:13 ` [U-Boot] [PATCH 1/4] armv8: ls1028aqds: Remove the definition of CONFIG_SYS_I2C_EARLY_INIT Alex Marginean
  3 siblings, 1 reply; 14+ messages in thread
From: Chuanhua Han @ 2019-07-10  7:48 UTC (permalink / raw)
  To: u-boot

This patch adds the pcf2127-rtc node under the i2c1
for ls1028aqds boards.

Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
---
depends on:
	- http://patchwork.ozlabs.org/project/uboot/list/?series=117203
	- http://patchwork.ozlabs.org/project/uboot/list/?series=117224
	- http://patchwork.ozlabs.org/project/uboot/list/?series=118231

 arch/arm/dts/fsl-ls1028a-qds.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/dts/fsl-ls1028a-qds.dts b/arch/arm/dts/fsl-ls1028a-qds.dts
index dde45d6..54b0791 100644
--- a/arch/arm/dts/fsl-ls1028a-qds.dts
+++ b/arch/arm/dts/fsl-ls1028a-qds.dts
@@ -49,6 +49,11 @@
 
 &i2c1 {
 	status = "okay";
+
+	rtc at 51 {
+		compatible = "pcf2127-rtc";
+		reg = <0x51>;
+	};
 };
 
 &i2c2 {
-- 
2.9.5

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH 1/4] armv8: ls1028aqds: Remove the definition of CONFIG_SYS_I2C_EARLY_INIT
  2019-07-10  7:48 [U-Boot] [PATCH 1/4] armv8: ls1028aqds: Remove the definition of CONFIG_SYS_I2C_EARLY_INIT Chuanhua Han
                   ` (2 preceding siblings ...)
  2019-07-10  7:48 ` [U-Boot] [PATCH 4/4] armv8: dts: ls1028aqds: Add pcf2127 node under i2c1 Chuanhua Han
@ 2019-07-15  7:13 ` Alex Marginean
  2019-08-22  8:33   ` Prabhakar Kushwaha
  3 siblings, 1 reply; 14+ messages in thread
From: Alex Marginean @ 2019-07-15  7:13 UTC (permalink / raw)
  To: u-boot

On 7/10/2019 10:48 AM, Chuanhua Han wrote:
> Since i2c uses dm mode, i2 controller will be initialized when reading
> and writing devices on i2c bus. So there is no need for the original
> non-dm mode i2c early initialization function call, this patch removed
> the definition of CONFIG_SYS_I2C_EARLY_INIT.
> 
> Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> ---
> depends on:
> 	- http://patchwork.ozlabs.org/project/uboot/list/?series=117203
> 	- http://patchwork.ozlabs.org/project/uboot/list/?series=117224
> 	- http://patchwork.ozlabs.org/project/uboot/list/?series=118231
> 
>   include/configs/ls1028aqds.h | 1 -
>   1 file changed, 1 deletion(-)
> 
Reviewed-by: Alex Marginean <alexm.osslist@gmail.com>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH 2/4] configs: ls1028aqds: Enable DM support for pcf2127 rtc
  2019-07-10  7:48 ` [U-Boot] [PATCH 2/4] configs: ls1028aqds: Enable DM support for pcf2127 rtc Chuanhua Han
@ 2019-07-15  7:15   ` Alex Marginean
  2019-07-15  7:20     ` [U-Boot] [EXT] " Chuanhua Han
  0 siblings, 1 reply; 14+ messages in thread
From: Alex Marginean @ 2019-07-15  7:15 UTC (permalink / raw)
  To: u-boot

On 7/10/2019 10:48 AM, Chuanhua Han wrote:
> Enable related configs on all ls1028aqds boards to support pcf2127
> rtc DM function.
> 
> Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> ---
> depends on:
> 	- http://patchwork.ozlabs.org/project/uboot/list/?series=117203
> 	- http://patchwork.ozlabs.org/project/uboot/list/?series=117224
> 	- http://patchwork.ozlabs.org/project/uboot/list/?series=118231
> 
>   configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 11 ++++++++++-
>   configs/ls1028aqds_tfa_defconfig             | 11 ++++++++++-
>   2 files changed, 20 insertions(+), 2 deletions(-)
> 

date command doesn't seem to work at my end:
=> date
wait_for_sr_state: Arbitration lost sr=92 cr=0 state=2020
i2c_init_transfer: failed for chip 0x51 retry=0
wait_for_sr_state: Arbitration lost sr=92 cr=0 state=2020
i2c_init_transfer: failed for chip 0x51 retry=1
wait_for_sr_state: Arbitration lost sr=92 cr=0 state=2020
i2c_init_transfer: failed for chip 0x51 retry=2
i2c_init_transfer: give up i2c_regs=0x2010000
## Get date failed

other than that it looks OK.

Reviewed-by: Alex Marginean <alexm.osslist@gmail.com>
Tested-by: Alex Marginean <alexm.osslist@gmail.com>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH 3/4] armv8: dts: ls1028aqds: Add pca9547 node under the i2c0 controller
  2019-07-10  7:48 ` [U-Boot] [PATCH 3/4] armv8: dts: ls1028aqds: Add pca9547 node under the i2c0 controller Chuanhua Han
@ 2019-07-15  7:16   ` Alex Marginean
  2019-08-22  8:33     ` Prabhakar Kushwaha
  0 siblings, 1 reply; 14+ messages in thread
From: Alex Marginean @ 2019-07-15  7:16 UTC (permalink / raw)
  To: u-boot

On 7/10/2019 10:48 AM, Chuanhua Han wrote:
> This patch adds pca9547 node to support i2c multiplexer
> under the i2c0 controller for ls1028aqds boards.
> 
> Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> ---
> depends on:
> 	- http://patchwork.ozlabs.org/project/uboot/list/?series=117203
> 	- http://patchwork.ozlabs.org/project/uboot/list/?series=117224
> 	- http://patchwork.ozlabs.org/project/uboot/list/?series=118231
> 
>   arch/arm/dts/fsl-ls1028a-qds.dts | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 

Reviewed-by: Alex Marginean <alexm.osslist@gmail.com>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH 4/4] armv8: dts: ls1028aqds: Add pcf2127 node under i2c1
  2019-07-10  7:48 ` [U-Boot] [PATCH 4/4] armv8: dts: ls1028aqds: Add pcf2127 node under i2c1 Chuanhua Han
@ 2019-07-15  7:17   ` Alex Marginean
  2019-08-22  8:33     ` Prabhakar Kushwaha
  0 siblings, 1 reply; 14+ messages in thread
From: Alex Marginean @ 2019-07-15  7:17 UTC (permalink / raw)
  To: u-boot

On 7/10/2019 10:48 AM, Chuanhua Han wrote:
> This patch adds the pcf2127-rtc node under the i2c1
> for ls1028aqds boards.
> 
> Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> ---
> depends on:
> 	- http://patchwork.ozlabs.org/project/uboot/list/?series=117203
> 	- http://patchwork.ozlabs.org/project/uboot/list/?series=117224
> 	- http://patchwork.ozlabs.org/project/uboot/list/?series=118231
> 
>   arch/arm/dts/fsl-ls1028a-qds.dts | 5 +++++
>   1 file changed, 5 insertions(+)
> 

Reviewed-by: Alex Marginean <alexm.osslist@gmail.com>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [EXT] Re: [PATCH 2/4] configs: ls1028aqds: Enable DM support for pcf2127 rtc
  2019-07-15  7:15   ` Alex Marginean
@ 2019-07-15  7:20     ` Chuanhua Han
  2019-07-15  8:09       ` Alex Marginean
  0 siblings, 1 reply; 14+ messages in thread
From: Chuanhua Han @ 2019-07-15  7:20 UTC (permalink / raw)
  To: u-boot



> -----Original Message-----
> From: Alex Marginean <alexm.osslist@gmail.com>
> Sent: 2019年7月15日 15:16
> To: Chuanhua Han <chuanhua.han@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; albert.u.boot at aribaud.net; Andy Tang
> <andy.tang@nxp.com>; Sudhanshu Gupta <sudhanshu.gupta@nxp.com>;
> Harninder Rai <harninder.rai@nxp.com>; Rajesh Bhagat
> <rajesh.bhagat@nxp.com>
> Cc: u-boot at lists.denx.de
> Subject: [EXT] Re: [U-Boot] [PATCH 2/4] configs: ls1028aqds: Enable DM
> support for pcf2127 rtc
> 
> Caution: EXT Email
> 
> On 7/10/2019 10:48 AM, Chuanhua Han wrote:
> > Enable related configs on all ls1028aqds boards to support pcf2127 rtc
> > DM function.
> >
> > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > ---
> > depends on:
> >       -
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatchwo
> rk.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D117203&amp;data
> =02%7C01%7Cchuanhua.han%40nxp.com%7C817d847ff0354fbe1aad08d708f
> 44625%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6369877175
> 48591048&amp;sdata=opbvJeeagqt4bcMU6afno3a6d6QwSFphkfTs2324eDI%
> 3D&amp;reserved=0
> >       -
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatchwo
> rk.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D117224&amp;data
> =02%7C01%7Cchuanhua.han%40nxp.com%7C817d847ff0354fbe1aad08d708f
> 44625%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6369877175
> 48601042&amp;sdata=3JzYgVuNprnWXXg41y%2Bpb4GJTVzmbt4McAwJnZx2v
> tY%3D&amp;reserved=0
> >       -
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> >
> work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D118231&amp;d
> ata
> >
> =02%7C01%7Cchuanhua.han%40nxp.com%7C817d847ff0354fbe1aad08d708f
> 44625%7
> >
> C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63698771754860104
> 2&amp;sda
> >
> ta=ilmiN7mqR8pyUEzLLhnwWPpSfm0uV%2BQBbxyCZESXkpA%3D&amp;reser
> ved=0
> >
> >   configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 11 ++++++++++-
> >   configs/ls1028aqds_tfa_defconfig             | 11 ++++++++++-
> >   2 files changed, 20 insertions(+), 2 deletions(-)
> >
> 
> date command doesn't seem to work at my end:
> => date
> wait_for_sr_state: Arbitration lost sr=92 cr=0 state=2020
> i2c_init_transfer: failed for chip 0x51 retry=0
> wait_for_sr_state: Arbitration lost sr=92 cr=0 state=2020
> i2c_init_transfer: failed for chip 0x51 retry=1
> wait_for_sr_state: Arbitration lost sr=92 cr=0 state=2020
> i2c_init_transfer: failed for chip 0x51 retry=2
> i2c_init_transfer: give up i2c_regs=0x2010000 ## Get date failed
No, You need to apply the fix pcf2127-rtc patch first.
http://patchwork.ozlabs.org/patch/1128859/

> 
> other than that it looks OK.
> 
> Reviewed-by: Alex Marginean <alexm.osslist@gmail.com>
> Tested-by: Alex Marginean <alexm.osslist@gmail.com>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [EXT] Re: [PATCH 2/4] configs: ls1028aqds: Enable DM support for pcf2127 rtc
  2019-07-15  7:20     ` [U-Boot] [EXT] " Chuanhua Han
@ 2019-07-15  8:09       ` Alex Marginean
  2019-07-15  8:13         ` Chuanhua Han
  0 siblings, 1 reply; 14+ messages in thread
From: Alex Marginean @ 2019-07-15  8:09 UTC (permalink / raw)
  To: u-boot

On 7/15/2019 10:20 AM, Chuanhua Han wrote:
> 
>> -----Original Message-----
>> From: Alex Marginean<alexm.osslist@gmail.com>
>> Sent: 2019年7月15日 15:16
[...]
>>
>> On 7/10/2019 10:48 AM, Chuanhua Han wrote:
>>> Enable related configs on all ls1028aqds boards to support pcf2127 rtc
>>> DM function.
>>>
>>> Signed-off-by: Chuanhua Han<chuanhua.han@nxp.com>
>>> ---
[...]
>>>    configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 11 ++++++++++-
>>>    configs/ls1028aqds_tfa_defconfig             | 11 ++++++++++-
>>>    2 files changed, 20 insertions(+), 2 deletions(-)
>>>
>> date command doesn't seem to work at my end:
>> => date
>> wait_for_sr_state: Arbitration lost sr=92 cr=0 state=2020
>> i2c_init_transfer: failed for chip 0x51 retry=0
>> wait_for_sr_state: Arbitration lost sr=92 cr=0 state=2020
>> i2c_init_transfer: failed for chip 0x51 retry=1
>> wait_for_sr_state: Arbitration lost sr=92 cr=0 state=2020
>> i2c_init_transfer: failed for chip 0x51 retry=2
>> i2c_init_transfer: give up i2c_regs=0x2010000 ## Get date failed
> No, You need to apply the fix pcf2127-rtc patch first.
> http://patchwork.ozlabs.org/patch/1128859/

I do have it applied:
$ git log | grep "rtc: pcf2127:"
     rtc: pcf2127: Fixed bug with rtc settings and getting error time

In fact the fix was merged:
https://gitlab.denx.de/u-boot/u-boot/commit/ef6c26d338a168110b7688b07e319ff46c73748d

Anyway, it could be an issue on my side, I just noticed it and thought I
should let you know.

Thanks!
Alex

> 
>> other than that it looks OK.
>>
>> Reviewed-by: Alex Marginean<alexm.osslist@gmail.com>
>> Tested-by: Alex Marginean<alexm.osslist@gmail.com>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [EXT] Re: [PATCH 2/4] configs: ls1028aqds: Enable DM support for pcf2127 rtc
  2019-07-15  8:09       ` Alex Marginean
@ 2019-07-15  8:13         ` Chuanhua Han
  0 siblings, 0 replies; 14+ messages in thread
From: Chuanhua Han @ 2019-07-15  8:13 UTC (permalink / raw)
  To: u-boot



> -----Original Message-----
> From: Alex Marginean <alexm.osslist@gmail.com>
> Sent: 2019年7月15日 16:09
> To: Chuanhua Han <chuanhua.han@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; albert.u.boot at aribaud.net; Andy Tang
> <andy.tang@nxp.com>; Sudhanshu Gupta <sudhanshu.gupta@nxp.com>;
> Harninder Rai <harninder.rai@nxp.com>; Rajesh Bhagat
> <rajesh.bhagat@nxp.com>
> Cc: u-boot at lists.denx.de
> Subject: Re: [EXT] Re: [U-Boot] [PATCH 2/4] configs: ls1028aqds: Enable DM
> support for pcf2127 rtc
> 
> Caution: EXT Email
> 
> On 7/15/2019 10:20 AM, Chuanhua Han wrote:
> >
> >> -----Original Message-----
> >> From: Alex Marginean<alexm.osslist@gmail.com>
> >> Sent: 2019年7月15日 15:16
> [...]
> >>
> >> On 7/10/2019 10:48 AM, Chuanhua Han wrote:
> >>> Enable related configs on all ls1028aqds boards to support pcf2127
> >>> rtc DM function.
> >>>
> >>> Signed-off-by: Chuanhua Han<chuanhua.han@nxp.com>
> >>> ---
> [...]
> >>>    configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 11 ++++++++++-
> >>>    configs/ls1028aqds_tfa_defconfig             | 11 ++++++++++-
> >>>    2 files changed, 20 insertions(+), 2 deletions(-)
> >>>
> >> date command doesn't seem to work at my end:
> >> => date
> >> wait_for_sr_state: Arbitration lost sr=92 cr=0 state=2020
> >> i2c_init_transfer: failed for chip 0x51 retry=0
> >> wait_for_sr_state: Arbitration lost sr=92 cr=0 state=2020
> >> i2c_init_transfer: failed for chip 0x51 retry=1
> >> wait_for_sr_state: Arbitration lost sr=92 cr=0 state=2020
> >> i2c_init_transfer: failed for chip 0x51 retry=2
> >> i2c_init_transfer: give up i2c_regs=0x2010000 ## Get date failed
> > No, You need to apply the fix pcf2127-rtc patch first.
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> >
> work.ozlabs.org%2Fpatch%2F1128859%2F&amp;data=02%7C01%7Cchuanhu
> a.han%4
> >
> 0nxp.com%7C690e3343c4594b1b974208d708fbb5a3%7C686ea1d3bc2b4c6f
> a92cd99c
> >
> 5c301635%7C0%7C0%7C636987749492274084&amp;sdata=F732QTXsPutbe
> 7JZCSf%2F
> > dII2lDJC9CdIyTLYAeGnsxY%3D&amp;reserved=0
> 
> I do have it applied:
> $ git log | grep "rtc: pcf2127:"
>      rtc: pcf2127: Fixed bug with rtc settings and getting error time
> 
> In fact the fix was merged:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.d
> enx.de%2Fu-boot%2Fu-boot%2Fcommit%2Fef6c26d338a168110b7688b07e3
> 19ff46c73748d&amp;data=02%7C01%7Cchuanhua.han%40nxp.com%7C690e
> 3343c4594b1b974208d708fbb5a3%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C636987749492274084&amp;sdata=fwWYzMv18hJakNOLDHTr
> AdaxTAGWfPZviRaRtyCCbdg%3D&amp;reserved=0
> 
> Anyway, it could be an issue on my side, I just noticed it and thought I should
> let you know.
You can use openstream tree.
> 
> Thanks!
> Alex
> 
> >
> >> other than that it looks OK.
> >>
> >> Reviewed-by: Alex Marginean<alexm.osslist@gmail.com>
> >> Tested-by: Alex Marginean<alexm.osslist@gmail.com>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH 4/4] armv8: dts: ls1028aqds: Add pcf2127 node under i2c1
  2019-07-15  7:17   ` Alex Marginean
@ 2019-08-22  8:33     ` Prabhakar Kushwaha
  0 siblings, 0 replies; 14+ messages in thread
From: Prabhakar Kushwaha @ 2019-08-22  8:33 UTC (permalink / raw)
  To: u-boot


> -----Original Message-----
> From: Alex Marginean <alexm.osslist@gmail.com>
> Sent: Monday, July 15, 2019 12:47 PM
> To: Chuanhua Han <chuanhua.han@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; albert.u.boot at aribaud.net; Andy Tang
> <andy.tang@nxp.com>; Sudhanshu Gupta <sudhanshu.gupta@nxp.com>;
> Harninder Rai <harninder.rai@nxp.com>; Rajesh Bhagat
> <rajesh.bhagat@nxp.com>
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH 4/4] armv8: dts: ls1028aqds: Add pcf2127 node
> under i2c1
> 
> On 7/10/2019 10:48 AM, Chuanhua Han wrote:
> > This patch adds the pcf2127-rtc node under the i2c1 for ls1028aqds
> > boards.
> >
> > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > ---
> > depends on:
> > 	-
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D117203&amp;
> data=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7C3dc430761b3341e14
> 99408d708f46fc8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6369
> 87718248265296&amp;sdata=gKT%2BfCmFXjCdsBWzUQZup43KmLn%2BKXTS
> ABtUWpeHPm8%3D&amp;reserved=0
> > 	-
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D117224&amp;
> data=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7C3dc430761b3341e14
> 99408d708f46fc8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6369
> 87718248265296&amp;sdata=TWqgQ8XOyXnzcR9Txo6XCMxBbrOS%2BqzbU9
> qkbaZ59do%3D&amp;reserved=0
> > 	-
> >
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> >
> work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D118231&amp;
> data
> >
> =02%7C01%7Cprabhakar.kushwaha%40nxp.com%7C3dc430761b3341e149940
> 8d708f4
> >
> 6fc8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636987718248265
> 296&a
> >
> mp;sdata=LV0tXQtxgHaRre%2F29FjL6q9Wxx3qbc9AfdtYwkbhF2g%3D&amp;r
> eserved
> > =0
> >
> >   arch/arm/dts/fsl-ls1028a-qds.dts | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> 
> Reviewed-by: Alex Marginean <alexm.osslist@gmail.com>

This patch has been applied to fsl-qoriq master, awaiting upstream.

--pk

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH 3/4] armv8: dts: ls1028aqds: Add pca9547 node under the i2c0 controller
  2019-07-15  7:16   ` Alex Marginean
@ 2019-08-22  8:33     ` Prabhakar Kushwaha
  0 siblings, 0 replies; 14+ messages in thread
From: Prabhakar Kushwaha @ 2019-08-22  8:33 UTC (permalink / raw)
  To: u-boot


> -----Original Message-----
> From: Alex Marginean <alexm.osslist@gmail.com>
> Sent: Monday, July 15, 2019 12:46 PM
> To: Chuanhua Han <chuanhua.han@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; albert.u.boot at aribaud.net; Andy Tang
> <andy.tang@nxp.com>; Sudhanshu Gupta <sudhanshu.gupta@nxp.com>;
> Harninder Rai <harninder.rai@nxp.com>; Rajesh Bhagat
> <rajesh.bhagat@nxp.com>
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH 3/4] armv8: dts: ls1028aqds: Add pca9547 node
> under the i2c0 controller
> 
> On 7/10/2019 10:48 AM, Chuanhua Han wrote:
> > This patch adds pca9547 node to support i2c multiplexer under the i2c0
> > controller for ls1028aqds boards.
> >
> > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > ---
> > depends on:
> > 	-
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D117203&amp;
> data=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7Ced38d8a5ece149ee
> 097d08d708f455ea%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> 6987717814075154&amp;sdata=xJFMjeWuinoMFb8sMB3lEVcmfsNo8hK9Krc
> OCS3i1hM%3D&amp;reserved=0
> > 	-
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D117224&amp;
> data=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7Ced38d8a5ece149ee
> 097d08d708f455ea%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63
> 6987717814075154&amp;sdata=13EaFR14G6vnSPPK%2BHRAmD45oNsKJ0tW
> Bj5j7yg9XCA%3D&amp;reserved=0
> > 	-
> >
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> >
> work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D118231&amp;
> data
> >
> =02%7C01%7Cprabhakar.kushwaha%40nxp.com%7Ced38d8a5ece149ee097d
> 08d708f4
> >
> 55ea%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63698771781407
> 5154&a
> >
> mp;sdata=VmG%2ByRw7oC3re4d22ZsdlaKjcmgk5aRq7SGxM%2BqFh8w%3D
> &amp;reserv
> > ed=0
> >
> >   arch/arm/dts/fsl-ls1028a-qds.dts | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> 
> Reviewed-by: Alex Marginean <alexm.osslist@gmail.com>

This patch has been applied to fsl-qoriq master, awaiting upstream.

--pk

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [U-Boot] [PATCH 1/4] armv8: ls1028aqds: Remove the definition of CONFIG_SYS_I2C_EARLY_INIT
  2019-07-15  7:13 ` [U-Boot] [PATCH 1/4] armv8: ls1028aqds: Remove the definition of CONFIG_SYS_I2C_EARLY_INIT Alex Marginean
@ 2019-08-22  8:33   ` Prabhakar Kushwaha
  0 siblings, 0 replies; 14+ messages in thread
From: Prabhakar Kushwaha @ 2019-08-22  8:33 UTC (permalink / raw)
  To: u-boot


> -----Original Message-----
> From: Alex Marginean <alexm.osslist@gmail.com>
> Sent: Monday, July 15, 2019 12:44 PM
> To: Chuanhua Han <chuanhua.han@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; albert.u.boot at aribaud.net; Andy Tang
> <andy.tang@nxp.com>; Sudhanshu Gupta <sudhanshu.gupta@nxp.com>;
> Harninder Rai <harninder.rai@nxp.com>; Rajesh Bhagat
> <rajesh.bhagat@nxp.com>
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH 1/4] armv8: ls1028aqds: Remove the definition
> of CONFIG_SYS_I2C_EARLY_INIT
> 
> On 7/10/2019 10:48 AM, Chuanhua Han wrote:
> > Since i2c uses dm mode, i2 controller will be initialized when reading
> > and writing devices on i2c bus. So there is no need for the original
> > non-dm mode i2c early initialization function call, this patch removed
> > the definition of CONFIG_SYS_I2C_EARLY_INIT.
> >
> > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > ---
> > depends on:
> > 	-
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D117203&amp;
> data=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7C2f6fd48f3fc54dbcdb
> d408d708f3ff64%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63698
> 7716369898821&amp;sdata=jn0c472wqv0sbsoHxhJHikiMFz6d3ZSNABVMkeq
> MMIc%3D&amp;reserved=0
> > 	-
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D117224&amp;
> data=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7C2f6fd48f3fc54dbcdb
> d408d708f3ff64%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63698
> 7716369898821&amp;sdata=s8moqO3dojCdcZYYcsxkhuCOYWchZzaCAfHa5cg
> Rfdw%3D&amp;reserved=0
> > 	-
> >
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> >
> work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D118231&amp;
> data
> >
> =02%7C01%7Cprabhakar.kushwaha%40nxp.com%7C2f6fd48f3fc54dbcdbd408
> d708f3
> >
> ff64%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636987716369898
> 821&a
> >
> mp;sdata=QPovyeok0sNuDdx1eVCQq0s1JYvb9aMNZ519LxR19qM%3D&amp;
> reserved=0
> >
> >   include/configs/ls1028aqds.h | 1 -
> >   1 file changed, 1 deletion(-)
> >
> Reviewed-by: Alex Marginean <alexm.osslist@gmail.com>"

This patch has been applied to fsl-qoriq master, awaiting upstream.

--pk

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2019-08-22  8:33 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-10  7:48 [U-Boot] [PATCH 1/4] armv8: ls1028aqds: Remove the definition of CONFIG_SYS_I2C_EARLY_INIT Chuanhua Han
2019-07-10  7:48 ` [U-Boot] [PATCH 2/4] configs: ls1028aqds: Enable DM support for pcf2127 rtc Chuanhua Han
2019-07-15  7:15   ` Alex Marginean
2019-07-15  7:20     ` [U-Boot] [EXT] " Chuanhua Han
2019-07-15  8:09       ` Alex Marginean
2019-07-15  8:13         ` Chuanhua Han
2019-07-10  7:48 ` [U-Boot] [PATCH 3/4] armv8: dts: ls1028aqds: Add pca9547 node under the i2c0 controller Chuanhua Han
2019-07-15  7:16   ` Alex Marginean
2019-08-22  8:33     ` Prabhakar Kushwaha
2019-07-10  7:48 ` [U-Boot] [PATCH 4/4] armv8: dts: ls1028aqds: Add pcf2127 node under i2c1 Chuanhua Han
2019-07-15  7:17   ` Alex Marginean
2019-08-22  8:33     ` Prabhakar Kushwaha
2019-07-15  7:13 ` [U-Boot] [PATCH 1/4] armv8: ls1028aqds: Remove the definition of CONFIG_SYS_I2C_EARLY_INIT Alex Marginean
2019-08-22  8:33   ` Prabhakar Kushwaha

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.