* [igt-dev] [PATCH i-g-t] tests/kms_chamelium: remove unused drmModeGetResources
@ 2019-07-11 7:41 Simon Ser
2019-07-11 13:34 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Simon Ser @ 2019-07-11 7:41 UTC (permalink / raw)
To: igt-dev
The function was called, but the result was never used. Probably a remnant from
a previous refactoring.
Signed-off-by: Simon Ser <simon.ser@intel.com>
---
tests/kms_chamelium.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index b749b5598c1d..321fb16b73bd 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -464,14 +464,11 @@ prepare_output(data_t *data, struct chamelium_port *port, enum test_edid edid)
{
igt_display_t *display = &data->display;
igt_output_t *output;
- drmModeRes *res;
drmModeConnector *connector =
chamelium_port_get_connector(data->chamelium, port, false);
enum pipe pipe;
bool found = false;
- igt_require(res = drmModeGetResources(data->drm_fd));
-
/* The chamelium's default EDID has a lot of resolutions, way more then
* we need to test. Additionally the default EDID doesn't support HDMI
* audio.
@@ -501,7 +498,6 @@ prepare_output(data_t *data, struct chamelium_port *port, enum test_edid edid)
igt_output_set_pipe(output, pipe);
drmModeFreeConnector(connector);
- drmModeFreeResources(res);
return output;
}
--
2.22.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_chamelium: remove unused drmModeGetResources
2019-07-11 7:41 [igt-dev] [PATCH i-g-t] tests/kms_chamelium: remove unused drmModeGetResources Simon Ser
@ 2019-07-11 13:34 ` Patchwork
2019-07-11 13:49 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
2019-07-12 4:21 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-07-11 13:34 UTC (permalink / raw)
To: Ser, Simon; +Cc: igt-dev
== Series Details ==
Series: tests/kms_chamelium: remove unused drmModeGetResources
URL : https://patchwork.freedesktop.org/series/63542/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6456 -> IGTPW_3254
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/63542/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_3254 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload:
- fi-blb-e6850: [PASS][1] -> [INCOMPLETE][2] ([fdo#107718])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/fi-blb-e6850/igt@i915_module_load@reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/fi-blb-e6850/igt@i915_module_load@reload.html
#### Possible fixes ####
* {igt@gem_ctx_switch@rcs0}:
- fi-icl-guc: [INCOMPLETE][3] ([fdo#107713]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/fi-icl-guc/igt@gem_ctx_switch@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/fi-icl-guc/igt@gem_ctx_switch@rcs0.html
* igt@kms_chamelium@hdmi-edid-read:
- {fi-icl-u4}: [FAIL][5] ([fdo#111045] / [fdo#111046 ]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/fi-icl-u4/igt@kms_chamelium@hdmi-edid-read.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/fi-icl-u4/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][7] ([fdo#109485]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
- fi-kbl-7567u: [FAIL][9] ([fdo#109485]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/fi-kbl-7567u/igt@kms_chamelium@hdmi-hpd-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/fi-kbl-7567u/igt@kms_chamelium@hdmi-hpd-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111046 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111046
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
Participating hosts (52 -> 47)
------------------------------
Additional (1): fi-icl-dsi
Missing (6): fi-kbl-soraka fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* IGT: IGT_5093 -> IGTPW_3254
CI_DRM_6456: 43aa8c3633274d7cf0a6dca4b8734d84d9928cf9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3254: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/
IGT_5093: 86dc48ede7c33bf69e15f84179d2f9e5b84c179b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_chamelium: remove unused drmModeGetResources
2019-07-11 7:41 [igt-dev] [PATCH i-g-t] tests/kms_chamelium: remove unused drmModeGetResources Simon Ser
2019-07-11 13:34 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-07-11 13:49 ` Ville Syrjälä
2019-07-12 4:21 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Ville Syrjälä @ 2019-07-11 13:49 UTC (permalink / raw)
To: Simon Ser; +Cc: igt-dev
On Thu, Jul 11, 2019 at 10:41:12AM +0300, Simon Ser wrote:
> The function was called, but the result was never used. Probably a remnant from
> a previous refactoring.
>
> Signed-off-by: Simon Ser <simon.ser@intel.com>
One can probably trust the compiler here.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/kms_chamelium.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
> index b749b5598c1d..321fb16b73bd 100644
> --- a/tests/kms_chamelium.c
> +++ b/tests/kms_chamelium.c
> @@ -464,14 +464,11 @@ prepare_output(data_t *data, struct chamelium_port *port, enum test_edid edid)
> {
> igt_display_t *display = &data->display;
> igt_output_t *output;
> - drmModeRes *res;
> drmModeConnector *connector =
> chamelium_port_get_connector(data->chamelium, port, false);
> enum pipe pipe;
> bool found = false;
>
> - igt_require(res = drmModeGetResources(data->drm_fd));
> -
> /* The chamelium's default EDID has a lot of resolutions, way more then
> * we need to test. Additionally the default EDID doesn't support HDMI
> * audio.
> @@ -501,7 +498,6 @@ prepare_output(data_t *data, struct chamelium_port *port, enum test_edid edid)
> igt_output_set_pipe(output, pipe);
>
> drmModeFreeConnector(connector);
> - drmModeFreeResources(res);
>
> return output;
> }
> --
> 2.22.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_chamelium: remove unused drmModeGetResources
2019-07-11 7:41 [igt-dev] [PATCH i-g-t] tests/kms_chamelium: remove unused drmModeGetResources Simon Ser
2019-07-11 13:34 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-07-11 13:49 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
@ 2019-07-12 4:21 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-07-12 4:21 UTC (permalink / raw)
To: Ser, Simon; +Cc: igt-dev
== Series Details ==
Series: tests/kms_chamelium: remove unused drmModeGetResources
URL : https://patchwork.freedesktop.org/series/63542/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6456_full -> IGTPW_3254_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/63542/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_3254_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_workarounds@suspend-resume:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] ([fdo#108566]) +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/shard-apl7/igt@gem_workarounds@suspend-resume.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/shard-apl8/igt@gem_workarounds@suspend-resume.html
* igt@i915_pm_rpm@i2c:
- shard-hsw: [PASS][3] -> [FAIL][4] ([fdo#104097])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/shard-hsw2/igt@i915_pm_rpm@i2c.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/shard-hsw1/igt@i915_pm_rpm@i2c.html
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-hsw: [PASS][5] -> [FAIL][6] ([fdo#102887])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/shard-hsw2/igt@kms_flip@2x-flip-vs-expired-vblank.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/shard-hsw2/igt@kms_flip@2x-flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: [PASS][7] -> [FAIL][8] ([fdo#103167]) +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109642] / [fdo#111068])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/shard-iclb3/igt@kms_psr2_su@frontbuffer.html
#### Possible fixes ####
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][11] ([fdo#110854]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/shard-iclb6/igt@gem_exec_balancer@smoke.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/shard-iclb2/igt@gem_exec_balancer@smoke.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][13] ([fdo#108566]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/shard-apl4/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_pm_rpm@system-suspend:
- shard-kbl: [INCOMPLETE][15] ([fdo#103665] / [fdo#107807]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/shard-kbl4/igt@i915_pm_rpm@system-suspend.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/shard-kbl7/igt@i915_pm_rpm@system-suspend.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [FAIL][17] ([fdo#105767]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/shard-hsw2/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-hsw: [SKIP][19] ([fdo#109271]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/shard-hsw2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/shard-hsw4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
- shard-glk: [FAIL][21] ([fdo#104873]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/shard-glk1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [FAIL][23] ([fdo#103355]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/shard-hsw5/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/shard-hsw1/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt:
- shard-glk: [FAIL][25] ([fdo#103167]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-iclb: [FAIL][27] ([fdo#103167]) -> [PASS][28] +8 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [SKIP][29] ([fdo#109441]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6456/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_gtt.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* IGT: IGT_5093 -> IGTPW_3254
* Piglit: piglit_4509 -> None
CI_DRM_6456: 43aa8c3633274d7cf0a6dca4b8734d84d9928cf9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3254: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/
IGT_5093: 86dc48ede7c33bf69e15f84179d2f9e5b84c179b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3254/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-12 4:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-11 7:41 [igt-dev] [PATCH i-g-t] tests/kms_chamelium: remove unused drmModeGetResources Simon Ser
2019-07-11 13:34 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-07-11 13:49 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
2019-07-12 4:21 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.