* [PATCH] drm/i915: Don't overestimate 4:2:0 link symbol clock
@ 2019-07-10 12:58 Ville Syrjala
2019-07-11 7:53 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ville Syrjala @ 2019-07-10 12:58 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
With 4:2:0 output the LS clock can be half of what it is with 4:4:4.
Make that happen.
Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 0bdb7ecc5a81..1dfacf090fb8 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1853,8 +1853,10 @@ intel_dp_compute_link_config_wide(struct intel_dp *intel_dp,
int mode_rate, link_clock, link_avail;
for (bpp = limits->max_bpp; bpp >= limits->min_bpp; bpp -= 2 * 3) {
+ int output_bpp = intel_dp_output_bpp(pipe_config, bpp);
+
mode_rate = intel_dp_link_required(adjusted_mode->crtc_clock,
- bpp);
+ output_bpp);
for (clock = limits->min_clock; clock <= limits->max_clock; clock++) {
for (lane_count = limits->min_lane_count;
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Don't overestimate 4:2:0 link symbol clock 2019-07-10 12:58 [PATCH] drm/i915: Don't overestimate 4:2:0 link symbol clock Ville Syrjala @ 2019-07-11 7:53 ` Patchwork 2019-07-11 14:28 ` ✓ Fi.CI.IGT: " Patchwork 2019-07-11 16:49 ` [PATCH] " Mun, Gwan-gyeong 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2019-07-11 7:53 UTC (permalink / raw) To: Ville Syrjälä; +Cc: intel-gfx == Series Details == Series: drm/i915: Don't overestimate 4:2:0 link symbol clock URL : https://patchwork.freedesktop.org/series/63501/ State : success == Summary == CI Bug Log - changes from CI_DRM_6449 -> Patchwork_13600 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/ Known issues ------------ Here are the changes found in Patchwork_13600 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s3: - fi-blb-e6850: [PASS][1] -> [INCOMPLETE][2] ([fdo#107718]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [PASS][3] -> [FAIL][4] ([fdo#109485]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html - fi-kbl-7567u: [PASS][5] -> [FAIL][6] ([fdo#109485]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/fi-kbl-7567u/igt@kms_chamelium@hdmi-hpd-fast.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/fi-kbl-7567u/igt@kms_chamelium@hdmi-hpd-fast.html * igt@kms_frontbuffer_tracking@basic: - fi-icl-u2: [PASS][7] -> [FAIL][8] ([fdo#103167]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html * igt@prime_self_import@basic-with_one_bo_two_files: - fi-icl-u3: [PASS][9] -> [DMESG-WARN][10] ([fdo#107724]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/fi-icl-u3/igt@prime_self_import@basic-with_one_bo_two_files.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/fi-icl-u3/igt@prime_self_import@basic-with_one_bo_two_files.html #### Possible fixes #### * igt@i915_selftest@live_sanitycheck: - fi-icl-u3: [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12] +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/fi-icl-u3/igt@i915_selftest@live_sanitycheck.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/fi-icl-u3/igt@i915_selftest@live_sanitycheck.html * igt@kms_chamelium@hdmi-edid-read: - {fi-icl-u4}: [FAIL][13] ([fdo#111045] / [fdo#111046 ]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/fi-icl-u4/igt@kms_chamelium@hdmi-edid-read.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/fi-icl-u4/igt@kms_chamelium@hdmi-edid-read.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485 [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045 [fdo#111046 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111046 Participating hosts (53 -> 47) ------------------------------ Missing (6): fi-kbl-soraka fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus Build changes ------------- * Linux: CI_DRM_6449 -> Patchwork_13600 CI_DRM_6449: 4551186d429beb8c04df695e4fae07b2a79f7d47 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5092: 2a66ae6626d5583240509f84117d1345a799b75a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_13600: df1a304f96bf88486d841d21d9eb4bc340ef17be @ git://anongit.freedesktop.org/gfx-ci/linux == Kernel 32bit build == Warning: Kernel 32bit buildtest failed: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/build_32bit.log CALL scripts/checksyscalls.sh CALL scripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: arch/x86/boot/bzImage is ready (#1) Building modules, stage 2. MODPOST 112 modules ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: "__divdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Makefile:1287: recipe for target 'modules' failed make: *** [modules] Error 2 == Linux commits == df1a304f96bf drm/i915: Don't overestimate 4:2:0 link symbol clock == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Don't overestimate 4:2:0 link symbol clock 2019-07-10 12:58 [PATCH] drm/i915: Don't overestimate 4:2:0 link symbol clock Ville Syrjala 2019-07-11 7:53 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2019-07-11 14:28 ` Patchwork 2019-07-11 16:49 ` [PATCH] " Mun, Gwan-gyeong 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2019-07-11 14:28 UTC (permalink / raw) To: Ville Syrjälä; +Cc: intel-gfx == Series Details == Series: drm/i915: Don't overestimate 4:2:0 link symbol clock URL : https://patchwork.freedesktop.org/series/63501/ State : success == Summary == CI Bug Log - changes from CI_DRM_6449_full -> Patchwork_13600_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_13600_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_workarounds@suspend-resume: - shard-iclb: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-iclb3/igt@gem_workarounds@suspend-resume.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-iclb7/igt@gem_workarounds@suspend-resume.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-apl8/igt@i915_suspend@fence-restore-tiled2untiled.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: - shard-glk: [PASS][5] -> [FAIL][6] ([fdo#105363]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-skl: [PASS][7] -> [FAIL][8] ([fdo#105363]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@plain-flip-ts-check: - shard-skl: [PASS][9] -> [FAIL][10] ([fdo#100368]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-skl7/igt@kms_flip@plain-flip-ts-check.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-skl9/igt@kms_flip@plain-flip-ts-check.html * igt@kms_flip_tiling@flip-changes-tiling-yf: - shard-skl: [PASS][11] -> [FAIL][12] ([fdo#108228] / [fdo#108303]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-skl1/igt@kms_flip_tiling@flip-changes-tiling-yf.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-skl4/igt@kms_flip_tiling@flip-changes-tiling-yf.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt: - shard-iclb: [PASS][13] -> [FAIL][14] ([fdo#103167]) +5 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([fdo#108566]) +3 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_psr@psr2_primary_mmap_gtt: - shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html * igt@kms_setmode@basic: - shard-apl: [PASS][19] -> [FAIL][20] ([fdo#99912]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-apl1/igt@kms_setmode@basic.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-apl2/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-b-ts-continuation-suspend: - shard-skl: [PASS][21] -> [INCOMPLETE][22] ([fdo#104108]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-skl3/igt@kms_vblank@pipe-b-ts-continuation-suspend.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-skl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html * igt@perf_pmu@rc6: - shard-kbl: [PASS][23] -> [SKIP][24] ([fdo#109271]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-kbl4/igt@perf_pmu@rc6.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-kbl2/igt@perf_pmu@rc6.html #### Possible fixes #### * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: [DMESG-WARN][25] ([fdo#108566]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_flip@flip-vs-suspend: - shard-hsw: [INCOMPLETE][27] ([fdo#103540]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-hsw4/igt@kms_flip@flip-vs-suspend.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-hsw8/igt@kms_flip@flip-vs-suspend.html - shard-iclb: [INCOMPLETE][29] ([fdo#107713] / [fdo#109507]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-iclb3/igt@kms_flip@flip-vs-suspend.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-iclb1/igt@kms_flip@flip-vs-suspend.html * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite: - shard-iclb: [FAIL][31] ([fdo#103167]) -> [PASS][32] +3 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-apl: [DMESG-WARN][33] ([fdo#108566]) -> [PASS][34] +8 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-apl1/igt@kms_frontbuffer_tracking@fbc-suspend.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-apl4/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_pipe_crc_basic@hang-read-crc-pipe-a: - shard-snb: [SKIP][35] ([fdo#109271]) -> [PASS][36] +1 similar issue [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-snb4/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-snb7/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [FAIL][37] ([fdo#108145] / [fdo#110403]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [SKIP][39] ([fdo#109441]) -> [PASS][40] +1 similar issue [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-iclb1/igt@kms_psr@psr2_cursor_render.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-iclb2/igt@kms_psr@psr2_cursor_render.html * igt@perf@polling: - shard-skl: [FAIL][41] ([fdo#110728]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-skl6/igt@perf@polling.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-skl8/igt@perf@polling.html * igt@tools_test@tools_test: - shard-apl: [SKIP][43] ([fdo#109271]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-apl1/igt@tools_test@tools_test.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-apl4/igt@tools_test@tools_test.html #### Warnings #### * igt@kms_flip@flip-vs-suspend: - shard-kbl: [INCOMPLETE][45] ([fdo#103665]) -> [DMESG-WARN][46] ([fdo#108566]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6449/shard-kbl7/igt@kms_flip@flip-vs-suspend.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/shard-kbl3/igt@kms_flip@flip-vs-suspend.html [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108228]: https://bugs.freedesktop.org/show_bug.cgi?id=108228 [fdo#108303]: https://bugs.freedesktop.org/show_bug.cgi?id=108303 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507 [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 [fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_6449 -> Patchwork_13600 CI_DRM_6449: 4551186d429beb8c04df695e4fae07b2a79f7d47 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5092: 2a66ae6626d5583240509f84117d1345a799b75a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_13600: df1a304f96bf88486d841d21d9eb4bc340ef17be @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13600/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Don't overestimate 4:2:0 link symbol clock 2019-07-10 12:58 [PATCH] drm/i915: Don't overestimate 4:2:0 link symbol clock Ville Syrjala 2019-07-11 7:53 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-07-11 14:28 ` ✓ Fi.CI.IGT: " Patchwork @ 2019-07-11 16:49 ` Mun, Gwan-gyeong 2019-07-11 19:56 ` Ville Syrjälä 2 siblings, 1 reply; 5+ messages in thread From: Mun, Gwan-gyeong @ 2019-07-11 16:49 UTC (permalink / raw) To: ville.syrjala, intel-gfx On Wed, 2019-07-10 at 15:58 +0300, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > With 4:2:0 output the LS clock can be half of what it is with 4:4:4. > Make that happen. > > Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > b/drivers/gpu/drm/i915/display/intel_dp.c > index 0bdb7ecc5a81..1dfacf090fb8 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -1853,8 +1853,10 @@ intel_dp_compute_link_config_wide(struct > intel_dp *intel_dp, > int mode_rate, link_clock, link_avail; > > for (bpp = limits->max_bpp; bpp >= limits->min_bpp; bpp -= 2 * > 3) { > + int output_bpp = intel_dp_output_bpp(pipe_config, bpp); > + > mode_rate = intel_dp_link_required(adjusted_mode- > >crtc_clock, > - bpp); > + output_bpp); > > for (clock = limits->min_clock; clock <= limits- > >max_clock; clock++) { > for (lane_count = limits->min_lane_count; According to DP 1.4 spec section 1.7.1 [Makeup of the Main-Link], previous implementation worked by below explaination. After the stream data is packed and mapped to the Main-Link, the packed stream data rate shall be less than or equal to the Main-Link’s link symbol rate. When the packed stream data rate is less than the Main- Link’s link symbol rate, stuffing symbols are inserted. Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> Tested-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Don't overestimate 4:2:0 link symbol clock 2019-07-11 16:49 ` [PATCH] " Mun, Gwan-gyeong @ 2019-07-11 19:56 ` Ville Syrjälä 0 siblings, 0 replies; 5+ messages in thread From: Ville Syrjälä @ 2019-07-11 19:56 UTC (permalink / raw) To: Mun, Gwan-gyeong; +Cc: intel-gfx On Thu, Jul 11, 2019 at 04:49:06PM +0000, Mun, Gwan-gyeong wrote: > On Wed, 2019-07-10 at 15:58 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > With 4:2:0 output the LS clock can be half of what it is with 4:4:4. > > Make that happen. > > > > Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_dp.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > > b/drivers/gpu/drm/i915/display/intel_dp.c > > index 0bdb7ecc5a81..1dfacf090fb8 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > > @@ -1853,8 +1853,10 @@ intel_dp_compute_link_config_wide(struct > > intel_dp *intel_dp, > > int mode_rate, link_clock, link_avail; > > > > for (bpp = limits->max_bpp; bpp >= limits->min_bpp; bpp -= 2 * > > 3) { > > + int output_bpp = intel_dp_output_bpp(pipe_config, bpp); > > + > > mode_rate = intel_dp_link_required(adjusted_mode- > > >crtc_clock, > > - bpp); > > + output_bpp); > > > > for (clock = limits->min_clock; clock <= limits- > > >max_clock; clock++) { > > for (lane_count = limits->min_lane_count; > According to DP 1.4 spec section 1.7.1 [Makeup of the Main-Link], > previous implementation worked by below explaination. > After the stream data is packed and mapped to the Main-Link, the packed > stream data rate shall be less than or equal to the Main-Link’s link > symbol rate. When the packed stream data rate is less than the Main- > Link’s link symbol rate, stuffing symbols are inserted. > > Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> > Tested-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> Nice. Thanks for double checking. Pushed to dinq. -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-11 19:56 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-07-10 12:58 [PATCH] drm/i915: Don't overestimate 4:2:0 link symbol clock Ville Syrjala 2019-07-11 7:53 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-07-11 14:28 ` ✓ Fi.CI.IGT: " Patchwork 2019-07-11 16:49 ` [PATCH] " Mun, Gwan-gyeong 2019-07-11 19:56 ` Ville Syrjälä
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.