[PATCH] configure: disable arm movw/movt relocations for GCC

[PATCH] configure: disable arm movw/movt relocations for GCC

[Leif Lindholm]

When building for arm, we already disable movw/movt relocations for clang,
since they are incompatible with PE.

When building with bare metal GCC toolchains (like the one used in the
travis ci scripts), we end up with these relocations again. So add an
additional test for the '-mword-relocations' flag used by GCC.

Reported-by: Alexander Graf <agraf@csgraf.de>
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---

Note: unless this is added before the travis-ci set, the arm ci build
will fail when enabled.

---

 configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 08b518fcc..e7725a546 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1198,7 +1198,8 @@ if test "x$target_cpu" = xarm; then
   AC_CACHE_CHECK([for options to disable movt and movw], grub_cv_target_cc_mno_movt, [
     grub_cv_target_cc_mno_movt=no
     for cand in "-mno-movt" \
-		"-mllvm -arm-use-movt=0"; do
+		"-mllvm -arm-use-movt=0" \
+		"-mword-relocations"; do
       if test x"$grub_cv_target_cc_mno_movt" != xno ; then
         break
       fi
-- 
2.11.0

Re: [PATCH] configure: disable arm movw/movt relocations for GCC

[Alexander Graf]

On 04.06.19 13:39, Leif Lindholm wrote:
> When building for arm, we already disable movw/movt relocations for clang,
> since they are incompatible with PE.
>
> When building with bare metal GCC toolchains (like the one used in the
> travis ci scripts), we end up with these relocations again. So add an
> additional test for the '-mword-relocations' flag used by GCC.
>
> Reported-by: Alexander Graf <agraf@csgraf.de>
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>


Reviewed-by: Alexander Graf <agraf@csgraf.de>


Alex

Re: [PATCH] configure: disable arm movw/movt relocations for GCC

[Daniel Kiper]

On Tue, Jun 04, 2019 at 01:49:51PM +0200, Alexander Graf wrote:
> On 04.06.19 13:39, Leif Lindholm wrote:
> > When building for arm, we already disable movw/movt relocations for clang,
> > since they are incompatible with PE.
> >
> > When building with bare metal GCC toolchains (like the one used in the
> > travis ci scripts), we end up with these relocations again. So add an
> > additional test for the '-mword-relocations' flag used by GCC.
> >
> > Reported-by: Alexander Graf <agraf@csgraf.de>
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> Reviewed-by: Alexander Graf <agraf@csgraf.de>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel

Re: [PATCH] configure: disable arm movw/movt relocations for GCC

[Vladimir 'phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1448 bytes --]

LGTM

On Tue, 4 Jun 2019, 13:40 Leif Lindholm, <leif.lindholm@linaro.org> wrote:

> When building for arm, we already disable movw/movt relocations for clang,
> since they are incompatible with PE.
>
> When building with bare metal GCC toolchains (like the one used in the
> travis ci scripts), we end up with these relocations again. So add an
> additional test for the '-mword-relocations' flag used by GCC.
>
> Reported-by: Alexander Graf <agraf@csgraf.de>
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>
> Note: unless this is added before the travis-ci set, the arm ci build
> will fail when enabled.
>
> ---
>
>  configure.ac | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 08b518fcc..e7725a546 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1198,7 +1198,8 @@ if test "x$target_cpu" = xarm; then
>    AC_CACHE_CHECK([for options to disable movt and movw],
> grub_cv_target_cc_mno_movt, [
>      grub_cv_target_cc_mno_movt=no
>      for cand in "-mno-movt" \
> -               "-mllvm -arm-use-movt=0"; do
> +               "-mllvm -arm-use-movt=0" \
> +               "-mword-relocations"; do
>        if test x"$grub_cv_target_cc_mno_movt" != xno ; then
>          break
>        fi
> --
> 2.11.0
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

[-- Attachment #2: Type: text/html, Size: 2689 bytes --]