From: Olivier Matz <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] devtools: better freebsd support
Date: Thu, 11 Jul 2019 15:06:12 +0200 [thread overview]
Message-ID: <20190711130612.xwm2znqdgxoqr4md@glumotte.dev.6wind.com> (raw)
In-Reply-To: <12936694.jvCGMiB3o0@xps>
On Mon, Jul 08, 2019 at 06:35:25PM +0200, Thomas Monjalon wrote:
> 05/07/2019 15:58, Olivier Matz:
> > - As "readlink -e" and "readlink -m" do not exist on freebsd,
> > use "readlink -f", it should not have any impact in these cases.
> > - "sed -ri" is invalid on freebsd and should be replaced by
> > "sed -ri=''"
> > - Use gmake instead of make.
> >
> > This fixes the following command:
> > SYSDIR=/usr/src/sys ./devtools/test-build.sh \
> > -j4 x86_64-native-freebsd-gcc
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > ---
> > --- a/devtools/test-build.sh
> > +++ b/devtools/test-build.sh
> > +[ -z $MAKE ] && command -v gmake > /dev/null && MAKE=gmake
> > +[ -z $MAKE ] && command -v make > /dev/null && MAKE=make
> > +[ -z $MAKE ] && echo "Cannot find make or gmake" && exit 1
>
> I'm surprised it works, given the -e in this script.
> I would be more confortable with "if/elif" constructs.
Honnestly, I'm surprised too :)
This is the expected. Quoting "man sh":
-e errexit
If not interactive, exit immediately if any untested command fails. The
exit status of a command is considered to be explicitly tested if the
command is used to control an if, elif, while, or until; or if the
command is the left hand operand of an "&&" or "||" operator.
next prev parent reply other threads:[~2019-07-11 13:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 7:43 [dpdk-dev] [PATCH] devtools: better freebsd support Olivier Matz
2019-05-23 10:47 ` Bruce Richardson
2019-05-23 10:58 ` David Marchand
2019-07-05 13:58 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2019-07-08 16:35 ` Thomas Monjalon
2019-07-11 13:06 ` Olivier Matz [this message]
2019-07-09 11:05 ` Musatescu, Flavia
2019-07-11 14:18 ` Olivier Matz
2019-07-11 14:25 ` [dpdk-dev] [PATCH v3] " Olivier Matz
2019-07-29 8:31 ` David Marchand
2019-07-29 8:36 ` David Marchand
2019-07-30 22:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711130612.xwm2znqdgxoqr4md@glumotte.dev.6wind.com \
--to=olivier.matz@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.