From: "Michael S. Tsirkin" <mst@redhat.com> To: Pankaj Gupta <pagupta@redhat.com> Cc: linux-nvdimm@lists.01.org, cohuck@redhat.com, linux-kernel@vger.kernel.org, yuval.shaia@oracle.com, virtualization@lists.linux-foundation.org, lcapitulino@redhat.com Subject: Re: [PATCH v2] virtio_pmem: fix sparse warning Date: Thu, 11 Jul 2019 13:47:08 -0400 [thread overview] Message-ID: <20190711134648-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <20190710175832.17252-1-pagupta@redhat.com> On Wed, Jul 10, 2019 at 11:28:32PM +0530, Pankaj Gupta wrote: > This patch fixes below sparse warning related to __virtio > type in virtio pmem driver. This is reported by Intel test > bot on linux-next tree. > > nd_virtio.c:56:28: warning: incorrect type in assignment > (different base types) > nd_virtio.c:56:28: expected unsigned int [unsigned] [usertype] type > nd_virtio.c:56:28: got restricted __virtio32 > nd_virtio.c:93:59: warning: incorrect type in argument 2 > (different base types) > nd_virtio.c:93:59: expected restricted __virtio32 [usertype] val > nd_virtio.c:93:59: got unsigned int [unsigned] [usertype] ret > > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Pankaj Gupta <pagupta@redhat.com> > --- > > This fixes a warning, so submitting it as a separate > patch on top of virtio pmem series. > > include/uapi/linux/virtio_pmem.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/uapi/linux/virtio_pmem.h b/include/uapi/linux/virtio_pmem.h > index efcd72f2d20d..7a7435281362 100644 > --- a/include/uapi/linux/virtio_pmem.h > +++ b/include/uapi/linux/virtio_pmem.h > @@ -10,7 +10,7 @@ > #ifndef _UAPI_LINUX_VIRTIO_PMEM_H > #define _UAPI_LINUX_VIRTIO_PMEM_H > > -#include <linux/types.h> > +#include <linux/virtio_types.h> > #include <linux/virtio_ids.h> > #include <linux/virtio_config.h> > > @@ -23,12 +23,12 @@ struct virtio_pmem_config { > > struct virtio_pmem_resp { > /* Host return status corresponding to flush request */ > - __u32 ret; > + __virtio32 ret; > }; > > struct virtio_pmem_req { > /* command type */ > - __u32 type; > + __virtio32 type; > }; > > #endif Same comment as previously: pls use __le and fix accessors. > -- > 2.20.1 _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: Pankaj Gupta <pagupta@redhat.com> Cc: virtualization@lists.linux-foundation.org, dan.j.williams@intel.com, yuval.shaia@oracle.com, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, cohuck@redhat.com, lcapitulino@redhat.com Subject: Re: [PATCH v2] virtio_pmem: fix sparse warning Date: Thu, 11 Jul 2019 13:47:08 -0400 [thread overview] Message-ID: <20190711134648-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <20190710175832.17252-1-pagupta@redhat.com> On Wed, Jul 10, 2019 at 11:28:32PM +0530, Pankaj Gupta wrote: > This patch fixes below sparse warning related to __virtio > type in virtio pmem driver. This is reported by Intel test > bot on linux-next tree. > > nd_virtio.c:56:28: warning: incorrect type in assignment > (different base types) > nd_virtio.c:56:28: expected unsigned int [unsigned] [usertype] type > nd_virtio.c:56:28: got restricted __virtio32 > nd_virtio.c:93:59: warning: incorrect type in argument 2 > (different base types) > nd_virtio.c:93:59: expected restricted __virtio32 [usertype] val > nd_virtio.c:93:59: got unsigned int [unsigned] [usertype] ret > > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Pankaj Gupta <pagupta@redhat.com> > --- > > This fixes a warning, so submitting it as a separate > patch on top of virtio pmem series. > > include/uapi/linux/virtio_pmem.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/uapi/linux/virtio_pmem.h b/include/uapi/linux/virtio_pmem.h > index efcd72f2d20d..7a7435281362 100644 > --- a/include/uapi/linux/virtio_pmem.h > +++ b/include/uapi/linux/virtio_pmem.h > @@ -10,7 +10,7 @@ > #ifndef _UAPI_LINUX_VIRTIO_PMEM_H > #define _UAPI_LINUX_VIRTIO_PMEM_H > > -#include <linux/types.h> > +#include <linux/virtio_types.h> > #include <linux/virtio_ids.h> > #include <linux/virtio_config.h> > > @@ -23,12 +23,12 @@ struct virtio_pmem_config { > > struct virtio_pmem_resp { > /* Host return status corresponding to flush request */ > - __u32 ret; > + __virtio32 ret; > }; > > struct virtio_pmem_req { > /* command type */ > - __u32 type; > + __virtio32 type; > }; > > #endif Same comment as previously: pls use __le and fix accessors. > -- > 2.20.1
next prev parent reply other threads:[~2019-07-11 17:49 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-10 17:58 [PATCH v2] virtio_pmem: fix sparse warning Pankaj Gupta 2019-07-10 17:58 ` Pankaj Gupta 2019-07-11 17:47 ` Michael S. Tsirkin [this message] 2019-07-11 17:47 ` Michael S. Tsirkin 2019-07-11 18:46 ` Pankaj Gupta 2019-07-11 18:46 ` Pankaj Gupta 2019-07-11 18:46 ` Pankaj Gupta 2019-07-11 17:47 ` Michael S. Tsirkin -- strict thread matches above, loose matches on Subject: below -- 2019-07-10 17:58 Pankaj Gupta
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190711134648-mutt-send-email-mst@kernel.org \ --to=mst@redhat.com \ --cc=cohuck@redhat.com \ --cc=lcapitulino@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=pagupta@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=yuval.shaia@oracle.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.