* [PATCH] nvme: tcp: depends on CRYPTO_HASH2 for nvme-tcp
@ 2019-07-11 15:13 Minwoo Im
2019-07-11 16:05 ` Sagi Grimberg
0 siblings, 1 reply; 3+ messages in thread
From: Minwoo Im @ 2019-07-11 15:13 UTC (permalink / raw)
The tcp host module is now taking those APIs from crypto ahash:
(1) crypto_ahash_final()
(2) crypto_ahash_digest()
(3) crypto_alloc_ahash()
nvme-tcp should depends on CRYPTO_HASH2.
Cc: Christoph Hellwig <hch at lst.de>
Cc: Keith Busch <kbusch at kernel.org>
Cc: Sagi Grimberg <sagi at grimberg.me>
Cc: Jens Axboe <axboe at fb.com>
Signed-off-by: Minwoo Im <minwoo.im.dev at gmail.com>
---
drivers/nvme/host/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
index ec43ac9199e2..711d3ea5143f 100644
--- a/drivers/nvme/host/Kconfig
+++ b/drivers/nvme/host/Kconfig
@@ -63,6 +63,7 @@ config NVME_TCP
tristate "NVM Express over Fabrics TCP host driver"
depends on INET
depends on BLK_DEV_NVME
+ depends on CRYPTO_HASH2
select NVME_FABRICS
help
This provides support for the NVMe over Fabrics protocol using
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] nvme: tcp: depends on CRYPTO_HASH2 for nvme-tcp
2019-07-11 15:13 [PATCH] nvme: tcp: depends on CRYPTO_HASH2 for nvme-tcp Minwoo Im
@ 2019-07-11 16:05 ` Sagi Grimberg
2019-07-11 17:08 ` Minwoo Im
0 siblings, 1 reply; 3+ messages in thread
From: Sagi Grimberg @ 2019-07-11 16:05 UTC (permalink / raw)
Hi Minwoo,
> The tcp host module is now taking those APIs from crypto ahash:
> (1) crypto_ahash_final()
> (2) crypto_ahash_digest()
> (3) crypto_alloc_ahash()
>
> nvme-tcp should depends on CRYPTO_HASH2.
It actually should depend on CRYPTO_CRC32C because
it needs CRC32C.
>
> Cc: Christoph Hellwig <hch at lst.de>
> Cc: Keith Busch <kbusch at kernel.org>
> Cc: Sagi Grimberg <sagi at grimberg.me>
> Cc: Jens Axboe <axboe at fb.com>
> Signed-off-by: Minwoo Im <minwoo.im.dev at gmail.com>
> ---
> drivers/nvme/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
> index ec43ac9199e2..711d3ea5143f 100644
> --- a/drivers/nvme/host/Kconfig
> +++ b/drivers/nvme/host/Kconfig
> @@ -63,6 +63,7 @@ config NVME_TCP
> tristate "NVM Express over Fabrics TCP host driver"
> depends on INET
> depends on BLK_DEV_NVME
> + depends on CRYPTO_HASH2
Lets make it select instead.
> select NVME_FABRICS
> help
> This provides support for the NVMe over Fabrics protocol using
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] nvme: tcp: depends on CRYPTO_HASH2 for nvme-tcp
2019-07-11 16:05 ` Sagi Grimberg
@ 2019-07-11 17:08 ` Minwoo Im
0 siblings, 0 replies; 3+ messages in thread
From: Minwoo Im @ 2019-07-11 17:08 UTC (permalink / raw)
Hi Sagi,
Thanks for your review on this.
On 19-07-11 09:05:28, Sagi Grimberg wrote:
> Hi Minwoo,
>
> > The tcp host module is now taking those APIs from crypto ahash:
> > (1) crypto_ahash_final()
> > (2) crypto_ahash_digest()
> > (3) crypto_alloc_ahash()
> >
> > nvme-tcp should depends on CRYPTO_HASH2.
>
> It actually should depend on CRYPTO_CRC32C because
> it needs CRC32C.
Okay. That looks right for this commit's goal..
> >
> > Cc: Christoph Hellwig <hch at lst.de>
> > Cc: Keith Busch <kbusch at kernel.org>
> > Cc: Sagi Grimberg <sagi at grimberg.me>
> > Cc: Jens Axboe <axboe at fb.com>
> > Signed-off-by: Minwoo Im <minwoo.im.dev at gmail.com>
> > ---
> > drivers/nvme/host/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
> > index ec43ac9199e2..711d3ea5143f 100644
> > --- a/drivers/nvme/host/Kconfig
> > +++ b/drivers/nvme/host/Kconfig
> > @@ -63,6 +63,7 @@ config NVME_TCP
> > tristate "NVM Express over Fabrics TCP host driver"
> > depends on INET
> > depends on BLK_DEV_NVME
> > + depends on CRYPTO_HASH2
>
> Lets make it select instead.
Oh, That would be much easier to use them. Will prepare updated patch
soon.
Thanks,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-11 17:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-11 15:13 [PATCH] nvme: tcp: depends on CRYPTO_HASH2 for nvme-tcp Minwoo Im
2019-07-11 16:05 ` Sagi Grimberg
2019-07-11 17:08 ` Minwoo Im
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.