* [Qemu-devel] [PATCH] xio3130_downstream: typo fix
@ 2019-07-11 19:25 Michael S. Tsirkin
2019-07-12 7:55 ` Marcel Apfelbaum
2019-07-12 17:10 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2019-07-11 19:25 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell
slt ctl/status are passed in incorrect order.
Fix this up.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reported-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/pci-bridge/xio3130_downstream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci-bridge/xio3130_downstream.c b/hw/pci-bridge/xio3130_downstream.c
index 899b0fd6c9..182e164f74 100644
--- a/hw/pci-bridge/xio3130_downstream.c
+++ b/hw/pci-bridge/xio3130_downstream.c
@@ -43,7 +43,7 @@ static void xio3130_downstream_write_config(PCIDevice *d, uint32_t address,
{
uint16_t slt_ctl, slt_sta;
- pcie_cap_slot_get(d, &slt_sta, &slt_ctl);
+ pcie_cap_slot_get(d, &slt_ctl, &slt_sta);
pci_bridge_write_config(d, address, val, len);
pcie_cap_flr_write_config(d, address, val, len);
pcie_cap_slot_write_config(d, slt_ctl, slt_sta, address, val, len);
--
MST
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] xio3130_downstream: typo fix
2019-07-11 19:25 [Qemu-devel] [PATCH] xio3130_downstream: typo fix Michael S. Tsirkin
@ 2019-07-12 7:55 ` Marcel Apfelbaum
2019-07-12 17:10 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Apfelbaum @ 2019-07-12 7:55 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: Peter Maydell
On 7/11/19 10:25 PM, Michael S. Tsirkin wrote:
> slt ctl/status are passed in incorrect order.
> Fix this up.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/pci-bridge/xio3130_downstream.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci-bridge/xio3130_downstream.c b/hw/pci-bridge/xio3130_downstream.c
> index 899b0fd6c9..182e164f74 100644
> --- a/hw/pci-bridge/xio3130_downstream.c
> +++ b/hw/pci-bridge/xio3130_downstream.c
> @@ -43,7 +43,7 @@ static void xio3130_downstream_write_config(PCIDevice *d, uint32_t address,
> {
> uint16_t slt_ctl, slt_sta;
>
> - pcie_cap_slot_get(d, &slt_sta, &slt_ctl);
> + pcie_cap_slot_get(d, &slt_ctl, &slt_sta);
> pci_bridge_write_config(d, address, val, len);
> pcie_cap_flr_write_config(d, address, val, len);
> pcie_cap_slot_write_config(d, slt_ctl, slt_sta, address, val, len);
Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Thanks,
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] xio3130_downstream: typo fix
2019-07-11 19:25 [Qemu-devel] [PATCH] xio3130_downstream: typo fix Michael S. Tsirkin
2019-07-12 7:55 ` Marcel Apfelbaum
@ 2019-07-12 17:10 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-07-12 17:10 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: Peter Maydell
On 7/11/19 9:25 PM, Michael S. Tsirkin wrote:
> slt ctl/status are passed in incorrect order.
> Fix this up.
>
Fixes: Coverity (CID 1403007)
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/pci-bridge/xio3130_downstream.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci-bridge/xio3130_downstream.c b/hw/pci-bridge/xio3130_downstream.c
> index 899b0fd6c9..182e164f74 100644
> --- a/hw/pci-bridge/xio3130_downstream.c
> +++ b/hw/pci-bridge/xio3130_downstream.c
> @@ -43,7 +43,7 @@ static void xio3130_downstream_write_config(PCIDevice *d, uint32_t address,
> {
> uint16_t slt_ctl, slt_sta;
>
> - pcie_cap_slot_get(d, &slt_sta, &slt_ctl);
> + pcie_cap_slot_get(d, &slt_ctl, &slt_sta);
> pci_bridge_write_config(d, address, val, len);
> pcie_cap_flr_write_config(d, address, val, len);
> pcie_cap_slot_write_config(d, slt_ctl, slt_sta, address, val, len);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-12 17:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-11 19:25 [Qemu-devel] [PATCH] xio3130_downstream: typo fix Michael S. Tsirkin
2019-07-12 7:55 ` Marcel Apfelbaum
2019-07-12 17:10 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.