From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Hook, Gary" <Gary.Hook@amd.com>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"Lendacky, Thomas" <Thomas.Lendacky@amd.com>
Subject: Re: [PATCH v2] crypto: ccp - memset structure fields to zero before reuse
Date: Fri, 12 Jul 2019 18:18:03 +0800 [thread overview]
Message-ID: <20190712101803.7fhefacu6l33eu4u@gondor.apana.org.au> (raw)
In-Reply-To: <20190710000849.3131-1-gary.hook@amd.com>
On Wed, Jul 10, 2019 at 12:09:22AM +0000, Hook, Gary wrote:
> The AES GCM function reuses an 'op' data structure, which members
> contain values that must be cleared for each (re)use.
>
> This fix resolves a crypto self-test failure:
> alg: aead: gcm-aes-ccp encryption test failed (wrong result) on test vector 2, cfg="two even aligned splits"
>
> Fixes: 36cf515b9bbe ("crypto: ccp - Enable support for AES GCM on v5 CCPs")
>
> Signed-off-by: Gary R Hook <gary.hook@amd.com>
> ---
>
> Changes since v1:
> - Explain in the commit message that this fix resolves a failed test
>
> drivers/crypto/ccp/ccp-ops.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-07-12 10:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 0:09 [PATCH v2] crypto: ccp - memset structure fields to zero before reuse Hook, Gary
2019-07-10 1:57 ` Eric Biggers
2019-07-10 15:59 ` Gary R Hook
2019-07-10 20:34 ` Eric Biggers
2019-07-10 22:50 ` Gary R Hook
2019-07-11 0:46 ` Eric Biggers
2019-07-11 15:25 ` Gary R Hook
2019-07-12 2:20 ` Herbert Xu
2019-07-12 10:18 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712101803.7fhefacu6l33eu4u@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Gary.Hook@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.