[Buildroot] [PATCH 1/2] package/vte: needs host-intltool

[Buildroot] [PATCH 1/2] package/vte: needs host-intltool

[Fabrice Fontaine]

Fixes:
 - http://autobuild.buildroot.org/results/30a8032ebba5a30bacd321c407a1d0734fadf757

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/vte/vte.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/vte/vte.mk b/package/vte/vte.mk
index 90853cb4a5..7332a1ae04 100644
--- a/package/vte/vte.mk
+++ b/package/vte/vte.mk
@@ -7,7 +7,7 @@
 VTE_VERSION = 0.48.3
 VTE_SOURCE = vte-$(VTE_VERSION).tar.xz
 VTE_SITE = http://ftp.gnome.org/pub/gnome/sources/vte/0.48
-VTE_DEPENDENCIES = host-pkgconf libgtk3 libxml2 pcre2
+VTE_DEPENDENCIES = host-intltool host-pkgconf libgtk3 libxml2 pcre2
 VTE_LICENSE = LGPL-2.1+
 VTE_LICENSE_FILES = COPYING
 VTE_CONF_OPTS += --disable-introspection --without-gnutls --disable-vala
-- 
2.20.1

[Buildroot] [PATCH 2/2] package/vte: add gnutls optional dependency

[Fabrice Fontaine]

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/vte/vte.mk | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/package/vte/vte.mk b/package/vte/vte.mk
index 7332a1ae04..0d5db34b62 100644
--- a/package/vte/vte.mk
+++ b/package/vte/vte.mk
@@ -10,6 +10,13 @@ VTE_SITE = http://ftp.gnome.org/pub/gnome/sources/vte/0.48
 VTE_DEPENDENCIES = host-intltool host-pkgconf libgtk3 libxml2 pcre2
 VTE_LICENSE = LGPL-2.1+
 VTE_LICENSE_FILES = COPYING
-VTE_CONF_OPTS += --disable-introspection --without-gnutls --disable-vala
+VTE_CONF_OPTS += --disable-introspection --disable-vala
+
+ifeq ($(BR2_PACKAGE_GNUTLS),y)
+VTE_CONF_OPTS += --with-gnutls
+VTE_DEPENDENCIES += gnutls
+else
+VTE_CONF_OPTS += --without-gnutls
+endif
 
 $(eval $(autotools-package))
-- 
2.20.1

[Buildroot] [PATCH 1/2] package/vte: needs host-intltool

[Thomas Petazzoni]

On Sat, 13 Jul 2019 10:32:55 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fixes:
>  - http://autobuild.buildroot.org/results/30a8032ebba5a30bacd321c407a1d0734fadf757
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

This vte package has not changed since it was introduced in January
2018. Why suddenly we have this error caused by the missing intltool ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 2/2] package/vte: add gnutls optional dependency

[Thomas Petazzoni]

On Sat, 13 Jul 2019 10:32:56 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/vte/vte.mk | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/2] package/vte: needs host-intltool

[Fabrice Fontaine]

Dear Thomas,

Le dim. 14 juil. 2019 ? 14:51, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> On Sat, 13 Jul 2019 10:32:55 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > Fixes:
> >  - http://autobuild.buildroot.org/results/30a8032ebba5a30bacd321c407a1d0734fadf757
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> This vte package has not changed since it was introduced in January
> 2018. Why suddenly we have this error caused by the missing intltool ?
This version of vte currently depends on intltool through
IT_PROG_INTLTOOL([0.35]) and it uses intltool-update to retrieve the
version.
However, on my build system and the one from the Xogium autobuilder,
intltool-update is not available which raise this build failure.
I don't know why we didn't get this error sooner, perhaps because
intltool was more widely installed on the different distributions or
because host-intltool was built due to another package?
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice

[Buildroot] [PATCH 1/2] package/vte: needs host-intltool

[Thomas Petazzoni]

On Sat, 13 Jul 2019 10:32:55 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fixes:
>  - http://autobuild.buildroot.org/results/30a8032ebba5a30bacd321c407a1d0734fadf757
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/vte/vte.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/2] package/vte: needs host-intltool

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fixes:
 >  - http://autobuild.buildroot.org/results/30a8032ebba5a30bacd321c407a1d0734fadf757

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2019.02.x and 2019.05.x, thanks.

-- 
Bye, Peter Korsgaard