Re: [PATCH] IIO: stm32: Remove quadrature related functions from trigger driver

From: Jonathan Cameron <jic23@kernel.org>
To: Benjamin GAIGNARD <benjamin.gaignard@st.com>
Cc: William Breathitt Gray <vilhelm.gray@gmail.com>,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Fabrice GASNIER <fabrice.gasnier@st.com>,
	"linux-stm32@st-md-mailman.stormreply.com" 
	<linux-stm32@st-md-mailman.stormreply.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] IIO: stm32: Remove quadrature related functions from trigger driver
Date: Sun, 14 Jul 2019 18:23:07 +0100	[thread overview]
Message-ID: <20190714182307.71df9b00@archlinux> (raw)
In-Reply-To: <08b3f84e-cee4-4fbe-031d-721aa9dc53d4@st.com>

On Sun, 14 Jul 2019 15:32:33 +0000
Benjamin GAIGNARD <benjamin.gaignard@st.com> wrote:

> On 7/14/19 12:09 PM, Jonathan Cameron wrote:
> > On Thu, 11 Jul 2019 21:16:20 +0900
> > William Breathitt Gray <vilhelm.gray@gmail.com> wrote:
> >  
> >> On Thu, Jul 11, 2019 at 02:12:27PM +0200, Benjamin Gaignard wrote:  
> >>> Le jeu. 11 juil. 2019 à 13:51, William Breathitt Gray
> >>> <vilhelm.gray@gmail.com> a écrit :  
> >>>> On Tue, May 07, 2019 at 11:12:24AM +0200, Benjamin Gaignard wrote:  
> >>>>> Quadrature feature is now hosted on it own framework.
> >>>>> Remove quadrature related code from stm32-trigger driver to avoid
> >>>>> code duplication and simplify the ABI.
> >>>>>
> >>>>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>  
> >>>> What is the status of this patch? Are there any objections currently for
> >>>> its inclusion?  
> >>> You were the only one asking for more details about it :-)
> >>> If you agree I think that Jonathan can merge it.
> >>>
> >>> Benjamin  
> >>>> William Breathitt Gray
> >>>>
> >>>> _______________________________________________
> >>>> linux-arm-kernel mailing list
> >>>> linux-arm-kernel@lists.infradead.org
> >>>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel  
> >> Yes, Jonathan please merge this if you have no objections, I hadn't
> >> realized I was delaying it.
> >>
> >> Thank you,
> >>
> >> William Breathitt Gray  
> > One last thing...  This seems to be a userspace ABI change.  What
> > are our potential issues with users of this ABI?
> >
> > It's not that costly to keep the code, though dropping the docs or
> > putting a depreciated note in them is probably a good idea.  Hence
> > I'm not totally convinced the risk of a regression is worth it.  
> 
> As far I know nobody use this interface yet for me there is no risk to 
> remove this code.
> 
> Benjamin
Hope you are right :)

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan

> 
> >
> > If we think it's the sort of change no one will notice, then
> > fair enough we'll give it a go and cross our fingers.
> >
> > Thanks,
> >
> > Jonathan
> >
>   