* [PATCH v3 02/24] atm: idt77252: Remove call to memset after dma_alloc_coherent
@ 2019-07-15 3:17 Fuqian Huang
2019-07-15 18:06 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Fuqian Huang @ 2019-07-15 3:17 UTC (permalink / raw)
Cc: Chas Williams, linux-atm-general, netdev, linux-kernel, Fuqian Huang
In commit 518a2f1925c3
("dma-mapping: zero memory returned from dma_alloc_*"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
Changes in v3:
- Use actual commit rather than the merge commit in the commit message
drivers/atm/idt77252.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
index 43a14579e80e..df51680e8931 100644
--- a/drivers/atm/idt77252.c
+++ b/drivers/atm/idt77252.c
@@ -1379,7 +1379,6 @@ init_tsq(struct idt77252_dev *card)
printk("%s: can't allocate TSQ.\n", card->name);
return -1;
}
- memset(card->tsq.base, 0, TSQSIZE);
card->tsq.last = card->tsq.base + TSQ_NUM_ENTRIES - 1;
card->tsq.next = card->tsq.last;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 02/24] atm: idt77252: Remove call to memset after dma_alloc_coherent
2019-07-15 3:17 [PATCH v3 02/24] atm: idt77252: Remove call to memset after dma_alloc_coherent Fuqian Huang
@ 2019-07-15 18:06 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-07-15 18:06 UTC (permalink / raw)
To: huangfq.daxian; +Cc: 3chas3, linux-atm-general, netdev, linux-kernel
From: Fuqian Huang <huangfq.daxian@gmail.com>
Date: Mon, 15 Jul 2019 11:17:09 +0800
> In commit 518a2f1925c3
> ("dma-mapping: zero memory returned from dma_alloc_*"),
> dma_alloc_coherent has already zeroed the memory.
> So memset is not needed.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-15 18:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-15 3:17 [PATCH v3 02/24] atm: idt77252: Remove call to memset after dma_alloc_coherent Fuqian Huang
2019-07-15 18:06 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.