[Qemu-devel] [PATCH 0/3] s390x/cpumodel fixes for 4.1

[Qemu-devel] [PATCH 0/3] s390x/cpumodel fixes for 4.1

[Christian Borntraeger]

Some fallout of the gen15 cpu model. As this is new in 4.1
it is still time to fixup some aspects.

Christian Borntraeger (3):
  s390x/cpumodel: remove esort from the default model
  s390x/cpumodel: also change name of vxbeh
  s390x/cpumodel: change internal name of vxp to make description

 target/s390x/cpu_features_def.inc.h | 2 +-
 target/s390x/gen-features.c         | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

-- 
2.21.0

[Qemu-devel] [PATCH 1/3] s390x/cpumodel: remove esort from the default model

[Christian Borntraeger]

esort might not be available on all models.

Fixes: caef62430fed6e73 ("s390x/cpumodel: add gen15 defintions")
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 target/s390x/gen-features.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
index 9f216219ff53..6debfc1d217e 100644
--- a/target/s390x/gen-features.c
+++ b/target/s390x/gen-features.c
@@ -642,7 +642,6 @@ static uint16_t default_GEN14_GA1[] = {
 
 static uint16_t default_GEN15_GA1[] = {
     S390_FEAT_VECTOR_ENH2,
-    S390_FEAT_GROUP_ENH_SORT,
     S390_FEAT_GROUP_DEFLATE_CONVERSION,
     S390_FEAT_VECTOR_BCD_ENH,
     S390_FEAT_GROUP_MSA_EXT_9,
-- 
2.21.0

[Qemu-devel] [PATCH 2/3] s390x/cpumodel: also change name of vxbeh

[Christian Borntraeger]

David suggested to keep everything in sync as 4.1 is not yet released.
This patch fixes the name "vxbeh" into "vxp".

To simplify the backports this patch will not change VECTOR_BCD_ENH as
this is just an internal name. That will be done by an extra patch that
does not need to be backported.

Suggested-by: David Hildenbrand <david@redhat.com>
Fixes: d05be57ddc2e ("s390: cpumodel: fix description for the new vector facility")
Fixes: 54d65de0b525 ("s390x/cpumodel: vector enhancements")
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 target/s390x/cpu_features_def.inc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/s390x/cpu_features_def.inc.h b/target/s390x/cpu_features_def.inc.h
index 3118a9f89228..99f58a89318a 100644
--- a/target/s390x/cpu_features_def.inc.h
+++ b/target/s390x/cpu_features_def.inc.h
@@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facil
 DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
 DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")
 DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")
-DEF_FEAT(VECTOR_BCD_ENH, "vxbeh", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
+DEF_FEAT(VECTOR_BCD_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
 DEF_FEAT(MSA_EXT_9, "msa9-base", STFL, 155, "Message-security-assist-extension-9 facility (excluding subfunctions)")
 DEF_FEAT(ETOKEN, "etoken", STFL, 156, "Etoken facility")
 
-- 
2.21.0

[Qemu-devel] [PATCH 3/3] s390x/cpumodel: change internal name of vxp to make description

[Christian Borntraeger]

The internal macro name VECTOR_BCD_ENH does not match the actual
description. Fix this.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 target/s390x/cpu_features_def.inc.h | 2 +-
 target/s390x/gen-features.c         | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/target/s390x/cpu_features_def.inc.h b/target/s390x/cpu_features_def.inc.h
index 99f58a89318a..f7c52bc17c2e 100644
--- a/target/s390x/cpu_features_def.inc.h
+++ b/target/s390x/cpu_features_def.inc.h
@@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facil
 DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
 DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")
 DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")
-DEF_FEAT(VECTOR_BCD_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
+DEF_FEAT(VECTOR_PACKED_DECIMAL_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
 DEF_FEAT(MSA_EXT_9, "msa9-base", STFL, 155, "Message-security-assist-extension-9 facility (excluding subfunctions)")
 DEF_FEAT(ETOKEN, "etoken", STFL, 156, "Etoken facility")
 
diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
index 6debfc1d217e..49a650ac52d0 100644
--- a/target/s390x/gen-features.c
+++ b/target/s390x/gen-features.c
@@ -558,7 +558,7 @@ static uint16_t full_GEN15_GA1[] = {
     S390_FEAT_VECTOR_ENH2,
     S390_FEAT_GROUP_ENH_SORT,
     S390_FEAT_GROUP_DEFLATE_CONVERSION,
-    S390_FEAT_VECTOR_BCD_ENH,
+    S390_FEAT_VECTOR_PACKED_DECIMAL_ENH,
     S390_FEAT_GROUP_MSA_EXT_9,
     S390_FEAT_GROUP_MSA_EXT_9_PCKMO,
     S390_FEAT_ETOKEN,
@@ -643,7 +643,7 @@ static uint16_t default_GEN14_GA1[] = {
 static uint16_t default_GEN15_GA1[] = {
     S390_FEAT_VECTOR_ENH2,
     S390_FEAT_GROUP_DEFLATE_CONVERSION,
-    S390_FEAT_VECTOR_BCD_ENH,
+    S390_FEAT_VECTOR_PACKED_DECIMAL_ENH,
     S390_FEAT_GROUP_MSA_EXT_9,
     S390_FEAT_GROUP_MSA_EXT_9_PCKMO,
     S390_FEAT_ETOKEN,
-- 
2.21.0

Re: [Qemu-devel] [PATCH 1/3] s390x/cpumodel: remove esort from the default model

[David Hildenbrand]

On 15.07.19 16:23, Christian Borntraeger wrote:
> esort might not be available on all models.
> 
> Fixes: caef62430fed6e73 ("s390x/cpumodel: add gen15 defintions")
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  target/s390x/gen-features.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
> index 9f216219ff53..6debfc1d217e 100644
> --- a/target/s390x/gen-features.c
> +++ b/target/s390x/gen-features.c
> @@ -642,7 +642,6 @@ static uint16_t default_GEN14_GA1[] = {
>  
>  static uint16_t default_GEN15_GA1[] = {
>      S390_FEAT_VECTOR_ENH2,
> -    S390_FEAT_GROUP_ENH_SORT,
>      S390_FEAT_GROUP_DEFLATE_CONVERSION,
>      S390_FEAT_VECTOR_BCD_ENH,
>      S390_FEAT_GROUP_MSA_EXT_9,
> 



Reviewed-by: David Hildenbrand <david@redhat.com>

-- 

Thanks,

David / dhildenb

Re: [Qemu-devel] [PATCH 2/3] s390x/cpumodel: also change name of vxbeh

[David Hildenbrand]

On 15.07.19 16:23, Christian Borntraeger wrote:
> David suggested to keep everything in sync as 4.1 is not yet released.
> This patch fixes the name "vxbeh" into "vxp".
> 
> To simplify the backports this patch will not change VECTOR_BCD_ENH as
> this is just an internal name. That will be done by an extra patch that
> does not need to be backported.
> 
> Suggested-by: David Hildenbrand <david@redhat.com>
> Fixes: d05be57ddc2e ("s390: cpumodel: fix description for the new vector facility")
> Fixes: 54d65de0b525 ("s390x/cpumodel: vector enhancements")
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  target/s390x/cpu_features_def.inc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/s390x/cpu_features_def.inc.h b/target/s390x/cpu_features_def.inc.h
> index 3118a9f89228..99f58a89318a 100644
> --- a/target/s390x/cpu_features_def.inc.h
> +++ b/target/s390x/cpu_features_def.inc.h
> @@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facil
>  DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
>  DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")
>  DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")
> -DEF_FEAT(VECTOR_BCD_ENH, "vxbeh", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
> +DEF_FEAT(VECTOR_BCD_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
>  DEF_FEAT(MSA_EXT_9, "msa9-base", STFL, 155, "Message-security-assist-extension-9 facility (excluding subfunctions)")
>  DEF_FEAT(ETOKEN, "etoken", STFL, 156, "Etoken facility")
>  
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 

Thanks,

David / dhildenb

Re: [Qemu-devel] [PATCH 3/3] s390x/cpumodel: change internal name of vxp to make description

[David Hildenbrand]

On 15.07.19 16:23, Christian Borntraeger wrote:
> The internal macro name VECTOR_BCD_ENH does not match the actual
> description. Fix this.
> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  target/s390x/cpu_features_def.inc.h | 2 +-
>  target/s390x/gen-features.c         | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/target/s390x/cpu_features_def.inc.h b/target/s390x/cpu_features_def.inc.h
> index 99f58a89318a..f7c52bc17c2e 100644
> --- a/target/s390x/cpu_features_def.inc.h
> +++ b/target/s390x/cpu_features_def.inc.h
> @@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facil
>  DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
>  DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")
>  DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")
> -DEF_FEAT(VECTOR_BCD_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
> +DEF_FEAT(VECTOR_PACKED_DECIMAL_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
>  DEF_FEAT(MSA_EXT_9, "msa9-base", STFL, 155, "Message-security-assist-extension-9 facility (excluding subfunctions)")
>  DEF_FEAT(ETOKEN, "etoken", STFL, 156, "Etoken facility")
>  
> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
> index 6debfc1d217e..49a650ac52d0 100644
> --- a/target/s390x/gen-features.c
> +++ b/target/s390x/gen-features.c
> @@ -558,7 +558,7 @@ static uint16_t full_GEN15_GA1[] = {
>      S390_FEAT_VECTOR_ENH2,
>      S390_FEAT_GROUP_ENH_SORT,
>      S390_FEAT_GROUP_DEFLATE_CONVERSION,
> -    S390_FEAT_VECTOR_BCD_ENH,
> +    S390_FEAT_VECTOR_PACKED_DECIMAL_ENH,
>      S390_FEAT_GROUP_MSA_EXT_9,
>      S390_FEAT_GROUP_MSA_EXT_9_PCKMO,
>      S390_FEAT_ETOKEN,
> @@ -643,7 +643,7 @@ static uint16_t default_GEN14_GA1[] = {
>  static uint16_t default_GEN15_GA1[] = {
>      S390_FEAT_VECTOR_ENH2,
>      S390_FEAT_GROUP_DEFLATE_CONVERSION,
> -    S390_FEAT_VECTOR_BCD_ENH,
> +    S390_FEAT_VECTOR_PACKED_DECIMAL_ENH,
>      S390_FEAT_GROUP_MSA_EXT_9,
>      S390_FEAT_GROUP_MSA_EXT_9_PCKMO,
>      S390_FEAT_ETOKEN,
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 

Thanks,

David / dhildenb

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/3] s390x/cpumodel: also change name of vxbeh

[Thomas Huth]

On 15/07/2019 16.23, Christian Borntraeger wrote:
> David suggested to keep everything in sync as 4.1 is not yet released.
> This patch fixes the name "vxbeh" into "vxp".
> 
> To simplify the backports this patch will not change VECTOR_BCD_ENH as
> this is just an internal name. That will be done by an extra patch that
> does not need to be backported.
> 
> Suggested-by: David Hildenbrand <david@redhat.com>
> Fixes: d05be57ddc2e ("s390: cpumodel: fix description for the new vector facility")
> Fixes: 54d65de0b525 ("s390x/cpumodel: vector enhancements")
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  target/s390x/cpu_features_def.inc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/s390x/cpu_features_def.inc.h b/target/s390x/cpu_features_def.inc.h
> index 3118a9f89228..99f58a89318a 100644
> --- a/target/s390x/cpu_features_def.inc.h
> +++ b/target/s390x/cpu_features_def.inc.h
> @@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facil
>  DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
>  DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")
>  DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")
> -DEF_FEAT(VECTOR_BCD_ENH, "vxbeh", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
> +DEF_FEAT(VECTOR_BCD_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")

We already have:

DEF_FEAT(VECTOR_PACKED_DECIMAL, "vxpd", STFL, 134, "Vector packed decimal facility")

... so I rather expected something like "vxpde" here instead? Or is there a reason
for just using "vxp"?

 Thomas

Re: [Qemu-devel] [PATCH 3/3] s390x/cpumodel: change internal name of vxp to make description

[Cornelia Huck]

On Mon, 15 Jul 2019 16:23:04 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> The internal macro name VECTOR_BCD_ENH does not match the actual
> description. Fix this.
> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  target/s390x/cpu_features_def.inc.h | 2 +-
>  target/s390x/gen-features.c         | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

s/make/match/ in $SUBJECT?

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/3] s390x/cpumodel: also change name of vxbeh

[Christian Borntraeger]

On 15.07.19 17:02, Thomas Huth wrote:
> On 15/07/2019 16.23, Christian Borntraeger wrote:
>> David suggested to keep everything in sync as 4.1 is not yet released.
>> This patch fixes the name "vxbeh" into "vxp".
>>
>> To simplify the backports this patch will not change VECTOR_BCD_ENH as
>> this is just an internal name. That will be done by an extra patch that
>> does not need to be backported.
>>
>> Suggested-by: David Hildenbrand <david@redhat.com>
>> Fixes: d05be57ddc2e ("s390: cpumodel: fix description for the new vector facility")
>> Fixes: 54d65de0b525 ("s390x/cpumodel: vector enhancements")
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>>  target/s390x/cpu_features_def.inc.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/s390x/cpu_features_def.inc.h b/target/s390x/cpu_features_def.inc.h
>> index 3118a9f89228..99f58a89318a 100644
>> --- a/target/s390x/cpu_features_def.inc.h
>> +++ b/target/s390x/cpu_features_def.inc.h
>> @@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facil
>>  DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
>>  DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")
>>  DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")
>> -DEF_FEAT(VECTOR_BCD_ENH, "vxbeh", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
>> +DEF_FEAT(VECTOR_BCD_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
> 
> We already have:
> 
> DEF_FEAT(VECTOR_PACKED_DECIMAL, "vxpd", STFL, 134, "Vector packed decimal facility")
> 
> ... so I rather expected something like "vxpde" here instead? Or is there a reason
> 
for just using "vxp"?

Matching what the Linux kernel has.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/s390/kernel/processor.c?id=a8fd61688dfad6fdce95fa64cacd8a66595697b8
> 
>  Thomas
> 

Re: [Qemu-devel] [PATCH 3/3] s390x/cpumodel: change internal name of vxp to make description

[Christian Borntraeger]

On 15.07.19 17:35, Cornelia Huck wrote:
> On Mon, 15 Jul 2019 16:23:04 +0200
> Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> 
>> The internal macro name VECTOR_BCD_ENH does not match the actual
>> description. Fix this.
>>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>>  target/s390x/cpu_features_def.inc.h | 2 +-
>>  target/s390x/gen-features.c         | 4 ++--
>>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> s/make/match/ in $SUBJECT?
> 
yep.

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/3] s390x/cpumodel: also change name of vxbeh

[Christian Borntraeger]

On 15.07.19 17:50, Christian Borntraeger wrote:
> 
> 
> On 15.07.19 17:02, Thomas Huth wrote:
>> On 15/07/2019 16.23, Christian Borntraeger wrote:
>>> David suggested to keep everything in sync as 4.1 is not yet released.
>>> This patch fixes the name "vxbeh" into "vxp".
>>>
>>> To simplify the backports this patch will not change VECTOR_BCD_ENH as
>>> this is just an internal name. That will be done by an extra patch that
>>> does not need to be backported.
>>>
>>> Suggested-by: David Hildenbrand <david@redhat.com>
>>> Fixes: d05be57ddc2e ("s390: cpumodel: fix description for the new vector facility")
>>> Fixes: 54d65de0b525 ("s390x/cpumodel: vector enhancements")
>>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>> ---
>>>  target/s390x/cpu_features_def.inc.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/target/s390x/cpu_features_def.inc.h b/target/s390x/cpu_features_def.inc.h
>>> index 3118a9f89228..99f58a89318a 100644
>>> --- a/target/s390x/cpu_features_def.inc.h
>>> +++ b/target/s390x/cpu_features_def.inc.h
>>> @@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facil
>>>  DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
>>>  DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")
>>>  DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")
>>> -DEF_FEAT(VECTOR_BCD_ENH, "vxbeh", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
>>> +DEF_FEAT(VECTOR_BCD_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
>>
>> We already have:
>>
>> DEF_FEAT(VECTOR_PACKED_DECIMAL, "vxpd", STFL, 134, "Vector packed decimal facility")
>>
>> ... so I rather expected something like "vxpde" here instead? Or is there a reason
>>
> for just using "vxp"?
> 
> Matching what the Linux kernel has.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/s390/kernel/processor.c?id=a8fd61688dfad6fdce95fa64cacd8a66595697b8
>>

Since we differ from the kernel in other places as well we might use something else, of course.

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/3] s390x/cpumodel: also change name of vxbeh

[David Hildenbrand]

On 15.07.19 18:12, Christian Borntraeger wrote:
> 
> 
> On 15.07.19 17:50, Christian Borntraeger wrote:
>>
>>
>> On 15.07.19 17:02, Thomas Huth wrote:
>>> On 15/07/2019 16.23, Christian Borntraeger wrote:
>>>> David suggested to keep everything in sync as 4.1 is not yet released.
>>>> This patch fixes the name "vxbeh" into "vxp".
>>>>
>>>> To simplify the backports this patch will not change VECTOR_BCD_ENH as
>>>> this is just an internal name. That will be done by an extra patch that
>>>> does not need to be backported.
>>>>
>>>> Suggested-by: David Hildenbrand <david@redhat.com>
>>>> Fixes: d05be57ddc2e ("s390: cpumodel: fix description for the new vector facility")
>>>> Fixes: 54d65de0b525 ("s390x/cpumodel: vector enhancements")
>>>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>>> ---
>>>>  target/s390x/cpu_features_def.inc.h | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/target/s390x/cpu_features_def.inc.h b/target/s390x/cpu_features_def.inc.h
>>>> index 3118a9f89228..99f58a89318a 100644
>>>> --- a/target/s390x/cpu_features_def.inc.h
>>>> +++ b/target/s390x/cpu_features_def.inc.h
>>>> @@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facil
>>>>  DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
>>>>  DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")
>>>>  DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")
>>>> -DEF_FEAT(VECTOR_BCD_ENH, "vxbeh", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
>>>> +DEF_FEAT(VECTOR_BCD_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
>>>
>>> We already have:
>>>
>>> DEF_FEAT(VECTOR_PACKED_DECIMAL, "vxpd", STFL, 134, "Vector packed decimal facility")
>>>
>>> ... so I rather expected something like "vxpde" here instead? Or is there a reason
>>>
>> for just using "vxp"?
>>
>> Matching what the Linux kernel has.
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/s390/kernel/processor.c?id=a8fd61688dfad6fdce95fa64cacd8a66595697b8
>>>
> 
> Since we differ from the kernel in other places as well we might use something else, of course.
> 

We also have

sortl vs. sort
vxe vs. vxeh
vxe2 vs. vxeh2

So I tend to prefer "vxpde", or rather "vxpdeh".

(all other enhancement facilities have "eh", so we should actually use
"vxpdeh")

-- 

Thanks,

David / dhildenb

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/3] s390x/cpumodel: also change name of vxbeh

[Christian Borntraeger]

On 16.07.19 09:24, David Hildenbrand wrote:
> On 15.07.19 18:12, Christian Borntraeger wrote:
>>
>>
>> On 15.07.19 17:50, Christian Borntraeger wrote:
>>>
>>>
>>> On 15.07.19 17:02, Thomas Huth wrote:
>>>> On 15/07/2019 16.23, Christian Borntraeger wrote:
>>>>> David suggested to keep everything in sync as 4.1 is not yet released.
>>>>> This patch fixes the name "vxbeh" into "vxp".
>>>>>
>>>>> To simplify the backports this patch will not change VECTOR_BCD_ENH as
>>>>> this is just an internal name. That will be done by an extra patch that
>>>>> does not need to be backported.
>>>>>
>>>>> Suggested-by: David Hildenbrand <david@redhat.com>
>>>>> Fixes: d05be57ddc2e ("s390: cpumodel: fix description for the new vector facility")
>>>>> Fixes: 54d65de0b525 ("s390x/cpumodel: vector enhancements")
>>>>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>>>> ---
>>>>>  target/s390x/cpu_features_def.inc.h | 2 +-
>>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/target/s390x/cpu_features_def.inc.h b/target/s390x/cpu_features_def.inc.h
>>>>> index 3118a9f89228..99f58a89318a 100644
>>>>> --- a/target/s390x/cpu_features_def.inc.h
>>>>> +++ b/target/s390x/cpu_features_def.inc.h
>>>>> @@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facil
>>>>>  DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
>>>>>  DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")
>>>>>  DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")
>>>>> -DEF_FEAT(VECTOR_BCD_ENH, "vxbeh", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
>>>>> +DEF_FEAT(VECTOR_BCD_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
>>>>
>>>> We already have:
>>>>
>>>> DEF_FEAT(VECTOR_PACKED_DECIMAL, "vxpd", STFL, 134, "Vector packed decimal facility")
>>>>
>>>> ... so I rather expected something like "vxpde" here instead? Or is there a reason
>>>>
>>> for just using "vxp"?
>>>
>>> Matching what the Linux kernel has.
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/s390/kernel/processor.c?id=a8fd61688dfad6fdce95fa64cacd8a66595697b8
>>>>
>>
>> Since we differ from the kernel in other places as well we might use something else, of course.
>>
> 
> We also have
> 
> sortl vs. sort
> vxe vs. vxeh
> vxe2 vs. vxeh2
> 
> So I tend to prefer "vxpde", or rather "vxpdeh".
> 
> (all other enhancement facilities have "eh", so we should actually use
> "vxpdeh")

Fine with me. Conny, shall I resend or can you fixup everything?

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/3] s390x/cpumodel: also change name of vxbeh

[Cornelia Huck]

On Tue, 16 Jul 2019 09:25:42 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> On 16.07.19 09:24, David Hildenbrand wrote:

> > We also have
> > 
> > sortl vs. sort
> > vxe vs. vxeh
> > vxe2 vs. vxeh2
> > 
> > So I tend to prefer "vxpde", or rather "vxpdeh".
> > 
> > (all other enhancement facilities have "eh", so we should actually use
> > "vxpdeh")  
> 
> Fine with me. Conny, shall I resend or can you fixup everything?
> 

I now have the following; can you please double check?

commit a02c8264b7219bc30ec258f068c89b93ad244c36
Author: Christian Borntraeger <borntraeger@de.ibm.com>
Date:   Mon Jul 15 16:23:03 2019 +0200

    s390x/cpumodel: also change name of vxbeh
    
    David suggested to keep everything in sync as 4.1 is not yet released.
    This patch fixes the name "vxbeh" into "vxpdeh".
    
    To simplify the backports this patch will not change VECTOR_BCD_ENH as
    this is just an internal name. That will be done by an extra patch that
    does not need to be backported.
    
    Suggested-by: David Hildenbrand <david@redhat.com>
    Fixes: d05be57ddc2e ("s390: cpumodel: fix description for the new vector facility")
    Fixes: 54d65de0b525 ("s390x/cpumodel: vector enhancements")
    Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
    Message-Id: <20190715142304.215018-3-borntraeger@de.ibm.com>
    Reviewed-by: David Hildenbrand <david@redhat.com>
    Signed-off-by: Cornelia Huck <cohuck@redhat.com>

diff --git a/target/s390x/cpu_features_def.inc.h b/target/s390x/cpu_features_def.inc.h
index 3118a9f89228..05b7674affe6 100644
--- a/target/s390x/cpu_features_def.inc.h
+++ b/target/s390x/cpu_features_def.inc.h
@@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facil
 DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
 DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")
 DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")
-DEF_FEAT(VECTOR_BCD_ENH, "vxbeh", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
+DEF_FEAT(VECTOR_BCD_ENH, "vxpdeh", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
 DEF_FEAT(MSA_EXT_9, "msa9-base", STFL, 155, "Message-security-assist-extension-9 facility (excluding subfunctions)")
 DEF_FEAT(ETOKEN, "etoken", STFL, 156, "Etoken facility")
 

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/3] s390x/cpumodel: also change name of vxbeh

[Thomas Huth]

On 16/07/2019 10.30, Cornelia Huck wrote:
> On Tue, 16 Jul 2019 09:25:42 +0200
> Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> 
>> On 16.07.19 09:24, David Hildenbrand wrote:
> 
>>> We also have
>>>
>>> sortl vs. sort
>>> vxe vs. vxeh
>>> vxe2 vs. vxeh2
>>>
>>> So I tend to prefer "vxpde", or rather "vxpdeh".
>>>
>>> (all other enhancement facilities have "eh", so we should actually use
>>> "vxpdeh")  
>>
>> Fine with me. Conny, shall I resend or can you fixup everything?
>>
> 
> I now have the following; can you please double check?
> 
> commit a02c8264b7219bc30ec258f068c89b93ad244c36
> Author: Christian Borntraeger <borntraeger@de.ibm.com>
> Date:   Mon Jul 15 16:23:03 2019 +0200
> 
>     s390x/cpumodel: also change name of vxbeh
>     
>     David suggested to keep everything in sync as 4.1 is not yet released.
>     This patch fixes the name "vxbeh" into "vxpdeh".
>     
>     To simplify the backports this patch will not change VECTOR_BCD_ENH as
>     this is just an internal name. That will be done by an extra patch that
>     does not need to be backported.
>     
>     Suggested-by: David Hildenbrand <david@redhat.com>
>     Fixes: d05be57ddc2e ("s390: cpumodel: fix description for the new vector facility")
>     Fixes: 54d65de0b525 ("s390x/cpumodel: vector enhancements")
>     Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>     Message-Id: <20190715142304.215018-3-borntraeger@de.ibm.com>
>     Reviewed-by: David Hildenbrand <david@redhat.com>
>     Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> 
> diff --git a/target/s390x/cpu_features_def.inc.h b/target/s390x/cpu_features_def.inc.h
> index 3118a9f89228..05b7674affe6 100644
> --- a/target/s390x/cpu_features_def.inc.h
> +++ b/target/s390x/cpu_features_def.inc.h
> @@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facil
>  DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
>  DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")
>  DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")
> -DEF_FEAT(VECTOR_BCD_ENH, "vxbeh", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
> +DEF_FEAT(VECTOR_BCD_ENH, "vxpdeh", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
>  DEF_FEAT(MSA_EXT_9, "msa9-base", STFL, 155, "Message-security-assist-extension-9 facility (excluding subfunctions)")
>  DEF_FEAT(ETOKEN, "etoken", STFL, 156, "Etoken facility")

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/3] s390x/cpumodel: also change name of vxbeh

[Christian Borntraeger]

On 16.07.19 10:30, Cornelia Huck wrote:
> On Tue, 16 Jul 2019 09:25:42 +0200
> Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> 
>> On 16.07.19 09:24, David Hildenbrand wrote:
> 
>>> We also have
>>>
>>> sortl vs. sort
>>> vxe vs. vxeh
>>> vxe2 vs. vxeh2
>>>
>>> So I tend to prefer "vxpde", or rather "vxpdeh".
>>>
>>> (all other enhancement facilities have "eh", so we should actually use
>>> "vxpdeh")  
>>
>> Fine with me. Conny, shall I resend or can you fixup everything?
>>
> 
> I now have the following; can you please double check?
looks good.
> 
> commit a02c8264b7219bc30ec258f068c89b93ad244c36
> Author: Christian Borntraeger <borntraeger@de.ibm.com>
> Date:   Mon Jul 15 16:23:03 2019 +0200
> 
>     s390x/cpumodel: also change name of vxbeh
>     
>     David suggested to keep everything in sync as 4.1 is not yet released.
>     This patch fixes the name "vxbeh" into "vxpdeh".
>     
>     To simplify the backports this patch will not change VECTOR_BCD_ENH as
>     this is just an internal name. That will be done by an extra patch that
>     does not need to be backported.
>     
>     Suggested-by: David Hildenbrand <david@redhat.com>
>     Fixes: d05be57ddc2e ("s390: cpumodel: fix description for the new vector facility")
>     Fixes: 54d65de0b525 ("s390x/cpumodel: vector enhancements")
>     Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>     Message-Id: <20190715142304.215018-3-borntraeger@de.ibm.com>
>     Reviewed-by: David Hildenbrand <david@redhat.com>
>     Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> 
> diff --git a/target/s390x/cpu_features_def.inc.h b/target/s390x/cpu_features_def.inc.h
> index 3118a9f89228..05b7674affe6 100644
> --- a/target/s390x/cpu_features_def.inc.h
> +++ b/target/s390x/cpu_features_def.inc.h
> @@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facil
>  DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
>  DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")
>  DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")
> -DEF_FEAT(VECTOR_BCD_ENH, "vxbeh", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
> +DEF_FEAT(VECTOR_BCD_ENH, "vxpdeh", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
>  DEF_FEAT(MSA_EXT_9, "msa9-base", STFL, 155, "Message-security-assist-extension-9 facility (excluding subfunctions)")
>  DEF_FEAT(ETOKEN, "etoken", STFL, 156, "Etoken facility")
>  
> 

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/3] s390x/cpumodel: remove esort from the default model

[Thomas Huth]

On 15/07/2019 16.23, Christian Borntraeger wrote:
> esort might not be available on all models.
> 
> Fixes: caef62430fed6e73 ("s390x/cpumodel: add gen15 defintions")
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  target/s390x/gen-features.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
> index 9f216219ff53..6debfc1d217e 100644
> --- a/target/s390x/gen-features.c
> +++ b/target/s390x/gen-features.c
> @@ -642,7 +642,6 @@ static uint16_t default_GEN14_GA1[] = {
>  
>  static uint16_t default_GEN15_GA1[] = {
>      S390_FEAT_VECTOR_ENH2,
> -    S390_FEAT_GROUP_ENH_SORT,
>      S390_FEAT_GROUP_DEFLATE_CONVERSION,
>      S390_FEAT_VECTOR_BCD_ENH,
>      S390_FEAT_GROUP_MSA_EXT_9,
> 

FWIW,

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [qemu-s390x] [PATCH 3/3] s390x/cpumodel: change internal name of vxp to make description

[Thomas Huth]

On 15/07/2019 16.23, Christian Borntraeger wrote:
> The internal macro name VECTOR_BCD_ENH does not match the actual
> description. Fix this.
> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  target/s390x/cpu_features_def.inc.h | 2 +-
>  target/s390x/gen-features.c         | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/target/s390x/cpu_features_def.inc.h b/target/s390x/cpu_features_def.inc.h
> index 99f58a89318a..f7c52bc17c2e 100644
> --- a/target/s390x/cpu_features_def.inc.h
> +++ b/target/s390x/cpu_features_def.inc.h
> @@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facil
>  DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
>  DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")
>  DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")
> -DEF_FEAT(VECTOR_BCD_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
> +DEF_FEAT(VECTOR_PACKED_DECIMAL_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")

With "vxpdeh" instead of "vxp":

Reviewed-by: Thomas Huth <thuth@redhat.com>


>  DEF_FEAT(MSA_EXT_9, "msa9-base", STFL, 155, "Message-security-assist-extension-9 facility (excluding subfunctions)")
>  DEF_FEAT(ETOKEN, "etoken", STFL, 156, "Etoken facility")
>  
> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
> index 6debfc1d217e..49a650ac52d0 100644
> --- a/target/s390x/gen-features.c
> +++ b/target/s390x/gen-features.c
> @@ -558,7 +558,7 @@ static uint16_t full_GEN15_GA1[] = {
>      S390_FEAT_VECTOR_ENH2,
>      S390_FEAT_GROUP_ENH_SORT,
>      S390_FEAT_GROUP_DEFLATE_CONVERSION,
> -    S390_FEAT_VECTOR_BCD_ENH,
> +    S390_FEAT_VECTOR_PACKED_DECIMAL_ENH,
>      S390_FEAT_GROUP_MSA_EXT_9,
>      S390_FEAT_GROUP_MSA_EXT_9_PCKMO,
>      S390_FEAT_ETOKEN,
> @@ -643,7 +643,7 @@ static uint16_t default_GEN14_GA1[] = {
>  static uint16_t default_GEN15_GA1[] = {
>      S390_FEAT_VECTOR_ENH2,
>      S390_FEAT_GROUP_DEFLATE_CONVERSION,
> -    S390_FEAT_VECTOR_BCD_ENH,
> +    S390_FEAT_VECTOR_PACKED_DECIMAL_ENH,
>      S390_FEAT_GROUP_MSA_EXT_9,
>      S390_FEAT_GROUP_MSA_EXT_9_PCKMO,
>      S390_FEAT_ETOKEN,
> 

Re: [Qemu-devel] [PATCH 0/3] s390x/cpumodel fixes for 4.1

[Cornelia Huck]

On Mon, 15 Jul 2019 16:23:01 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> Some fallout of the gen15 cpu model. As this is new in 4.1
> it is still time to fixup some aspects.
> 
> Christian Borntraeger (3):
>   s390x/cpumodel: remove esort from the default model
>   s390x/cpumodel: also change name of vxbeh
>   s390x/cpumodel: change internal name of vxp to make description
> 
>  target/s390x/cpu_features_def.inc.h | 2 +-
>  target/s390x/gen-features.c         | 5 ++---
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 

Thanks, queued to s390-fixes (with s/vxp/vxpdeh/).

Re: [Qemu-devel] [PATCH 0/3] s390x/cpumodel fixes for 4.1

[no-reply]

Patchew URL: https://patchew.org/QEMU/20190715142304.215018-1-borntraeger@de.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190715142304.215018-1-borntraeger@de.ibm.com
Type: series
Subject: [Qemu-devel] [PATCH 0/3] s390x/cpumodel fixes for 4.1

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190715142304.215018-1-borntraeger@de.ibm.com -> patchew/20190715142304.215018-1-borntraeger@de.ibm.com
Switched to a new branch 'test'
7bc436d3ed s390x/cpumodel: change internal name of vxp to make description
6b0474bbb3 s390x/cpumodel: also change name of vxbeh
2a3445555a s390x/cpumodel: remove esort from the default model

=== OUTPUT BEGIN ===
1/3 Checking commit 2a3445555a55 (s390x/cpumodel: remove esort from the default model)
2/3 Checking commit 6b0474bbb3ec (s390x/cpumodel: also change name of vxbeh)
WARNING: line over 80 characters
#29: FILE: target/s390x/cpu_features_def.inc.h:107:
+DEF_FEAT(VECTOR_BCD_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")

total: 0 errors, 1 warnings, 8 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/3 Checking commit 7bc436d3eda4 (s390x/cpumodel: change internal name of vxp to make description)
ERROR: line over 90 characters
#22: FILE: target/s390x/cpu_features_def.inc.h:107:
+DEF_FEAT(VECTOR_PACKED_DECIMAL_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")

total: 1 errors, 0 warnings, 24 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190715142304.215018-1-borntraeger@de.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com