* [PATCH] PCI: Remove unused EXPORT_SYMBOL()s from drivers/pci/bus.c
@ 2019-07-17 18:23 ` skunberg.kelsey
0 siblings, 0 replies; 9+ messages in thread
From: Kelsey Skunberg @ 2019-07-17 18:23 UTC (permalink / raw)
To: linux-pci, linux-kernel, bhelgaas
Cc: skhan, linux-kernel-mentees, skunberg.kelsey
pci_bus_get() and pci_bus_put() are not used by a loadable kernel module
and do not need to be exported. Remove lines exporting pci_bus_get() and
pci_bus_put().
Functions were exported in commit fe830ef62ac6 ("PCI: Introduce
pci_bus_{get|put}() to manage PCI bus reference count"). No found history
of functions being used by a loadable kernel module.
Signed-off-by: Kelsey Skunberg <skunberg.kelsey@gmail.com>
---
drivers/pci/bus.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
index 495059d923f7..8e40b3e6da77 100644
--- a/drivers/pci/bus.c
+++ b/drivers/pci/bus.c
@@ -417,11 +417,9 @@ struct pci_bus *pci_bus_get(struct pci_bus *bus)
get_device(&bus->dev);
return bus;
}
-EXPORT_SYMBOL(pci_bus_get);
void pci_bus_put(struct pci_bus *bus)
{
if (bus)
put_device(&bus->dev);
}
-EXPORT_SYMBOL(pci_bus_put);
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Linux-kernel-mentees] [PATCH] PCI: Remove unused EXPORT_SYMBOL()s from drivers/pci/bus.c
@ 2019-07-17 18:23 ` skunberg.kelsey
0 siblings, 0 replies; 9+ messages in thread
From: skunberg.kelsey @ 2019-07-17 18:23 UTC (permalink / raw)
pci_bus_get() and pci_bus_put() are not used by a loadable kernel module
and do not need to be exported. Remove lines exporting pci_bus_get() and
pci_bus_put().
Functions were exported in commit fe830ef62ac6 ("PCI: Introduce
pci_bus_{get|put}() to manage PCI bus reference count"). No found history
of functions being used by a loadable kernel module.
Signed-off-by: Kelsey Skunberg <skunberg.kelsey at gmail.com>
---
drivers/pci/bus.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
index 495059d923f7..8e40b3e6da77 100644
--- a/drivers/pci/bus.c
+++ b/drivers/pci/bus.c
@@ -417,11 +417,9 @@ struct pci_bus *pci_bus_get(struct pci_bus *bus)
get_device(&bus->dev);
return bus;
}
-EXPORT_SYMBOL(pci_bus_get);
void pci_bus_put(struct pci_bus *bus)
{
if (bus)
put_device(&bus->dev);
}
-EXPORT_SYMBOL(pci_bus_put);
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Linux-kernel-mentees] [PATCH] PCI: Remove unused EXPORT_SYMBOL()s from drivers/pci/bus.c
@ 2019-07-17 18:23 ` skunberg.kelsey
0 siblings, 0 replies; 9+ messages in thread
From: Kelsey Skunberg @ 2019-07-17 18:23 UTC (permalink / raw)
pci_bus_get() and pci_bus_put() are not used by a loadable kernel module
and do not need to be exported. Remove lines exporting pci_bus_get() and
pci_bus_put().
Functions were exported in commit fe830ef62ac6 ("PCI: Introduce
pci_bus_{get|put}() to manage PCI bus reference count"). No found history
of functions being used by a loadable kernel module.
Signed-off-by: Kelsey Skunberg <skunberg.kelsey at gmail.com>
---
drivers/pci/bus.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
index 495059d923f7..8e40b3e6da77 100644
--- a/drivers/pci/bus.c
+++ b/drivers/pci/bus.c
@@ -417,11 +417,9 @@ struct pci_bus *pci_bus_get(struct pci_bus *bus)
get_device(&bus->dev);
return bus;
}
-EXPORT_SYMBOL(pci_bus_get);
void pci_bus_put(struct pci_bus *bus)
{
if (bus)
put_device(&bus->dev);
}
-EXPORT_SYMBOL(pci_bus_put);
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH] PCI: Remove unused EXPORT_SYMBOL()s from drivers/pci/bus.c
2019-07-17 18:23 ` skunberg.kelsey
(?)
@ 2019-07-17 20:48 ` gregkh
-1 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2019-07-17 20:48 UTC (permalink / raw)
To: Kelsey Skunberg; +Cc: linux-pci, linux-kernel, bhelgaas, linux-kernel-mentees
On Wed, Jul 17, 2019 at 12:23:53PM -0600, Kelsey Skunberg wrote:
> pci_bus_get() and pci_bus_put() are not used by a loadable kernel module
> and do not need to be exported. Remove lines exporting pci_bus_get() and
> pci_bus_put().
>
> Functions were exported in commit fe830ef62ac6 ("PCI: Introduce
> pci_bus_{get|put}() to manage PCI bus reference count"). No found history
> of functions being used by a loadable kernel module.
>
> Signed-off-by: Kelsey Skunberg <skunberg.kelsey@gmail.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Linux-kernel-mentees] [PATCH] PCI: Remove unused EXPORT_SYMBOL()s from drivers/pci/bus.c
@ 2019-07-17 20:48 ` gregkh
0 siblings, 0 replies; 9+ messages in thread
From: gregkh @ 2019-07-17 20:48 UTC (permalink / raw)
On Wed, Jul 17, 2019 at 12:23:53PM -0600, Kelsey Skunberg wrote:
> pci_bus_get() and pci_bus_put() are not used by a loadable kernel module
> and do not need to be exported. Remove lines exporting pci_bus_get() and
> pci_bus_put().
>
> Functions were exported in commit fe830ef62ac6 ("PCI: Introduce
> pci_bus_{get|put}() to manage PCI bus reference count"). No found history
> of functions being used by a loadable kernel module.
>
> Signed-off-by: Kelsey Skunberg <skunberg.kelsey at gmail.com>
Acked-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Linux-kernel-mentees] [PATCH] PCI: Remove unused EXPORT_SYMBOL()s from drivers/pci/bus.c
@ 2019-07-17 20:48 ` gregkh
0 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2019-07-17 20:48 UTC (permalink / raw)
On Wed, Jul 17, 2019 at 12:23:53PM -0600, Kelsey Skunberg wrote:
> pci_bus_get() and pci_bus_put() are not used by a loadable kernel module
> and do not need to be exported. Remove lines exporting pci_bus_get() and
> pci_bus_put().
>
> Functions were exported in commit fe830ef62ac6 ("PCI: Introduce
> pci_bus_{get|put}() to manage PCI bus reference count"). No found history
> of functions being used by a loadable kernel module.
>
> Signed-off-by: Kelsey Skunberg <skunberg.kelsey at gmail.com>
Acked-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH] PCI: Remove unused EXPORT_SYMBOL()s from drivers/pci/bus.c
2019-07-17 18:23 ` skunberg.kelsey
(?)
@ 2019-07-23 23:36 ` helgaas
-1 siblings, 0 replies; 9+ messages in thread
From: Bjorn Helgaas @ 2019-07-23 23:36 UTC (permalink / raw)
To: Kelsey Skunberg; +Cc: linux-pci, linux-kernel, linux-kernel-mentees, Greg KH
[+cc Greg]
On Wed, Jul 17, 2019 at 12:23:53PM -0600, Kelsey Skunberg wrote:
> pci_bus_get() and pci_bus_put() are not used by a loadable kernel module
> and do not need to be exported. Remove lines exporting pci_bus_get() and
> pci_bus_put().
>
> Functions were exported in commit fe830ef62ac6 ("PCI: Introduce
> pci_bus_{get|put}() to manage PCI bus reference count"). No found history
> of functions being used by a loadable kernel module.
>
> Signed-off-by: Kelsey Skunberg <skunberg.kelsey@gmail.com>
Applied with Greg's ack to pci/hide for v5.4, thanks!
> ---
> drivers/pci/bus.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
> index 495059d923f7..8e40b3e6da77 100644
> --- a/drivers/pci/bus.c
> +++ b/drivers/pci/bus.c
> @@ -417,11 +417,9 @@ struct pci_bus *pci_bus_get(struct pci_bus *bus)
> get_device(&bus->dev);
> return bus;
> }
> -EXPORT_SYMBOL(pci_bus_get);
>
> void pci_bus_put(struct pci_bus *bus)
> {
> if (bus)
> put_device(&bus->dev);
> }
> -EXPORT_SYMBOL(pci_bus_put);
> --
> 2.20.1
>
> _______________________________________________
> Linux-kernel-mentees mailing list
> Linux-kernel-mentees@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Linux-kernel-mentees] [PATCH] PCI: Remove unused EXPORT_SYMBOL()s from drivers/pci/bus.c
@ 2019-07-23 23:36 ` helgaas
0 siblings, 0 replies; 9+ messages in thread
From: helgaas @ 2019-07-23 23:36 UTC (permalink / raw)
[+cc Greg]
On Wed, Jul 17, 2019 at 12:23:53PM -0600, Kelsey Skunberg wrote:
> pci_bus_get() and pci_bus_put() are not used by a loadable kernel module
> and do not need to be exported. Remove lines exporting pci_bus_get() and
> pci_bus_put().
>
> Functions were exported in commit fe830ef62ac6 ("PCI: Introduce
> pci_bus_{get|put}() to manage PCI bus reference count"). No found history
> of functions being used by a loadable kernel module.
>
> Signed-off-by: Kelsey Skunberg <skunberg.kelsey at gmail.com>
Applied with Greg's ack to pci/hide for v5.4, thanks!
> ---
> drivers/pci/bus.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
> index 495059d923f7..8e40b3e6da77 100644
> --- a/drivers/pci/bus.c
> +++ b/drivers/pci/bus.c
> @@ -417,11 +417,9 @@ struct pci_bus *pci_bus_get(struct pci_bus *bus)
> get_device(&bus->dev);
> return bus;
> }
> -EXPORT_SYMBOL(pci_bus_get);
>
> void pci_bus_put(struct pci_bus *bus)
> {
> if (bus)
> put_device(&bus->dev);
> }
> -EXPORT_SYMBOL(pci_bus_put);
> --
> 2.20.1
>
> _______________________________________________
> Linux-kernel-mentees mailing list
> Linux-kernel-mentees at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Linux-kernel-mentees] [PATCH] PCI: Remove unused EXPORT_SYMBOL()s from drivers/pci/bus.c
@ 2019-07-23 23:36 ` helgaas
0 siblings, 0 replies; 9+ messages in thread
From: Bjorn Helgaas @ 2019-07-23 23:36 UTC (permalink / raw)
[+cc Greg]
On Wed, Jul 17, 2019 at 12:23:53PM -0600, Kelsey Skunberg wrote:
> pci_bus_get() and pci_bus_put() are not used by a loadable kernel module
> and do not need to be exported. Remove lines exporting pci_bus_get() and
> pci_bus_put().
>
> Functions were exported in commit fe830ef62ac6 ("PCI: Introduce
> pci_bus_{get|put}() to manage PCI bus reference count"). No found history
> of functions being used by a loadable kernel module.
>
> Signed-off-by: Kelsey Skunberg <skunberg.kelsey at gmail.com>
Applied with Greg's ack to pci/hide for v5.4, thanks!
> ---
> drivers/pci/bus.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
> index 495059d923f7..8e40b3e6da77 100644
> --- a/drivers/pci/bus.c
> +++ b/drivers/pci/bus.c
> @@ -417,11 +417,9 @@ struct pci_bus *pci_bus_get(struct pci_bus *bus)
> get_device(&bus->dev);
> return bus;
> }
> -EXPORT_SYMBOL(pci_bus_get);
>
> void pci_bus_put(struct pci_bus *bus)
> {
> if (bus)
> put_device(&bus->dev);
> }
> -EXPORT_SYMBOL(pci_bus_put);
> --
> 2.20.1
>
> _______________________________________________
> Linux-kernel-mentees mailing list
> Linux-kernel-mentees at lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-07-23 23:36 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-17 18:23 [PATCH] PCI: Remove unused EXPORT_SYMBOL()s from drivers/pci/bus.c Kelsey Skunberg
2019-07-17 18:23 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-17 18:23 ` skunberg.kelsey
2019-07-17 20:48 ` Greg KH
2019-07-17 20:48 ` Greg KH
2019-07-17 20:48 ` gregkh
2019-07-23 23:36 ` Bjorn Helgaas
2019-07-23 23:36 ` Bjorn Helgaas
2019-07-23 23:36 ` helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.