* [Buildroot] [PATCH] package/python-idna: select PYTHON3_UNICODEDATA
@ 2019-07-16 17:58 Alex Xu
2019-07-17 6:43 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Alex Xu @ 2019-07-16 17:58 UTC (permalink / raw)
To: buildroot
Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
---
package/python-idna/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/python-idna/Config.in b/package/python-idna/Config.in
index 1fd56ceaf6..c247fa89d0 100644
--- a/package/python-idna/Config.in
+++ b/package/python-idna/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_PYTHON_IDNA
bool "python-idna"
+ select BR2_PACKAGE_PYTHON3_UNICODEDATA
help
A library to support the Internationalised Domain Names in
Applications (IDNA) protocol as specified in RFC 5891. This
--
2.22.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/python-idna: select PYTHON3_UNICODEDATA
2019-07-16 17:58 [Buildroot] [PATCH] package/python-idna: select PYTHON3_UNICODEDATA Alex Xu
@ 2019-07-17 6:43 ` Thomas Petazzoni
2019-07-17 19:12 ` [Buildroot] [PATCH v2] " Alex Xu
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-07-17 6:43 UTC (permalink / raw)
To: buildroot
Hello Alex,
On Tue, 16 Jul 2019 13:58:30 -0400
"Alex Xu (Hello71)" <alex_y_xu@yahoo.ca> wrote:
> Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
Thanks for your patch. However, the commit log is empty, and therefore
it doesn't carry any explanation as to why this change is necessary.
Could you give more details ?
> diff --git a/package/python-idna/Config.in b/package/python-idna/Config.in
> index 1fd56ceaf6..c247fa89d0 100644
> --- a/package/python-idna/Config.in
> +++ b/package/python-idna/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_PYTHON_IDNA
> bool "python-idna"
> + select BR2_PACKAGE_PYTHON3_UNICODEDATA
Nit: there is an indentation problem, we indent those lines with a tab,
not with spaces.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2] package/python-idna: select PYTHON3_UNICODEDATA
2019-07-17 6:43 ` Thomas Petazzoni
@ 2019-07-17 19:12 ` Alex Xu
2019-07-18 20:27 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Alex Xu @ 2019-07-17 19:12 UTC (permalink / raw)
To: buildroot
idna requires unicodedata:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "usr/lib/python3.7/site-packages/idna/__init__.py", line 2, in <module>
File "usr/lib/python3.7/site-packages/idna/core.py", line 3, in <module>
ModuleNotFoundError: No module named 'unicodedata'
Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
---
package/python-idna/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/python-idna/Config.in b/package/python-idna/Config.in
index 1fd56ceaf6..ddc2cd7d17 100644
--- a/package/python-idna/Config.in
+++ b/package/python-idna/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_PYTHON_IDNA
bool "python-idna"
+ select BR2_PACKAGE_PYTHON3_UNICODEDATA
help
A library to support the Internationalised Domain Names in
Applications (IDNA) protocol as specified in RFC 5891. This
--
2.22.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2] package/python-idna: select PYTHON3_UNICODEDATA
2019-07-17 19:12 ` [Buildroot] [PATCH v2] " Alex Xu
@ 2019-07-18 20:27 ` Thomas Petazzoni
2019-08-04 20:13 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-07-18 20:27 UTC (permalink / raw)
To: buildroot
Hello Alex,
Thanks for the new iteration of the patch. There was still an issue,
but see below.
On Wed, 17 Jul 2019 15:12:15 -0400
"Alex Xu (Hello71)" <alex_y_xu@yahoo.ca> wrote:
> diff --git a/package/python-idna/Config.in b/package/python-idna/Config.in
> index 1fd56ceaf6..ddc2cd7d17 100644
> --- a/package/python-idna/Config.in
> +++ b/package/python-idna/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_PYTHON_IDNA
> bool "python-idna"
> + select BR2_PACKAGE_PYTHON3_UNICODEDATA
This only takes care of the case where python3 is used, by python-idna
can also be used when python (2.x) is selected.
So I changed this to:
+ select BR2_PACKAGE_PYTHON_UNICODEDATA if BR2_PACKAGE_PYTHON
+ select BR2_PACKAGE_PYTHON3_UNICODEDATA if BR2_PACKAGE_PYTHON3
and applied.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2] package/python-idna: select PYTHON3_UNICODEDATA
2019-07-18 20:27 ` Thomas Petazzoni
@ 2019-08-04 20:13 ` Peter Korsgaard
0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2019-08-04 20:13 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Hello Alex,
> Thanks for the new iteration of the patch. There was still an issue,
> but see below.
> On Wed, 17 Jul 2019 15:12:15 -0400
> "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca> wrote:
>> diff --git a/package/python-idna/Config.in b/package/python-idna/Config.in
>> index 1fd56ceaf6..ddc2cd7d17 100644
>> --- a/package/python-idna/Config.in
>> +++ b/package/python-idna/Config.in
>> @@ -1,5 +1,6 @@
>> config BR2_PACKAGE_PYTHON_IDNA
>> bool "python-idna"
>> + select BR2_PACKAGE_PYTHON3_UNICODEDATA
> This only takes care of the case where python3 is used, by python-idna
> can also be used when python (2.x) is selected.
> So I changed this to:
> + select BR2_PACKAGE_PYTHON_UNICODEDATA if BR2_PACKAGE_PYTHON
> + select BR2_PACKAGE_PYTHON3_UNICODEDATA if BR2_PACKAGE_PYTHON3
> and applied.
Committed to 2019.02.x and 2019.05.x with the same fixes, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-04 20:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-16 17:58 [Buildroot] [PATCH] package/python-idna: select PYTHON3_UNICODEDATA Alex Xu
2019-07-17 6:43 ` Thomas Petazzoni
2019-07-17 19:12 ` [Buildroot] [PATCH v2] " Alex Xu
2019-07-18 20:27 ` Thomas Petazzoni
2019-08-04 20:13 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.