* [PATCH v2 0/3] Add power domain range for MU13 side b / IRQSTR_DSP
@ 2019-07-18 10:25 ` Daniel Baluta
0 siblings, 0 replies; 12+ messages in thread
From: Daniel Baluta @ 2019-07-18 10:25 UTC (permalink / raw)
To: shawnguo
Cc: aisheng.dong, =kernel, Daniel Baluta, s.hauer, ulf.hansson,
linux-kernel, paul.olaru, linux-imx, festevam, shengjiu.wang,
linux-arm-kernel
This patch adds power domain range for MU13 side b and irqsteer in
preparation for adding support for DSP <-> AP IPC communication.
Changes since v1:
- fixed typo in patch 1/3 commit message
- enhance commit message for patch 2/3 as per Aisheng's comments
- only add PD range for mu 13 side B
Daniel Baluta (3):
firmware: imx: scu-pd: Rename mu PD range to mu_a
firmware: imx: scu-pd: Add mu13 b side PD range
firmware: imx: scu-pd: Add IRQSTR_DSP PD range
drivers/firmware/imx/scu-pd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2 1/3] firmware: imx: scu-pd: Rename mu PD range to mu_a
2019-07-18 10:25 ` Daniel Baluta
@ 2019-07-18 10:25 ` Daniel Baluta
-1 siblings, 0 replies; 12+ messages in thread
From: Daniel Baluta @ 2019-07-18 10:25 UTC (permalink / raw)
To: shawnguo
Cc: s.hauer, =kernel, festevam, linux-imx, aisheng.dong, ulf.hansson,
linux-arm-kernel, linux-kernel, shengjiu.wang, paul.olaru,
Daniel Baluta
The Messaging Unit module enables two processors within the SoC to
communicate and coordinate by passing messages through the MU interface.
MUs have 2 “sides” with independent programming interfaces. Rename
mu PD range to mu_a because it's actually side A of MUs.
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
---
drivers/firmware/imx/scu-pd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
index 480cec69e2c9..950d30238186 100644
--- a/drivers/firmware/imx/scu-pd.c
+++ b/drivers/firmware/imx/scu-pd.c
@@ -92,7 +92,7 @@ static const struct imx_sc_pd_range imx8qxp_scu_pd_ranges[] = {
{ "gpt", IMX_SC_R_GPT_0, 5, true, 0 },
{ "kpp", IMX_SC_R_KPP, 1, false, 0 },
{ "fspi", IMX_SC_R_FSPI_0, 2, true, 0 },
- { "mu", IMX_SC_R_MU_0A, 14, true, 0 },
+ { "mu_a", IMX_SC_R_MU_0A, 14, true, 0 },
/* CONN SS */
{ "usb", IMX_SC_R_USB_0, 2, true, 0 },
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2 1/3] firmware: imx: scu-pd: Rename mu PD range to mu_a
@ 2019-07-18 10:25 ` Daniel Baluta
0 siblings, 0 replies; 12+ messages in thread
From: Daniel Baluta @ 2019-07-18 10:25 UTC (permalink / raw)
To: shawnguo
Cc: aisheng.dong, =kernel, Daniel Baluta, s.hauer, ulf.hansson,
linux-kernel, paul.olaru, linux-imx, festevam, shengjiu.wang,
linux-arm-kernel
The Messaging Unit module enables two processors within the SoC to
communicate and coordinate by passing messages through the MU interface.
MUs have 2 “sides” with independent programming interfaces. Rename
mu PD range to mu_a because it's actually side A of MUs.
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
---
drivers/firmware/imx/scu-pd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
index 480cec69e2c9..950d30238186 100644
--- a/drivers/firmware/imx/scu-pd.c
+++ b/drivers/firmware/imx/scu-pd.c
@@ -92,7 +92,7 @@ static const struct imx_sc_pd_range imx8qxp_scu_pd_ranges[] = {
{ "gpt", IMX_SC_R_GPT_0, 5, true, 0 },
{ "kpp", IMX_SC_R_KPP, 1, false, 0 },
{ "fspi", IMX_SC_R_FSPI_0, 2, true, 0 },
- { "mu", IMX_SC_R_MU_0A, 14, true, 0 },
+ { "mu_a", IMX_SC_R_MU_0A, 14, true, 0 },
/* CONN SS */
{ "usb", IMX_SC_R_USB_0, 2, true, 0 },
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v2 2/3] firmware: imx: scu-pd: Add mu13 b side PD range
2019-07-18 10:25 ` Daniel Baluta
@ 2019-07-18 10:25 ` Daniel Baluta
-1 siblings, 0 replies; 12+ messages in thread
From: Daniel Baluta @ 2019-07-18 10:25 UTC (permalink / raw)
To: shawnguo
Cc: s.hauer, =kernel, festevam, linux-imx, aisheng.dong, ulf.hansson,
linux-arm-kernel, linux-kernel, shengjiu.wang, paul.olaru,
Daniel Baluta
LSIO subsystem contains 14 MU instances.
5 MUs to communicate between AP <-> SCU
- side-A PD range managed by AP
- side-B PD range managed by SCU
9 MUs to communicate between all cores (AP/M4/DSP).
- side-A PD range managed by core-A (AP/M4/DSP)
- side-B PD range managed by core-B (AP/M4/DSP).
Communication between AP <-> DSP is done through the
assigned MU number 13.
So, we power up side-A by the AP and we decide to
power up side-B also from AP. This is because powering
it up from DSP would be painful.
Powering up side B from DSP would require the DSP to
communicate with SCU and to keep things simple we don't
want that now.
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
drivers/firmware/imx/scu-pd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
index 950d30238186..eb9700b66a76 100644
--- a/drivers/firmware/imx/scu-pd.c
+++ b/drivers/firmware/imx/scu-pd.c
@@ -93,6 +93,7 @@ static const struct imx_sc_pd_range imx8qxp_scu_pd_ranges[] = {
{ "kpp", IMX_SC_R_KPP, 1, false, 0 },
{ "fspi", IMX_SC_R_FSPI_0, 2, true, 0 },
{ "mu_a", IMX_SC_R_MU_0A, 14, true, 0 },
+ { "mu_b", IMX_SC_R_MU_13B, 1, true, 13 },
/* CONN SS */
{ "usb", IMX_SC_R_USB_0, 2, true, 0 },
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2 2/3] firmware: imx: scu-pd: Add mu13 b side PD range
@ 2019-07-18 10:25 ` Daniel Baluta
0 siblings, 0 replies; 12+ messages in thread
From: Daniel Baluta @ 2019-07-18 10:25 UTC (permalink / raw)
To: shawnguo
Cc: aisheng.dong, =kernel, Daniel Baluta, s.hauer, ulf.hansson,
linux-kernel, paul.olaru, linux-imx, festevam, shengjiu.wang,
linux-arm-kernel
LSIO subsystem contains 14 MU instances.
5 MUs to communicate between AP <-> SCU
- side-A PD range managed by AP
- side-B PD range managed by SCU
9 MUs to communicate between all cores (AP/M4/DSP).
- side-A PD range managed by core-A (AP/M4/DSP)
- side-B PD range managed by core-B (AP/M4/DSP).
Communication between AP <-> DSP is done through the
assigned MU number 13.
So, we power up side-A by the AP and we decide to
power up side-B also from AP. This is because powering
it up from DSP would be painful.
Powering up side B from DSP would require the DSP to
communicate with SCU and to keep things simple we don't
want that now.
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
drivers/firmware/imx/scu-pd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
index 950d30238186..eb9700b66a76 100644
--- a/drivers/firmware/imx/scu-pd.c
+++ b/drivers/firmware/imx/scu-pd.c
@@ -93,6 +93,7 @@ static const struct imx_sc_pd_range imx8qxp_scu_pd_ranges[] = {
{ "kpp", IMX_SC_R_KPP, 1, false, 0 },
{ "fspi", IMX_SC_R_FSPI_0, 2, true, 0 },
{ "mu_a", IMX_SC_R_MU_0A, 14, true, 0 },
+ { "mu_b", IMX_SC_R_MU_13B, 1, true, 13 },
/* CONN SS */
{ "usb", IMX_SC_R_USB_0, 2, true, 0 },
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* RE: [PATCH v2 2/3] firmware: imx: scu-pd: Add mu13 b side PD range
2019-07-18 10:25 ` Daniel Baluta
@ 2019-07-18 11:56 ` Aisheng Dong
-1 siblings, 0 replies; 12+ messages in thread
From: Aisheng Dong @ 2019-07-18 11:56 UTC (permalink / raw)
To: Daniel Baluta, shawnguo
Cc: s.hauer, =kernel, festevam, dl-linux-imx, ulf.hansson,
linux-arm-kernel, linux-kernel, S.j. Wang, Paul Olaru,
Daniel Baluta
> From: Daniel Baluta <daniel.baluta@nxp.com>
> Sent: Thursday, July 18, 2019 6:25 PM
>
> LSIO subsystem contains 14 MU instances.
>
> 5 MUs to communicate between AP <-> SCU
> - side-A PD range managed by AP
> - side-B PD range managed by SCU
>
> 9 MUs to communicate between all cores (AP/M4/DSP).
> - side-A PD range managed by core-A (AP/M4/DSP)
> - side-B PD range managed by core-B (AP/M4/DSP).
>
> Communication between AP <-> DSP is done through the assigned MU number
> 13.
>
> So, we power up side-A by the AP and we decide to power up side-B also from
> AP. This is because powering it up from DSP would be painful.
>
> Powering up side B from DSP would require the DSP to communicate with SCU
> and to keep things simple we don't want that now.
>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Aisheng
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH v2 2/3] firmware: imx: scu-pd: Add mu13 b side PD range
@ 2019-07-18 11:56 ` Aisheng Dong
0 siblings, 0 replies; 12+ messages in thread
From: Aisheng Dong @ 2019-07-18 11:56 UTC (permalink / raw)
To: Daniel Baluta, shawnguo
Cc: =kernel, Daniel Baluta, s.hauer, ulf.hansson, linux-kernel,
Paul Olaru, dl-linux-imx, festevam, S.j. Wang, linux-arm-kernel
> From: Daniel Baluta <daniel.baluta@nxp.com>
> Sent: Thursday, July 18, 2019 6:25 PM
>
> LSIO subsystem contains 14 MU instances.
>
> 5 MUs to communicate between AP <-> SCU
> - side-A PD range managed by AP
> - side-B PD range managed by SCU
>
> 9 MUs to communicate between all cores (AP/M4/DSP).
> - side-A PD range managed by core-A (AP/M4/DSP)
> - side-B PD range managed by core-B (AP/M4/DSP).
>
> Communication between AP <-> DSP is done through the assigned MU number
> 13.
>
> So, we power up side-A by the AP and we decide to power up side-B also from
> AP. This is because powering it up from DSP would be painful.
>
> Powering up side B from DSP would require the DSP to communicate with SCU
> and to keep things simple we don't want that now.
>
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Aisheng
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2 3/3] firmware: imx: scu-pd: Add IRQSTR_DSP PD range
2019-07-18 10:25 ` Daniel Baluta
@ 2019-07-18 10:25 ` Daniel Baluta
-1 siblings, 0 replies; 12+ messages in thread
From: Daniel Baluta @ 2019-07-18 10:25 UTC (permalink / raw)
To: shawnguo
Cc: s.hauer, =kernel, festevam, linux-imx, aisheng.dong, ulf.hansson,
linux-arm-kernel, linux-kernel, shengjiu.wang, paul.olaru,
Daniel Baluta
The DSP interrupt steer gathers interrupts from the system
and can be used to steer them to DSP.
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
---
drivers/firmware/imx/scu-pd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
index eb9700b66a76..b556612207e5 100644
--- a/drivers/firmware/imx/scu-pd.c
+++ b/drivers/firmware/imx/scu-pd.c
@@ -131,6 +131,7 @@ static const struct imx_sc_pd_range imx8qxp_scu_pd_ranges[] = {
{ "lcd0-pwm", IMX_SC_R_LCD_0_PWM_0, 1, true, 0 },
{ "lpuart", IMX_SC_R_UART_0, 4, true, 0 },
{ "lpspi", IMX_SC_R_SPI_0, 4, true, 0 },
+ { "irqstr_dsp", IMX_SC_R_IRQSTR_DSP, 1, false, 0 },
/* VPU SS */
{ "vpu", IMX_SC_R_VPU, 1, false, 0 },
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2 3/3] firmware: imx: scu-pd: Add IRQSTR_DSP PD range
@ 2019-07-18 10:25 ` Daniel Baluta
0 siblings, 0 replies; 12+ messages in thread
From: Daniel Baluta @ 2019-07-18 10:25 UTC (permalink / raw)
To: shawnguo
Cc: aisheng.dong, =kernel, Daniel Baluta, s.hauer, ulf.hansson,
linux-kernel, paul.olaru, linux-imx, festevam, shengjiu.wang,
linux-arm-kernel
The DSP interrupt steer gathers interrupts from the system
and can be used to steer them to DSP.
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
---
drivers/firmware/imx/scu-pd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
index eb9700b66a76..b556612207e5 100644
--- a/drivers/firmware/imx/scu-pd.c
+++ b/drivers/firmware/imx/scu-pd.c
@@ -131,6 +131,7 @@ static const struct imx_sc_pd_range imx8qxp_scu_pd_ranges[] = {
{ "lcd0-pwm", IMX_SC_R_LCD_0_PWM_0, 1, true, 0 },
{ "lpuart", IMX_SC_R_UART_0, 4, true, 0 },
{ "lpspi", IMX_SC_R_SPI_0, 4, true, 0 },
+ { "irqstr_dsp", IMX_SC_R_IRQSTR_DSP, 1, false, 0 },
/* VPU SS */
{ "vpu", IMX_SC_R_VPU, 1, false, 0 },
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2 0/3] Add power domain range for MU13 side b / IRQSTR_DSP
2019-07-18 10:25 ` Daniel Baluta
@ 2019-07-23 7:50 ` Shawn Guo
-1 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2019-07-23 7:50 UTC (permalink / raw)
To: Daniel Baluta
Cc: s.hauer, =kernel, festevam, linux-imx, aisheng.dong, ulf.hansson,
linux-arm-kernel, linux-kernel, shengjiu.wang, paul.olaru
On Thu, Jul 18, 2019 at 01:25:16PM +0300, Daniel Baluta wrote:
> This patch adds power domain range for MU13 side b and irqsteer in
> preparation for adding support for DSP <-> AP IPC communication.
>
> Changes since v1:
> - fixed typo in patch 1/3 commit message
> - enhance commit message for patch 2/3 as per Aisheng's comments
> - only add PD range for mu 13 side B
>
> Daniel Baluta (3):
> firmware: imx: scu-pd: Rename mu PD range to mu_a
> firmware: imx: scu-pd: Add mu13 b side PD range
> firmware: imx: scu-pd: Add IRQSTR_DSP PD range
Applied all, thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 0/3] Add power domain range for MU13 side b / IRQSTR_DSP
@ 2019-07-23 7:50 ` Shawn Guo
0 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2019-07-23 7:50 UTC (permalink / raw)
To: Daniel Baluta
Cc: aisheng.dong, =kernel, s.hauer, ulf.hansson, linux-kernel,
paul.olaru, linux-imx, festevam, shengjiu.wang, linux-arm-kernel
On Thu, Jul 18, 2019 at 01:25:16PM +0300, Daniel Baluta wrote:
> This patch adds power domain range for MU13 side b and irqsteer in
> preparation for adding support for DSP <-> AP IPC communication.
>
> Changes since v1:
> - fixed typo in patch 1/3 commit message
> - enhance commit message for patch 2/3 as per Aisheng's comments
> - only add PD range for mu 13 side B
>
> Daniel Baluta (3):
> firmware: imx: scu-pd: Rename mu PD range to mu_a
> firmware: imx: scu-pd: Add mu13 b side PD range
> firmware: imx: scu-pd: Add IRQSTR_DSP PD range
Applied all, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread