* [Buildroot] [PATCH 1/1] package/hiawatha: depends on BR2_TOOLCHAIN_HAS_SYNC_4
@ 2019-07-17 22:02 Fabrice Fontaine
2019-07-18 18:30 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2019-07-17 22:02 UTC (permalink / raw)
To: buildroot
hiawatha uses __sync_add_and_fetch_ 4 and __sync_sub_and_fetch_4
Fixes:
- http://autobuild.buildroot.org/results/396f3ec849229eea9298215fbb1e1aac9f48c677
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/hiawatha/Config.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/hiawatha/Config.in b/package/hiawatha/Config.in
index 68e47fde87..8f1908f6f4 100644
--- a/package/hiawatha/Config.in
+++ b/package/hiawatha/Config.in
@@ -1,11 +1,13 @@
comment "hiawatha needs a toolchain w/ threads, dynamic library"
depends on BR2_USE_MMU
+ depends on BR2_TOOLCHAIN_HAS_SYNC_4
depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
config BR2_PACKAGE_HIAWATHA
bool "hiawatha"
# needs fork()
depends on BR2_USE_MMU
+ depends on BR2_TOOLCHAIN_HAS_SYNC_4 # __sync_*_4 intrisics
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on !BR2_STATIC_LIBS
select BR2_PACKAGE_ZLIB
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] package/hiawatha: depends on BR2_TOOLCHAIN_HAS_SYNC_4
2019-07-17 22:02 [Buildroot] [PATCH 1/1] package/hiawatha: depends on BR2_TOOLCHAIN_HAS_SYNC_4 Fabrice Fontaine
@ 2019-07-18 18:30 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2019-07-18 18:30 UTC (permalink / raw)
To: buildroot
Hello Fabrice,
On Thu, 18 Jul 2019 00:02:15 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> hiawatha uses __sync_add_and_fetch_ 4 and __sync_sub_and_fetch_4
>
> Fixes:
> - http://autobuild.buildroot.org/results/396f3ec849229eea9298215fbb1e1aac9f48c677
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
It would be nice to have more context about why the problem is suddenly
happening. In this case, it's due to the bump to v10.9.
So I've added more details in the commit log and applied. But generally
speaking, when there is a build failure, it is always good to see since
when it happens, and not just to fix the immediate problem, but to see
if there is a reason for suddenly having build failures that were not
occurring in the past.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-18 18:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-17 22:02 [Buildroot] [PATCH 1/1] package/hiawatha: depends on BR2_TOOLCHAIN_HAS_SYNC_4 Fabrice Fontaine
2019-07-18 18:30 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.