* [igt-dev] [PATCH i-g-t 0/4] lib/igt_edid: misc quality-of-life improvements @ 2019-07-19 11:38 Simon Ser 2019-07-19 11:38 ` [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: use struct edid instead of unsigned char Simon Ser ` (7 more replies) 0 siblings, 8 replies; 11+ messages in thread From: Simon Ser @ 2019-07-19 11:38 UTC (permalink / raw) To: igt-dev This series makes it easier and a little bit safer to use igt_edid. Simon Ser (4): lib/igt_kms: use struct edid instead of unsigned char lib/igt_kms: drop EDID_LENGTH, replace with EDID_BLOCK_SIZE lib/igt_edid: make HDMI VSDB data array unsigned lib/igt_edid: merge edid_ext_update_cea_checksum into edid_update_checksum lib/igt_chamelium.c | 3 +-- lib/igt_chamelium.h | 3 ++- lib/igt_edid.c | 20 ++++++++++------ lib/igt_edid.h | 5 ++-- lib/igt_kms.c | 49 +++++++++++++++++++--------------------- lib/igt_kms.h | 19 +++++++--------- lib/tests/igt_edid.c | 23 +++++++++++-------- tests/i915/i915_pm_rpm.c | 13 ++++++----- tests/kms_3d.c | 2 +- tests/kms_chamelium.c | 4 ++-- tests/kms_hdmi_inject.c | 4 ++-- 11 files changed, 76 insertions(+), 69 deletions(-) -- 2.22.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: use struct edid instead of unsigned char 2019-07-19 11:38 [igt-dev] [PATCH i-g-t 0/4] lib/igt_edid: misc quality-of-life improvements Simon Ser @ 2019-07-19 11:38 ` Simon Ser 2019-07-19 11:38 ` [igt-dev] [PATCH i-g-t 2/4] lib/igt_kms: drop EDID_LENGTH, replace with EDID_BLOCK_SIZE Simon Ser ` (6 subsequent siblings) 7 siblings, 0 replies; 11+ messages in thread From: Simon Ser @ 2019-07-19 11:38 UTC (permalink / raw) To: igt-dev This has several advantages: * No more need to convert back and forth between these two (everybody should use struct edid, the exception being lib/tests/igt_edid which performs sanity checks) * Makes it clearer that users can call edid_get_size on a returned EDID blob * Improves type safety (it's more obvious is a random blob is used as an EDID) Signed-off-by: Simon Ser <simon.ser@intel.com> --- lib/igt_chamelium.c | 3 +-- lib/igt_chamelium.h | 3 ++- lib/igt_kms.c | 38 +++++++++++++++++++------------------- lib/igt_kms.h | 18 ++++++++---------- lib/tests/igt_edid.c | 14 ++++++++------ tests/kms_3d.c | 2 +- tests/kms_chamelium.c | 4 ++-- tests/kms_hdmi_inject.c | 4 ++-- 8 files changed, 43 insertions(+), 43 deletions(-) diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c index 301e9d214dd1..ad30e803d2a5 100644 --- a/lib/igt_chamelium.c +++ b/lib/igt_chamelium.c @@ -562,10 +562,9 @@ static void chamelium_destroy_edid(struct chamelium *chamelium, int edid_id) * Returns: An opaque pointer to the Chamelium EDID */ struct chamelium_edid *chamelium_new_edid(struct chamelium *chamelium, - const unsigned char *raw_edid) + const struct edid *edid) { struct chamelium_edid *chamelium_edid; - const struct edid *edid = (struct edid *) raw_edid; size_t edid_size = edid_get_size(edid); chamelium_edid = calloc(1, sizeof(struct chamelium_edid)); diff --git a/lib/igt_chamelium.h b/lib/igt_chamelium.h index b6b7eb4436f8..ca6aef801b6f 100644 --- a/lib/igt_chamelium.h +++ b/lib/igt_chamelium.h @@ -34,6 +34,7 @@ #include "igt_debugfs.h" struct igt_fb; +struct edid; struct chamelium; struct chamelium_port; @@ -114,7 +115,7 @@ void chamelium_schedule_hpd_toggle(struct chamelium *chamelium, struct chamelium_port *port, int delay_ms, bool rising_edge); struct chamelium_edid *chamelium_new_edid(struct chamelium *chamelium, - const unsigned char *edid); + const struct edid *edid); const struct edid *chamelium_edid_get_raw(struct chamelium_edid *edid, struct chamelium_port *port); void chamelium_port_set_edid(struct chamelium *chamelium, diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 175e71c310b7..b7fb165e0678 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -100,7 +100,7 @@ static int forced_connectors_device[MAX_CONNECTORS + 1]; * * Returns: a basic edid block */ -const unsigned char *igt_kms_get_base_edid(void) +const struct edid *igt_kms_get_base_edid(void) { static struct edid edid; drmModeModeInfo mode = {}; @@ -119,7 +119,7 @@ const unsigned char *igt_kms_get_base_edid(void) edid_init_with_mode(&edid, &mode); edid_update_checksum(&edid); - return (unsigned char *) &edid; + return &edid; } /** @@ -136,7 +136,7 @@ const unsigned char *igt_kms_get_base_edid(void) * * Returns: an alternate edid block */ -const unsigned char *igt_kms_get_alt_edid(void) +const struct edid *igt_kms_get_alt_edid(void) { static struct edid edid; drmModeModeInfo mode = {}; @@ -155,12 +155,12 @@ const unsigned char *igt_kms_get_alt_edid(void) edid_init_with_mode(&edid, &mode); edid_update_checksum(&edid); - return (unsigned char *) &edid; + return &edid; } #define AUDIO_EDID_LENGTH (2 * EDID_LENGTH) -static void +static const struct edid * generate_audio_edid(unsigned char raw_edid[static AUDIO_EDID_LENGTH], bool with_vsdb, struct cea_sad *sad, struct cea_speaker_alloc *speaker_alloc) @@ -206,9 +206,11 @@ generate_audio_edid(unsigned char raw_edid[static AUDIO_EDID_LENGTH], edid_update_checksum(edid); edid_ext_update_cea_checksum(edid_ext); + + return edid; } -const unsigned char *igt_kms_get_hdmi_audio_edid(void) +const struct edid *igt_kms_get_hdmi_audio_edid(void) { int channels; uint8_t sampling_rates, sample_sizes; @@ -229,12 +231,10 @@ const unsigned char *igt_kms_get_hdmi_audio_edid(void) /* Initialize the Speaker Allocation Data */ speaker_alloc.speakers = CEA_SPEAKER_FRONT_LEFT_RIGHT_CENTER; - generate_audio_edid(raw_edid, true, &sad, &speaker_alloc); - - return raw_edid; + return generate_audio_edid(raw_edid, true, &sad, &speaker_alloc); } -const unsigned char *igt_kms_get_dp_audio_edid(void) +const struct edid *igt_kms_get_dp_audio_edid(void) { int channels; uint8_t sampling_rates, sample_sizes; @@ -255,9 +255,7 @@ const unsigned char *igt_kms_get_dp_audio_edid(void) /* Initialize the Speaker Allocation Data */ speaker_alloc.speakers = CEA_SPEAKER_FRONT_LEFT_RIGHT_CENTER; - generate_audio_edid(raw_edid, false, &sad, &speaker_alloc); - - return raw_edid; + return generate_audio_edid(raw_edid, false, &sad, &speaker_alloc); } static const uint8_t edid_4k_svds[] = { @@ -268,7 +266,7 @@ static const uint8_t edid_4k_svds[] = { 19, /* 720p @ 50Hz */ }; -const unsigned char *igt_kms_get_4k_edid(void) +const struct edid *igt_kms_get_4k_edid(void) { static unsigned char raw_edid[256] = {0}; struct edid *edid; @@ -317,10 +315,11 @@ const unsigned char *igt_kms_get_4k_edid(void) edid_update_checksum(edid); edid_ext_update_cea_checksum(edid_ext); - return raw_edid; + + return edid; } -const unsigned char *igt_kms_get_3d_edid(void) +const struct edid *igt_kms_get_3d_edid(void) { static unsigned char raw_edid[256] = {0}; struct edid *edid; @@ -368,7 +367,8 @@ const unsigned char *igt_kms_get_3d_edid(void) edid_update_checksum(edid); edid_ext_update_cea_checksum(edid_ext); - return raw_edid; + + return edid; } const char * const igt_plane_prop_names[IGT_NUM_PLANE_PROPS] = { @@ -1084,7 +1084,7 @@ bool kmstest_force_connector(int drm_fd, drmModeConnector *connector, * If @edid is NULL, the forced EDID will be removed. */ void kmstest_force_edid(int drm_fd, drmModeConnector *connector, - const unsigned char *edid) + const struct edid *edid) { char *path; int debugfs_fd, ret; @@ -1101,7 +1101,7 @@ void kmstest_force_edid(int drm_fd, drmModeConnector *connector, ret = write(debugfs_fd, "reset", 5); else ret = write(debugfs_fd, edid, - edid_get_size((struct edid *) edid)); + edid_get_size(edid)); close(debugfs_fd); /* To allow callers to always use GetConnectorCurrent we need to force a diff --git a/lib/igt_kms.h b/lib/igt_kms.h index 0486737bb8be..0b9374a16b0e 100644 --- a/lib/igt_kms.h +++ b/lib/igt_kms.h @@ -191,11 +191,12 @@ enum intel_broadcast_rgb_mode { BROADCAST_RGB_16_235 }; +struct edid; bool kmstest_force_connector(int fd, drmModeConnector *connector, enum kmstest_force_connector_state state); void kmstest_force_edid(int drm_fd, drmModeConnector *connector, - const unsigned char *edid); + const struct edid *edid); bool kmstest_get_connector_default_mode(int drm_fd, drmModeConnector *connector, drmModeModeInfo *mode); @@ -753,16 +754,13 @@ void igt_reset_connectors(void); uint32_t kmstest_get_vbl_flag(uint32_t pipe_id); -struct cea_sad; -struct cea_speaker_alloc; - #define EDID_LENGTH 128 -const unsigned char *igt_kms_get_base_edid(void); -const unsigned char *igt_kms_get_alt_edid(void); -const unsigned char *igt_kms_get_hdmi_audio_edid(void); -const unsigned char *igt_kms_get_dp_audio_edid(void); -const unsigned char *igt_kms_get_4k_edid(void); -const unsigned char *igt_kms_get_3d_edid(void); +const struct edid *igt_kms_get_base_edid(void); +const struct edid *igt_kms_get_alt_edid(void); +const struct edid *igt_kms_get_hdmi_audio_edid(void); +const struct edid *igt_kms_get_dp_audio_edid(void); +const struct edid *igt_kms_get_4k_edid(void); +const struct edid *igt_kms_get_3d_edid(void); struct udev_monitor *igt_watch_hotplug(void); bool igt_hotplug_detected(struct udev_monitor *mon, diff --git a/lib/tests/igt_edid.c b/lib/tests/igt_edid.c index fc98f1bb71ce..bbbf15058982 100644 --- a/lib/tests/igt_edid.c +++ b/lib/tests/igt_edid.c @@ -64,7 +64,7 @@ static bool edid_block_checksum(const unsigned char *raw_edid) return csum == 0; } -typedef const unsigned char *(*get_edid_func)(void); +typedef const struct edid *(*get_edid_func)(void); igt_simple_main { @@ -80,23 +80,25 @@ igt_simple_main { "3d", igt_kms_get_3d_edid, 1 }, {0}, }, *f; - const unsigned char *edid; + const struct edid *edid; + const uint8_t *raw_edid; size_t i; for (f = funcs; f->f; f++) { edid = f->f(); + raw_edid = (uint8_t *) edid; - igt_assert_f(edid_header_is_valid(edid), + igt_assert_f(edid_header_is_valid(raw_edid), "invalid header on %s EDID", f->desc); /* check base edid block */ - igt_assert_f(edid_block_checksum(edid), + igt_assert_f(edid_block_checksum(raw_edid), "checksum failed on %s EDID", f->desc); /* check extension blocks, if any */ - igt_assert_f(edid[126] == f->exts, + igt_assert_f(raw_edid[126] == f->exts, "unexpected number of extensions on %s EDID", f->desc); for (i = 0; i < f->exts; i++) - igt_assert_f(edid_block_checksum(edid + (i + 1) * EDID_LENGTH), + igt_assert_f(edid_block_checksum(raw_edid + (i + 1) * EDID_LENGTH), "CEA block checksum failed on %s EDID", f->desc); } } diff --git a/tests/kms_3d.c b/tests/kms_3d.c index 8ade6d347a29..7e880dd22e30 100644 --- a/tests/kms_3d.c +++ b/tests/kms_3d.c @@ -31,7 +31,7 @@ igt_simple_main int drm_fd; drmModeRes *res; drmModeConnector *connector; - const unsigned char *edid; + const struct edid *edid; int mode_count, connector_id; drm_fd = drm_open_driver_master(DRIVER_INTEL); diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c index b7d30a2d0f55..03cd9370c84f 100644 --- a/tests/kms_chamelium.c +++ b/tests/kms_chamelium.c @@ -260,7 +260,7 @@ test_basic_hotplug(data_t *data, struct chamelium_port *port, int toggle_count) igt_hpd_storm_reset(data->drm_fd); } -static const unsigned char *get_edid(enum test_edid edid); +static const struct edid *get_edid(enum test_edid edid); static void set_edid(data_t *data, struct chamelium_port *port, enum test_edid edid) @@ -2141,7 +2141,7 @@ test_hpd_storm_disable(data_t *data, struct chamelium_port *port, int width) igt_hpd_storm_reset(data->drm_fd); } -static const unsigned char *get_edid(enum test_edid edid) +static const struct edid *get_edid(enum test_edid edid) { switch (edid) { case TEST_EDID_BASE: diff --git a/tests/kms_hdmi_inject.c b/tests/kms_hdmi_inject.c index 78684241737b..157d58275107 100644 --- a/tests/kms_hdmi_inject.c +++ b/tests/kms_hdmi_inject.c @@ -79,7 +79,7 @@ get_connector(int drm_fd, drmModeRes *res) static void hdmi_inject_4k(int drm_fd, drmModeConnector *connector) { - const unsigned char *edid; + const struct edid *edid; struct kmstest_connector_config config; int ret, cid, i, crtc_mask = -1; int fb_id; @@ -140,7 +140,7 @@ hdmi_inject_4k(int drm_fd, drmModeConnector *connector) static void hdmi_inject_audio(int drm_fd, drmModeConnector *connector) { - const unsigned char *edid; + const struct edid *edid; int fb_id, cid, ret, crtc_mask = -1; struct igt_fb fb; struct kmstest_connector_config config; -- 2.22.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH i-g-t 2/4] lib/igt_kms: drop EDID_LENGTH, replace with EDID_BLOCK_SIZE 2019-07-19 11:38 [igt-dev] [PATCH i-g-t 0/4] lib/igt_edid: misc quality-of-life improvements Simon Ser 2019-07-19 11:38 ` [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: use struct edid instead of unsigned char Simon Ser @ 2019-07-19 11:38 ` Simon Ser 2019-07-19 11:38 ` [igt-dev] [PATCH i-g-t 3/4] lib/igt_edid: make HDMI VSDB data array unsigned Simon Ser ` (5 subsequent siblings) 7 siblings, 0 replies; 11+ messages in thread From: Simon Ser @ 2019-07-19 11:38 UTC (permalink / raw) To: igt-dev EDID_LENGTH is misleading because EDIDs are a variable size (they contain one or more 128-byte EDID blocks). This commit renames it to EDID_BLOCK_SIZE which makes it clear users need to call edid_get_size to get the total size. The declaration has also been moved to igt_edid. ("Size" has been chosen over "length" because it's clearer that it's a number of bytes, not a number of elements) Signed-off-by: Simon Ser <simon.ser@intel.com> --- lib/igt_edid.h | 2 ++ lib/igt_kms.c | 8 ++++---- lib/igt_kms.h | 1 - lib/tests/igt_edid.c | 13 ++++++++----- tests/i915/i915_pm_rpm.c | 13 +++++++------ 5 files changed, 21 insertions(+), 16 deletions(-) diff --git a/lib/igt_edid.h b/lib/igt_edid.h index 606541ac63b4..319ccc3dc734 100644 --- a/lib/igt_edid.h +++ b/lib/igt_edid.h @@ -32,6 +32,8 @@ #include <xf86drmMode.h> +#define EDID_BLOCK_SIZE 128 + /** * est_timings: set of established timings */ diff --git a/lib/igt_kms.c b/lib/igt_kms.c index b7fb165e0678..e66f5af2083c 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -158,10 +158,10 @@ const struct edid *igt_kms_get_alt_edid(void) return &edid; } -#define AUDIO_EDID_LENGTH (2 * EDID_LENGTH) +#define AUDIO_EDID_SIZE (2 * EDID_BLOCK_SIZE) static const struct edid * -generate_audio_edid(unsigned char raw_edid[static AUDIO_EDID_LENGTH], +generate_audio_edid(unsigned char raw_edid[static AUDIO_EDID_SIZE], bool with_vsdb, struct cea_sad *sad, struct cea_speaker_alloc *speaker_alloc) { @@ -214,7 +214,7 @@ const struct edid *igt_kms_get_hdmi_audio_edid(void) { int channels; uint8_t sampling_rates, sample_sizes; - static unsigned char raw_edid[AUDIO_EDID_LENGTH] = {0}; + static unsigned char raw_edid[AUDIO_EDID_SIZE] = {0}; struct cea_sad sad = {0}; struct cea_speaker_alloc speaker_alloc = {0}; @@ -238,7 +238,7 @@ const struct edid *igt_kms_get_dp_audio_edid(void) { int channels; uint8_t sampling_rates, sample_sizes; - static unsigned char raw_edid[AUDIO_EDID_LENGTH] = {0}; + static unsigned char raw_edid[AUDIO_EDID_SIZE] = {0}; struct cea_sad sad = {0}; struct cea_speaker_alloc speaker_alloc = {0}; diff --git a/lib/igt_kms.h b/lib/igt_kms.h index 0b9374a16b0e..a3b1bece95be 100644 --- a/lib/igt_kms.h +++ b/lib/igt_kms.h @@ -754,7 +754,6 @@ void igt_reset_connectors(void); uint32_t kmstest_get_vbl_flag(uint32_t pipe_id); -#define EDID_LENGTH 128 const struct edid *igt_kms_get_base_edid(void); const struct edid *igt_kms_get_alt_edid(void); const struct edid *igt_kms_get_hdmi_audio_edid(void); diff --git a/lib/tests/igt_edid.c b/lib/tests/igt_edid.c index bbbf15058982..8474d29e27bc 100644 --- a/lib/tests/igt_edid.c +++ b/lib/tests/igt_edid.c @@ -57,7 +57,7 @@ static bool edid_block_checksum(const unsigned char *raw_edid) size_t i; unsigned char csum = 0; - for (i = 0; i < EDID_LENGTH; i++) { + for (i = 0; i < EDID_BLOCK_SIZE; i++) { csum += raw_edid[i]; } @@ -81,7 +81,7 @@ igt_simple_main {0}, }, *f; const struct edid *edid; - const uint8_t *raw_edid; + const uint8_t *raw_edid, *raw_block; size_t i; for (f = funcs; f->f; f++) { @@ -97,8 +97,11 @@ igt_simple_main igt_assert_f(raw_edid[126] == f->exts, "unexpected number of extensions on %s EDID", f->desc); - for (i = 0; i < f->exts; i++) - igt_assert_f(edid_block_checksum(raw_edid + (i + 1) * EDID_LENGTH), - "CEA block checksum failed on %s EDID", f->desc); + for (i = 0; i < f->exts; i++) { + raw_block = raw_edid + (i + 1) * EDID_BLOCK_SIZE; + igt_assert_f(edid_block_checksum(raw_block), + "CEA block checksum failed on %s EDID", + f->desc); + } } } diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c index e2c7ba217081..2168ff72c97b 100644 --- a/tests/i915/i915_pm_rpm.c +++ b/tests/i915/i915_pm_rpm.c @@ -50,6 +50,7 @@ #include "igt_sysfs.h" #include "igt_debugfs.h" #include "igt_device.h" +#include "igt_edid.h" #define MSR_PKG_CST_CONFIG_CONTROL 0xE2 /* HSW/BDW: */ @@ -655,10 +656,10 @@ static bool i2c_read_edid(const char *connector_name, unsigned char *edid) return rc >= 0; } -static void format_hex_string(const unsigned char edid[static EDID_LENGTH], - char buf[static EDID_LENGTH * 5 + 1]) +static void format_hex_string(const unsigned char edid[static EDID_BLOCK_SIZE], + char buf[static EDID_BLOCK_SIZE * 5 + 1]) { - for (int i = 0; i < EDID_LENGTH; ++i) + for (int i = 0; i < EDID_BLOCK_SIZE; ++i) sprintf(buf+i*5, "0x%02x ", edid[i]); } @@ -670,7 +671,7 @@ static void test_i2c(struct mode_set_data *data) for (int i = 0; i < data->res->count_connectors; i++) { unsigned char *drm_edid = data->edids[i] ? data->edids[i]->data : NULL; - unsigned char i2c_edid[EDID_LENGTH] = {}; + unsigned char i2c_edid[EDID_BLOCK_SIZE] = {}; igt_output_t *output = igt_output_from_connector(&display, data->connectors[i]); @@ -694,13 +695,13 @@ static void test_i2c(struct mode_set_data *data) continue; if (got_i2c_edid && got_drm_edid) - edids_equal = (0 == memcmp(drm_edid, i2c_edid, EDID_LENGTH)); + edids_equal = (0 == memcmp(drm_edid, i2c_edid, EDID_BLOCK_SIZE)); else edids_equal = false; if (!edids_equal) { - char buf[5 * EDID_LENGTH + 1]; + char buf[5 * EDID_BLOCK_SIZE + 1]; igt_critical("Detected EDID mismatch on connector %s\n", connector_name); -- 2.22.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH i-g-t 3/4] lib/igt_edid: make HDMI VSDB data array unsigned 2019-07-19 11:38 [igt-dev] [PATCH i-g-t 0/4] lib/igt_edid: misc quality-of-life improvements Simon Ser 2019-07-19 11:38 ` [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: use struct edid instead of unsigned char Simon Ser 2019-07-19 11:38 ` [igt-dev] [PATCH i-g-t 2/4] lib/igt_kms: drop EDID_LENGTH, replace with EDID_BLOCK_SIZE Simon Ser @ 2019-07-19 11:38 ` Simon Ser 2019-07-19 11:38 ` [igt-dev] [PATCH i-g-t 4/4] lib/igt_edid: merge edid_ext_update_cea_checksum into edid_update_checksum Simon Ser ` (4 subsequent siblings) 7 siblings, 0 replies; 11+ messages in thread From: Simon Ser @ 2019-07-19 11:38 UTC (permalink / raw) To: igt-dev This array is filled manually, some bytes might have the MSB set. This fixes the following warning: ../lib/igt_kms.c:357:18: warning: implicit conversion from 'int' to 'char' changes value from 128 to -128 [-Wconstant-conversion] hdmi->data[0] = HDMI_VSDB_VIDEO_3D_PRESENT; /* HDMI video flags */ ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Simon Ser <simon.ser@intel.com> --- lib/igt_edid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/igt_edid.h b/lib/igt_edid.h index 319ccc3dc734..d256b7896c90 100644 --- a/lib/igt_edid.h +++ b/lib/igt_edid.h @@ -238,7 +238,7 @@ struct hdmi_vsdb { uint8_t flags1; /* enum hdmi_vsdb_flags1 */ uint8_t max_tdms_clock; /* multiply by 5MHz */ uint8_t flags2; /* enum hdmi_vsdb_flags2 */ - char data[]; /* latency, misc, VIC, 3D */ + uint8_t data[]; /* latency, misc, VIC, 3D */ } __attribute__((packed)); #define HDMI_VSDB_MIN_SIZE 2 /* just the source physical address */ -- 2.22.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH i-g-t 4/4] lib/igt_edid: merge edid_ext_update_cea_checksum into edid_update_checksum 2019-07-19 11:38 [igt-dev] [PATCH i-g-t 0/4] lib/igt_edid: misc quality-of-life improvements Simon Ser ` (2 preceding siblings ...) 2019-07-19 11:38 ` [igt-dev] [PATCH i-g-t 3/4] lib/igt_edid: make HDMI VSDB data array unsigned Simon Ser @ 2019-07-19 11:38 ` Simon Ser 2019-07-19 12:11 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_edid: misc quality-of-life improvements Patchwork ` (3 subsequent siblings) 7 siblings, 0 replies; 11+ messages in thread From: Simon Ser @ 2019-07-19 11:38 UTC (permalink / raw) To: igt-dev Callers no longer need to call edid_ext_update_cea_checksum on each extension block. This makes it less error-prone to miss one block by mistake. Signed-off-by: Simon Ser <simon.ser@intel.com> --- lib/igt_edid.c | 20 +++++++++++++------- lib/igt_edid.h | 1 - lib/igt_kms.c | 3 --- 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/lib/igt_edid.c b/lib/igt_edid.c index af31d66f3a57..dcc909bc63bb 100644 --- a/lib/igt_edid.c +++ b/lib/igt_edid.c @@ -296,12 +296,24 @@ static uint8_t compute_checksum(const uint8_t *buf, size_t size) } /** - * edid_update_checksum: compute and update the EDID checksum + * edid_update_checksum: compute and update the checksums of the main EDID + * block and all extension blocks */ void edid_update_checksum(struct edid *edid) { + size_t i; + struct edid_ext *ext; + edid->checksum = compute_checksum((uint8_t *) edid, sizeof(struct edid)); + + for (i = 0; i < edid->extensions_len; i++) { + ext = &edid->extensions[i]; + if (ext->tag == EDID_EXT_CEA) + ext->data.cea.checksum = + compute_checksum((uint8_t *) ext, + sizeof(struct edid_ext)); + } } /** @@ -464,9 +476,3 @@ void edid_ext_set_cea(struct edid_ext *ext, size_t data_blocks_size, cea->dtd_start = 4 + data_blocks_size; cea->misc = flags | num_native_dtds; } - -void edid_ext_update_cea_checksum(struct edid_ext *ext) -{ - ext->data.cea.checksum = compute_checksum((uint8_t *) ext, - sizeof(struct edid_ext)); -} diff --git a/lib/igt_edid.h b/lib/igt_edid.h index d256b7896c90..59b47a977fe3 100644 --- a/lib/igt_edid.h +++ b/lib/igt_edid.h @@ -368,7 +368,6 @@ void detailed_timing_set_string(struct detailed_timing *dt, void cea_sad_init_pcm(struct cea_sad *sad, int channels, uint8_t sampling_rates, uint8_t sample_sizes); -void edid_ext_update_cea_checksum(struct edid_ext *ext); const struct cea_vsdb *cea_vsdb_get_hdmi_default(size_t *size); size_t edid_cea_data_block_set_sad(struct edid_cea_data_block *block, const struct cea_sad *sads, size_t sads_len); diff --git a/lib/igt_kms.c b/lib/igt_kms.c index e66f5af2083c..9dcf0ebd6416 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -205,7 +205,6 @@ generate_audio_edid(unsigned char raw_edid[static AUDIO_EDID_SIZE], edid_ext_set_cea(edid_ext, cea_data_size, 0, EDID_CEA_BASIC_AUDIO); edid_update_checksum(edid); - edid_ext_update_cea_checksum(edid_ext); return edid; } @@ -314,7 +313,6 @@ const struct edid *igt_kms_get_4k_edid(void) edid_ext_set_cea(edid_ext, cea_data_size, 0, 0); edid_update_checksum(edid); - edid_ext_update_cea_checksum(edid_ext); return edid; } @@ -366,7 +364,6 @@ const struct edid *igt_kms_get_3d_edid(void) edid_ext_set_cea(edid_ext, cea_data_size, 0, 0); edid_update_checksum(edid); - edid_ext_update_cea_checksum(edid_ext); return edid; } -- 2.22.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_edid: misc quality-of-life improvements 2019-07-19 11:38 [igt-dev] [PATCH i-g-t 0/4] lib/igt_edid: misc quality-of-life improvements Simon Ser ` (3 preceding siblings ...) 2019-07-19 11:38 ` [igt-dev] [PATCH i-g-t 4/4] lib/igt_edid: merge edid_ext_update_cea_checksum into edid_update_checksum Simon Ser @ 2019-07-19 12:11 ` Patchwork 2019-07-19 12:13 ` Ser, Simon 2019-07-19 14:26 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork ` (2 subsequent siblings) 7 siblings, 1 reply; 11+ messages in thread From: Patchwork @ 2019-07-19 12:11 UTC (permalink / raw) To: Ser, Simon; +Cc: igt-dev == Series Details == Series: lib/igt_edid: misc quality-of-life improvements URL : https://patchwork.freedesktop.org/series/63939/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6509 -> IGTPW_3278 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_3278 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_3278, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://patchwork.freedesktop.org/api/1.0/series/63939/revisions/1/mbox/ Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_3278: ### IGT changes ### #### Possible regressions #### * igt@i915_module_load@reload-no-display: - fi-bwr-2160: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-bwr-2160/igt@i915_module_load@reload-no-display.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-bwr-2160/igt@i915_module_load@reload-no-display.html Known issues ------------ Here are the changes found in IGTPW_3278 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@debugfs_test@read_all_entries: - fi-ilk-650: [PASS][3] -> [DMESG-WARN][4] ([fdo#106387]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-ilk-650/igt@debugfs_test@read_all_entries.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-ilk-650/igt@debugfs_test@read_all_entries.html * igt@i915_selftest@live_contexts: - fi-skl-iommu: [PASS][5] -> [INCOMPLETE][6] ([fdo#111050]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-skl-iommu/igt@i915_selftest@live_contexts.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-skl-iommu/igt@i915_selftest@live_contexts.html * igt@i915_selftest@live_execlists: - fi-skl-gvtdvm: [PASS][7] -> [DMESG-FAIL][8] ([fdo#111108]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html * igt@kms_frontbuffer_tracking@basic: - fi-hsw-peppy: [PASS][9] -> [DMESG-WARN][10] ([fdo#102614]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html #### Possible fixes #### * igt@i915_selftest@live_client: - fi-icl-dsi: [INCOMPLETE][11] ([fdo#107713]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-icl-dsi/igt@i915_selftest@live_client.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-icl-dsi/igt@i915_selftest@live_client.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [FAIL][13] ([fdo#109485]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614 [fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485 [fdo#111050]: https://bugs.freedesktop.org/show_bug.cgi?id=111050 [fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108 Participating hosts (52 -> 47) ------------------------------ Missing (5): fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus Build changes ------------- * IGT: IGT_5103 -> IGTPW_3278 CI_DRM_6509: 2eda05e19db04b001c2b0a9b32bfd43077d5a738 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3278: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/ IGT_5103: 45c31e294b9d7874a9a21860f8a89c64bc853df2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_edid: misc quality-of-life improvements 2019-07-19 12:11 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_edid: misc quality-of-life improvements Patchwork @ 2019-07-19 12:13 ` Ser, Simon 2019-07-19 13:49 ` Martin Peres 0 siblings, 1 reply; 11+ messages in thread From: Ser, Simon @ 2019-07-19 12:13 UTC (permalink / raw) To: igt-dev, martin.peres On Fri, 2019-07-19 at 12:11 +0000, Patchwork wrote: > == Series Details == > > Series: lib/igt_edid: misc quality-of-life improvements > URL : https://patchwork.freedesktop.org/series/63939/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_6509 -> IGTPW_3278 > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with IGTPW_3278 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in IGTPW_3278, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: https://patchwork.freedesktop.org/api/1.0/series/63939/revisions/1/mbox/ > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in IGTPW_3278: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@i915_module_load@reload-no-display: > - fi-bwr-2160: [PASS][1] -> [INCOMPLETE][2] > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-bwr-2160/igt@i915_module_load@reload-no-display.html > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-bwr-2160/igt@i915_module_load@reload-no-display.html > Cc Martin > Known issues > ------------ > > Here are the changes found in IGTPW_3278 that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@debugfs_test@read_all_entries: > - fi-ilk-650: [PASS][3] -> [DMESG-WARN][4] ([fdo#106387]) > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-ilk-650/igt@debugfs_test@read_all_entries.html > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-ilk-650/igt@debugfs_test@read_all_entries.html > > * igt@i915_selftest@live_contexts: > - fi-skl-iommu: [PASS][5] -> [INCOMPLETE][6] ([fdo#111050]) > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-skl-iommu/igt@i915_selftest@live_contexts.html > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-skl-iommu/igt@i915_selftest@live_contexts.html > > * igt@i915_selftest@live_execlists: > - fi-skl-gvtdvm: [PASS][7] -> [DMESG-FAIL][8] ([fdo#111108]) > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html > > * igt@kms_frontbuffer_tracking@basic: > - fi-hsw-peppy: [PASS][9] -> [DMESG-WARN][10] ([fdo#102614]) > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html > > > #### Possible fixes #### > > * igt@i915_selftest@live_client: > - fi-icl-dsi: [INCOMPLETE][11] ([fdo#107713]) -> [PASS][12] > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-icl-dsi/igt@i915_selftest@live_client.html > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-icl-dsi/igt@i915_selftest@live_client.html > > * igt@kms_chamelium@hdmi-hpd-fast: > - fi-kbl-7500u: [FAIL][13] ([fdo#109485]) -> [PASS][14] > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html > > > [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614 > [fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387 > [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 > [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485 > [fdo#111050]: https://bugs.freedesktop.org/show_bug.cgi?id=111050 > [fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108 > > > Participating hosts (52 -> 47) > ------------------------------ > > Missing (5): fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus > > > Build changes > ------------- > > * IGT: IGT_5103 -> IGTPW_3278 > > CI_DRM_6509: 2eda05e19db04b001c2b0a9b32bfd43077d5a738 @ git://anongit.freedesktop.org/gfx-ci/linux > IGTPW_3278: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/ > IGT_5103: 45c31e294b9d7874a9a21860f8a89c64bc853df2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_edid: misc quality-of-life improvements 2019-07-19 12:13 ` Ser, Simon @ 2019-07-19 13:49 ` Martin Peres 0 siblings, 0 replies; 11+ messages in thread From: Martin Peres @ 2019-07-19 13:49 UTC (permalink / raw) To: Ser, Simon, igt-dev On 19/07/2019 15:13, Ser, Simon wrote: > On Fri, 2019-07-19 at 12:11 +0000, Patchwork wrote: >> == Series Details == >> >> Series: lib/igt_edid: misc quality-of-life improvements >> URL : https://patchwork.freedesktop.org/series/63939/ >> State : failure >> >> == Summary == >> >> CI Bug Log - changes from CI_DRM_6509 -> IGTPW_3278 >> ==================================================== >> >> Summary >> ------- >> >> **FAILURE** >> >> Serious unknown changes coming with IGTPW_3278 absolutely need to be >> verified manually. >> >> If you think the reported changes have nothing to do with the changes >> introduced in IGTPW_3278, please notify your bug team to allow them >> to document this new failure mode, which will reduce false positives in CI. >> >> External URL: https://patchwork.freedesktop.org/api/1.0/series/63939/revisions/1/mbox/ >> >> Possible new issues >> ------------------- >> >> Here are the unknown changes that may have been introduced in IGTPW_3278: >> >> ### IGT changes ### >> >> #### Possible regressions #### >> >> * igt@i915_module_load@reload-no-display: >> - fi-bwr-2160: [PASS][1] -> [INCOMPLETE][2] >> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-bwr-2160/igt@i915_module_load@reload-no-display.html >> [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-bwr-2160/igt@i915_module_load@reload-no-display.html >> > > Cc Martin Thanks: https://bugs.freedesktop.org/show_bug.cgi?id=111174 I just re-reported the run. Next time, please ping me on IRC as I don't have time to monitor all patch series. Martin > >> Known issues >> ------------ >> >> Here are the changes found in IGTPW_3278 that come from known issues: >> >> ### IGT changes ### >> >> #### Issues hit #### >> >> * igt@debugfs_test@read_all_entries: >> - fi-ilk-650: [PASS][3] -> [DMESG-WARN][4] ([fdo#106387]) >> [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-ilk-650/igt@debugfs_test@read_all_entries.html >> [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-ilk-650/igt@debugfs_test@read_all_entries.html >> >> * igt@i915_selftest@live_contexts: >> - fi-skl-iommu: [PASS][5] -> [INCOMPLETE][6] ([fdo#111050]) >> [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-skl-iommu/igt@i915_selftest@live_contexts.html >> [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-skl-iommu/igt@i915_selftest@live_contexts.html >> >> * igt@i915_selftest@live_execlists: >> - fi-skl-gvtdvm: [PASS][7] -> [DMESG-FAIL][8] ([fdo#111108]) >> [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html >> [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html >> >> * igt@kms_frontbuffer_tracking@basic: >> - fi-hsw-peppy: [PASS][9] -> [DMESG-WARN][10] ([fdo#102614]) >> [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html >> [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html >> >> >> #### Possible fixes #### >> >> * igt@i915_selftest@live_client: >> - fi-icl-dsi: [INCOMPLETE][11] ([fdo#107713]) -> [PASS][12] >> [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-icl-dsi/igt@i915_selftest@live_client.html >> [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-icl-dsi/igt@i915_selftest@live_client.html >> >> * igt@kms_chamelium@hdmi-hpd-fast: >> - fi-kbl-7500u: [FAIL][13] ([fdo#109485]) -> [PASS][14] >> [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html >> [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html >> >> >> [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614 >> [fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387 >> [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 >> [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485 >> [fdo#111050]: https://bugs.freedesktop.org/show_bug.cgi?id=111050 >> [fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108 >> >> >> Participating hosts (52 -> 47) >> ------------------------------ >> >> Missing (5): fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus >> >> >> Build changes >> ------------- >> >> * IGT: IGT_5103 -> IGTPW_3278 >> >> CI_DRM_6509: 2eda05e19db04b001c2b0a9b32bfd43077d5a738 @ git://anongit.freedesktop.org/gfx-ci/linux >> IGTPW_3278: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/ >> IGT_5103: 45c31e294b9d7874a9a21860f8a89c64bc853df2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools >> >> == Logs == >> >> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_edid: misc quality-of-life improvements 2019-07-19 11:38 [igt-dev] [PATCH i-g-t 0/4] lib/igt_edid: misc quality-of-life improvements Simon Ser ` (4 preceding siblings ...) 2019-07-19 12:11 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_edid: misc quality-of-life improvements Patchwork @ 2019-07-19 14:26 ` Patchwork 2019-07-19 17:11 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2019-08-15 8:25 ` [igt-dev] [PATCH i-g-t 0/4] " Arkadiusz Hiler 7 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2019-07-19 14:26 UTC (permalink / raw) To: Ser, Simon; +Cc: igt-dev == Series Details == Series: lib/igt_edid: misc quality-of-life improvements URL : https://patchwork.freedesktop.org/series/63939/ State : success == Summary == CI Bug Log - changes from CI_DRM_6509 -> IGTPW_3278 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/63939/revisions/1/mbox/ Known issues ------------ Here are the changes found in IGTPW_3278 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@debugfs_test@read_all_entries: - fi-ilk-650: [PASS][1] -> [DMESG-WARN][2] ([fdo#106387]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-ilk-650/igt@debugfs_test@read_all_entries.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-ilk-650/igt@debugfs_test@read_all_entries.html * igt@i915_module_load@reload-no-display: - fi-bwr-2160: [PASS][3] -> [INCOMPLETE][4] ([fdo#111174]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-bwr-2160/igt@i915_module_load@reload-no-display.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-bwr-2160/igt@i915_module_load@reload-no-display.html * igt@i915_selftest@live_contexts: - fi-skl-iommu: [PASS][5] -> [INCOMPLETE][6] ([fdo#111050]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-skl-iommu/igt@i915_selftest@live_contexts.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-skl-iommu/igt@i915_selftest@live_contexts.html * igt@i915_selftest@live_execlists: - fi-skl-gvtdvm: [PASS][7] -> [DMESG-FAIL][8] ([fdo#111108]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html * igt@kms_frontbuffer_tracking@basic: - fi-hsw-peppy: [PASS][9] -> [DMESG-WARN][10] ([fdo#102614]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html #### Possible fixes #### * igt@i915_selftest@live_client: - fi-icl-dsi: [INCOMPLETE][11] ([fdo#107713]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-icl-dsi/igt@i915_selftest@live_client.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-icl-dsi/igt@i915_selftest@live_client.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [FAIL][13] ([fdo#109485]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614 [fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485 [fdo#111050]: https://bugs.freedesktop.org/show_bug.cgi?id=111050 [fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108 [fdo#111174]: https://bugs.freedesktop.org/show_bug.cgi?id=111174 Participating hosts (52 -> 47) ------------------------------ Missing (5): fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus Build changes ------------- * IGT: IGT_5103 -> IGTPW_3278 CI_DRM_6509: 2eda05e19db04b001c2b0a9b32bfd43077d5a738 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3278: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/ IGT_5103: 45c31e294b9d7874a9a21860f8a89c64bc853df2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for lib/igt_edid: misc quality-of-life improvements 2019-07-19 11:38 [igt-dev] [PATCH i-g-t 0/4] lib/igt_edid: misc quality-of-life improvements Simon Ser ` (5 preceding siblings ...) 2019-07-19 14:26 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork @ 2019-07-19 17:11 ` Patchwork 2019-08-15 8:25 ` [igt-dev] [PATCH i-g-t 0/4] " Arkadiusz Hiler 7 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2019-07-19 17:11 UTC (permalink / raw) To: Ser, Simon; +Cc: igt-dev == Series Details == Series: lib/igt_edid: misc quality-of-life improvements URL : https://patchwork.freedesktop.org/series/63939/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6509_full -> IGTPW_3278_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_3278_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_3278_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://patchwork.freedesktop.org/api/1.0/series/63939/revisions/1/mbox/ Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_3278_full: ### IGT changes ### #### Possible regressions #### * igt@i915_selftest@live_hangcheck: - shard-iclb: [PASS][1] -> [DMESG-WARN][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb3/igt@i915_selftest@live_hangcheck.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-iclb4/igt@i915_selftest@live_hangcheck.html Known issues ------------ Here are the changes found in IGTPW_3278_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite: - shard-iclb: [PASS][3] -> [FAIL][4] ([fdo#103167]) +4 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-iclb: [PASS][5] -> [FAIL][6] ([fdo#103166]) +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-x.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-x.html * igt@kms_psr@psr2_primary_mmap_cpu: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109441]) +3 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html * igt@kms_vblank@pipe-c-ts-continuation-suspend: - shard-apl: [PASS][9] -> [DMESG-WARN][10] ([fdo#108566]) +3 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-apl2/igt@kms_vblank@pipe-c-ts-continuation-suspend.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-apl1/igt@kms_vblank@pipe-c-ts-continuation-suspend.html #### Possible fixes #### * igt@gem_ctx_isolation@rcs0-s3: - shard-apl: [DMESG-WARN][11] ([fdo#108566]) -> [PASS][12] +6 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-apl5/igt@gem_ctx_isolation@rcs0-s3.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-apl2/igt@gem_ctx_isolation@rcs0-s3.html * igt@gem_eio@unwedge-stress: - shard-snb: [FAIL][13] ([fdo#109661]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-snb5/igt@gem_eio@unwedge-stress.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-snb4/igt@gem_eio@unwedge-stress.html * igt@gem_mmap_gtt@big-copy: - shard-iclb: [INCOMPLETE][15] ([fdo#107713] / [fdo#109100]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb7/igt@gem_mmap_gtt@big-copy.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-iclb5/igt@gem_mmap_gtt@big-copy.html * igt@i915_pm_rc6_residency@rc6-accuracy: - shard-iclb: [SKIP][17] ([fdo#110933]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb5/igt@i915_pm_rc6_residency@rc6-accuracy.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-iclb3/igt@i915_pm_rc6_residency@rc6-accuracy.html * igt@kms_atomic_transition@plane-toggle-modeset-transition: - shard-snb: [SKIP][19] ([fdo#109271]) -> [PASS][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-snb1/igt@kms_atomic_transition@plane-toggle-modeset-transition.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-snb4/igt@kms_atomic_transition@plane-toggle-modeset-transition.html * igt@kms_flip@dpms-vs-vblank-race: - shard-kbl: [FAIL][21] ([fdo#103060]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-kbl1/igt@kms_flip@dpms-vs-vblank-race.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-kbl6/igt@kms_flip@dpms-vs-vblank-race.html * igt@kms_flip@modeset-vs-vblank-race-interruptible: - shard-glk: [FAIL][23] ([fdo#103060]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-glk5/igt@kms_flip@modeset-vs-vblank-race-interruptible.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-glk3/igt@kms_flip@modeset-vs-vblank-race-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt: - shard-apl: [FAIL][25] ([fdo#103167]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-apl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-apl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html - shard-kbl: [FAIL][27] ([fdo#103167]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [SKIP][29] ([fdo#109642] / [fdo#111068]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb5/igt@kms_psr2_su@frontbuffer.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-iclb2/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@psr2_sprite_mmap_cpu: - shard-iclb: [SKIP][31] ([fdo#109441]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_cpu.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html * igt@kms_setmode@basic: - shard-apl: [FAIL][33] ([fdo#99912]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-apl8/igt@kms_setmode@basic.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-apl7/igt@kms_setmode@basic.html * igt@perf_pmu@rc6: - shard-iclb: [SKIP][35] ([fdo#110877]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb4/igt@perf_pmu@rc6.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-iclb4/igt@perf_pmu@rc6.html #### Warnings #### * igt@i915_pm_rc6_residency@media-rc6-accuracy: - shard-iclb: [SKIP][37] ([fdo#110933]) -> [SKIP][38] ([fdo#109289]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6509/shard-iclb4/igt@i915_pm_rc6_residency@media-rc6-accuracy.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/shard-iclb6/igt@i915_pm_rc6_residency@media-rc6-accuracy.html [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060 [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661 [fdo#110877]: https://bugs.freedesktop.org/show_bug.cgi?id=110877 [fdo#110933]: https://bugs.freedesktop.org/show_bug.cgi?id=110933 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (10 -> 6) ------------------------------ Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 Build changes ------------- * IGT: IGT_5103 -> IGTPW_3278 * Piglit: piglit_4509 -> None CI_DRM_6509: 2eda05e19db04b001c2b0a9b32bfd43077d5a738 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3278: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/ IGT_5103: 45c31e294b9d7874a9a21860f8a89c64bc853df2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3278/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 0/4] lib/igt_edid: misc quality-of-life improvements 2019-07-19 11:38 [igt-dev] [PATCH i-g-t 0/4] lib/igt_edid: misc quality-of-life improvements Simon Ser ` (6 preceding siblings ...) 2019-07-19 17:11 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork @ 2019-08-15 8:25 ` Arkadiusz Hiler 7 siblings, 0 replies; 11+ messages in thread From: Arkadiusz Hiler @ 2019-08-15 8:25 UTC (permalink / raw) To: Simon Ser; +Cc: igt-dev On Fri, Jul 19, 2019 at 02:38:43PM +0300, Simon Ser wrote: > This series makes it easier and a little bit safer to use igt_edid. Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com> for the whole series _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-08-15 8:25 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-07-19 11:38 [igt-dev] [PATCH i-g-t 0/4] lib/igt_edid: misc quality-of-life improvements Simon Ser 2019-07-19 11:38 ` [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: use struct edid instead of unsigned char Simon Ser 2019-07-19 11:38 ` [igt-dev] [PATCH i-g-t 2/4] lib/igt_kms: drop EDID_LENGTH, replace with EDID_BLOCK_SIZE Simon Ser 2019-07-19 11:38 ` [igt-dev] [PATCH i-g-t 3/4] lib/igt_edid: make HDMI VSDB data array unsigned Simon Ser 2019-07-19 11:38 ` [igt-dev] [PATCH i-g-t 4/4] lib/igt_edid: merge edid_ext_update_cea_checksum into edid_update_checksum Simon Ser 2019-07-19 12:11 ` [igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_edid: misc quality-of-life improvements Patchwork 2019-07-19 12:13 ` Ser, Simon 2019-07-19 13:49 ` Martin Peres 2019-07-19 14:26 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork 2019-07-19 17:11 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2019-08-15 8:25 ` [igt-dev] [PATCH i-g-t 0/4] " Arkadiusz Hiler
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.