All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 1/2] tools/vbt_decode: Update PSR1 training pattern decode
@ 2019-07-20  1:37 Dhinakaran Pandiyan
  2019-07-20  1:37 ` [igt-dev] [PATCH i-g-t 2/2] tools/vbt_decode: Fix PSR2 decoded training pattern duration Dhinakaran Pandiyan
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Dhinakaran Pandiyan @ 2019-07-20  1:37 UTC (permalink / raw)
  To: igt-dev; +Cc: Dhinakaran Pandiyan

The bit field corresponding to PSR1 training patterns used to be
platform agnostic. But, for VBT versions above 205 on gen9+, the values
map to hardware supported duration. The only exception being BXT, which
follows the legacy mapping.

Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
 tools/intel_vbt_decode.c | 37 ++++++++++++++++++++++++++++++-------
 1 file changed, 30 insertions(+), 7 deletions(-)

diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
index 3b9006f5..ea64eee2 100644
--- a/tools/intel_vbt_decode.c
+++ b/tools/intel_vbt_decode.c
@@ -945,14 +945,20 @@ static void dump_psr(struct context *context,
 	const struct bdb_psr *psr_block = block->data;
 	int i;
 	uint32_t psr2_tp_time;
+	const char *bxt_str = "$VBT_BROXTON";
+	bool is_bxt;
 
 	/* The same block ID was used for something else before? */
 	if (context->bdb->version < 165)
 		return;
 
+	is_bxt = !strncmp((char *)context->vbt->signature, bxt_str,
+			  strlen(bxt_str));
 	psr2_tp_time = psr_block->psr2_tp2_tp3_wakeup_time;
+
 	for (i = 0; i < 16; i++) {
 		const struct psr_table *psr = &psr_block->psr_table[i];
+		static const uint16_t psr1_tp_times[] = {500, 100, 2500, 0};
 
 		if (i != context->panel_type && !context->dump_all_panel_types)
 			continue;
@@ -979,16 +985,33 @@ static void dump_psr(struct context *context,
 			break;
 		}
 
-		printf("\t\tIdle frames to for PSR enable: %d\n",
+		printf("\t\tIdle frames to wait for PSR enable: %d\n",
 		       psr->idle_frames);
 
-		printf("\t\tTP1 wakeup time: %d usec (0x%x)\n",
-		       psr->tp1_wakeup_time * 100,
-		       psr->tp1_wakeup_time);
 
-		printf("\t\tTP2/TP3 wakeup time: %d usec (0x%x)\n",
-		       psr->tp2_tp3_wakeup_time * 100,
-		       psr->tp2_tp3_wakeup_time);
+		if (is_bxt || context->bdb->version < 205)
+			printf("\t\tTP1 wakeup time: %d usec (0x%x)\n",
+			       psr->tp1_wakeup_time * 100,
+			       psr->tp1_wakeup_time);
+		else if (psr->tp1_wakeup_time <= 2)
+			printf("\t\tTP1 wakeup time: %d usec (0x%x)\n",
+			       psr1_tp_times[psr->tp1_wakeup_time],
+			       psr->tp1_wakeup_time);
+		else
+			printf("\t\tTP1 wakeup time invalid (0x%x)",
+			       psr->tp1_wakeup_time);
+
+		if (is_bxt || context->bdb->version < 205)
+			printf("\t\tTP2/TP3 wakeup time: %d usec (0x%x)\n",
+			       psr->tp2_tp3_wakeup_time * 100,
+			       psr->tp2_tp3_wakeup_time);
+		else if (psr->tp2_tp3_wakeup_time <= 2)
+			printf("\t\tTP2/TP3 wakeup time: %d usec (0x%x)\n",
+			       psr1_tp_times[psr->tp2_tp3_wakeup_time],
+			       psr->tp2_tp3_wakeup_time);
+		else
+			printf("\t\tTP2/3 wakeup time invalid (0x%x)",
+			       psr->tp2_tp3_wakeup_time);
 
 		if (context->bdb->version >= 226) {
 			int index;
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-31 13:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-20  1:37 [igt-dev] [PATCH i-g-t 1/2] tools/vbt_decode: Update PSR1 training pattern decode Dhinakaran Pandiyan
2019-07-20  1:37 ` [igt-dev] [PATCH i-g-t 2/2] tools/vbt_decode: Fix PSR2 decoded training pattern duration Dhinakaran Pandiyan
2019-07-20  3:14 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tools/vbt_decode: Update PSR1 training pattern decode Patchwork
2019-07-29 23:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tools/vbt_decode: Update PSR1 training pattern decode (rev2) Patchwork
2019-07-30  9:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-07-31 13:10 ` [igt-dev] [PATCH i-g-t 1/2] tools/vbt_decode: Update PSR1 training pattern decode Jani Nikula

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.