All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Eric Auger <eric.auger@redhat.com>,
	eric.auger.pro@gmail.com, m.szyprowski@samsung.com,
	robin.murphy@arm.com, jasowang@redhat.com,
	virtualization@lists.linux-foundation.org,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] virtio/virtio_ring: Fix the dma_max_mapping_size call
Date: Mon, 22 Jul 2019 11:39:57 -0400	[thread overview]
Message-ID: <20190722113403-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190722152710.GB3780@lst.de>

On Mon, Jul 22, 2019 at 05:27:10PM +0200, Christoph Hellwig wrote:
> On Mon, Jul 22, 2019 at 04:55:09PM +0200, Eric Auger wrote:
> > Do not call dma_max_mapping_size for devices that have no DMA
> > mask set, otherwise we can hit a NULL pointer dereference.
> > 
> > This occurs when a virtio-blk-pci device is protected with
> > a virtual IOMMU.
> > 
> > Fixes: e6d6dd6c875e ("virtio: Introduce virtio_max_dma_size()")
> > Signed-off-by: Eric Auger <eric.auger@redhat.com>
> > Suggested-by: Christoph Hellwig <hch@lst.de>
> 
> Looks good.  virtio maintainers, let me know if you want to queue
> it up or if I should pick the patch up through the dma-mapping tree.

Personally I dislike this API because I feel presence of dma mask does
not strictly have to reflect max size. And generally the requirement to
check presence of mask feels like an undocumented hack to me.  Even
reading code will not help you avoid the warning, everyone will get it
wrong and get the warning splat in their logs.  So I would prefer just
v1 of the patch that makes dma API do the right thing for us.

However, if that's not going to be the case, let's fix it up in virtio.
In any case, for both v1 and v2 of the patches, you can merge them
through your tree:

Acked-by: Michael S. Tsirkin <mst@redhat.com>

-- 
MST

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: jasowang@redhat.com, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	iommu@lists.linux-foundation.org, eric.auger.pro@gmail.com,
	robin.murphy@arm.com
Subject: Re: [PATCH 2/2] virtio/virtio_ring: Fix the dma_max_mapping_size call
Date: Mon, 22 Jul 2019 11:39:57 -0400	[thread overview]
Message-ID: <20190722113403-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190722152710.GB3780@lst.de>

On Mon, Jul 22, 2019 at 05:27:10PM +0200, Christoph Hellwig wrote:
> On Mon, Jul 22, 2019 at 04:55:09PM +0200, Eric Auger wrote:
> > Do not call dma_max_mapping_size for devices that have no DMA
> > mask set, otherwise we can hit a NULL pointer dereference.
> > 
> > This occurs when a virtio-blk-pci device is protected with
> > a virtual IOMMU.
> > 
> > Fixes: e6d6dd6c875e ("virtio: Introduce virtio_max_dma_size()")
> > Signed-off-by: Eric Auger <eric.auger@redhat.com>
> > Suggested-by: Christoph Hellwig <hch@lst.de>
> 
> Looks good.  virtio maintainers, let me know if you want to queue
> it up or if I should pick the patch up through the dma-mapping tree.

Personally I dislike this API because I feel presence of dma mask does
not strictly have to reflect max size. And generally the requirement to
check presence of mask feels like an undocumented hack to me.  Even
reading code will not help you avoid the warning, everyone will get it
wrong and get the warning splat in their logs.  So I would prefer just
v1 of the patch that makes dma API do the right thing for us.

However, if that's not going to be the case, let's fix it up in virtio.
In any case, for both v1 and v2 of the patches, you can merge them
through your tree:

Acked-by: Michael S. Tsirkin <mst@redhat.com>

-- 
MST
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2019-07-22 15:40 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22 14:55 [PATCH 0/2] Fix NULL pointer dereference with virtio-blk-pci and virtual IOMMU Eric Auger
2019-07-22 14:55 ` Eric Auger
2019-07-22 14:55 ` [PATCH 1/2] dma-mapping: Protect dma_addressing_limited against NULL dma_mask Eric Auger
2019-07-22 14:55   ` Eric Auger
2019-07-22 15:26   ` Christoph Hellwig
2019-07-22 15:26     ` Christoph Hellwig
2019-07-22 15:46     ` Auger Eric
2019-07-22 15:46       ` Auger Eric
2019-07-22 15:46     ` Auger Eric
2019-07-22 15:26   ` Christoph Hellwig
2019-07-22 14:55 ` Eric Auger
2019-07-22 14:55 ` [PATCH 2/2] virtio/virtio_ring: Fix the dma_max_mapping_size call Eric Auger
2019-07-22 14:55 ` Eric Auger
2019-07-22 14:55   ` Eric Auger
2019-07-22 15:27   ` Christoph Hellwig
2019-07-22 15:27     ` Christoph Hellwig
2019-07-22 15:39     ` Michael S. Tsirkin [this message]
2019-07-22 15:39       ` Michael S. Tsirkin
2019-07-22 15:39     ` Michael S. Tsirkin
2019-07-22 15:27   ` Christoph Hellwig
2019-07-22 15:33   ` Michael S. Tsirkin
2019-07-22 15:33   ` Michael S. Tsirkin
2019-07-22 15:33     ` Michael S. Tsirkin
2019-07-23 15:38     ` Christoph Hellwig
2019-07-23 15:38       ` Christoph Hellwig
2019-07-23 15:47       ` Michael S. Tsirkin
2019-07-23 15:47       ` Michael S. Tsirkin
2019-07-23 15:47         ` Michael S. Tsirkin
2019-07-23 15:38     ` Christoph Hellwig
2019-07-22 15:36   ` Robin Murphy
2019-07-22 15:36   ` Robin Murphy
2019-07-22 15:36     ` Robin Murphy
2019-07-22 15:45     ` Michael S. Tsirkin
2019-07-22 15:45       ` Michael S. Tsirkin
2019-07-22 15:45     ` Michael S. Tsirkin
2019-07-23 15:38     ` Christoph Hellwig
2019-07-23 15:38       ` Christoph Hellwig
2019-07-23 15:38       ` Christoph Hellwig
2019-07-24 22:10       ` Michael S. Tsirkin
2019-07-24 22:10       ` Michael S. Tsirkin
2019-07-24 22:10         ` Michael S. Tsirkin
2019-07-25  5:25         ` Christoph Hellwig
2019-07-25  5:25         ` Christoph Hellwig
2019-07-25  5:25           ` Christoph Hellwig
2019-07-25 11:53       ` Auger Eric
2019-07-25 11:53         ` Auger Eric
2019-07-25 13:04         ` Christoph Hellwig
2019-07-25 13:04         ` Christoph Hellwig
2019-07-25 13:04           ` Christoph Hellwig
2019-07-25 16:32           ` Auger Eric
2019-07-25 16:32           ` Auger Eric
2019-07-25 16:32             ` Auger Eric
2019-07-25 11:53       ` Auger Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190722113403-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=eric.auger@redhat.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=robin.murphy@arm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.