* [PATCH] crypto: nx: nx-842-powernv: Add of_node_put() before return
@ 2019-07-23 8:08 Nishka Dasgupta
2019-07-24 7:42 ` Stewart Smith
0 siblings, 1 reply; 2+ messages in thread
From: Nishka Dasgupta @ 2019-07-23 8:08 UTC (permalink / raw)
To: haren, herbert, davem, benh, paulus, mpe, linux-crypto, linuxppc-dev
Cc: Nishka Dasgupta
Each iteration of for_each_child_of_node puts the previous node, but
in the case of a return from the middle of the loop, there is no put,
thus causing a memory leak. Add an of_node_put before the return.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
drivers/crypto/nx/nx-842-powernv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/nx/nx-842-powernv.c b/drivers/crypto/nx/nx-842-powernv.c
index e78ff5c65ed6..c037a2403b82 100644
--- a/drivers/crypto/nx/nx-842-powernv.c
+++ b/drivers/crypto/nx/nx-842-powernv.c
@@ -1020,6 +1020,7 @@ static __init int nx842_powernv_init(void)
ret = nx842_powernv_probe_vas(dn);
if (ret) {
nx842_delete_coprocs();
+ of_node_put(dn);
return ret;
}
}
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: nx: nx-842-powernv: Add of_node_put() before return
2019-07-23 8:08 [PATCH] crypto: nx: nx-842-powernv: Add of_node_put() before return Nishka Dasgupta
@ 2019-07-24 7:42 ` Stewart Smith
0 siblings, 0 replies; 2+ messages in thread
From: Stewart Smith @ 2019-07-24 7:42 UTC (permalink / raw)
To: Nishka Dasgupta, haren, herbert, davem, benh, paulus, mpe,
linux-crypto, linuxppc-dev
Cc: Nishka Dasgupta
Nishka Dasgupta <nishkadg.linux@gmail.com> writes:
> Each iteration of for_each_child_of_node puts the previous node, but
This is for_each_compatible_node.
otherwise looks okay,
Acked-by: Stewart Smith <stewart@linux.ibm.com>
--
Stewart Smith
OPAL Architect, IBM.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-24 7:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 8:08 [PATCH] crypto: nx: nx-842-powernv: Add of_node_put() before return Nishka Dasgupta
2019-07-24 7:42 ` Stewart Smith
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.