From: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com> To: <alex.williamson@redhat.com>, <eric.auger@redhat.com> Cc: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <iommu@lists.linux-foundation.org>, <linuxarm@huawei.com>, <john.garry@huawei.com>, <xuwei5@hisilicon.com>, <kevin.tian@intel.com>, Shameer Kolothum <shameerali.kolothum.thodi@huawei.com> Subject: [PATCH v8 0/6] vfio/type1: Add support for valid iova list management Date: Tue, 23 Jul 2019 17:06:31 +0100 [thread overview] Message-ID: <20190723160637.8384-1-shameerali.kolothum.thodi@huawei.com> (raw) This is to revive this series which almost made to 4.18 but got dropped as Alex found an issue[1] with IGD and USB devices RMRR region being reported as reserved regions. Thanks to Eric for his work here[2]. It provides a way to exclude these regions while reporting the valid iova regions and this respin make use of that. Please note that I don't have a platform to verify the reported RMRR issue and appreciate testing on those platforms. Thanks, Shameer [1] https://lkml.org/lkml/2018/6/5/760 [2] https://lore.kernel.org/patchwork/cover/1083072/ v7-->v8 -Rebased to 5.3-rc1 -Addressed comments from Alex and Eric. Please see individual patch history. -Added Eric's R-by to patches 4/5/6 v6-->v7 -Rebased to 5.2-rc6 + Eric's patches -Added logic to exclude IOMMU_RESV_DIRECT_RELAXABLE reserved memory region type(patch #2). -Dropped patch #4 of v6 as it is already part of mainline. -Addressed "container with only an mdev device will have an empty list" case(patches 4/6 & 5/6 - Suggested by Alex) Old ---- This series introduces an iova list associated with a vfio iommu. The list is kept updated taking care of iommu apertures, and reserved regions. Also this series adds checks for any conflict with existing dma mappings whenever a new device group is attached to the domain. User-space can retrieve valid iova ranges using VFIO_IOMMU_GET_INFO ioctl capability chains. Any dma map request outside the valid iova range will be rejected. v5 --> v6 -Rebased to 4.17-rc1 -Changed the ordering such that previous patch#7 "iommu/dma: Move PCI window region reservation back...") is now patch #4. This will avoid any bisection issues pointed out by Alex. -Added Robins's Reviewed-by tag for patch#4 v4 --> v5 Rebased to next-20180315. -Incorporated the corner case bug fix suggested by Alex to patch #5. -Based on suggestions by Alex and Robin, added patch#7. This moves the PCI window reservation back in to DMA specific path. This is to fix the issue reported by Eric[1]. v3 --> v4 Addressed comments received for v3. -dma_addr_t instead of phys_addr_t -LIST_HEAD() usage. -Free up iova_copy list in case of error. -updated logic in filling the iova caps info(patch #5) RFCv2 --> v3 Removed RFC tag. Addressed comments from Alex and Eric: - Added comments to make iova list management logic more clear. - Use of iova list copy so that original is not altered in case of failure. RFCv1 --> RFCv2 Addressed comments from Alex: -Introduced IOVA list management and added checks for conflicts with existing dma map entries during attach/detach. Shameer Kolothum (6): vfio/type1: Introduce iova list and add iommu aperture validity check vfio/type1: Check reserved region conflict and update iova list vfio/type1: Update iova list on detach vfio/type1: check dma map request is within a valid iova range vfio/type1: Add IOVA range capability support vfio/type1: remove duplicate retrieval of reserved regions drivers/vfio/vfio_iommu_type1.c | 518 +++++++++++++++++++++++++++++++- include/uapi/linux/vfio.h | 26 +- 2 files changed, 531 insertions(+), 13 deletions(-) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com> To: <alex.williamson@redhat.com>, <eric.auger@redhat.com> Cc: kevin.tian@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, xuwei5@hisilicon.com, linuxarm@huawei.com, iommu@lists.linux-foundation.org Subject: [PATCH v8 0/6] vfio/type1: Add support for valid iova list management Date: Tue, 23 Jul 2019 17:06:31 +0100 [thread overview] Message-ID: <20190723160637.8384-1-shameerali.kolothum.thodi@huawei.com> (raw) This is to revive this series which almost made to 4.18 but got dropped as Alex found an issue[1] with IGD and USB devices RMRR region being reported as reserved regions. Thanks to Eric for his work here[2]. It provides a way to exclude these regions while reporting the valid iova regions and this respin make use of that. Please note that I don't have a platform to verify the reported RMRR issue and appreciate testing on those platforms. Thanks, Shameer [1] https://lkml.org/lkml/2018/6/5/760 [2] https://lore.kernel.org/patchwork/cover/1083072/ v7-->v8 -Rebased to 5.3-rc1 -Addressed comments from Alex and Eric. Please see individual patch history. -Added Eric's R-by to patches 4/5/6 v6-->v7 -Rebased to 5.2-rc6 + Eric's patches -Added logic to exclude IOMMU_RESV_DIRECT_RELAXABLE reserved memory region type(patch #2). -Dropped patch #4 of v6 as it is already part of mainline. -Addressed "container with only an mdev device will have an empty list" case(patches 4/6 & 5/6 - Suggested by Alex) Old ---- This series introduces an iova list associated with a vfio iommu. The list is kept updated taking care of iommu apertures, and reserved regions. Also this series adds checks for any conflict with existing dma mappings whenever a new device group is attached to the domain. User-space can retrieve valid iova ranges using VFIO_IOMMU_GET_INFO ioctl capability chains. Any dma map request outside the valid iova range will be rejected. v5 --> v6 -Rebased to 4.17-rc1 -Changed the ordering such that previous patch#7 "iommu/dma: Move PCI window region reservation back...") is now patch #4. This will avoid any bisection issues pointed out by Alex. -Added Robins's Reviewed-by tag for patch#4 v4 --> v5 Rebased to next-20180315. -Incorporated the corner case bug fix suggested by Alex to patch #5. -Based on suggestions by Alex and Robin, added patch#7. This moves the PCI window reservation back in to DMA specific path. This is to fix the issue reported by Eric[1]. v3 --> v4 Addressed comments received for v3. -dma_addr_t instead of phys_addr_t -LIST_HEAD() usage. -Free up iova_copy list in case of error. -updated logic in filling the iova caps info(patch #5) RFCv2 --> v3 Removed RFC tag. Addressed comments from Alex and Eric: - Added comments to make iova list management logic more clear. - Use of iova list copy so that original is not altered in case of failure. RFCv1 --> RFCv2 Addressed comments from Alex: -Introduced IOVA list management and added checks for conflicts with existing dma map entries during attach/detach. Shameer Kolothum (6): vfio/type1: Introduce iova list and add iommu aperture validity check vfio/type1: Check reserved region conflict and update iova list vfio/type1: Update iova list on detach vfio/type1: check dma map request is within a valid iova range vfio/type1: Add IOVA range capability support vfio/type1: remove duplicate retrieval of reserved regions drivers/vfio/vfio_iommu_type1.c | 518 +++++++++++++++++++++++++++++++- include/uapi/linux/vfio.h | 26 +- 2 files changed, 531 insertions(+), 13 deletions(-) -- 2.17.1 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next reply other threads:[~2019-07-23 16:08 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-23 16:06 Shameer Kolothum [this message] 2019-07-23 16:06 ` [PATCH v8 0/6] vfio/type1: Add support for valid iova list management Shameer Kolothum 2019-07-23 16:06 ` [PATCH v8 1/6] vfio/type1: Introduce iova list and add iommu aperture validity check Shameer Kolothum 2019-07-23 16:06 ` Shameer Kolothum 2019-07-26 17:09 ` Auger Eric 2019-07-26 17:09 ` Auger Eric 2019-07-23 16:06 ` [PATCH v8 2/6] vfio/type1: Check reserved region conflict and update iova list Shameer Kolothum 2019-07-23 16:06 ` Shameer Kolothum 2019-07-26 17:09 ` Auger Eric 2019-07-26 17:09 ` Auger Eric 2019-07-23 16:06 ` [PATCH v8 3/6] vfio/type1: Update iova list on detach Shameer Kolothum 2019-07-23 16:06 ` Shameer Kolothum 2019-07-26 17:09 ` Auger Eric 2019-07-26 17:09 ` Auger Eric 2019-07-23 16:06 ` [PATCH v8 4/6] vfio/type1: check dma map request is within a valid iova range Shameer Kolothum 2019-07-23 16:06 ` Shameer Kolothum 2019-07-23 16:06 ` [PATCH v8 5/6] vfio/type1: Add IOVA range capability support Shameer Kolothum 2019-07-23 16:06 ` Shameer Kolothum 2019-07-23 16:06 ` [PATCH v8 6/6] vfio/type1: remove duplicate retrieval of reserved regions Shameer Kolothum 2019-07-23 16:06 ` Shameer Kolothum 2019-08-23 9:02 ` [PATCH v8 0/6] vfio/type1: Add support for valid iova list management Shameerali Kolothum Thodi 2019-08-23 9:02 ` Shameerali Kolothum Thodi 2019-08-23 20:51 ` Alex Williamson 2019-08-23 20:51 ` Alex Williamson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190723160637.8384-1-shameerali.kolothum.thodi@huawei.com \ --to=shameerali.kolothum.thodi@huawei.com \ --cc=alex.williamson@redhat.com \ --cc=eric.auger@redhat.com \ --cc=iommu@lists.linux-foundation.org \ --cc=john.garry@huawei.com \ --cc=kevin.tian@intel.com \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=xuwei5@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.