From: David Miller <davem@davemloft.net>
To: skunberg.kelsey@gmail.com
Cc: iyappan@os.amperecomputing.com, keyur@os.amperecomputing.com,
quan@os.amperecomputing.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v3] drivers: net: xgene: Remove acpi_has_method() calls
Date: Wed, 24 Jul 2019 11:30:08 -0700 (PDT) [thread overview]
Message-ID: <20190724.113008.1837834250766825392.davem@davemloft.net> (raw)
In-Reply-To: <20190724060659.105292-1-skunberg.kelsey@gmail.com>
From: Kelsey Skunberg <skunberg.kelsey@gmail.com>
Date: Wed, 24 Jul 2019 00:06:59 -0600
> acpi_evaluate_object will already return an error if the needed method
> does not exist. Remove unnecessary acpi_has_method() calls and check the
> returned acpi_status for failure instead.
>
> Signed-off-by: Kelsey Skunberg <skunberg.kelsey@gmail.com>
> ---
> Changes in v2:
> - Fixed white space warnings and errors
>
> Changes in v3:
> - Resolved build errors caused by missing bracket
Applied, will push out after build testing :)
WARNING: multiple messages have this Message-ID (diff)
From: davem at davemloft.net (David Miller)
Subject: [Linux-kernel-mentees] [PATCH v3] drivers: net: xgene: Remove acpi_has_method() calls
Date: Wed, 24 Jul 2019 11:30:08 -0700 (PDT) [thread overview]
Message-ID: <20190724.113008.1837834250766825392.davem@davemloft.net> (raw)
In-Reply-To: <20190724060659.105292-1-skunberg.kelsey@gmail.com>
From: Kelsey Skunberg <skunberg.kelsey at gmail.com>
Date: Wed, 24 Jul 2019 00:06:59 -0600
> acpi_evaluate_object will already return an error if the needed method
> does not exist. Remove unnecessary acpi_has_method() calls and check the
> returned acpi_status for failure instead.
>
> Signed-off-by: Kelsey Skunberg <skunberg.kelsey at gmail.com>
> ---
> Changes in v2:
> - Fixed white space warnings and errors
>
> Changes in v3:
> - Resolved build errors caused by missing bracket
Applied, will push out after build testing :)
WARNING: multiple messages have this Message-ID (diff)
From: davem@davemloft.net (David Miller)
Subject: [Linux-kernel-mentees] [PATCH v3] drivers: net: xgene: Remove acpi_has_method() calls
Date: Wed, 24 Jul 2019 11:30:08 -0700 (PDT) [thread overview]
Message-ID: <20190724.113008.1837834250766825392.davem@davemloft.net> (raw)
Message-ID: <20190724183008.Slcp-MK8YEOvusiBA_Vv259XVl59bwkso-hIYv_YUco@z> (raw)
In-Reply-To: <20190724060659.105292-1-skunberg.kelsey@gmail.com>
From: Kelsey Skunberg <skunberg.kelsey@gmail.com>
Date: Wed, 24 Jul 2019 00:06:59 -0600
> acpi_evaluate_object will already return an error if the needed method
> does not exist. Remove unnecessary acpi_has_method() calls and check the
> returned acpi_status for failure instead.
>
> Signed-off-by: Kelsey Skunberg <skunberg.kelsey at gmail.com>
> ---
> Changes in v2:
> - Fixed white space warnings and errors
>
> Changes in v3:
> - Resolved build errors caused by missing bracket
Applied, will push out after build testing :)
next prev parent reply other threads:[~2019-07-24 18:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 3:04 [PATCH] drivers: net: xgene: Remove acpi_has_method() calls Kelsey Skunberg
2019-07-22 3:04 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-22 3:04 ` skunberg.kelsey
2019-07-22 11:05 ` kbuild test robot
2019-07-22 11:05 ` [Linux-kernel-mentees] " kbuild test robot
2019-07-22 11:05 ` lkp
2019-07-23 1:17 ` David Miller
2019-07-23 1:17 ` [Linux-kernel-mentees] " David Miller
2019-07-23 1:17 ` davem
2019-07-23 18:58 ` [PATCH v2] " Kelsey Skunberg
2019-07-23 18:58 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-23 18:58 ` skunberg.kelsey
2019-07-23 21:06 ` David Miller
2019-07-23 21:06 ` [Linux-kernel-mentees] " David Miller
2019-07-23 21:06 ` davem
2019-07-23 21:07 ` David Miller
2019-07-23 21:07 ` [Linux-kernel-mentees] " David Miller
2019-07-23 21:07 ` davem
2019-07-24 5:56 ` Kelsey Skunberg
2019-07-24 5:56 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-24 5:56 ` skunberg.kelsey
2019-07-23 22:56 ` Bjorn Helgaas
2019-07-23 22:56 ` [Linux-kernel-mentees] " Bjorn Helgaas
2019-07-23 22:56 ` bjorn.helgaas
2019-07-23 23:17 ` Kelsey Skunberg
2019-07-23 23:17 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-23 23:17 ` skunberg.kelsey
2019-07-24 6:06 ` [PATCH v3] " Kelsey Skunberg
2019-07-24 6:06 ` [Linux-kernel-mentees] " Kelsey Skunberg
2019-07-24 6:06 ` skunberg.kelsey
2019-07-24 18:30 ` David Miller [this message]
2019-07-24 18:30 ` David Miller
2019-07-24 18:30 ` davem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724.113008.1837834250766825392.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=iyappan@os.amperecomputing.com \
--cc=keyur@os.amperecomputing.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quan@os.amperecomputing.com \
--cc=skhan@linuxfoundation.org \
--cc=skunberg.kelsey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.