* [PATCH 00/14] Stateful/stateless codec core support
@ 2019-07-24 11:10 Hans Verkuil
2019-07-24 11:10 ` [PATCH 01/14] v4l2-ioctl.c: OR flags in v4l_fill_fmtdesc(), not don't overwrite Hans Verkuil
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Hans Verkuil @ 2019-07-24 11:10 UTC (permalink / raw)
To: linux-media
(There were too many recipients for my provider, so resending
without the zillion CCs, just read the mailinglist instead :-) )
This series consolidates various patches/patch series that add
features or document memory-to-memory video codec interfaces.
This includes patches adding V4L2_FMT_FLAG_DYN_RESOLUTION,
new code adding V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER, new code
adding V4L2_DEC_CMD_FLUSH, patches adding V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF
(now with documentation) and patches documenting the stateful
encoder/decoder and stateless decoder.
The stateful encoder documentation is still RFC quality (there are
open TODOs, see https://patchwork.kernel.org/cover/10972783/).
The stateless decoder documentation is the same as the v5 posted
by Alexandre, but with my comments incorporated.
Also added are updated pixelformat descriptions. Please review this!
I didn't update the MPEG4 format since I'm not sure what to put there.
If anyone has access to recent codec standards, then I would really
like to have the right references to 'MPEG Picture' and 'Access Unit'.
It would be good to just refer to the definition of what a Picture
or Access Unit is in the right standards.
Changes for the stateful decoder documentation since v4:
- In the Decoding section change "multiple ``OUTPUT`` buffers generate
one ``CAPTURE`` buffer: timestamp of the ``OUTPUT`` buffer queued last
will be copied." to "queued first" since this corresponds to
existing implementations.
- Document that width and height are required fields in step 4 of the
Capture Setup.
- Mention the new ENUM_FMT flags.
Changes for the stateless decoder documentation since v5:
- Document that width and height are required fields in step 4 of the
Capture Setup.
- Mention the new V4L2_DEC_CMD_FLUSH command to flush the last held
capture buffer. This replaces the 'queue an empty buffer' solution.
In my view this series is ready to go in, except for the last patch
(stateful encoder).
Maxime, I didn't add the proposed V4L2_FMT_FLAG_MANUAL_RESOLUTION
flag since I think that can go in separately. I also am not 100%
happy with that name, although I can't think of a better one.
Regards,
Hans
Alexandre Courbot (1):
media: docs-rst: Document m2m stateless video decoder interface
Hans Verkuil (6):
v4l2-ioctl.c: OR flags in v4l_fill_fmtdesc(), not don't overwrite
videodev2.h: add V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER
videodev2.h.rst.exceptions: tymecode -> timecode
vb2: add V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF
videodev2.h: add V4L2_DEC_CMD_FLUSH
pixfmt-compressed.rst: improve H264/HEVC/MPEG1+2/VP8+9 documentation
Maxime Jourdan (5):
videodev2.h: add V4L2_FMT_FLAG_DYN_RESOLUTION
media: venus: vdec: flag OUTPUT formats with
V4L2_FMT_FLAG_DYN_RESOLUTION
media: s5p_mfc_dec: set flags for OUTPUT coded formats
media: mtk-vcodec: flag OUTPUT formats with
V4L2_FMT_FLAG_DYN_RESOLUTION
media: vicodec: set flags for vdec/stateful OUTPUT coded formats
Tomasz Figa (2):
media: docs-rst: Document memory-to-memory video decoder interface
media: docs-rst: Document memory-to-memory video encoder interface
Documentation/media/uapi/v4l/buffer.rst | 13 +
Documentation/media/uapi/v4l/dev-decoder.rst | 1101 +++++++++++++++++
Documentation/media/uapi/v4l/dev-encoder.rst | 608 +++++++++
Documentation/media/uapi/v4l/dev-mem2mem.rst | 10 +-
.../media/uapi/v4l/dev-stateless-decoder.rst | 424 +++++++
.../media/uapi/v4l/pixfmt-compressed.rst | 36 +-
Documentation/media/uapi/v4l/pixfmt-v4l2.rst | 10 +
Documentation/media/uapi/v4l/v4l2.rst | 12 +-
.../media/uapi/v4l/vidioc-decoder-cmd.rst | 52 +-
.../media/uapi/v4l/vidioc-dqevent.rst | 11 +-
.../media/uapi/v4l/vidioc-encoder-cmd.rst | 51 +-
.../media/uapi/v4l/vidioc-enum-fmt.rst | 16 +
.../media/uapi/v4l/vidioc-reqbufs.rst | 6 +
.../media/videodev2.h.rst.exceptions | 7 +-
.../media/common/videobuf2/videobuf2-v4l2.c | 8 +-
.../platform/mtk-vcodec/mtk_vcodec_dec.c | 4 +
.../platform/mtk-vcodec/mtk_vcodec_drv.h | 1 +
drivers/media/platform/qcom/venus/core.h | 1 +
drivers/media/platform/qcom/venus/vdec.c | 11 +
.../media/platform/s5p-mfc/s5p_mfc_common.h | 1 +
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 18 +
drivers/media/platform/vicodec/vicodec-core.c | 3 +
drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
include/media/v4l2-mem2mem.h | 42 +
include/media/videobuf2-core.h | 3 +
include/media/videobuf2-v4l2.h | 5 +
include/uapi/linux/videodev2.h | 20 +-
27 files changed, 2419 insertions(+), 57 deletions(-)
create mode 100644 Documentation/media/uapi/v4l/dev-decoder.rst
create mode 100644 Documentation/media/uapi/v4l/dev-encoder.rst
create mode 100644 Documentation/media/uapi/v4l/dev-stateless-decoder.rst
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 01/14] v4l2-ioctl.c: OR flags in v4l_fill_fmtdesc(), not don't overwrite
2019-07-24 11:10 [PATCH 00/14] Stateful/stateless codec core support Hans Verkuil
@ 2019-07-24 11:10 ` Hans Verkuil
2019-07-24 11:10 ` [PATCH 02/14] videodev2.h: add V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER Hans Verkuil
2019-07-24 11:10 ` [PATCH 03/14] videodev2.h: add V4L2_FMT_FLAG_DYN_RESOLUTION Hans Verkuil
2 siblings, 0 replies; 6+ messages in thread
From: Hans Verkuil @ 2019-07-24 11:10 UTC (permalink / raw)
To: linux-media; +Cc: Hans Verkuil
If a driver sets a FMT flag in the enum_fmt op, then that will be
ignored since v4l_fill_fmtdesc() overwrites it again.
v4l_fill_fmtdesc() should OR its flag, not overwrite it.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
index 80efc581e3f9..911a20f915c5 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -1390,7 +1390,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
if (descr)
WARN_ON(strscpy(fmt->description, descr, sz) < 0);
- fmt->flags = flags;
+ fmt->flags |= flags;
}
static int v4l_enum_fmt(const struct v4l2_ioctl_ops *ops,
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 02/14] videodev2.h: add V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER
2019-07-24 11:10 [PATCH 00/14] Stateful/stateless codec core support Hans Verkuil
2019-07-24 11:10 ` [PATCH 01/14] v4l2-ioctl.c: OR flags in v4l_fill_fmtdesc(), not don't overwrite Hans Verkuil
@ 2019-07-24 11:10 ` Hans Verkuil
2019-07-24 11:10 ` [PATCH 03/14] videodev2.h: add V4L2_FMT_FLAG_DYN_RESOLUTION Hans Verkuil
2 siblings, 0 replies; 6+ messages in thread
From: Hans Verkuil @ 2019-07-24 11:10 UTC (permalink / raw)
To: linux-media; +Cc: Hans Verkuil
Add an enum_fmt format flag to specifically tag coded formats where
full bitstream parsing is supported by the device.
Some stateful decoders are capable of fully parsing a bitstream,
but others require that userspace pre-parses the bitstream into
frames or fields (see the corresponding pixelformat descriptions
for details).
If this flag is set, then this pre-parsing step is not required
(but still possible, of course).
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
Documentation/media/uapi/v4l/vidioc-enum-fmt.rst | 8 ++++++++
Documentation/media/videodev2.h.rst.exceptions | 1 +
include/uapi/linux/videodev2.h | 5 +++--
3 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst
index 822d6730e7d2..4e24e671f32e 100644
--- a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst
+++ b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst
@@ -127,6 +127,14 @@ one until ``EINVAL`` is returned.
- This format is not native to the device but emulated through
software (usually libv4l2), where possible try to use a native
format instead for better performance.
+ * - ``V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER``
+ - 0x0004
+ - The hardware decoder for this compressed bitstream format (aka coded
+ format) is capable of parsing the bitstream. Applications do not
+ need to parse the bitstream themselves to find the boundaries between
+ frames/fields. This flag can only be used in combination with the
+ ``V4L2_FMT_FLAG_COMPRESSED`` flag, since this applies to compressed
+ formats only.
Return Value
diff --git a/Documentation/media/videodev2.h.rst.exceptions b/Documentation/media/videodev2.h.rst.exceptions
index 55cbe324b9fc..74fb9f00c12d 100644
--- a/Documentation/media/videodev2.h.rst.exceptions
+++ b/Documentation/media/videodev2.h.rst.exceptions
@@ -180,6 +180,7 @@ replace define V4L2_PIX_FMT_FLAG_PREMUL_ALPHA reserved-formats
# V4L2 format flags
replace define V4L2_FMT_FLAG_COMPRESSED fmtdesc-flags
replace define V4L2_FMT_FLAG_EMULATED fmtdesc-flags
+replace define V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER fmtdesc-flags
# V4L2 tymecode types
replace define V4L2_TC_TYPE_24FPS timecode-type
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index 2427bc4d8eba..8c5a28666b16 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -774,8 +774,9 @@ struct v4l2_fmtdesc {
__u32 reserved[4];
};
-#define V4L2_FMT_FLAG_COMPRESSED 0x0001
-#define V4L2_FMT_FLAG_EMULATED 0x0002
+#define V4L2_FMT_FLAG_COMPRESSED 0x0001
+#define V4L2_FMT_FLAG_EMULATED 0x0002
+#define V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER 0x0004
/* Frame Size and frame rate enumeration */
/*
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 03/14] videodev2.h: add V4L2_FMT_FLAG_DYN_RESOLUTION
2019-07-24 11:10 [PATCH 00/14] Stateful/stateless codec core support Hans Verkuil
2019-07-24 11:10 ` [PATCH 01/14] v4l2-ioctl.c: OR flags in v4l_fill_fmtdesc(), not don't overwrite Hans Verkuil
2019-07-24 11:10 ` [PATCH 02/14] videodev2.h: add V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER Hans Verkuil
@ 2019-07-24 11:10 ` Hans Verkuil
2 siblings, 0 replies; 6+ messages in thread
From: Hans Verkuil @ 2019-07-24 11:10 UTC (permalink / raw)
To: linux-media; +Cc: Maxime Jourdan, Hans Verkuil, Tomasz Figa
From: Maxime Jourdan <mjourdan@baylibre.com>
Add an enum_fmt format flag to specifically tag coded formats where
dynamic resolution switching is supported by the device.
This is useful for some codec drivers that can support dynamic
resolution switching for one or more of their listed coded formats. It
allows userspace to know whether it should extract the video parameters
itself, or if it can rely on the device to send V4L2_EVENT_SOURCE_CHANGE
when such changes are detected.
Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
[hverkuil-cisco@xs4all.nl: added flag to videodev2.h.rst.exceptions]
[hverkuil-cisco@xs4all.nl: updated commit text: 'one or more' instead of 'all']
Acked-by: Tomasz Figa <tfiga@chromium.org>
---
Documentation/media/uapi/v4l/vidioc-enum-fmt.rst | 8 ++++++++
Documentation/media/videodev2.h.rst.exceptions | 1 +
include/uapi/linux/videodev2.h | 1 +
3 files changed, 10 insertions(+)
diff --git a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst
index 4e24e671f32e..05454780cb21 100644
--- a/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst
+++ b/Documentation/media/uapi/v4l/vidioc-enum-fmt.rst
@@ -135,6 +135,14 @@ one until ``EINVAL`` is returned.
frames/fields. This flag can only be used in combination with the
``V4L2_FMT_FLAG_COMPRESSED`` flag, since this applies to compressed
formats only.
+ * - ``V4L2_FMT_FLAG_DYN_RESOLUTION``
+ - 0x0008
+ - Dynamic resolution switching is supported by the device for this
+ compressed bitstream format (aka coded format). It will notify the user
+ via the event ``V4L2_EVENT_SOURCE_CHANGE`` when changes in the video
+ parameters are detected. This flag can only be used in combination
+ with the ``V4L2_FMT_FLAG_COMPRESSED`` flag, since this applies to
+ compressed formats only.
Return Value
diff --git a/Documentation/media/videodev2.h.rst.exceptions b/Documentation/media/videodev2.h.rst.exceptions
index 74fb9f00c12d..0a9a1b386443 100644
--- a/Documentation/media/videodev2.h.rst.exceptions
+++ b/Documentation/media/videodev2.h.rst.exceptions
@@ -181,6 +181,7 @@ replace define V4L2_PIX_FMT_FLAG_PREMUL_ALPHA reserved-formats
replace define V4L2_FMT_FLAG_COMPRESSED fmtdesc-flags
replace define V4L2_FMT_FLAG_EMULATED fmtdesc-flags
replace define V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER fmtdesc-flags
+replace define V4L2_FMT_FLAG_DYN_RESOLUTION fmtdesc-flags
# V4L2 tymecode types
replace define V4L2_TC_TYPE_24FPS timecode-type
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index 8c5a28666b16..ed572b05bd25 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -777,6 +777,7 @@ struct v4l2_fmtdesc {
#define V4L2_FMT_FLAG_COMPRESSED 0x0001
#define V4L2_FMT_FLAG_EMULATED 0x0002
#define V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER 0x0004
+#define V4L2_FMT_FLAG_DYN_RESOLUTION 0x0008
/* Frame Size and frame rate enumeration */
/*
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 00/14] Stateful/stateless codec core support
2019-07-24 11:05 [PATCH 00/14] Stateful/stateless codec core support Hans Verkuil
@ 2019-07-26 9:12 ` Hans Verkuil
0 siblings, 0 replies; 6+ messages in thread
From: Hans Verkuil @ 2019-07-26 9:12 UTC (permalink / raw)
To: linux-media
Cc: Maxime Jourdan, Tomasz Figa, Stanimir Varbanov,
Sylwester Nawrocki, Alexandre Courbot, Maxime Ripard,
Nicolas Dufresne, Paul Kocialkowski, Ezequiel Garcia,
Boris Brezillon, Philipp Zabel
Just a reminder: due to problems with my provider (overly strict spammer
detection) I had to post this series again, this time without any CCs.
So the full series is here:
https://patchwork.linuxtv.org/cover/57699/
Please review. I certainly need help with "pixfmt-compressed.rst:
improve H264/HEVC/MPEG1+2/VP8+9 documentation".
Also, I only added V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER to the s5p-mfc and
vicodec drivers. Please comment if other drivers also support this.
Regards,
Hans
On 7/24/19 1:05 PM, Hans Verkuil wrote:
> This series consolidates various patches/patch series that add
> features or document memory-to-memory video codec interfaces.
>
> This includes patches adding V4L2_FMT_FLAG_DYN_RESOLUTION,
> new code adding V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER, new code
> adding V4L2_DEC_CMD_FLUSH, patches adding V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF
> (now with documentation) and patches documenting the stateful
> encoder/decoder and stateless decoder.
>
> The stateful encoder documentation is still RFC quality (there are
> open TODOs, see https://patchwork.kernel.org/cover/10972783/).
>
> The stateless decoder documentation is the same as the v5 posted
> by Alexandre, but with my comments incorporated.
>
> Also added are updated pixelformat descriptions. Please review this!
> I didn't update the MPEG4 format since I'm not sure what to put there.
>
> If anyone has access to recent codec standards, then I would really
> like to have the right references to 'MPEG Picture' and 'Access Unit'.
> It would be good to just refer to the definition of what a Picture
> or Access Unit is in the right standards.
>
> Changes for the stateful decoder documentation since v4:
>
> - In the Decoding section change "multiple ``OUTPUT`` buffers generate
> one ``CAPTURE`` buffer: timestamp of the ``OUTPUT`` buffer queued last
> will be copied." to "queued first" since this corresponds to
> existing implementations.
>
> - Document that width and height are required fields in step 4 of the
> Capture Setup.
>
> - Mention the new ENUM_FMT flags.
>
> Changes for the stateless decoder documentation since v5:
>
> - Document that width and height are required fields in step 4 of the
> Capture Setup.
>
> - Mention the new V4L2_DEC_CMD_FLUSH command to flush the last held
> capture buffer. This replaces the 'queue an empty buffer' solution.
>
> In my view this series is ready to go in, except for the last patch
> (stateful encoder).
>
> Maxime, I didn't add the proposed V4L2_FMT_FLAG_MANUAL_RESOLUTION
> flag since I think that can go in separately. I also am not 100%
> happy with that name, although I can't think of a better one.
>
> Regards,
>
> Hans
>
> Alexandre Courbot (1):
> media: docs-rst: Document m2m stateless video decoder interface
>
> Hans Verkuil (6):
> v4l2-ioctl.c: OR flags in v4l_fill_fmtdesc(), not don't overwrite
> videodev2.h: add V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER
> videodev2.h.rst.exceptions: tymecode -> timecode
> vb2: add V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF
> videodev2.h: add V4L2_DEC_CMD_FLUSH
> pixfmt-compressed.rst: improve H264/HEVC/MPEG1+2/VP8+9 documentation
>
> Maxime Jourdan (5):
> videodev2.h: add V4L2_FMT_FLAG_DYN_RESOLUTION
> media: venus: vdec: flag OUTPUT formats with
> V4L2_FMT_FLAG_DYN_RESOLUTION
> media: s5p_mfc_dec: set flags for OUTPUT coded formats
> media: mtk-vcodec: flag OUTPUT formats with
> V4L2_FMT_FLAG_DYN_RESOLUTION
> media: vicodec: set flags for vdec/stateful OUTPUT coded formats
>
> Tomasz Figa (2):
> media: docs-rst: Document memory-to-memory video decoder interface
> media: docs-rst: Document memory-to-memory video encoder interface
>
> Documentation/media/uapi/v4l/buffer.rst | 13 +
> Documentation/media/uapi/v4l/dev-decoder.rst | 1101 +++++++++++++++++
> Documentation/media/uapi/v4l/dev-encoder.rst | 608 +++++++++
> Documentation/media/uapi/v4l/dev-mem2mem.rst | 10 +-
> .../media/uapi/v4l/dev-stateless-decoder.rst | 424 +++++++
> .../media/uapi/v4l/pixfmt-compressed.rst | 36 +-
> Documentation/media/uapi/v4l/pixfmt-v4l2.rst | 10 +
> Documentation/media/uapi/v4l/v4l2.rst | 12 +-
> .../media/uapi/v4l/vidioc-decoder-cmd.rst | 52 +-
> .../media/uapi/v4l/vidioc-dqevent.rst | 11 +-
> .../media/uapi/v4l/vidioc-encoder-cmd.rst | 51 +-
> .../media/uapi/v4l/vidioc-enum-fmt.rst | 16 +
> .../media/uapi/v4l/vidioc-reqbufs.rst | 6 +
> .../media/videodev2.h.rst.exceptions | 7 +-
> .../media/common/videobuf2/videobuf2-v4l2.c | 8 +-
> .../platform/mtk-vcodec/mtk_vcodec_dec.c | 4 +
> .../platform/mtk-vcodec/mtk_vcodec_drv.h | 1 +
> drivers/media/platform/qcom/venus/core.h | 1 +
> drivers/media/platform/qcom/venus/vdec.c | 11 +
> .../media/platform/s5p-mfc/s5p_mfc_common.h | 1 +
> drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 18 +
> drivers/media/platform/vicodec/vicodec-core.c | 3 +
> drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
> include/media/v4l2-mem2mem.h | 42 +
> include/media/videobuf2-core.h | 3 +
> include/media/videobuf2-v4l2.h | 5 +
> include/uapi/linux/videodev2.h | 20 +-
> 27 files changed, 2419 insertions(+), 57 deletions(-)
> create mode 100644 Documentation/media/uapi/v4l/dev-decoder.rst
> create mode 100644 Documentation/media/uapi/v4l/dev-encoder.rst
> create mode 100644 Documentation/media/uapi/v4l/dev-stateless-decoder.rst
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 00/14] Stateful/stateless codec core support
@ 2019-07-24 11:05 Hans Verkuil
2019-07-26 9:12 ` Hans Verkuil
0 siblings, 1 reply; 6+ messages in thread
From: Hans Verkuil @ 2019-07-24 11:05 UTC (permalink / raw)
To: linux-media
Cc: Maxime Jourdan, Tomasz Figa, Stanimir Varbanov,
Sylwester Nawrocki, Alexandre Courbot, Maxime Ripard,
Nicolas Dufresne, Paul Kocialkowski, Ezequiel Garcia,
Boris Brezillon, Philipp Zabel
This series consolidates various patches/patch series that add
features or document memory-to-memory video codec interfaces.
This includes patches adding V4L2_FMT_FLAG_DYN_RESOLUTION,
new code adding V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER, new code
adding V4L2_DEC_CMD_FLUSH, patches adding V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF
(now with documentation) and patches documenting the stateful
encoder/decoder and stateless decoder.
The stateful encoder documentation is still RFC quality (there are
open TODOs, see https://patchwork.kernel.org/cover/10972783/).
The stateless decoder documentation is the same as the v5 posted
by Alexandre, but with my comments incorporated.
Also added are updated pixelformat descriptions. Please review this!
I didn't update the MPEG4 format since I'm not sure what to put there.
If anyone has access to recent codec standards, then I would really
like to have the right references to 'MPEG Picture' and 'Access Unit'.
It would be good to just refer to the definition of what a Picture
or Access Unit is in the right standards.
Changes for the stateful decoder documentation since v4:
- In the Decoding section change "multiple ``OUTPUT`` buffers generate
one ``CAPTURE`` buffer: timestamp of the ``OUTPUT`` buffer queued last
will be copied." to "queued first" since this corresponds to
existing implementations.
- Document that width and height are required fields in step 4 of the
Capture Setup.
- Mention the new ENUM_FMT flags.
Changes for the stateless decoder documentation since v5:
- Document that width and height are required fields in step 4 of the
Capture Setup.
- Mention the new V4L2_DEC_CMD_FLUSH command to flush the last held
capture buffer. This replaces the 'queue an empty buffer' solution.
In my view this series is ready to go in, except for the last patch
(stateful encoder).
Maxime, I didn't add the proposed V4L2_FMT_FLAG_MANUAL_RESOLUTION
flag since I think that can go in separately. I also am not 100%
happy with that name, although I can't think of a better one.
Regards,
Hans
Alexandre Courbot (1):
media: docs-rst: Document m2m stateless video decoder interface
Hans Verkuil (6):
v4l2-ioctl.c: OR flags in v4l_fill_fmtdesc(), not don't overwrite
videodev2.h: add V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER
videodev2.h.rst.exceptions: tymecode -> timecode
vb2: add V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF
videodev2.h: add V4L2_DEC_CMD_FLUSH
pixfmt-compressed.rst: improve H264/HEVC/MPEG1+2/VP8+9 documentation
Maxime Jourdan (5):
videodev2.h: add V4L2_FMT_FLAG_DYN_RESOLUTION
media: venus: vdec: flag OUTPUT formats with
V4L2_FMT_FLAG_DYN_RESOLUTION
media: s5p_mfc_dec: set flags for OUTPUT coded formats
media: mtk-vcodec: flag OUTPUT formats with
V4L2_FMT_FLAG_DYN_RESOLUTION
media: vicodec: set flags for vdec/stateful OUTPUT coded formats
Tomasz Figa (2):
media: docs-rst: Document memory-to-memory video decoder interface
media: docs-rst: Document memory-to-memory video encoder interface
Documentation/media/uapi/v4l/buffer.rst | 13 +
Documentation/media/uapi/v4l/dev-decoder.rst | 1101 +++++++++++++++++
Documentation/media/uapi/v4l/dev-encoder.rst | 608 +++++++++
Documentation/media/uapi/v4l/dev-mem2mem.rst | 10 +-
.../media/uapi/v4l/dev-stateless-decoder.rst | 424 +++++++
.../media/uapi/v4l/pixfmt-compressed.rst | 36 +-
Documentation/media/uapi/v4l/pixfmt-v4l2.rst | 10 +
Documentation/media/uapi/v4l/v4l2.rst | 12 +-
.../media/uapi/v4l/vidioc-decoder-cmd.rst | 52 +-
.../media/uapi/v4l/vidioc-dqevent.rst | 11 +-
.../media/uapi/v4l/vidioc-encoder-cmd.rst | 51 +-
.../media/uapi/v4l/vidioc-enum-fmt.rst | 16 +
.../media/uapi/v4l/vidioc-reqbufs.rst | 6 +
.../media/videodev2.h.rst.exceptions | 7 +-
.../media/common/videobuf2/videobuf2-v4l2.c | 8 +-
.../platform/mtk-vcodec/mtk_vcodec_dec.c | 4 +
.../platform/mtk-vcodec/mtk_vcodec_drv.h | 1 +
drivers/media/platform/qcom/venus/core.h | 1 +
drivers/media/platform/qcom/venus/vdec.c | 11 +
.../media/platform/s5p-mfc/s5p_mfc_common.h | 1 +
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 18 +
drivers/media/platform/vicodec/vicodec-core.c | 3 +
drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
include/media/v4l2-mem2mem.h | 42 +
include/media/videobuf2-core.h | 3 +
include/media/videobuf2-v4l2.h | 5 +
include/uapi/linux/videodev2.h | 20 +-
27 files changed, 2419 insertions(+), 57 deletions(-)
create mode 100644 Documentation/media/uapi/v4l/dev-decoder.rst
create mode 100644 Documentation/media/uapi/v4l/dev-encoder.rst
create mode 100644 Documentation/media/uapi/v4l/dev-stateless-decoder.rst
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-26 9:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-24 11:10 [PATCH 00/14] Stateful/stateless codec core support Hans Verkuil
2019-07-24 11:10 ` [PATCH 01/14] v4l2-ioctl.c: OR flags in v4l_fill_fmtdesc(), not don't overwrite Hans Verkuil
2019-07-24 11:10 ` [PATCH 02/14] videodev2.h: add V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER Hans Verkuil
2019-07-24 11:10 ` [PATCH 03/14] videodev2.h: add V4L2_FMT_FLAG_DYN_RESOLUTION Hans Verkuil
-- strict thread matches above, loose matches on Subject: below --
2019-07-24 11:05 [PATCH 00/14] Stateful/stateless codec core support Hans Verkuil
2019-07-26 9:12 ` Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.