All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jernej Skrabec <jernej.skrabec@siol.net>
To: thierry.reding@gmail.com, mripard@kernel.org, wens@csie.org
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
	linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: [PATCH 2/6] pwm: sun4i: Add a quirk for reset line
Date: Fri, 26 Jul 2019 20:40:41 +0200	[thread overview]
Message-ID: <20190726184045.14669-3-jernej.skrabec@siol.net> (raw)
In-Reply-To: <20190726184045.14669-1-jernej.skrabec@siol.net>

H6 PWM core needs deasserted reset line in order to work.

Add a quirk for it.

Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
---
 drivers/pwm/pwm-sun4i.c | 27 +++++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
index de78c824bbfd..1b7be8fbde86 100644
--- a/drivers/pwm/pwm-sun4i.c
+++ b/drivers/pwm/pwm-sun4i.c
@@ -16,6 +16,7 @@
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/pwm.h>
+#include <linux/reset.h>
 #include <linux/slab.h>
 #include <linux/spinlock.h>
 #include <linux/time.h>
@@ -72,12 +73,14 @@ static const u32 prescaler_table[] = {
 
 struct sun4i_pwm_data {
 	bool has_prescaler_bypass;
+	bool has_reset;
 	unsigned int npwm;
 };
 
 struct sun4i_pwm_chip {
 	struct pwm_chip chip;
 	struct clk *clk;
+	struct reset_control *rst;
 	void __iomem *base;
 	spinlock_t ctrl_lock;
 	const struct sun4i_pwm_data *data;
@@ -371,6 +374,14 @@ static int sun4i_pwm_probe(struct platform_device *pdev)
 	if (IS_ERR(pwm->clk))
 		return PTR_ERR(pwm->clk);
 
+	if (pwm->data->has_reset) {
+		pwm->rst = devm_reset_control_get(&pdev->dev, NULL);
+		if (IS_ERR(pwm->rst))
+			return PTR_ERR(pwm->rst);
+
+		reset_control_deassert(pwm->rst);
+	}
+
 	pwm->chip.dev = &pdev->dev;
 	pwm->chip.ops = &sun4i_pwm_ops;
 	pwm->chip.base = -1;
@@ -383,19 +394,31 @@ static int sun4i_pwm_probe(struct platform_device *pdev)
 	ret = pwmchip_add(&pwm->chip);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret);
-		return ret;
+		goto err_pwm_add;
 	}
 
 	platform_set_drvdata(pdev, pwm);
 
 	return 0;
+
+err_pwm_add:
+	reset_control_assert(pwm->rst);
+
+	return ret;
 }
 
 static int sun4i_pwm_remove(struct platform_device *pdev)
 {
 	struct sun4i_pwm_chip *pwm = platform_get_drvdata(pdev);
+	int ret;
+
+	ret = pwmchip_remove(&pwm->chip);
+	if (ret)
+		return ret;
 
-	return pwmchip_remove(&pwm->chip);
+	reset_control_assert(pwm->rst);
+
+	return 0;
 }
 
 static struct platform_driver sun4i_pwm_driver = {
-- 
2.22.0


WARNING: multiple messages have this Message-ID (diff)
From: Jernej Skrabec <jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
To: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	mripard-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	wens-jdAy2FN1RRM@public.gmane.org
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: [PATCH 2/6] pwm: sun4i: Add a quirk for reset line
Date: Fri, 26 Jul 2019 20:40:41 +0200	[thread overview]
Message-ID: <20190726184045.14669-3-jernej.skrabec@siol.net> (raw)
In-Reply-To: <20190726184045.14669-1-jernej.skrabec-gGgVlfcn5nU@public.gmane.org>

H6 PWM core needs deasserted reset line in order to work.

Add a quirk for it.

Signed-off-by: Jernej Skrabec <jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
---
 drivers/pwm/pwm-sun4i.c | 27 +++++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
index de78c824bbfd..1b7be8fbde86 100644
--- a/drivers/pwm/pwm-sun4i.c
+++ b/drivers/pwm/pwm-sun4i.c
@@ -16,6 +16,7 @@
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/pwm.h>
+#include <linux/reset.h>
 #include <linux/slab.h>
 #include <linux/spinlock.h>
 #include <linux/time.h>
@@ -72,12 +73,14 @@ static const u32 prescaler_table[] = {
 
 struct sun4i_pwm_data {
 	bool has_prescaler_bypass;
+	bool has_reset;
 	unsigned int npwm;
 };
 
 struct sun4i_pwm_chip {
 	struct pwm_chip chip;
 	struct clk *clk;
+	struct reset_control *rst;
 	void __iomem *base;
 	spinlock_t ctrl_lock;
 	const struct sun4i_pwm_data *data;
@@ -371,6 +374,14 @@ static int sun4i_pwm_probe(struct platform_device *pdev)
 	if (IS_ERR(pwm->clk))
 		return PTR_ERR(pwm->clk);
 
+	if (pwm->data->has_reset) {
+		pwm->rst = devm_reset_control_get(&pdev->dev, NULL);
+		if (IS_ERR(pwm->rst))
+			return PTR_ERR(pwm->rst);
+
+		reset_control_deassert(pwm->rst);
+	}
+
 	pwm->chip.dev = &pdev->dev;
 	pwm->chip.ops = &sun4i_pwm_ops;
 	pwm->chip.base = -1;
@@ -383,19 +394,31 @@ static int sun4i_pwm_probe(struct platform_device *pdev)
 	ret = pwmchip_add(&pwm->chip);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret);
-		return ret;
+		goto err_pwm_add;
 	}
 
 	platform_set_drvdata(pdev, pwm);
 
 	return 0;
+
+err_pwm_add:
+	reset_control_assert(pwm->rst);
+
+	return ret;
 }
 
 static int sun4i_pwm_remove(struct platform_device *pdev)
 {
 	struct sun4i_pwm_chip *pwm = platform_get_drvdata(pdev);
+	int ret;
+
+	ret = pwmchip_remove(&pwm->chip);
+	if (ret)
+		return ret;
 
-	return pwmchip_remove(&pwm->chip);
+	reset_control_assert(pwm->rst);
+
+	return 0;
 }
 
 static struct platform_driver sun4i_pwm_driver = {
-- 
2.22.0

WARNING: multiple messages have this Message-ID (diff)
From: Jernej Skrabec <jernej.skrabec@siol.net>
To: thierry.reding@gmail.com, mripard@kernel.org, wens@csie.org
Cc: mark.rutland@arm.com, linux-pwm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-sunxi@googlegroups.com, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] pwm: sun4i: Add a quirk for reset line
Date: Fri, 26 Jul 2019 20:40:41 +0200	[thread overview]
Message-ID: <20190726184045.14669-3-jernej.skrabec@siol.net> (raw)
In-Reply-To: <20190726184045.14669-1-jernej.skrabec@siol.net>

H6 PWM core needs deasserted reset line in order to work.

Add a quirk for it.

Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
---
 drivers/pwm/pwm-sun4i.c | 27 +++++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
index de78c824bbfd..1b7be8fbde86 100644
--- a/drivers/pwm/pwm-sun4i.c
+++ b/drivers/pwm/pwm-sun4i.c
@@ -16,6 +16,7 @@
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/pwm.h>
+#include <linux/reset.h>
 #include <linux/slab.h>
 #include <linux/spinlock.h>
 #include <linux/time.h>
@@ -72,12 +73,14 @@ static const u32 prescaler_table[] = {
 
 struct sun4i_pwm_data {
 	bool has_prescaler_bypass;
+	bool has_reset;
 	unsigned int npwm;
 };
 
 struct sun4i_pwm_chip {
 	struct pwm_chip chip;
 	struct clk *clk;
+	struct reset_control *rst;
 	void __iomem *base;
 	spinlock_t ctrl_lock;
 	const struct sun4i_pwm_data *data;
@@ -371,6 +374,14 @@ static int sun4i_pwm_probe(struct platform_device *pdev)
 	if (IS_ERR(pwm->clk))
 		return PTR_ERR(pwm->clk);
 
+	if (pwm->data->has_reset) {
+		pwm->rst = devm_reset_control_get(&pdev->dev, NULL);
+		if (IS_ERR(pwm->rst))
+			return PTR_ERR(pwm->rst);
+
+		reset_control_deassert(pwm->rst);
+	}
+
 	pwm->chip.dev = &pdev->dev;
 	pwm->chip.ops = &sun4i_pwm_ops;
 	pwm->chip.base = -1;
@@ -383,19 +394,31 @@ static int sun4i_pwm_probe(struct platform_device *pdev)
 	ret = pwmchip_add(&pwm->chip);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret);
-		return ret;
+		goto err_pwm_add;
 	}
 
 	platform_set_drvdata(pdev, pwm);
 
 	return 0;
+
+err_pwm_add:
+	reset_control_assert(pwm->rst);
+
+	return ret;
 }
 
 static int sun4i_pwm_remove(struct platform_device *pdev)
 {
 	struct sun4i_pwm_chip *pwm = platform_get_drvdata(pdev);
+	int ret;
+
+	ret = pwmchip_remove(&pwm->chip);
+	if (ret)
+		return ret;
 
-	return pwmchip_remove(&pwm->chip);
+	reset_control_assert(pwm->rst);
+
+	return 0;
 }
 
 static struct platform_driver sun4i_pwm_driver = {
-- 
2.22.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-07-26 18:41 UTC|newest]

Thread overview: 128+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-26 18:40 [PATCH 0/6] pwm: sun4i: Add support for Allwinner H6 Jernej Skrabec
2019-07-26 18:40 ` Jernej Skrabec
2019-07-26 18:40 ` Jernej Skrabec
2019-07-26 18:40 ` [PATCH 1/6] dt-bindings: pwm: allwinner: Add H6 PWM description Jernej Skrabec
2019-07-26 18:40   ` Jernej Skrabec
2019-07-27 10:42   ` Maxime Ripard
2019-07-27 10:42     ` Maxime Ripard
2019-07-27 10:42     ` Maxime Ripard
2019-07-26 18:40 ` Jernej Skrabec [this message]
2019-07-26 18:40   ` [PATCH 2/6] pwm: sun4i: Add a quirk for reset line Jernej Skrabec
2019-07-26 18:40   ` Jernej Skrabec
2019-07-27 10:42   ` Maxime Ripard
2019-07-27 10:42     ` Maxime Ripard
2019-07-29  6:36   ` Uwe Kleine-König
2019-07-29  6:36     ` Uwe Kleine-König
2019-07-29  6:36     ` Uwe Kleine-König
2019-07-29  6:43     ` Chen-Yu Tsai
2019-07-29  6:43       ` Chen-Yu Tsai
2019-07-29  6:43       ` Chen-Yu Tsai
2019-07-29  7:12       ` Uwe Kleine-König
2019-07-29  7:12         ` Uwe Kleine-König
2019-07-29  7:12         ` Uwe Kleine-König
2019-07-29 10:18         ` Philipp Zabel
2019-07-29 10:18           ` Philipp Zabel
2019-07-29 16:37         ` Maxime Ripard
2019-07-29 16:37           ` Maxime Ripard
2019-07-29 18:20           ` Uwe Kleine-König
2019-07-29 18:20             ` Uwe Kleine-König
2019-07-29 18:20             ` Uwe Kleine-König
2019-07-26 18:40 ` [PATCH 3/6] pwm: sun4i: Add a quirk for bus clock Jernej Skrabec
2019-07-26 18:40   ` Jernej Skrabec
2019-07-26 18:40   ` Jernej Skrabec
2019-07-27 10:46   ` Maxime Ripard
2019-07-27 10:46     ` Maxime Ripard
2019-07-27 14:15     ` Jernej Škrabec
2019-07-27 14:15       ` Jernej Škrabec
2019-07-27 14:15       ` Jernej Škrabec
2019-07-27 14:27     ` Chen-Yu Tsai
2019-07-27 14:27       ` Chen-Yu Tsai
2019-07-27 14:27       ` Chen-Yu Tsai
2019-07-29  6:38   ` Uwe Kleine-König
2019-07-29  6:38     ` Uwe Kleine-König
2019-07-29 15:48     ` Jernej Škrabec
2019-07-29 15:48       ` Jernej Škrabec
2019-07-29 15:48       ` Jernej Škrabec
2019-07-29 16:14       ` Uwe Kleine-König
2019-07-29 16:14         ` Uwe Kleine-König
2019-07-29 16:14         ` Uwe Kleine-König
2019-07-29 16:45         ` Maxime Ripard
2019-07-29 16:45           ` Maxime Ripard
2019-07-29 19:04           ` Uwe Kleine-König
2019-07-29 19:04             ` Uwe Kleine-König
2019-07-29 19:04             ` Uwe Kleine-König
2019-07-26 18:40 ` [PATCH 4/6] pwm: sun4i: Add support for H6 PWM Jernej Skrabec
2019-07-26 18:40   ` Jernej Skrabec
2019-07-26 18:40   ` Jernej Skrabec
2019-07-29  6:40   ` Uwe Kleine-König
2019-07-29  6:40     ` Uwe Kleine-König
2019-07-29  6:40     ` Uwe Kleine-König
2019-07-29 15:55     ` Jernej Škrabec
2019-07-29 15:55       ` Jernej Škrabec
2019-07-29 15:55       ` Jernej Škrabec
2019-07-29 16:07       ` Uwe Kleine-König
2019-07-29 16:07         ` Uwe Kleine-König
2019-07-29 16:07         ` Uwe Kleine-König
2019-07-29 16:09         ` [linux-sunxi] " Chen-Yu Tsai
2019-07-29 16:09           ` Chen-Yu Tsai
2019-07-29 16:24           ` Uwe Kleine-König
2019-07-29 16:24             ` Uwe Kleine-König
2019-07-29 16:24             ` Uwe Kleine-König
2019-07-29 16:24             ` Uwe Kleine-König
2019-07-29 16:40             ` [linux-sunxi] " Jernej Škrabec
2019-07-29 16:40               ` Jernej Škrabec
2019-07-29 16:40               ` Jernej Škrabec
2019-07-29 18:40               ` [linux-sunxi] " Uwe Kleine-König
2019-07-29 18:40                 ` Uwe Kleine-König
2019-07-29 18:40                 ` Uwe Kleine-König
2019-07-29 18:46                 ` [linux-sunxi] " Jernej Škrabec
2019-07-29 18:46                   ` Jernej Škrabec
2019-07-29 18:46                   ` Jernej Škrabec
2019-07-29 18:51                   ` [linux-sunxi] " Uwe Kleine-König
2019-07-29 18:51                     ` Uwe Kleine-König
2019-07-29 18:51                     ` Uwe Kleine-König
2019-07-29 22:04                     ` [linux-sunxi] " Jernej Škrabec
2019-07-29 22:04                       ` Jernej Škrabec
2019-07-29 22:04                       ` Jernej Škrabec
2019-07-30  8:09                       ` [linux-sunxi] " Uwe Kleine-König
2019-07-30  8:09                         ` Uwe Kleine-König
2019-07-30  8:09                         ` Uwe Kleine-König
2019-07-30  8:32                         ` [linux-sunxi] " Chen-Yu Tsai
2019-07-30  8:32                           ` Chen-Yu Tsai
2019-07-30  8:32                           ` Chen-Yu Tsai
2019-07-30 17:06                         ` [linux-sunxi] " Maxime Ripard
2019-07-30 17:06                           ` Maxime Ripard
2019-07-31  6:52                           ` Uwe Kleine-König
2019-07-31  6:52                             ` Uwe Kleine-König
2019-07-31  6:52                             ` Uwe Kleine-König
2019-08-12  9:56                             ` [linux-sunxi] " Maxime Ripard
2019-08-12  9:56                               ` Maxime Ripard
2019-08-12 10:47                               ` Uwe Kleine-König
2019-08-12 10:47                                 ` Uwe Kleine-König
2019-08-12 10:47                                 ` Uwe Kleine-König
2019-08-12 10:51                                 ` [linux-sunxi] " Jernej Škrabec
2019-08-12 10:51                                   ` Jernej Škrabec
2019-08-12 10:51                                   ` Jernej Škrabec
2019-07-26 18:40 ` [PATCH 5/6] pwm: sun4i: Add support to output source clock directly Jernej Skrabec
2019-07-26 18:40   ` Jernej Skrabec
2019-07-26 18:40   ` Jernej Skrabec
2019-07-27 10:50   ` Maxime Ripard
2019-07-27 10:50     ` Maxime Ripard
2019-07-27 14:28     ` Jernej Škrabec
2019-07-27 14:28       ` Jernej Škrabec
2019-07-27 14:28       ` Jernej Škrabec
2019-07-27 14:54       ` [linux-sunxi] " Chen-Yu Tsai
2019-07-27 14:54         ` Chen-Yu Tsai
2019-07-27 14:54         ` Chen-Yu Tsai
2019-07-29  7:06   ` Uwe Kleine-König
2019-07-29  7:06     ` Uwe Kleine-König
2019-07-29  7:06     ` Uwe Kleine-König
2019-07-29 16:16     ` Jernej Škrabec
2019-07-29 16:16       ` Jernej Škrabec
2019-07-29 16:16       ` Jernej Škrabec
2019-07-29 16:29       ` Uwe Kleine-König
2019-07-29 16:29         ` Uwe Kleine-König
2019-07-26 18:40 ` [PATCH 6/6] arm64: dts: allwinner: h6: Add PWM node Jernej Skrabec
2019-07-26 18:40   ` Jernej Skrabec
2019-07-27 10:51   ` Maxime Ripard
2019-07-27 10:51     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190726184045.14669-3-jernej.skrabec@siol.net \
    --to=jernej.skrabec@siol.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mark.rutland@arm.com \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.