* [PATCH iproute2 0/1] Fix s64 argument parsing
@ 2019-07-04 12:24 Kurt Kanzenbach
2019-07-04 12:24 ` [PATCH iproute2 1/1] utils: Fix get_s64() function Kurt Kanzenbach
2019-07-29 11:04 ` [PATCH iproute2 0/1] Fix s64 argument parsing Kurt Kanzenbach
0 siblings, 2 replies; 4+ messages in thread
From: Kurt Kanzenbach @ 2019-07-04 12:24 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, Kurt Kanzenbach
Hi,
while using the TAPRIO Qdisc on ARM32 I've noticed that the base_time parameter is
incorrectly configured. The problem is the utility function get_s64() used by
TAPRIO doesn't parse the value correctly.
Thanks,
Kurt
Kurt Kanzenbach (1):
utils: Fix get_s64() function
lib/utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH iproute2 1/1] utils: Fix get_s64() function
2019-07-04 12:24 [PATCH iproute2 0/1] Fix s64 argument parsing Kurt Kanzenbach
@ 2019-07-04 12:24 ` Kurt Kanzenbach
2019-07-29 11:04 ` [PATCH iproute2 0/1] Fix s64 argument parsing Kurt Kanzenbach
1 sibling, 0 replies; 4+ messages in thread
From: Kurt Kanzenbach @ 2019-07-04 12:24 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, Kurt Kanzenbach
get_s64() uses internally strtoll() to parse the value out of a given
string. strtoll() returns a long long. However, the intermediate variable is
long only which might be 32 bit on some systems. So, fix it.
Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
---
lib/utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/utils.c b/lib/utils.c
index be0f11b00280..9c3702fd4a04 100644
--- a/lib/utils.c
+++ b/lib/utils.c
@@ -390,7 +390,7 @@ int get_u8(__u8 *val, const char *arg, int base)
int get_s64(__s64 *val, const char *arg, int base)
{
- long res;
+ long long res;
char *ptr;
errno = 0;
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH iproute2 0/1] Fix s64 argument parsing
2019-07-04 12:24 [PATCH iproute2 0/1] Fix s64 argument parsing Kurt Kanzenbach
2019-07-04 12:24 ` [PATCH iproute2 1/1] utils: Fix get_s64() function Kurt Kanzenbach
@ 2019-07-29 11:04 ` Kurt Kanzenbach
2019-07-29 15:51 ` Stephen Hemminger
1 sibling, 1 reply; 4+ messages in thread
From: Kurt Kanzenbach @ 2019-07-29 11:04 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 466 bytes --]
On Thu, Jul 04, 2019 at 02:24:26PM +0200, Kurt Kanzenbach wrote:
> Hi,
>
> while using the TAPRIO Qdisc on ARM32 I've noticed that the base_time parameter is
> incorrectly configured. The problem is the utility function get_s64() used by
> TAPRIO doesn't parse the value correctly.
polite ping.
>
> Thanks,
> Kurt
>
> Kurt Kanzenbach (1):
> utils: Fix get_s64() function
>
> lib/utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.11.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH iproute2 0/1] Fix s64 argument parsing
2019-07-29 11:04 ` [PATCH iproute2 0/1] Fix s64 argument parsing Kurt Kanzenbach
@ 2019-07-29 15:51 ` Stephen Hemminger
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2019-07-29 15:51 UTC (permalink / raw)
To: Kurt Kanzenbach; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 692 bytes --]
On Mon, 29 Jul 2019 13:04:09 +0200
Kurt Kanzenbach <kurt.kanzenbach@linutronix.de> wrote:
> On Thu, Jul 04, 2019 at 02:24:26PM +0200, Kurt Kanzenbach wrote:
> > Hi,
> >
> > while using the TAPRIO Qdisc on ARM32 I've noticed that the base_time parameter is
> > incorrectly configured. The problem is the utility function get_s64() used by
> > TAPRIO doesn't parse the value correctly.
>
> polite ping.
>
> >
> > Thanks,
> > Kurt
> >
> > Kurt Kanzenbach (1):
> > utils: Fix get_s64() function
> >
> > lib/utils.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --
> > 2.11.0
> >
Not sure why this got marked "Changes Requested"
Applied.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-29 15:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-04 12:24 [PATCH iproute2 0/1] Fix s64 argument parsing Kurt Kanzenbach
2019-07-04 12:24 ` [PATCH iproute2 1/1] utils: Fix get_s64() function Kurt Kanzenbach
2019-07-29 11:04 ` [PATCH iproute2 0/1] Fix s64 argument parsing Kurt Kanzenbach
2019-07-29 15:51 ` Stephen Hemminger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.