From: Kees Cook <keescook@chromium.org> To: "Gustavo A. R. Silva" <gustavo@embeddedor.com> Cc: Michael Cyr <mikecyr@linux.ibm.com>, "James E.J. Bottomley" <jejb@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Rothwell <sfr@canb.auug.org.au> Subject: Re: [PATCH] scsi: ibmvscsi_tgt: Mark expected switch fall-throughs Date: Mon, 29 Jul 2019 09:46:12 -0700 [thread overview] Message-ID: <201907290946.C8FFE767@keescook> (raw) In-Reply-To: <20190729112902.GA3768@embeddedor> On Mon, Jul 29, 2019 at 06:29:02AM -0500, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings (Building: powerpc allyesconfig): > > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_adapter_info': > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:1582:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (connection_broken(vscsi)) > ^ > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:1584:2: note: here > default: > ^~~~~~~ > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_ping_response': > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:2494:16: warning: this statement may fall through [-Wimplicit-fallthrough=] > vscsi->flags |= CLIENT_FAILED; > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:2495:2: note: here > case H_DROPPED: > ^~~~ > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:2496:16: warning: this statement may fall through [-Wimplicit-fallthrough=] > vscsi->flags |= RESPONSE_Q_DOWN; > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:2497:2: note: here > case H_REMOTE_PARM: > ^~~~ > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Reviewed-by: Kees Cook <keescook@chromium.org> -Kees > --- > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > index 7f9535392a93..a929fe76102b 100644 > --- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > +++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > @@ -1581,6 +1581,7 @@ static long ibmvscsis_adapter_info(struct scsi_info *vscsi, > case H_PERMISSION: > if (connection_broken(vscsi)) > flag_bits = (RESPONSE_Q_DOWN | CLIENT_FAILED); > + /* Fall through */ > default: > dev_err(&vscsi->dev, "adapter_info: h_copy_rdma to client failed, rc %ld\n", > rc); > @@ -2492,8 +2493,10 @@ static long ibmvscsis_ping_response(struct scsi_info *vscsi) > break; > case H_CLOSED: > vscsi->flags |= CLIENT_FAILED; > + /* Fall through */ > case H_DROPPED: > vscsi->flags |= RESPONSE_Q_DOWN; > + /* Fall through */ > case H_REMOTE_PARM: > dev_err(&vscsi->dev, "ping_response: h_send_crq failed, rc %ld\n", > rc); > -- > 2.22.0 > -- Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org> To: "Gustavo A. R. Silva" <gustavo@embeddedor.com> Cc: Michael Cyr <mikecyr@linux.ibm.com>, "James E.J. Bottomley" <jejb@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Rothwell <sfr@canb.auug.org.au> Subject: Re: [PATCH] scsi: ibmvscsi_tgt: Mark expected switch fall-throughs Date: Mon, 29 Jul 2019 16:46:12 +0000 [thread overview] Message-ID: <201907290946.C8FFE767@keescook> (raw) In-Reply-To: <20190729112902.GA3768@embeddedor> On Mon, Jul 29, 2019 at 06:29:02AM -0500, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings (Building: powerpc allyesconfig): > > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_adapter_info': > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:1582:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (connection_broken(vscsi)) > ^ > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:1584:2: note: here > default: > ^~~~~~~ > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_ping_response': > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:2494:16: warning: this statement may fall through [-Wimplicit-fallthrough=] > vscsi->flags |= CLIENT_FAILED; > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:2495:2: note: here > case H_DROPPED: > ^~~~ > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:2496:16: warning: this statement may fall through [-Wimplicit-fallthrough=] > vscsi->flags |= RESPONSE_Q_DOWN; > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:2497:2: note: here > case H_REMOTE_PARM: > ^~~~ > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Reviewed-by: Kees Cook <keescook@chromium.org> -Kees > --- > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > index 7f9535392a93..a929fe76102b 100644 > --- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > +++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > @@ -1581,6 +1581,7 @@ static long ibmvscsis_adapter_info(struct scsi_info *vscsi, > case H_PERMISSION: > if (connection_broken(vscsi)) > flag_bits = (RESPONSE_Q_DOWN | CLIENT_FAILED); > + /* Fall through */ > default: > dev_err(&vscsi->dev, "adapter_info: h_copy_rdma to client failed, rc %ld\n", > rc); > @@ -2492,8 +2493,10 @@ static long ibmvscsis_ping_response(struct scsi_info *vscsi) > break; > case H_CLOSED: > vscsi->flags |= CLIENT_FAILED; > + /* Fall through */ > case H_DROPPED: > vscsi->flags |= RESPONSE_Q_DOWN; > + /* Fall through */ > case H_REMOTE_PARM: > dev_err(&vscsi->dev, "ping_response: h_send_crq failed, rc %ld\n", > rc); > -- > 2.22.0 > -- Kees Cook
next prev parent reply other threads:[~2019-07-29 16:46 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-29 11:29 [PATCH] scsi: ibmvscsi_tgt: Mark expected switch fall-throughs Gustavo A. R. Silva 2019-07-29 11:29 ` Gustavo A. R. Silva 2019-07-29 16:46 ` Kees Cook [this message] 2019-07-29 16:46 ` Kees Cook 2019-07-29 18:18 ` Ly, Bryant 2019-07-30 20:00 ` Martin K. Petersen 2019-07-30 20:00 ` Martin K. Petersen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201907290946.C8FFE767@keescook \ --to=keescook@chromium.org \ --cc=gustavo@embeddedor.com \ --cc=jejb@linux.ibm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=mikecyr@linux.ibm.com \ --cc=sfr@canb.auug.org.au \ --cc=target-devel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.