* [igt-dev] [PATCH i-g-t v1] igt/lib: Start using x and y params for gpu walk
@ 2019-07-29 14:15 Stanislav Lisovskiy
2019-07-29 16:22 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Stanislav Lisovskiy @ 2019-07-29 14:15 UTC (permalink / raw)
To: igt-dev; +Cc: stanislav.lisovskiy, ville.syrjala, martin.peres
While doing some gpu fill based tests, noticed that
actually the x and y parameters do not affect the
filled area at all.
After short study looks like gen8_gpgpu_walk was not
using those at all.
Started using those according to bspec, so now it is
actually possible to use initial x and y values.
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
lib/gpu_cmds.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/gpu_cmds.c b/lib/gpu_cmds.c
index 8d270ee8..48ddfa0c 100644
--- a/lib/gpu_cmds.c
+++ b/lib/gpu_cmds.c
@@ -681,12 +681,12 @@ gen8_emit_gpgpu_walk(struct intel_batchbuffer *batch,
0); /* width:1 */
/* thread group X */
- OUT_BATCH(0);
+ OUT_BATCH(x);
OUT_BATCH(0);
OUT_BATCH(x_dim);
/* thread group Y */
- OUT_BATCH(0);
+ OUT_BATCH(y);
OUT_BATCH(0);
OUT_BATCH(y_dim);
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for igt/lib: Start using x and y params for gpu walk 2019-07-29 14:15 [igt-dev] [PATCH i-g-t v1] igt/lib: Start using x and y params for gpu walk Stanislav Lisovskiy @ 2019-07-29 16:22 ` Patchwork 2019-07-29 17:01 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2019-07-29 16:22 UTC (permalink / raw) To: Stanislav Lisovskiy; +Cc: igt-dev == Series Details == Series: igt/lib: Start using x and y params for gpu walk URL : https://patchwork.freedesktop.org/series/64388/ State : success == Summary == CI Bug Log - changes from CI_DRM_6574 -> IGTPW_3303 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/64388/revisions/1/mbox/ Known issues ------------ Here are the changes found in IGTPW_3303 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@kms_chamelium@common-hpd-after-suspend: - fi-kbl-7567u: [PASS][1] -> [WARN][2] ([fdo#109380]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/fi-kbl-7567u/igt@kms_chamelium@common-hpd-after-suspend.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/fi-kbl-7567u/igt@kms_chamelium@common-hpd-after-suspend.html * igt@kms_pipe_crc_basic@read-crc-pipe-c: - fi-kbl-7567u: [PASS][3] -> [SKIP][4] ([fdo#109271]) +23 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/fi-kbl-7567u/igt@kms_pipe_crc_basic@read-crc-pipe-c.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/fi-kbl-7567u/igt@kms_pipe_crc_basic@read-crc-pipe-c.html #### Possible fixes #### * igt@gem_basic@create-fd-close: - fi-icl-u3: [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/fi-icl-u3/igt@gem_basic@create-fd-close.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/fi-icl-u3/igt@gem_basic@create-fd-close.html * igt@gem_ctx_create@basic-files: - fi-icl-u3: [INCOMPLETE][7] ([fdo#107713] / [fdo#109100]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/fi-icl-u3/igt@gem_ctx_create@basic-files.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/fi-icl-u3/igt@gem_ctx_create@basic-files.html * igt@i915_selftest@live_execlists: - fi-skl-gvtdvm: [DMESG-FAIL][9] ([fdo#111108]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380 [fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108 Participating hosts (51 -> 45) ------------------------------ Additional (1): fi-pnv-d510 Missing (7): fi-kbl-soraka fi-byt-squawks fi-bsw-cyan fi-gdg-551 fi-icl-y fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5114 -> IGTPW_3303 CI-20190529: 20190529 CI_DRM_6574: 30577cdd3fc7a9385b5ef15940606d320d6e2c4a @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3303: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/ IGT_5114: 54450721c3b323d01e0c6e5d5e883b7499c8022c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✗ GitLab.Pipeline: warning for igt/lib: Start using x and y params for gpu walk 2019-07-29 14:15 [igt-dev] [PATCH i-g-t v1] igt/lib: Start using x and y params for gpu walk Stanislav Lisovskiy 2019-07-29 16:22 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork @ 2019-07-29 17:01 ` Patchwork 2019-07-30 1:14 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork 2019-08-07 8:36 ` [igt-dev] [PATCH i-g-t v1] " Lisovskiy, Stanislav 3 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2019-07-29 17:01 UTC (permalink / raw) To: Stanislav Lisovskiy; +Cc: igt-dev == Series Details == Series: igt/lib: Start using x and y params for gpu walk URL : https://patchwork.freedesktop.org/series/64388/ State : warning == Summary == Pipeline status: FAILED. See https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/51944 for more details. == Logs == For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/51944 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for igt/lib: Start using x and y params for gpu walk 2019-07-29 14:15 [igt-dev] [PATCH i-g-t v1] igt/lib: Start using x and y params for gpu walk Stanislav Lisovskiy 2019-07-29 16:22 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2019-07-29 17:01 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork @ 2019-07-30 1:14 ` Patchwork 2019-08-07 8:36 ` [igt-dev] [PATCH i-g-t v1] " Lisovskiy, Stanislav 3 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2019-07-30 1:14 UTC (permalink / raw) To: Stanislav Lisovskiy; +Cc: igt-dev == Series Details == Series: igt/lib: Start using x and y params for gpu walk URL : https://patchwork.freedesktop.org/series/64388/ State : success == Summary == CI Bug Log - changes from CI_DRM_6574_full -> IGTPW_3303_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/64388/revisions/1/mbox/ Known issues ------------ Here are the changes found in IGTPW_3303_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_suspend@forcewake: - shard-kbl: [PASS][1] -> [INCOMPLETE][2] ([fdo#103665]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/shard-kbl1/igt@i915_suspend@forcewake.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/shard-kbl1/igt@i915_suspend@forcewake.html * igt@kms_color@pipe-c-ctm-blue-to-red: - shard-kbl: [PASS][3] -> [FAIL][4] ([fdo#107201]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/shard-kbl2/igt@kms_color@pipe-c-ctm-blue-to-red.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/shard-kbl7/igt@kms_color@pipe-c-ctm-blue-to-red.html - shard-apl: [PASS][5] -> [FAIL][6] ([fdo#107201]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/shard-apl3/igt@kms_color@pipe-c-ctm-blue-to-red.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/shard-apl1/igt@kms_color@pipe-c-ctm-blue-to-red.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render: - shard-iclb: [PASS][7] -> [FAIL][8] ([fdo#103167]) +6 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-render.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes: - shard-apl: [PASS][9] -> [DMESG-WARN][10] ([fdo#108566]) +2 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html * igt@kms_psr2_su@page_flip: - shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109642] / [fdo#111068]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/shard-iclb2/igt@kms_psr2_su@page_flip.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/shard-iclb7/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_no_drrs: - shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109441]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/shard-iclb2/igt@kms_psr@psr2_no_drrs.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/shard-iclb8/igt@kms_psr@psr2_no_drrs.html * igt@kms_setmode@basic: - shard-kbl: [PASS][15] -> [FAIL][16] ([fdo#99912]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/shard-kbl6/igt@kms_setmode@basic.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/shard-kbl3/igt@kms_setmode@basic.html #### Possible fixes #### * igt@gem_eio@unwedge-stress: - shard-snb: [FAIL][17] ([fdo#109661]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/shard-snb6/igt@gem_eio@unwedge-stress.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/shard-snb2/igt@gem_eio@unwedge-stress.html * igt@i915_suspend@debugfs-reader: - shard-apl: [DMESG-WARN][19] ([fdo#108566]) -> [PASS][20] +1 similar issue [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/shard-apl8/igt@i915_suspend@debugfs-reader.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/shard-apl6/igt@i915_suspend@debugfs-reader.html * igt@kms_big_fb@x-tiled-16bpp-rotate-0: - shard-snb: [INCOMPLETE][21] ([fdo#105411]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/shard-snb6/igt@kms_big_fb@x-tiled-16bpp-rotate-0.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/shard-snb5/igt@kms_big_fb@x-tiled-16bpp-rotate-0.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: - shard-glk: [FAIL][23] ([fdo#105363]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render: - shard-iclb: [FAIL][25] ([fdo#103167]) -> [PASS][26] +4 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: - shard-kbl: [INCOMPLETE][27] ([fdo#103665]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html * igt@kms_psr@psr2_cursor_mmap_cpu: - shard-iclb: [SKIP][29] ([fdo#109441]) -> [PASS][30] +4 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/shard-iclb1/igt@kms_psr@psr2_cursor_mmap_cpu.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html * igt@perf_pmu@rc6-runtime-pm-long: - shard-hsw: [FAIL][31] ([fdo#105010]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6574/shard-hsw6/igt@perf_pmu@rc6-runtime-pm-long.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/shard-hsw6/igt@perf_pmu@rc6-runtime-pm-long.html [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411 [fdo#107201]: https://bugs.freedesktop.org/show_bug.cgi?id=107201 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912 Participating hosts (10 -> 6) ------------------------------ Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5114 -> IGTPW_3303 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_6574: 30577cdd3fc7a9385b5ef15940606d320d6e2c4a @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_3303: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/ IGT_5114: 54450721c3b323d01e0c6e5d5e883b7499c8022c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3303/ _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v1] igt/lib: Start using x and y params for gpu walk 2019-07-29 14:15 [igt-dev] [PATCH i-g-t v1] igt/lib: Start using x and y params for gpu walk Stanislav Lisovskiy ` (2 preceding siblings ...) 2019-07-30 1:14 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork @ 2019-08-07 8:36 ` Lisovskiy, Stanislav 3 siblings, 0 replies; 5+ messages in thread From: Lisovskiy, Stanislav @ 2019-08-07 8:36 UTC (permalink / raw) To: igt-dev, chris; +Cc: Syrjala, Ville, Peres, Martin On Mon, 2019-07-29 at 17:15 +0300, Stanislav Lisovskiy wrote: > While doing some gpu fill based tests, noticed that > actually the x and y parameters do not affect the > filled area at all. > After short study looks like gen8_gpgpu_walk was not > using those at all. > Started using those according to bspec, so now it is > actually possible to use initial x and y values. > > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > --- > lib/gpu_cmds.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/gpu_cmds.c b/lib/gpu_cmds.c > index 8d270ee8..48ddfa0c 100644 > --- a/lib/gpu_cmds.c > +++ b/lib/gpu_cmds.c > @@ -681,12 +681,12 @@ gen8_emit_gpgpu_walk(struct intel_batchbuffer > *batch, > 0); /* width:1 */ > > /* thread group X */ > - OUT_BATCH(0); > + OUT_BATCH(x); > OUT_BATCH(0); > OUT_BATCH(x_dim); > > /* thread group Y */ > - OUT_BATCH(0); > + OUT_BATCH(y); > OUT_BATCH(0); > OUT_BATCH(y_dim); > Chris, could you please have a look if this is correct? Probably we also need to add this for other platforms, I was just implementing a stress test case where I wanted to use shader to fill some specific part of frame buffer and then figured out that x and y parameters are not used. Best Regards, Lisovskiy Stanislav _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-07 8:36 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-07-29 14:15 [igt-dev] [PATCH i-g-t v1] igt/lib: Start using x and y params for gpu walk Stanislav Lisovskiy 2019-07-29 16:22 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork 2019-07-29 17:01 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork 2019-07-30 1:14 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork 2019-08-07 8:36 ` [igt-dev] [PATCH i-g-t v1] " Lisovskiy, Stanislav
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.