* [meta-gnome][PATCH] gnome-system-monitor: Add DEPENDS on polkit
@ 2019-07-28 10:52 Adrian Bunk
2019-07-28 15:32 ` Khem Raj
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2019-07-28 10:52 UTC (permalink / raw)
To: openembedded-devel
The build fails without polkit in DISTRO_FEATURES:
FAILED: org.gnome.gnome-system-monitor.policy
msgfmt: cannot locate ITS rules for org.gnome.gnome-system-monitor.policy.in
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
.../gnome-system-monitor/gnome-system-monitor_3.32.0.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb b/meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb
index 701b0891c..8d39101e9 100644
--- a/meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb
+++ b/meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb
@@ -10,6 +10,7 @@ DEPENDS = " \
gtkmm3 \
libgtop \
librsvg \
+ polkit \
"
GNOMEBASEBUILDCLASS = "meson"
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [meta-gnome][PATCH] gnome-system-monitor: Add DEPENDS on polkit
2019-07-28 10:52 [meta-gnome][PATCH] gnome-system-monitor: Add DEPENDS on polkit Adrian Bunk
@ 2019-07-28 15:32 ` Khem Raj
2019-07-28 16:20 ` Adrian Bunk
0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2019-07-28 15:32 UTC (permalink / raw)
To: Adrian Bunk, openembedded-devel
On 7/28/19 3:52 AM, Adrian Bunk wrote:
> The build fails without polkit in DISTRO_FEATURES:
> FAILED: org.gnome.gnome-system-monitor.policy
> msgfmt: cannot locate ITS rules for org.gnome.gnome-system-monitor.policy.in
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> ---
> .../gnome-system-monitor/gnome-system-monitor_3.32.0.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb b/meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb
> index 701b0891c..8d39101e9 100644
> --- a/meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb
> +++ b/meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb
> @@ -10,6 +10,7 @@ DEPENDS = " \
> gtkmm3 \
> libgtop \
> librsvg \
> + polkit \
> "
this should be probably guarded with polkit as DISTRO_FEATURE knob as well.
>
> GNOMEBASEBUILDCLASS = "meson"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-gnome][PATCH] gnome-system-monitor: Add DEPENDS on polkit
2019-07-28 15:32 ` Khem Raj
@ 2019-07-28 16:20 ` Adrian Bunk
2019-07-28 20:08 ` Martin Jansa
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2019-07-28 16:20 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-devel
On Sun, Jul 28, 2019 at 08:32:37AM -0700, Khem Raj wrote:
>
> On 7/28/19 3:52 AM, Adrian Bunk wrote:
> > The build fails without polkit in DISTRO_FEATURES:
> > FAILED: org.gnome.gnome-system-monitor.policy
> > msgfmt: cannot locate ITS rules for org.gnome.gnome-system-monitor.policy.in
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > ---
> > .../gnome-system-monitor/gnome-system-monitor_3.32.0.bb | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb b/meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb
> > index 701b0891c..8d39101e9 100644
> > --- a/meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb
> > +++ b/meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb
> > @@ -10,6 +10,7 @@ DEPENDS = " \
> > gtkmm3 \
> > libgtop \
> > librsvg \
> > + polkit \
> > "
> this should be probably guarded with polkit as DISTRO_FEATURE knob as well.
The error message already tells that automatically:
ERROR: Nothing PROVIDES 'polkit' (but /home/bunk/sources/meta-openembedded/meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb DEPENDS on or otherwise requires it)
polkit was skipped: missing required distro feature 'polkit' (not in DISTRO_FEATURES)
ERROR: Required build target 'gnome-system-monitor' has no buildable providers.
Missing or unbuildable dependency chain was: ['gnome-system-monitor', 'polkit']
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-gnome][PATCH] gnome-system-monitor: Add DEPENDS on polkit
2019-07-28 16:20 ` Adrian Bunk
@ 2019-07-28 20:08 ` Martin Jansa
2019-07-30 7:46 ` Adrian Bunk
0 siblings, 1 reply; 5+ messages in thread
From: Martin Jansa @ 2019-07-28 20:08 UTC (permalink / raw)
To: Adrian Bunk; +Cc: openembedded-devel
It does tell that there are errors, but we don't want errors in "bitbake
world" :).
inherit distro_features_check
REQUIRED_DISTRO_FEATURES = "polkit"
tells the same for gnome-system-monitor directly without showing any errors
(because it's automatically skipped when polkit isn't in DISTRO_FEATURES).
On Sun, Jul 28, 2019 at 6:20 PM Adrian Bunk <bunk@stusta.de> wrote:
> On Sun, Jul 28, 2019 at 08:32:37AM -0700, Khem Raj wrote:
> >
> > On 7/28/19 3:52 AM, Adrian Bunk wrote:
> > > The build fails without polkit in DISTRO_FEATURES:
> > > FAILED: org.gnome.gnome-system-monitor.policy
> > > msgfmt: cannot locate ITS rules for
> org.gnome.gnome-system-monitor.policy.in
> > >
> > > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > > ---
> > > .../gnome-system-monitor/gnome-system-monitor_3.32.0.bb |
> 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/meta-gnome/recipes-gnome/gnome-system-monitor/
> gnome-system-monitor_3.32.0.bb
> b/meta-gnome/recipes-gnome/gnome-system-monitor/
> gnome-system-monitor_3.32.0.bb
> > > index 701b0891c..8d39101e9 100644
> > > --- a/meta-gnome/recipes-gnome/gnome-system-monitor/
> gnome-system-monitor_3.32.0.bb
> > > +++ b/meta-gnome/recipes-gnome/gnome-system-monitor/
> gnome-system-monitor_3.32.0.bb
> > > @@ -10,6 +10,7 @@ DEPENDS = " \
> > > gtkmm3 \
> > > libgtop \
> > > librsvg \
> > > + polkit \
> > > "
> > this should be probably guarded with polkit as DISTRO_FEATURE knob as
> well.
>
> The error message already tells that automatically:
>
> ERROR: Nothing PROVIDES 'polkit' (but
> /home/bunk/sources/meta-openembedded/meta-gnome/recipes-gnome/gnome-system-monitor/
> gnome-system-monitor_3.32.0.bb DEPENDS on or otherwise requires it)
> polkit was skipped: missing required distro feature 'polkit' (not in
> DISTRO_FEATURES)
> ERROR: Required build target 'gnome-system-monitor' has no buildable
> providers.
> Missing or unbuildable dependency chain was: ['gnome-system-monitor',
> 'polkit']
>
>
> cu
> Adrian
>
> --
>
> "Is there not promise of rain?" Ling Tan asked suddenly out
> of the darkness. There had been need of rain for many days.
> "Only a promise," Lao Er said.
> Pearl S. Buck - Dragon Seed
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-gnome][PATCH] gnome-system-monitor: Add DEPENDS on polkit
2019-07-28 20:08 ` Martin Jansa
@ 2019-07-30 7:46 ` Adrian Bunk
0 siblings, 0 replies; 5+ messages in thread
From: Adrian Bunk @ 2019-07-30 7:46 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-devel
On Sun, Jul 28, 2019 at 10:08:24PM +0200, Martin Jansa wrote:
> It does tell that there are errors, but we don't want errors in "bitbake
> world" :).
>...
Thanks, now I get it.
v2 sent.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-30 7:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-28 10:52 [meta-gnome][PATCH] gnome-system-monitor: Add DEPENDS on polkit Adrian Bunk
2019-07-28 15:32 ` Khem Raj
2019-07-28 16:20 ` Adrian Bunk
2019-07-28 20:08 ` Martin Jansa
2019-07-30 7:46 ` Adrian Bunk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.