All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Peter De Schrijver <pdeschrijver@nvidia.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v4 10/13] cpuidle: tegra: Support CPU cluster power-down state on Tegra30
Date: Tue, 30 Jul 2019 20:09:52 +0300	[thread overview]
Message-ID: <20190730170955.11987-11-digetx@gmail.com> (raw)
In-Reply-To: <20190730170955.11987-1-digetx@gmail.com>

The new CPU Idle driver has all necessary features in order to allow
the deepest idling state on Tegra30 SoC where the whole CPU cluster is
power-gated using the coupled idle state.

Note that outer_disable() now need to be invoked directly since it
produces erroneous warning message about secondary CPUs being online
because it doesn't know that secondaries are turned off at that point
by the cpuidle driver.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm/mach-tegra/pm.c        | 7 ++++---
 drivers/cpuidle/cpuidle-tegra.c | 1 -
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-tegra/pm.c b/arch/arm/mach-tegra/pm.c
index 7d9ef26e52a7..16a02937d3da 100644
--- a/arch/arm/mach-tegra/pm.c
+++ b/arch/arm/mach-tegra/pm.c
@@ -146,9 +146,10 @@ static int tegra_sleep_cpu(unsigned long v2p)
 	 * if any of secondary CPU's is online and this is the LP2-idle
 	 * code-path only for Tegra20/30.
 	 */
-	if (trusted_foundations_registered())
-		outer_disable();
-
+#ifdef CONFIG_OUTER_CACHE
+	if (trusted_foundations_registered() && outer_cache.disable)
+		outer_cache.disable();
+#endif
 	/*
 	 * Note that besides of setting up CPU reset vector this firmware
 	 * call may also do the following, depending on the FW version:
diff --git a/drivers/cpuidle/cpuidle-tegra.c b/drivers/cpuidle/cpuidle-tegra.c
index 867c0403ea81..9e1659e93af6 100644
--- a/drivers/cpuidle/cpuidle-tegra.c
+++ b/drivers/cpuidle/cpuidle-tegra.c
@@ -324,7 +324,6 @@ static int tegra_cpuidle_probe(struct platform_device *pdev)
 		tegra_idle_driver.states[TEGRA_C7].disabled = true;
 		break;
 	case TEGRA30:
-		tegra_idle_driver.states[TEGRA_CC6].disabled = true;
 		break;
 	case TEGRA114:
 	case TEGRA124:
-- 
2.22.0

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Peter De Schrijver <pdeschrijver@nvidia.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: [PATCH v4 10/13] cpuidle: tegra: Support CPU cluster power-down state on Tegra30
Date: Tue, 30 Jul 2019 20:09:52 +0300	[thread overview]
Message-ID: <20190730170955.11987-11-digetx@gmail.com> (raw)
In-Reply-To: <20190730170955.11987-1-digetx@gmail.com>

The new CPU Idle driver has all necessary features in order to allow
the deepest idling state on Tegra30 SoC where the whole CPU cluster is
power-gated using the coupled idle state.

Note that outer_disable() now need to be invoked directly since it
produces erroneous warning message about secondary CPUs being online
because it doesn't know that secondaries are turned off at that point
by the cpuidle driver.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 arch/arm/mach-tegra/pm.c        | 7 ++++---
 drivers/cpuidle/cpuidle-tegra.c | 1 -
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-tegra/pm.c b/arch/arm/mach-tegra/pm.c
index 7d9ef26e52a7..16a02937d3da 100644
--- a/arch/arm/mach-tegra/pm.c
+++ b/arch/arm/mach-tegra/pm.c
@@ -146,9 +146,10 @@ static int tegra_sleep_cpu(unsigned long v2p)
 	 * if any of secondary CPU's is online and this is the LP2-idle
 	 * code-path only for Tegra20/30.
 	 */
-	if (trusted_foundations_registered())
-		outer_disable();
-
+#ifdef CONFIG_OUTER_CACHE
+	if (trusted_foundations_registered() && outer_cache.disable)
+		outer_cache.disable();
+#endif
 	/*
 	 * Note that besides of setting up CPU reset vector this firmware
 	 * call may also do the following, depending on the FW version:
diff --git a/drivers/cpuidle/cpuidle-tegra.c b/drivers/cpuidle/cpuidle-tegra.c
index 867c0403ea81..9e1659e93af6 100644
--- a/drivers/cpuidle/cpuidle-tegra.c
+++ b/drivers/cpuidle/cpuidle-tegra.c
@@ -324,7 +324,6 @@ static int tegra_cpuidle_probe(struct platform_device *pdev)
 		tegra_idle_driver.states[TEGRA_C7].disabled = true;
 		break;
 	case TEGRA30:
-		tegra_idle_driver.states[TEGRA_CC6].disabled = true;
 		break;
 	case TEGRA114:
 	case TEGRA124:
-- 
2.22.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-07-30 17:09 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 17:09 [PATCH v4 00/13] Consolidate and improve NVIDIA Tegra CPUIDLE driver(s) Dmitry Osipenko
2019-07-30 17:09 ` Dmitry Osipenko
2019-07-30 17:09 ` [PATCH v4 01/13] ARM: tegra: Remove cpuidle drivers to replace them with a new driver Dmitry Osipenko
2019-07-30 17:09   ` Dmitry Osipenko
2019-07-30 17:09 ` [PATCH v4 02/13] ARM: tegra: Change tegra_set_cpu_in_lp2() type to void Dmitry Osipenko
2019-07-30 17:09   ` Dmitry Osipenko
2019-07-30 17:09 ` [PATCH v4 03/13] ARM: tegra: Propagate error from tegra_idle_lp2_last() Dmitry Osipenko
2019-07-30 17:09   ` Dmitry Osipenko
2019-07-30 17:09   ` Dmitry Osipenko
2019-07-30 17:09 ` [PATCH v4 04/13] ARM: tegra: Compile sleep-tegra20/30.S unconditionally Dmitry Osipenko
2019-07-30 17:09   ` Dmitry Osipenko
2019-07-30 17:09 ` [PATCH v4 05/13] ARM: tegra: Expose PM functions required for new cpuidle driver Dmitry Osipenko
2019-07-30 17:09   ` Dmitry Osipenko
2019-07-30 17:09 ` [PATCH v4 06/13] ARM: tegra: Rename some of the newly exposed PM functions Dmitry Osipenko
2019-07-30 17:09   ` Dmitry Osipenko
2019-07-30 17:09 ` [PATCH v4 07/13] ARM: tegra: Add tegra_pm_park_secondary_cpu() Dmitry Osipenko
2019-07-30 17:09   ` Dmitry Osipenko
2019-07-30 17:09 ` [PATCH v4 08/13] clk: tegra: Add missing stubs for the case of !CONFIG_PM_SLEEP Dmitry Osipenko
2019-07-30 17:09   ` Dmitry Osipenko
2019-07-30 17:09 ` [PATCH v4 09/13] cpuidle: Introduce unified driver for NVIDIA Tegra SoCs Dmitry Osipenko
2019-07-30 17:09   ` Dmitry Osipenko
2019-07-30 17:09 ` Dmitry Osipenko [this message]
2019-07-30 17:09   ` [PATCH v4 10/13] cpuidle: tegra: Support CPU cluster power-down state on Tegra30 Dmitry Osipenko
2019-07-30 17:09 ` [PATCH v4 11/13] ARM: tegra: Create simple platform device for cpuidle driver Dmitry Osipenko
2019-07-30 17:09   ` Dmitry Osipenko
2019-07-30 17:09 ` [PATCH v4 12/13] ARM: multi_v7_defconfig: Enable Tegra " Dmitry Osipenko
2019-07-30 17:09   ` Dmitry Osipenko
2019-07-30 17:09 ` [PATCH v4 13/13] ARM: tegra: Enable Tegra cpuidle driver in tegra_defconfig Dmitry Osipenko
2019-07-30 17:09   ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190730170955.11987-11-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=pdeschrijver@nvidia.com \
    --cc=rjw@rjwysocki.net \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.