* [PATCH] drm/i915: Report resv_obj allocation failure
@ 2019-07-30 20:58 Chris Wilson
2019-07-30 23:02 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Chris Wilson @ 2019-07-30 20:58 UTC (permalink / raw)
To: intel-gfx
Since commit 64d6c500a384 ("drm/i915: Generalise GPU activity
tracking"), we have been prepared for i915_vma_move_to_active() to fail.
We can take advantage of this to report the failure for allocating the
shared-fence slot in the reservation_object.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_vma.c | 31 +++++++++----------------------
1 file changed, 9 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index eb16a1a93bbc..7734d6218ce7 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -886,23 +886,6 @@ void i915_vma_revoke_mmap(struct i915_vma *vma)
list_del(&vma->obj->userfault_link);
}
-static void export_fence(struct i915_vma *vma,
- struct i915_request *rq,
- unsigned int flags)
-{
- struct reservation_object *resv = vma->resv;
-
- /*
- * Ignore errors from failing to allocate the new fence, we can't
- * handle an error right now. Worst case should be missed
- * synchronisation leading to rendering corruption.
- */
- if (flags & EXEC_OBJECT_WRITE)
- reservation_object_add_excl_fence(resv, &rq->fence);
- else if (reservation_object_reserve_shared(resv, 1) == 0)
- reservation_object_add_shared_fence(resv, &rq->fence);
-}
-
int i915_vma_move_to_active(struct i915_vma *vma,
struct i915_request *rq,
unsigned int flags)
@@ -926,14 +909,20 @@ int i915_vma_move_to_active(struct i915_vma *vma,
if (unlikely(err))
return err;
- obj->write_domain = 0;
if (flags & EXEC_OBJECT_WRITE) {
- obj->write_domain = I915_GEM_DOMAIN_RENDER;
-
if (intel_fb_obj_invalidate(obj, ORIGIN_CS))
__i915_active_request_set(&obj->frontbuffer_write, rq);
+ reservation_object_add_excl_fence(vma->resv, &rq->fence);
+ obj->write_domain = I915_GEM_DOMAIN_RENDER;
obj->read_domains = 0;
+ } else {
+ err = reservation_object_reserve_shared(vma->resv, 1);
+ if (unlikely(err))
+ return err;
+
+ reservation_object_add_shared_fence(vma->resv, &rq->fence);
+ obj->write_domain = 0;
}
obj->read_domains |= I915_GEM_GPU_DOMAINS;
obj->mm.dirty = true;
@@ -941,8 +930,6 @@ int i915_vma_move_to_active(struct i915_vma *vma,
if (flags & EXEC_OBJECT_NEEDS_FENCE)
__i915_active_request_set(&vma->last_fence, rq);
- export_fence(vma, rq, flags);
-
GEM_BUG_ON(!i915_vma_is_active(vma));
return 0;
}
--
2.22.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Report resv_obj allocation failure
2019-07-30 20:58 [PATCH] drm/i915: Report resv_obj allocation failure Chris Wilson
@ 2019-07-30 23:02 ` Patchwork
2019-08-01 12:20 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-08-02 15:00 ` [PATCH] " Matthew Auld
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-07-30 23:02 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Report resv_obj allocation failure
URL : https://patchwork.freedesktop.org/series/64450/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6586 -> Patchwork_13811
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/
Known issues
------------
Here are the changes found in Patchwork_13811 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic-files:
- fi-icl-u3: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#109100])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-icl-u3/igt@gem_ctx_create@basic-files.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/fi-icl-u3/igt@gem_ctx_create@basic-files.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][3] -> [FAIL][4] ([fdo#108511])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
* igt@kms_busy@basic-flip-c:
- fi-kbl-7500u: [PASS][5] -> [SKIP][6] ([fdo#109271] / [fdo#109278]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-kbl-7500u/igt@kms_busy@basic-flip-c.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/fi-kbl-7500u/igt@kms_busy@basic-flip-c.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7567u: [PASS][7] -> [WARN][8] ([fdo#109380])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-kbl-7567u/igt@kms_chamelium@common-hpd-after-suspend.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/fi-kbl-7567u/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7567u: [PASS][9] -> [FAIL][10] ([fdo#109485])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-kbl-7567u/igt@kms_chamelium@hdmi-hpd-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/fi-kbl-7567u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [PASS][11] -> [FAIL][12] ([fdo#103167])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-kbl-7567u: [PASS][13] -> [SKIP][14] ([fdo#109271]) +23 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-kbl-7567u/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/fi-kbl-7567u/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- fi-icl-dsi: [INCOMPLETE][15] ([fdo#107713] / [fdo#109100]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-icl-dsi/igt@gem_ctx_create@basic-files.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/fi-icl-dsi/igt@gem_ctx_create@basic-files.html
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: [INCOMPLETE][17] ([fdo#107718]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/fi-blb-e6850/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_module_load@reload-no-display:
- fi-bwr-2160: [INCOMPLETE][19] ([fdo#111174]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-bwr-2160/igt@i915_module_load@reload-no-display.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/fi-bwr-2160/igt@i915_module_load@reload-no-display.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#111174]: https://bugs.freedesktop.org/show_bug.cgi?id=111174
Participating hosts (54 -> 46)
------------------------------
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6586 -> Patchwork_13811
CI-20190529: 20190529
CI_DRM_6586: 066993443a56467f54fdcf560e89378f8e93a15b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5116: d2e6dd2f789596da5bd06efc2e9448e3160583b6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13811: 34031cdfb8b424dec7d1263abc88ed5879afbc8b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
34031cdfb8b4 drm/i915: Report resv_obj allocation failure
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915: Report resv_obj allocation failure
2019-07-30 20:58 [PATCH] drm/i915: Report resv_obj allocation failure Chris Wilson
2019-07-30 23:02 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-08-01 12:20 ` Patchwork
2019-08-02 15:00 ` [PATCH] " Matthew Auld
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-08-01 12:20 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Report resv_obj allocation failure
URL : https://patchwork.freedesktop.org/series/64450/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6586_full -> Patchwork_13811_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_13811_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_13811_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_13811_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_hangman@error-state-capture-rcs0:
- shard-apl: [PASS][1] -> ([PASS][2], [DMESG-WARN][3])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-apl6/igt@i915_hangman@error-state-capture-rcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-apl8/igt@i915_hangman@error-state-capture-rcs0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-apl4/igt@i915_hangman@error-state-capture-rcs0.html
Known issues
------------
Here are the changes found in Patchwork_13811_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-apl: [PASS][4] -> ([PASS][5], [DMESG-WARN][6]) ([fdo#108566]) +5 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-apl8/igt@gem_ctx_isolation@bcs0-s3.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-apl2/igt@gem_ctx_isolation@bcs0-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-apl7/igt@gem_ctx_isolation@bcs0-s3.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#110854])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb1/igt@gem_exec_balancer@smoke.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-iclb6/igt@gem_exec_balancer@smoke.html
* igt@gem_softpin@noreloc-s3:
- shard-kbl: [PASS][9] -> ([PASS][10], [DMESG-WARN][11]) ([fdo#108566]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-kbl4/igt@gem_softpin@noreloc-s3.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-kbl7/igt@gem_softpin@noreloc-s3.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-kbl4/igt@gem_softpin@noreloc-s3.html
* igt@gem_tiled_swapping@non-threaded:
- shard-glk: [PASS][12] -> ([PASS][13], [DMESG-WARN][14]) ([fdo#108686])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-glk3/igt@gem_tiled_swapping@non-threaded.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-glk9/igt@gem_tiled_swapping@non-threaded.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-glk2/igt@gem_tiled_swapping@non-threaded.html
* igt@i915_selftest@live_hangcheck:
- shard-iclb: [PASS][15] -> [INCOMPLETE][16] ([fdo#107713] / [fdo#108569])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb6/igt@i915_selftest@live_hangcheck.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-iclb8/igt@i915_selftest@live_hangcheck.html
* igt@i915_suspend@forcewake:
- shard-skl: [PASS][17] -> ([INCOMPLETE][18], [PASS][19]) ([fdo#104108])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl1/igt@i915_suspend@forcewake.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-skl6/igt@i915_suspend@forcewake.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-skl1/igt@i915_suspend@forcewake.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-skl: [PASS][20] -> ([PASS][21], [INCOMPLETE][22]) ([fdo#110741])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-skl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-size-change:
- shard-skl: [PASS][23] -> ([FAIL][24], [PASS][25]) ([fdo#103232]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-size-change.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-skl5/igt@kms_cursor_crc@pipe-c-cursor-size-change.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-skl7/igt@kms_cursor_crc@pipe-c-cursor-size-change.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [PASS][26] -> ([PASS][27], [FAIL][28]) ([fdo#103355])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-hsw5/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-glk: [PASS][29] -> ([FAIL][30], [PASS][31]) ([fdo#100368])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-glk1/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-glk3/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-glk6/igt@kms_flip@2x-plain-flip-ts-check-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][32] -> ([PASS][33], [FAIL][34]) ([fdo#105363])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl5/igt@kms_flip@flip-vs-expired-vblank.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-skl4/igt@kms_flip@flip-vs-expired-vblank.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-skl6/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_flip_tiling@flip-x-tiled:
- shard-skl: [PASS][35] -> [FAIL][36] ([fdo#108145] / [fdo#108303])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl9/igt@kms_flip_tiling@flip-x-tiled.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-skl5/igt@kms_flip_tiling@flip-x-tiled.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt:
- shard-skl: [PASS][37] -> ([FAIL][38], [FAIL][39]) ([fdo#103167] / [fdo#108040])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl4/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-skl3/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-skl2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
- shard-iclb: [PASS][40] -> [FAIL][41] ([fdo#103167]) +6 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][42] -> ([FAIL][43], [FAIL][44]) ([fdo#108145])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][45] -> [FAIL][46] ([fdo#108145] / [fdo#110403])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_cursor@pipe-a-viewport-size-256:
- shard-snb: [PASS][47] -> ([PASS][48], [SKIP][49]) ([fdo#109271])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-snb2/igt@kms_plane_cursor@pipe-a-viewport-size-256.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-snb6/igt@kms_plane_cursor@pipe-a-viewport-size-256.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-snb7/igt@kms_plane_cursor@pipe-a-viewport-size-256.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][50] -> [SKIP][51] ([fdo#109642] / [fdo#111068])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-iclb1/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][52] -> [SKIP][53] ([fdo#109441]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html
#### Possible fixes ####
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][54] ([fdo#108566]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-apl5/igt@i915_suspend@fence-restore-tiled2untiled.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_cursor_legacy@all-pipes-torture-bo:
- shard-iclb: [INCOMPLETE][56] ([fdo#107713]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb7/igt@kms_cursor_legacy@all-pipes-torture-bo.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-iclb1/igt@kms_cursor_legacy@all-pipes-torture-bo.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][58] ([fdo#105363]) -> ([PASS][59], [PASS][60])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-iclb: [FAIL][61] ([fdo#103167]) -> [PASS][62] +3 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [SKIP][63] ([fdo#109441]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb4/igt@kms_psr@psr2_basic.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-iclb2/igt@kms_psr@psr2_basic.html
#### Warnings ####
* igt@gem_softpin@noreloc-s3:
- shard-apl: [DMESG-WARN][65] ([fdo#108566]) -> ([DMESG-WARN][66], [PASS][67]) ([fdo#108566])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-apl7/igt@gem_softpin@noreloc-s3.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-apl6/igt@gem_softpin@noreloc-s3.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-apl5/igt@gem_softpin@noreloc-s3.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][68] ([fdo#109349]) -> [DMESG-WARN][69] ([fdo#107724])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb4/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][70] ([fdo#108566]) -> ([DMESG-WARN][71], [PASS][72]) ([fdo#108566]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-suspend.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][73] ([fdo#99912]) -> ([FAIL][74], [PASS][75]) ([fdo#99912])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-kbl2/igt@kms_setmode@basic.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-kbl2/igt@kms_setmode@basic.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/shard-kbl3/igt@kms_setmode@basic.html
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108303]: https://bugs.freedesktop.org/show_bug.cgi?id=108303
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110741]: https://bugs.freedesktop.org/show_bug.cgi?id=110741
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6586 -> Patchwork_13811
CI-20190529: 20190529
CI_DRM_6586: 066993443a56467f54fdcf560e89378f8e93a15b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5116: d2e6dd2f789596da5bd06efc2e9448e3160583b6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13811: 34031cdfb8b424dec7d1263abc88ed5879afbc8b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13811/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Report resv_obj allocation failure
2019-07-30 20:58 [PATCH] drm/i915: Report resv_obj allocation failure Chris Wilson
2019-07-30 23:02 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-08-01 12:20 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2019-08-02 15:00 ` Matthew Auld
2019-08-02 15:05 ` Chris Wilson
2 siblings, 1 reply; 6+ messages in thread
From: Matthew Auld @ 2019-08-02 15:00 UTC (permalink / raw)
To: Chris Wilson; +Cc: Intel Graphics Development
On Tue, 30 Jul 2019 at 21:58, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Since commit 64d6c500a384 ("drm/i915: Generalise GPU activity
> tracking"), we have been prepared for i915_vma_move_to_active() to fail.
> We can take advantage of this to report the failure for allocating the
> shared-fence slot in the reservation_object.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Report resv_obj allocation failure
2019-08-02 15:00 ` [PATCH] " Matthew Auld
@ 2019-08-02 15:05 ` Chris Wilson
2019-08-02 19:12 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2019-08-02 15:05 UTC (permalink / raw)
To: Matthew Auld; +Cc: Intel Graphics Development
Quoting Matthew Auld (2019-08-02 16:00:18)
> On Tue, 30 Jul 2019 at 21:58, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > Since commit 64d6c500a384 ("drm/i915: Generalise GPU activity
> > tracking"), we have been prepared for i915_vma_move_to_active() to fail.
> > We can take advantage of this to report the failure for allocating the
> > shared-fence slot in the reservation_object.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Thanks. One day, we should lift even the reservation allocation out of
the reservation lock. (That will make it move convenient to use that
lock from inside fs-reclaim paths.)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Report resv_obj allocation failure
2019-08-02 15:05 ` Chris Wilson
@ 2019-08-02 19:12 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2019-08-02 19:12 UTC (permalink / raw)
To: Chris Wilson; +Cc: Intel Graphics Development
On Fri, Aug 2, 2019 at 5:06 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Quoting Matthew Auld (2019-08-02 16:00:18)
> > On Tue, 30 Jul 2019 at 21:58, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > >
> > > Since commit 64d6c500a384 ("drm/i915: Generalise GPU activity
> > > tracking"), we have been prepared for i915_vma_move_to_active() to fail.
> > > We can take advantage of this to report the failure for allocating the
> > > shared-fence slot in the reservation_object.
> > >
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>
> Thanks. One day, we should lift even the reservation allocation out of
> the reservation lock. (That will make it move convenient to use that
> lock from inside fs-reclaim paths.)
Being able to allocate memory while holding the reservation_obj lock
is fairly fundamental assumption in all ttm based drivers. So I dont
think that'll work out, since even for our own objects dma-buf can
share them widely.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-02 19:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-30 20:58 [PATCH] drm/i915: Report resv_obj allocation failure Chris Wilson
2019-07-30 23:02 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-08-01 12:20 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-08-02 15:00 ` [PATCH] " Matthew Auld
2019-08-02 15:05 ` Chris Wilson
2019-08-02 19:12 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.