All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: "Toralf Förster" <toralf.foerster@gmx.de>,
	"Linux Kernel" <linux-kernel@vger.kernel.org>,
	"Nathan Huckleberry" <nhuck@google.com>
Subject: Re: Kernel patch commit message and content do differ
Date: Tue, 30 Jul 2019 18:29:03 -0400	[thread overview]
Message-ID: <20190730222903.GI29162@sasha-vm> (raw)
In-Reply-To: <20190729204242.GG250418@google.com>

On Mon, Jul 29, 2019 at 01:42:42PM -0700, Matthias Kaehlcke wrote:
>Hi,
>
>On Mon, Jul 29, 2019 at 10:20:25PM +0200, Toralf Förster wrote:
>> May I ask you to clarify why
>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/diff/queue-5.2/net-ipv4-fib_trie-avoid-cryptic-ternary-expressions.patch?id=e1b76013997246a0d14b7443acbb393577d2a1e8
>> speaks about a ternary operator, whereas the diff shows a changed
>> #define?
>
>This is a good question, apparently the content of the queued patch is:
>
>commit 4df607cc6fe8e46b258ff2a53d0a60ca3008ffc7
>Author: Nathan Huckleberry <nhuck@google.com>
>Date:   Mon Jun 17 10:28:29 2019 -0700
>
>    kbuild: Remove unnecessary -Wno-unused-value
>
>
>however the commit message is from:
>
>commit 25cec756891e8733433efea63b2254ddc93aa5cc
>Author: Matthias Kaehlcke <mka@chromium.org>
>Date:   Tue Jun 18 14:14:40 2019 -0700
>
>    net/ipv4: fib_trie: Avoid cryptic ternary expressions
>
>
>Other than that the stable port also is missing a Signed-off-by tag
>from Nathan.
>
>Looks like the patch didn't actually make it into -stable yet? If that
>is correct we should be in time to fix it up before it becomes part of
>the git history.

Right, it was an issue with my script which is now fixed. I've also
fixed up the stable tree. Thanks for pointing it out.

--
Thanks,
Sasha

      reply	other threads:[~2019-07-30 22:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29 20:20 Kernel patch commit message and content do differ Toralf Förster
2019-07-29 20:42 ` Matthias Kaehlcke
2019-07-30 22:29   ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190730222903.GI29162@sasha-vm \
    --to=sashal@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=nhuck@google.com \
    --cc=toralf.foerster@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.